rjmccall added a comment.

I'm a little worried about the shift to emit an unconditional error on 
`volatile`.  Can we at least separate that into its own patch and just fix the 
bug in this one?  And please try to reach out whoever originally added this 
feature to see if that restriction is okay vs. just ignoring it, because it 
certainly looks like the `volatile` exception was intentionally designed.

Other than that, this looks great, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131979/new/

https://reviews.llvm.org/D131979

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to