[PATCH] D132473: [Docs][OpenCL][SPIR-V] Release 15 notes for Clang

svenvh added a comment. In D132473#3742688 , @Anastasia wrote: > @svenvh as you made quite a lot of changes in the headers feel free to expand > the description if you feel we should document some of those in more detail. I think you have captured it qu

[clang-tools-extra] 552b59b - [clangd] Bump timeout for a flaky test

Author: Kadir Cetinkaya Date: 2022-08-23T18:18:17+02:00 New Revision: 552b59b9e69fe1cb2b1ee0cb49cf8376a3dc0869 URL: https://github.com/llvm/llvm-project/commit/552b59b9e69fe1cb2b1ee0cb49cf8376a3dc0869 DIFF: https://github.com/llvm/llvm-project/commit/552b59b9e69fe1cb2b1ee0cb49cf8376a3dc0869.dif

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added inline comments. Comment at: llvm/include/llvm/IR/InstrTypes.h:1863 + /// not access or only reads memory. + bool doesNotReadThreadIDNorLivesInPresplitCoroutine() const { +return doesNoReadThreadID() || !getFunction() || rjmccall wrote: > Thi

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov updated this revision to Diff 454872. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D131858 Files: clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/performa

[clang] 16cb3be - [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

Author: Fred Tingaud Date: 2022-08-23T18:33:26+02:00 New Revision: 16cb3be62600621361644ebd15d071c711d6aa86 URL: https://github.com/llvm/llvm-project/commit/16cb3be62600621361644ebd15d071c711d6aa86 DIFF: https://github.com/llvm/llvm-project/commit/16cb3be62600621361644ebd15d071c711d6aa86.diff

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

This revision was automatically updated to reflect the committed changes. Closed by commit rG16cb3be62600: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments (authored by frederic-tingaud-sonarsource, committed by steakhal). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

thakis added a comment. Makes sense to me. Maybe @hans has an opinion too. WDYT about accepting the same string for -fuse-ld= to mean "platform linker" there as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132444/new/ https://reviews.llvm.

[PATCH] D132289: [analyzer] Drop deprecated flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca17b58f569: [analyzer] Drop deprecated flags (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132289/new/ https://reviews.llvm.org/D1

[clang] 6ca17b5 - [analyzer] Drop deprecated flags

Author: Balazs Benics Date: 2022-08-23T18:39:21+02:00 New Revision: 6ca17b58f569d43838404f5c94856e3584a23d0f URL: https://github.com/llvm/llvm-project/commit/6ca17b58f569d43838404f5c94856e3584a23d0f DIFF: https://github.com/llvm/llvm-project/commit/6ca17b58f569d43838404f5c94856e3584a23d0f.diff

[PATCH] D132444: [clang] Allow using -rtlib=platform to switching to the default rtlib on all targets

mstorsjo added a comment. In D132444#3743020 , @thakis wrote: > Makes sense to me. Maybe @hans has an opinion too. > > WDYT about accepting the same string for -fuse-ld= to mean "platform linker" > there as well? Sounds reasonable to me - requiring the

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.h:1 +//===-- Coroutines.h ---*- C++//-*-===// +// typo: `-*- C++ -*-` Comment at: lldb/source/Plugins/Language

[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

rjmccall added a comment. In D131979#3742399 , @yihanaa wrote: > As far as I know, turning on the -fsanitizer=alignment options when calling > __builtin_assume_aligned in C code, if > the 1st arg has volatile qualifier, Clang will emit "call void > @__u

[PATCH] D132486: Revert "libclang.so: Make SONAME the same as LLVM version"

thieta created this revision. Herald added subscribers: fedor.sergeev, mgorny. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit bc39d7bdd4977a953b2e102f8f7eb479ad78984e

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Mostly mechanics here. I

[PATCH] D132421: [NFC] [HLSL] Add HLSLExternalSemaSource as ExternalSemaSource instead of ASTContext::ExternalSource.

python3kgae updated this revision to Diff 454888. python3kgae added a comment. When there's no external source set, add HLSLSema as ExternalSource so ASTWriter can access HLSLSema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://

[PATCH] D132486: Revert "libclang.so: Make SONAME the same as LLVM version"

h-vetinari added a comment. IMO looks good, thanks! For reference & completeness, this came from https://github.com/h-vetinari/llvm-project/tree/libclang after discussion in https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground-to-keep-it-behind-option/64410 Rep

[PATCH] D132421: [NFC] [HLSL] Add HLSLExternalSemaSource as ExternalSemaSource instead of ASTContext::ExternalSource.

python3kgae updated this revision to Diff 454889. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: clang/lib/Frontend/FrontendAction.cpp c

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

ldionne created this revision. ldionne added a reviewer: fhahn. Herald added a subscriber: mgorny. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We build libcxx using LLVM_ENABLE_RUNTIMES during Stage2

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz updated this revision to Diff 454892. beanz added a comment. Updates based on review feedback: - Wraped diagnostic text in td - Added FIXME for return type annotations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131625/new/ https://reviews

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

beanz added inline comments. Comment at: clang/test/SemaHLSL/pch.hlsl:5 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl \ +// RUN: -finclude-default-header -include-pch %t -ast-dump-all /dev/null \ +// RUN: | FileCheck %s I want to make sure

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132488/new/ https://reviews.llvm.org/D132488

[PATCH] D132414: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14

This revision was automatically updated to reflect the committed changes. Closed by commit rG088ba8efeb49: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14 (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 088ba8e - [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14

Author: Yuanfang Chen Date: 2022-08-23T10:45:35-07:00 New Revision: 088ba8efeb4921deb49534714ddefb14a91afe46 URL: https://github.com/llvm/llvm-project/commit/088ba8efeb4921deb49534714ddefb14a91afe46 DIFF: https://github.com/llvm/llvm-project/commit/088ba8efeb4921deb49534714ddefb14a91afe46.diff

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks, Timm. The changes look reasonable to me, so I'll accept. Given my unfamiliarity with this code though, it would be great if someone else also gave it a nod. CHANGES SINCE L

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Thanks for the link - fair enough. We'll see how ubiquitous the constexpr-creating-sort-of-unused-variables situation is. If it comes up a lot we might want to disable the warning for GCC 9. On Mon, Aug 22, 2022 at 7:58 PM chuanqi.xcq wrote: > > Hi David, > > This is the reproduce link from god

[PATCH] D132111: [clang][Interp] Implement pointer (de)ref operations and DeclRefExprs

erichkeane accepted this revision. erichkeane added a comment. I'm happy as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132111/new/ https://reviews.llvm.org/D132111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

sfertile added inline comments. Comment at: llvm/lib/Bitcode/Writer/EmbedBitcodePass.cpp:26 + +PreservedAnalyses EmbedBitcodePass::run(Module &M, ModuleAnalysisManager &AM) { + if (M.getGlobalVariable("llvm.embedded.module", true)) From the discourse discussion:

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm. You might add some comments in CGVTables.cpp about why this is done and what the alternatives might be in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D130867: [clang] adds builtin `std::invoke` and `std::invoke_r`

cjdb updated this revision to Diff 454908. cjdb added a comment. rebases onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130867/new/ https://reviews.llvm.org/D130867 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Somehow we've taken a huge step back on unpromotion, and I'm worried you're now doing the exact thing I didn't want us doing and forcing all the downstream clients to handle the possibility of a promoted result. Comment at: clang/lib/CodeGen/CGExprCo

[clang] ba8b5ff - Adding a note about the macro __FLT_EVAL_METHOD__; NFC

Author: Zahira Ammarguellat Date: 2022-08-23T14:35:57-04:00 New Revision: ba8b5ff874ad438a07ac3cc4f2bc75898b1401f8 URL: https://github.com/llvm/llvm-project/commit/ba8b5ff874ad438a07ac3cc4f2bc75898b1401f8 DIFF: https://github.com/llvm/llvm-project/commit/ba8b5ff874ad438a07ac3cc4f2bc75898b1401f8

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

This revision was automatically updated to reflect the committed changes. Closed by commit rGba8b5ff874ad: Adding a note about the macro __FLT_EVAL_METHOD__; NFC (authored by zahiraam, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 454911. avogelsgesang marked 6 inline comments as done. avogelsgesang added a comment. addressed comments from @aprantl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D

[PATCH] D131625: [HLSL] Entry functions require param annotation

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though I had a question about the test's RUN line. Comment at: clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl:1 +// RUN: %clang_cc1 -triple dx

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3743318 , @rjmccall wrote: > Somehow we've taken a huge step back on unpromotion, and I'm worried you're > now doing the exact thing I didn't want us doing and forcing all the > downstream clients to handle the possi

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454913. royjacobson added a comment. Rebase on main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/DeclCXX.

[clang] 7171615 - [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

Author: Roy Jacobson Date: 2022-08-23T21:48:42+03:00 New Revision: 7171615099142ed49042c0f27af437b05150dd9b URL: https://github.com/llvm/llvm-project/commit/7171615099142ed49042c0f27af437b05150dd9b DIFF: https://github.com/llvm/llvm-project/commit/7171615099142ed49042c0f27af437b05150dd9b.diff

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG717161509914: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions) (authored by royjacobson). Repository: rG LLVM Github Monor

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454918. abrahamcd marked 4 inline comments as done. abrahamcd added a comment. Modified Printer's interface to use unique pointers when setting the SARIF writer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. I'm not sure what optimization you mean. Because the ABI returns 16-bit and 32-bit FP values differently, there really isn't a way that we can return a value without going through a truncation/extension cycle. There's potential to eliminate those with IPO, but we sho

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:615 + ComplexPairTy result = VisitMinus(E, promotionTy); + return result; +} rjmccall wrote: > This is not unpromoting if the original `PromotionType` is null. The idea for this cha

[PATCH] D132074: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8f722e630d: [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU (authored by jhuber6). Changed prior to commit: https://review

[clang] 2b8f722 - [OpenMP] Add option to assert no nested OpenMP parallelism on the GPU

Author: Joseph Huber Date: 2022-08-23T14:09:51-05:00 New Revision: 2b8f722e630d0fdf1ca267361866a27c8d4c9387 URL: https://github.com/llvm/llvm-project/commit/2b8f722e630d0fdf1ca267361866a27c8d4c9387 DIFF: https://github.com/llvm/llvm-project/commit/2b8f722e630d0fdf1ca267361866a27c8d4c9387.diff

[PATCH] D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order

ychen planned changes to this revision. ychen added a comment. I'll do a compile-time impact measurement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127259/new/ https://reviews.llvm.org/D127259 ___ cf

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

jrtc27 requested changes to this revision. jrtc27 added inline comments. This revision now requires changes to proceed. Comment at: clang/CMakeLists.txt:467 +option(CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION + "Force the SOVERSION of libclang to be equal to CLANG_MAJOR" OFF) +

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3740714 , @alecto wrote: > If possible I would like to error out if MaxEmptyLinesToKeep < > DefinitionBlockSpacing, because that case is probably a mistake on the part > of the user, and a failure would be

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454926. abrahamcd added a comment. Documented issue with representing PresumedLocs modified by \#line directives. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Fi

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:34 +/// \see FullDependencies::Commands. +class Command { +public: benlangmuir wrote: > jansvoboda11 wrote: > > Have you considered using the

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. Please mark things as done. Comment at: clang/include/clang/Format/Format.h:297 AlignConsecutiveStyle AlignConsecutiveDeclarations; + /// Style of aligning consecutive trailing comments. + /// Run clang/docs/tools/dump_f

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

h-vetinari added a comment. Thanks for the review. Given that you have concerns, could you voice them in a larger forum (https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground-to-keep-it-behind-option/64410), where so far the direction was in favour of going back t

[PATCH] D132275: [clang] Create alloca to pass into static lambda

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM (We might want to consider messing with the rules for calling lambdas that don't capture anything, since there's no way to actually access it from the lambda body. But it's unlikely

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

jrtc27 added a comment. In D132486#3743461 , @h-vetinari wrote: > Thanks for the review. Given that you have concerns, could you voice them in > a larger forum > (https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground-to-k

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:116 + +Locations.push_back( +CharSourceRange{SourceRange{BeginLoc, EndLoc}, /* ITR = */ false}); I noticed that when processing additional source ranges, regular sourc

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang marked an inline comment as done. avogelsgesang added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:44 + +lldbutil.run_to_source_breakpoint(self, '// Break after

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

cjdb added inline comments. Comment at: clang/lib/Frontend/FrontendAction.cpp:727-728 + static_cast(&CI.getDiagnosticClient()) + ->setSarifWriter(std::unique_ptr( + new SarifDocumentWriter(CI.getSourceManager(; +} Now that the i

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

This revision was automatically updated to reflect the committed changes. Closed by commit rG083e3a173d9e: [clang-tidy] Skip unions in use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/

[clang-tools-extra] 083e3a1 - [clang-tidy] Skip unions in use-equals-default

Author: Alexander Shaposhnikov Date: 2022-08-23T20:09:47Z New Revision: 083e3a173d9e9d71733e0445e6f4a93e7f918dfa URL: https://github.com/llvm/llvm-project/commit/083e3a173d9e9d71733e0445e6f4a93e7f918dfa DIFF: https://github.com/llvm/llvm-project/commit/083e3a173d9e9d71733e0445e6f4a93e7f918dfa.d

[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. sorry for the big delay, I did run the benchmarks and it looks fine ran this through llvm-compile-time-tracker, looks good https://llvm-compile-time-tracker.com/compare.php?from=552b59b9e6

[PATCH] D132398: Allow static consteval member functions to be used in const expressions.

usaxena95 updated this revision to Diff 454942. usaxena95 added a comment. only allow static members with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132398/new/ https://reviews.llvm.org/D132398 Files: clang/lib/AST/ExprConstant.cpp cl

[clang] 9477869 - [clang] Add support for __attribute__((guard(nocf)))

Author: Alvin Wong Date: 2022-08-23T23:39:38+03:00 New Revision: 94778692ad25456c9042caae96c40a7c066b6249 URL: https://github.com/llvm/llvm-project/commit/94778692ad25456c9042caae96c40a7c066b6249 DIFF: https://github.com/llvm/llvm-project/commit/94778692ad25456c9042caae96c40a7c066b6249.diff LO

[PATCH] D132302: [clang] Add support for __attribute__((guard(nocf)))

This revision was automatically updated to reflect the committed changes. Closed by commit rG94778692ad25: [clang] Add support for __attribute__((guard(nocf))) (authored by alvinhochun, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D132302?vs=454798&id=454944#toc Re

[PATCH] D132398: Allow static consteval member functions to be used in const expressions.

usaxena95 updated this revision to Diff 454946. usaxena95 added a comment. Add constexpr tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132398/new/ https://reviews.llvm.org/D132398 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX

[PATCH] D132398: Allow constant static members to be used with 'this'

usaxena95 updated this revision to Diff 454947. usaxena95 added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132398/new/ https://reviews.llvm.org/D132398 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/cxx2a-conste

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454950. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Added use of std::make_unique. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files:

[clang] b5a9adf - [clang] Create alloca to pass into static lambda

Author: Vitaly Buka Date: 2022-08-23T13:53:17-07:00 New Revision: b5a9adf1f533c6403d780bb127bda4b53f7dc7ed URL: https://github.com/llvm/llvm-project/commit/b5a9adf1f533c6403d780bb127bda4b53f7dc7ed DIFF: https://github.com/llvm/llvm-project/commit/b5a9adf1f533c6403d780bb127bda4b53f7dc7ed.diff L

[PATCH] D132275: [clang] Create alloca to pass into static lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5a9adf1f533: [clang] Create alloca to pass into static lambda (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://r

[clang] 7dfcf93 - [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

Author: Louis Dionne Date: 2022-08-23T17:02:51-04:00 New Revision: 7dfcf9342b5af794aadd4ca81490090fe7ca6a45 URL: https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45 DIFF: https://github.com/llvm/llvm-project/commit/7dfcf9342b5af794aadd4ca81490090fe7ca6a45.diff

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dfcf9342b5a: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2. (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D132487: [pseudo] Placeholder disambiguation strategy: always choose second

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This looks a good start! Comment at: clang-tools-extra/pseudo/tool/ClangPseudo.cpp:231 + +if (Disambiguate && PrintForest) { + ForestNode *DisambigRoot = &Root;

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

h-vetinari added a comment. > My concerns have already been raised by others in that thread and related > issues, I see no point in restating them yet again. I don't see consensus, I > see a handful of people discussing reverting a change that broke a whole > bunch of assumptions made by real-w

[PATCH] D131718: [HLSL] Add abs library function

beanz updated this revision to Diff 454962. beanz added a comment. Herald added a subscriber: MaskRay. Updating with a fix for half type parameters. This addresses the issue I filed here: https://github.com/llvm/llvm-project/issues/57100 The issue was caused by HLSL not implying options to allow

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3742779 , @joanahalili wrote: > This is the reproducer we managed to create for the memory increase. As > mentioned above we notice both a difference in memory and execution time. Thanks. I also added a print of t

[PATCH] D132501: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Wwhen Clang encounters `@import M.Private` during implicit b

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, benlangmuir. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Wwhen Clang encounters `@import M.Private` during implicit b

[PATCH] D132501: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Arcanist created two revisions, removing this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132501/new/ https://reviews.llvm.org/D132501 _

[PATCH] D132430: [clang][modules] Track affecting modules

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:311 +if (!MDC.isPrebuiltModule(M)) + DirectModularDeps.insert(M); + benlangmuir wrote: > If using eager loading, this will cause us to load the mo

[PATCH] D132430: [clang][modules] Track affecting modules

benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-incomplete-umbrella.c:82 +// CHECK_TU-NEXT: "command-line": [ +// CHECK_TU:], +// CHECK_TU-NEXT: "file-deps": [ jansvoboda11 wrote: > benlangmuir wrote: > > Th

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google created this revision. Herald added a project: All. luken-google requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes issue #55216. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132503 Files: clang/lib/

[PATCH] D132430: [clang][modules] Track affecting modules

jansvoboda11 updated this revision to Diff 454975. jansvoboda11 added a comment. Add `-fmodule-file=` assertions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132430/new/ https://reviews.llvm.org/D132430 Files: clang/include/clang/Basic/Module.h

[PATCH] D132430: [clang][modules] Track affecting modules

jansvoboda11 updated this revision to Diff 454979. jansvoboda11 added a comment. Backslashes in tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132430/new/ https://reviews.llvm.org/D132430 Files: clang/include/clang/Basic/Module.h

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 updated this revision to Diff 454982. Ericson2314 added a comment. Convert `CMAKE_CFG_INTDIR` as @sebastian-ne suggests, also .../bin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: b

[PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) --

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3743736 , @mizvekov wrote: > In D128113#3742779 , @joanahalili > wrote: > >> This is the reproducer we managed to create for the memory increase. As >> mentioned above we noti

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

cjdb added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnosticPrinter.h:41 + void setPrefix(llvm::StringRef Value) { +Prefix = std::move(Value); + } We don't need to move a StringRef. Comment at: clang/lib/Frontend/S

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

jingham added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:15 + +class TestCoroutineHandle(TestBase): +def do_test(self, stdlib_type): aprantl wrote: > Nice test!

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

jingham added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:44 + +lldbutil.run_to_source_breakpoint(self, '// Break after co_yield', +lldb.SBFileSpec("main.cpp"

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3743936 , @alexfh wrote: > I wonder what is the practical application of the substitution index in > SubstTemplateTypeParmType? Diagnostics? Matching AST? Something else? What > would be the cost of calculating the i

[PATCH] D132192: [RISCV] Add '32bit' feature to rv32 only builtins.

luismarques added a comment. Overall LGTM. I have one concern, though. The old error message was more user friendly. Referring to RV32 as an extension is... weird. You're already massaging the error with the `OF = "RV64"` / `OF = "RV32"`. Can't you special case this feature check error handlin

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455005. abrahamcd added a comment. Removed use of pointer reset in Printer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SA

[clang] aac73a3 - [analyzer] Process non-POD array element destructors

Author: isuckatcs Date: 2022-08-24T01:28:21+02:00 New Revision: aac73a31add5e80c746a7794d832f2cdf226486c URL: https://github.com/llvm/llvm-project/commit/aac73a31add5e80c746a7794d832f2cdf226486c DIFF: https://github.com/llvm/llvm-project/commit/aac73a31add5e80c746a7794d832f2cdf226486c.diff LOG

[PATCH] D130737: [analyzer] Process non-POD array element destructors

This revision was automatically updated to reflect the committed changes. Closed by commit rGaac73a31add5: [analyzer] Process non-POD array element destructors (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

phosek updated this revision to Diff 455020. phosek added a comment. Test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132440/new/ https://reviews.llvm.org/D132440 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/com

[PATCH] D132440: [Clang] Avoid using unwind library in the MSVC environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeca29d4a37b8: [Clang] Avoid using unwind library in the MSVC environment (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] eca29d4 - [Clang] Avoid using unwind library in the MSVC environment

Author: Petr Hosek Date: 2022-08-24T00:09:01Z New Revision: eca29d4a37b8d1c93fe99be6289a60bb11cf789d URL: https://github.com/llvm/llvm-project/commit/eca29d4a37b8d1c93fe99be6289a60bb11cf789d DIFF: https://github.com/llvm/llvm-project/commit/eca29d4a37b8d1c93fe99be6289a60bb11cf789d.diff LOG: [C

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang updated this revision to Diff 455022. avogelsgesang marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ https://reviews.llvm.org/D132415 Files: clang/docs/tools/clang-formatted-files.txt lldb/packages/Python/lldbsuite/test/lldbtes

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py:15 + +class TestCoroutineHandle(TestBase): +def do_test(self, stdlib_type): jingham wrote: > apra

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3744128 , @mizvekov wrote: > In D128113#3743936 , @alexfh wrote: > >> I wonder what is the practical application of the substitution index in >> SubstTemplateTypeParmType? Diagn

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3744290 , @alexfh wrote: > Do you have a practical example that would use the substitution index? I > believe you had something in mind before you implemented this patch? Oh, yes, this is needed for / is going to cul

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3744296 , @mizvekov wrote: > In D128113#3744290 , @alexfh wrote: > >> Do you have a practical example that would use the substitution index? I >> believe you had something in mi

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda marked 2 inline comments as done. arda added inline comments. Comment at: llvm/lib/Bitcode/Writer/EmbedBitcodePass.cpp:26 + +PreservedAnalyses EmbedBitcodePass::run(Module &M, ModuleAnalysisManager &AM) { + if (M.getGlobalVariable("llvm.embedded.module", true))

<    1   2   3   >