[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

CarlosAlbertoEnciso added a comment. In D131755#3723366 , @beanz wrote: > Looks good to me. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131755/new/ https://reviews.llvm.org/D13175

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

michele.scandale added a comment. I can see failures related to this change in a downstream version of clang where the default `ClangABICompat` value is not `Latest` (after the followup https://reviews.llvm.org/rGda6187f566b7881cb8350621aea9bd582de569b9). My understanding is that with `-fclang-a

[clang] 177cbb1 - [CMake] Explicit bootstrap options override any passthrough ones.

Author: Carlos Alberto Enciso Date: 2022-08-17T08:16:10+01:00 New Revision: 177cbb1c9b661b15a7db35e4ec9255adf502a6cb URL: https://github.com/llvm/llvm-project/commit/177cbb1c9b661b15a7db35e4ec9255adf502a6cb DIFF: https://github.com/llvm/llvm-project/commit/177cbb1c9b661b15a7db35e4ec9255adf502a6

[PATCH] D131755: [CMake] Explicit bootstrap options override any passthrough ones.

This revision was automatically updated to reflect the committed changes. Closed by commit rG177cbb1c9b66: [CMake] Explicit bootstrap options override any passthrough ones. (authored by CarlosAlbertoEnciso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D131385: [clangd] Support for standard type hierarchy

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1713 + fillSuperTypes(*ParentDecl, TUPath, *ParentSym, RPSet); + Item.data.parents->emplace_back(ParentSym->data); + Item.parents->emplace_back

[PATCH] D131385: [clangd] Support for standard type hierarchy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG83411bf06f34: [clangd] Support for standard type hierarchy (authored by kadircet). Repository: rG LLVM

[clang-tools-extra] 83411bf - [clangd] Support for standard type hierarchy

Author: Kadir Cetinkaya Date: 2022-08-17T09:29:15+02:00 New Revision: 83411bf06f34ae06731008eeabfc53553c1a1f86 URL: https://github.com/llvm/llvm-project/commit/83411bf06f34ae06731008eeabfc53553c1a1f86 DIFF: https://github.com/llvm/llvm-project/commit/83411bf06f34ae06731008eeabfc53553c1a1f86.dif

[clang] 4dd71b3 - [clang] Give priority to Class context while parsing declarations

Author: Furkan Usta Date: 2022-08-17T10:06:39+02:00 New Revision: 4dd71b3cb9473e960d06f5c4c60f0817bd5b9cf6 URL: https://github.com/llvm/llvm-project/commit/4dd71b3cb9473e960d06f5c4c60f0817bd5b9cf6 DIFF: https://github.com/llvm/llvm-project/commit/4dd71b3cb9473e960d06f5c4c60f0817bd5b9cf6.diff L

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd71b3cb947: [clang] Give priority to Class context while parsing declarations (authored by furkanusta, committed by kadircet). Changed prior to commit: https://reviews.llvm.org/D130363?vs=451604&id=45

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource added a comment. Hi @NoQ . Would you have time to look if the changes I did to this PR solve your concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 ___ cfe-commi

[clang] 8837ef4 - [clang] Apply FixIts to members declared via `using` in derived classes

Author: Denis Fatkulin Date: 2022-08-17T10:09:48+02:00 New Revision: 8837ef4d373be3f9b4ea297596ee917a1a91377e URL: https://github.com/llvm/llvm-project/commit/8837ef4d373be3f9b4ea297596ee917a1a91377e DIFF: https://github.com/llvm/llvm-project/commit/8837ef4d373be3f9b4ea297596ee917a1a91377e.diff

[PATCH] D131088: [clang] Apply FixIts to members declared via `using` in derived classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8837ef4d373b: [clang] Apply FixIts to members declared via `using` in derived classes (authored by denis-fatkulin, committed by kadircet). Changed prior to commit: https://reviews.llvm.org/D131088?vs=45

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

royjacobson added a comment. Stopping by - I assume this targets Clang 16 now, so the abi compat level should be adjusted to 15. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128745/new/ https://reviews.llvm.org/D128745 __

[clang] b296aed - [clang] fix a typo in da6187f566b7881cb835

Author: Yuanfang Chen Date: 2022-08-17T01:27:12-07:00 New Revision: b296aed8ae239c20ebdd7969e978f8d2a3b9c178 URL: https://github.com/llvm/llvm-project/commit/b296aed8ae239c20ebdd7969e978f8d2a3b9c178 DIFF: https://github.com/llvm/llvm-project/commit/b296aed8ae239c20ebdd7969e978f8d2a3b9c178.diff

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3728087 , @michele.scandale wrote: > I can see failures related to this change in a downstream version of clang > where the default `ClangABICompat` value is not `Latest` (after the followup > https://reviews.llvm.org/

[PATCH] D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template

ychen added a comment. In D128745#3728196 , @royjacobson wrote: > Stopping by - I assume this targets Clang 16 now, so the abi compat level > should be adjusted to 15. Sure, I'll make a new patch for that. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D131879: [clang][analyzer] Errno modeling code refactor (NFC).

balazske updated this revision to Diff 453231. balazske marked 4 inline comments as done. balazske added a comment. Small improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131879/new/ https://reviews.llvm.org/D131879 Files: clang/lib/S

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

DavidSpickett added inline comments. Comment at: clang/test/CodeGen/const-init.c:2 +// setting strict FP behaviour in the run line below tests that the compiler +// does the right thing for global compound literals (compoundliteral test) +// RUN: %clang_cc1 -no-opaque-pointers -t

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D131677: [clang][RISCV] Fix incorrect ABI lowering for inherited structs under hard-float ABIs

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, result has compared with GCC for `rv32gc/ilp32d` and `rv64gc/lp64d`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131677/new/ https://reviews.llvm.org/D131677

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:283-284 + mutable bool EofInitialized = false; + mutable int EofVal = -1; + Have you considered using `llvm::Optional` for this? Comment at: cla

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Would you like me to commit it on your behalf again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131678/new/ https://reviews.llvm.org/D131

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:191 + auto r5 = [&x5]{}; +} Can you add some cases with implicit capture (using [=] and [&]) Repository: rG LLVM Git

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added a comment. In D131678#3728412 , @njames93 wrote: > Would you like me to commit it on your behalf again? Yes, the email is the same - vladimir.plyash...@jetbrains.com Reposito

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/SymmetricBinaryOperatorCheck.cpp:24-34 +using transformer::applyFirst; +using transformer::cat; +using transformer::changeTo; +using transformer::insertBefore; +using transformer::makeRule

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains added a comment. In D128981#3728070 , @jansvoboda11 wrote: > Hi @iains, upstream Clang crashes on the attached test case due to an > assertion failure. Git bisect pointed me to this commit. Can you please take > a look? Previously, the test would

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

hokein updated this revision to Diff 453259. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130747/new/ https://reviews.llvm.org/D130747 Files: clang-tools-extra/p

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

hokein added a comment. In D130747#3727386 , @sammccall wrote: > LG, though i think we should eliminate class-name altogether. > > This gives most of the perf, which is nice! > > The reduction in ambiguous nodes is less impressive than before :-( As > di

[clang] 956f8c0 - [Driver] Override default location of config files

Author: Serge Pavlov Date: 2022-08-17T18:52:53+07:00 New Revision: 956f8c0e1028edd65f68c4b386224d4ccb58c5b6 URL: https://github.com/llvm/llvm-project/commit/956f8c0e1028edd65f68c4b386224d4ccb58c5b6 DIFF: https://github.com/llvm/llvm-project/commit/956f8c0e1028edd65f68c4b386224d4ccb58c5b6.diff

[clang] d7e06d5 - Update the status of some more C99 features

Author: Aaron Ballman Date: 2022-08-17T08:11:56-04:00 New Revision: d7e06d5675b62b5d3d89e6d6210c34b74a1a8356 URL: https://github.com/llvm/llvm-project/commit/d7e06d5675b62b5d3d89e6d6210c34b74a1a8356 DIFF: https://github.com/llvm/llvm-project/commit/d7e06d5675b62b5d3d89e6d6210c34b74a1a8356.diff

[clang-tools-extra] 6a9f79e - [pseudo] Eliminate the type-name identifier ambiguities in the grammar.

Author: Haojian Wu Date: 2022-08-17T14:30:53+02:00 New Revision: 6a9f79e1020db9f581d00791f1f644b64facfebe URL: https://github.com/llvm/llvm-project/commit/6a9f79e1020db9f581d00791f1f644b64facfebe DIFF: https://github.com/llvm/llvm-project/commit/6a9f79e1020db9f581d00791f1f644b64facfebe.diff LO

[PATCH] D130747: [pseudo] Eliminate the type-name identifier ambiguities in the grammar.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a9f79e1020d: [pseudo] Eliminate the type-name identifier ambiguities in the grammar. (authored by hokein). Repository: rG LLVM Github Monorepo C

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

aaron.ballman added a comment. Precommit CI failures are unrelated to this patch. Comment at: clang/lib/AST/ExprConstant.cpp:13547-13550 + if (const auto *VD = dyn_cast_or_null(Info.EvaluatingDecl.dyn_cast())) { +if (VD && !VD->isConstexpr()) + ConstexprV

[PATCH] D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior

aaron.ballman abandoned this revision. aaron.ballman added a comment. This was partially covered by https://reviews.llvm.org/D131479 and the rest should be handled in a different patch, so abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

asb added a comment. This seems like a sensible direction to me - let's discuss in the sync-up call this Thursday to check everyone is on-board and doesn't have concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/ https://reviews.ll

[PATCH] D131990: [DRAFT][WebAssembly] Do not support `[[clang::musttail]]` by default

aaron.ballman added a comment. > Marked draft for further discussion because I'm not sure getting this: > > test.cpp:10:7: warning: unknown attribute 'musttail' ignored > [-Wunknown-attributes] > [[clang::musttail]] return bar(x * 10); > > is actually better developer experience than gett

[PATCH] D131942: [clang][Inter[ Implement bool and nullptr literal expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { +

[clang] d483730 - Re-apply "Deferred Concept Instantiation Implementation""

Author: Erich Keane Date: 2022-08-17T06:24:40-07:00 New Revision: d483730d8c3fa2e0d4192b2f3c61c761b124e6ad URL: https://github.com/llvm/llvm-project/commit/d483730d8c3fa2e0d4192b2f3c61c761b124e6ad DIFF: https://github.com/llvm/llvm-project/commit/d483730d8c3fa2e0d4192b2f3c61c761b124e6ad.diff L

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd483730d8c3f: Re-apply "Deferred Concept Instantiation Implementation"" (authored by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

pscoro updated this revision to Diff 453272. pscoro added a comment. Reverted chain revision again, final Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D131683: Diagnosing the Future Keywords

erichkeane added a comment. I didn't have time to dig into the correctness of the TokenKinds or test changes (hopefully @aaron.ballman can take some time on that), but implementation overall looks correct, just with some style/formatting issues. Comment at: clang/include/clan

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Adding new types to the type system is quite invasive; was there an RFC for this you can point me to along with a design document? I have no idea how to review this bec

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

carlosgalvezp updated this revision to Diff 453277. carlosgalvezp added a comment. Added unit test for implicit capture (ref and value) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131780/new/ https://reviews.llvm.org/D131780 Files: clang-tool

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Same question here about an RFC for adding this new type to the type system and a design document for how the type behaves as in https://reviews.llvm.org/D122215. ==

[PATCH] D130510: Missing tautological compare warnings due to unary operators

aaron.ballman added a comment. In D130510#3727096 , @rtrieu wrote: > This patch has been moving back and forth between > `IsIntegerLiteralConstantExpr` and `getIntegerLiteralSubexpressionValue`. > The first function is preexisting and the second one is

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. working on the test. Will update the patch soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 ___ cfe-commits mailing list cfe-

[PATCH] D131935: [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit

jloser accepted this revision. jloser added a comment. This revision is now accepted and ready to land. LGTM! Thanks for the follow-up cleanup. I'll rebase once this lands to avoid the cast in https://reviews.llvm.org/D131869 if that works for you. Repository: rG LLVM Github Monorepo CHANGES

[clang] 656c5d6 - [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit

Author: Paul Kirth Date: 2022-08-17T14:38:53Z New Revision: 656c5d652ce10257e90c7693b34336b6ce0ecfa3 URL: https://github.com/llvm/llvm-project/commit/656c5d652ce10257e90c7693b34336b6ce0ecfa3 DIFF: https://github.com/llvm/llvm-project/commit/656c5d652ce10257e90c7693b34336b6ce0ecfa3.diff LOG: [c

[PATCH] D131935: [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG656c5d652ce1: [clang][llvm][NFC] Change misexpect's tolerance option to be 32-bit (authored by paulkirth). Repository: rG LLVM Github Monorepo CH

[PATCH] D131942: [clang][Inter[ Implement bool and nullptr literal expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { + Co

[PATCH] D131942: [clang][Inter[ Implement bool and nullptr literal expressions

tbaeder updated this revision to Diff 453284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131942/new/ https://reviews.llvm.org/D131942 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Disasm.cpp clang/lib/AST/Interp/Fun

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { +

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

chrish_ericsson_atx updated this revision to Diff 453286. chrish_ericsson_atx added a comment. Corrected git-clang-format issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131926/new/ https://reviews.llvm.org/D131926 Files: clang-tools-extra/clang-tidy/bugprone/SizeofExpressionChe

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375. We should also not c

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

jamieschmeiser added a comment. Good progress. Comment at: clang/lib/Driver/Driver.cpp:97 #include "llvm/Support/raw_ostream.h" +#include #include This include isn't necessary. There are asserts already in the file so this is transitively included.

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. In D131547#3723083 , @dmgreen wrote: > I think we usually try to do the same, if the intrinsics have been in > released compilers. There is an example in > https://reviews.llvm.org/D98487#change-tOTTgECYYAO5, hopefully these w

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

cor3ntin abandoned this revision. cor3ntin added a comment. No longer pursuing that as llvm 14 seems EOL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123850/new/ https://reviews.llvm.org/D123850 ___ cfe

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

dmgreen added a comment. In D131547#3728842 , @sdesmalen wrote: > In D131547#3723083 , @dmgreen wrote: > >> I think we usually try to do the same, if the intrinsics have been in >> released compilers. There is an

[PATCH] D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-const-or-ref-data-members.cpp:191 + auto r5 = [&x5]{}; +} njames93 wrote: > Can you add some cases with implicit capture (using [=] and [&]) I should

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { +

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, -

[clang] 74b5dad - Add N2653 to the C2x status page

Author: Aaron Ballman Date: 2022-08-17T11:30:31-04:00 New Revision: 74b5dad5e944db21e56e6d81eb14f11891a741ab URL: https://github.com/llvm/llvm-project/commit/74b5dad5e944db21e56e6d81eb14f11891a741ab DIFF: https://github.com/llvm/llvm-project/commit/74b5dad5e944db21e56e6d81eb14f11891a741ab.diff

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonars

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression-2.c:42 + sum += sizeof(__typeof(&TS)); + sum += sizeof(STRKWD MyStruct*); + sum += sizeof(__typeof(STRKWD MyStruct*)); Based on the document

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske updated this revision to Diff 453297. balazske added a comment. StdLibraryFunctionsChecker should not overwrite errno constraints that are set by StreamChecker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132017/new/ https://reviews.llvm

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well; should we add a release note for this? I suspect not because it's improving an experimental feature that's not really ready for prime time yet, but I don't know how others feel. CHANGES SINCE LAST ACTION https

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane added a comment. In D131942#3728974 , @aaron.ballman wrote: > LGTM as well; should we add a release note for this? I suspect not because > it's improving an experimental feature that's not really ready for prime time > yet, but I don't know

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added a comment. Precommit CI is failing with a failure that looks like it's relevant: TEST 'Clang :: Parser/static_assert.c' FAILED Script: -- : 'RUN: at line 1'; c:\ws\w9\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3728994 , @erichkeane wrote: > In D131942#3728974 , @aaron.ballman > wrote: > >> LGTM as well; should we add a release note for this? I suspect not because >> it's impr

[PATCH] D131685: [clang][AST] RecursiveASTVisitor should visit owned TagDecl of friend type.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks like a reasonable representation of such record decls to me. Changing the AST to nest them under typelocs instead is indeed a bigger project (and it's hard to say whether it's

[PATCH] D132031: Do not evaluate dependent immediate invocations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this LGTM, though I did have a testing question. Also, please be sure to add a release note for the fix. Comment at: clang/test/SemaCXX/cxx2a-conste

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. In D131547#3728867 , @dmgreen wrote: > In D131547#3728842 , @sdesmalen > wrote: > >> In D131547#3723083 , @dmgreen >> wrote: >> >>> I think we

[PATCH] D131555: [Clang] Propagate const context info when emitting compound literal

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131555/new/ https://reviews.llvm.org/D131555 _

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

mizvekov added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/sizeof-expression.cpp:236-238 - // CHECK-MESSAGES: :[[@LINE-1]]:10: warning: suspicious usage of 'sizeof(A*)'; pointer to aggregate sum += sizeof(PMyStruct); - // CHECK-MESSAGES

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 453328. Ericson2314 marked an inline comment as done. Ericson2314 added a comment. Rebase, fix outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Fi

[PATCH] D131255: Fix Wbitfield-constant-conversion on 1-bit signed bitfield

aaron.ballman added a comment. After some more thought and some offline discussions, I think I have a reasonable way forward: let's add `-Wsingle-bit-bitfield-constant-conversion` as a new warning group under `-Wbitfield-constant-conversion` that controls the diagnostic for one-bit bitfields. T

[PATCH] D132030: [analyzer] Pass correct bldrCtx to computeObjectUnderConstruction

tomasz-kaminski-sonarsource updated this revision to Diff 453334. tomasz-kaminski-sonarsource added a comment. Fixed formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132030/new/ https://reviews.llvm.org/D132030 Files: clang/include/clan

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:95-98 + static CompressionSpecRef Unknown; + static CompressionSpecRef None; + static CompressionSpecRef Zlib; + static CompressionSpecRef ZStd; dblaikie wrote: > ckissane wro

[PATCH] D131926: [clang-tidy] Fix for bugprone-sizeof-expression PR57167

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from removing some comments now that we figured out what's going on. Please hold off on landing for a day or two in case @njames93 has other opinions though. Comment at: clang-tools-extra/test/cl

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3140 + return CGF.Builder.CreateFPExt(result, ConvertType(E->getType())); + } + return result; rjmccall wrote: > zahiraam wrote: > > rjmccall wrote: > > > Please extract this bl

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

tbaeder added a comment. In D131942#3729057 , @aaron.ballman wrote: > In D131942#3728994 , @erichkeane > wrote: > >> In D131942#3728974 , >> @aaron.ballman wrote: >> >>

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. With this last patch, the behaviors of CodeGen/volatile-1.c and CodeGenCXX/volatile-1.cpp have changed ( change with __imag). I have uploaded the changes but still trying to figure out what exactly changed and why. Thanks. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453345. arda added a comment. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Add clang and llvm related changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://rev

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3729379 , @tbaeder wrote: > In D131942#3729057 , @aaron.ballman > wrote: > >> In D131942#3728994 , @erichkeane >> wrote: >> >>>

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 453346. abrahamcd added a comment. Removed Clang name from FileCheck test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://reviews.llvm.org/D131632 Files: clang/include/clang/Frontend/SAR

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:213 TestAndClearIgnoreImag(); +PromotionType = getPromotionType(E->getSubExpr()->getType()); +if (!PromotionType.isNull()) Same problem Comment at: cla

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik updated this revision to Diff 453350. shafik marked 2 inline comments as done. shafik added a comment. - Simplify condition to set `ConstexprVar` even more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 Files: clang/lib/AST/ExprConst

[PATCH] D129507: [llvm-objcopy] Add option to dump embedded offloading images

jhuber6 updated this revision to Diff 453354. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Moving to clang packager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129507/new/ https://reviews.llvm.o

[clang-tools-extra] fa8f861 - [clang-tidy] hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

Author: Vladimir Plyashkun Date: 2022-08-17T19:25:59+01:00 New Revision: fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8 URL: https://github.com/llvm/llvm-project/commit/fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8 DIFF: https://github.com/llvm/llvm-project/commit/fa8f8616028abbc10aa5a3ad4641e8a40ec20cc8.

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa8f8616028a: [clang-tidy] hicpp-signed-bitwise - Return location of the operand (and not of… (authored by vladimir.plyashkun, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen updated this revision to Diff 453373. ychen added a comment. - add more explanation as comments - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 Files: clang/lib/CodeGen/CGDeclCXX.cpp cl

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

ychen added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:580 +I = DelayedCXXInitPosition.find(D); +unsigned LexOrder = I == DelayedCXXInitPosition.end() ? ~0U : I->second; +AddGlobalCtor(Fn, 65535, LexOrder, COMDATKey); efriedma wrote:

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

rymiel added a comment. It seems that even with this patch, there is seemingly weird formatting with the negation in requires clauses, such as: template requires !F int bar(T t); This is because the "fake parens" of the unary expression opened is never closed by the special

[PATCH] D132056: [HLSL] Restrict to supported targets

beanz created this revision. beanz added reviewers: aaron.ballman, bogner, python3kgae, pow2clk, jcranmer-intel. Herald added subscribers: Anastasia, JDevlieghere. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. Someday we would like to support

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane updated this revision to Diff 453379. ckissane added a comment. - remove CompressionSpecRefs::{Zlib,ZStd} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131992/new/ https://reviews.llvm.org/D131992 Files: clang-tools-extra/clangd/index/S

[PATCH] D131992: [Support] compression proposal for a enum->spec->impl approach

ckissane marked 6 inline comments as done. ckissane added inline comments. Comment at: llvm/include/llvm/Support/Compression.h:40 +CompressionSpecRef getCompressionSpec(CompressionKind Kind); +CompressionSpecRef getSchemeDetails(CompressionImplRef Implementation); + -

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 453386. arda added a comment. Replace section name from .fatlto to .llvm.lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ https://reviews.llvm.org/D131618 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453388. Codesbyusman added a comment. updated test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analys

[PATCH] D131874: [Clang] Tighten restrictions on enum out of range diagnostic to avoid constant initialization

shafik updated this revision to Diff 453389. shafik marked an inline comment as done. shafik added a comment. - Added `consteval` test with default parameters CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131874/new/ https://reviews.llvm.org/D131874 Files: clang/lib/AST/ExprConstant.

[PATCH] D130531: [IR] Use Min behavior for module flag "PIC Level"

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130531/new/ https://reviews.llvm.org/D130531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

  1   2   >