[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. @uabelho Hi, that's a typeinfo symbol of libc++ abi. It's quite weird that __cxa_throw is availble while _ZTIPKc is not. Do you have some special setting regarding libc++ in your environment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:136-137 {{CDF_MaybeBuiltin, "memcpy", 3}, - std::bind(&CStringChecker::evalMemcpy, _1, _2, _3, false)}, + std::bind(&CStringChecker::evalMemcpy, _1, _2, _3, +

[clang] 9b1897b - [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

Author: Rainer Orth Date: 2022-07-29T09:19:38+02:00 New Revision: 9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460 URL: https://github.com/llvm/llvm-project/commit/9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460 DIFF: https://github.com/llvm/llvm-project/commit/9b1897bbd0e3a6e9ef099e74c3d3ed35428c0460.diff L

[PATCH] D130569: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1897bbd0e3: [Driver] Use libatomic for 32-bit SPARC atomics support on Linux (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D130273: [clang][Driver] Handle SPARC -mcpu=native etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3714884ae4: [clang][Driver] Handle SPARC -mcpu=native etc. (authored by ro). Changed prior to commit: https://reviews.llvm.org/D130273?vs=448290

[clang] bf37148 - [clang][Driver] Handle SPARC -mcpu=native etc.

Author: Rainer Orth Date: 2022-07-29T09:27:09+02:00 New Revision: bf3714884ae4b4a0301bc6af78e8b4deff12558b URL: https://github.com/llvm/llvm-project/commit/bf3714884ae4b4a0301bc6af78e8b4deff12558b DIFF: https://github.com/llvm/llvm-project/commit/bf3714884ae4b4a0301bc6af78e8b4deff12558b.diff L

[PATCH] D130688: [Driver][Sparc] Default to -mcpu=v9 for SparcV8 on Linux

ro added a comment. In D130688#3686512 , @MaskRay wrote: > Making the behavior different for different Linux distributions is not great, > but if it matches the practice, I think it is fine. It's the best we can do in `clang`, I fear, due to the compile

[PATCH] D130747: [pseudo] wip/prototype: eliminate identifier ambiguities in the grammar.

hokein created this revision. hokein added reviewers: sammccall, usaxena95. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. See https://reviews.llvm.org/D130626 for details; A prototype to e

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

uabelho added a comment. In D129242#3686610 , @sunho wrote: > @uabelho Hi, that's a typeinfo symbol of libc++ abi. It's quite weird that > __cxa_throw is availble while _ZTIPKc is not. Do you have some special > setting regarding libc++ in your environm

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686397 , @thakis wrote: > It'd be nice if this was landed opt-in behind some cmake variable at first, > so that folks could try it out on their bots and see how well things work. You can already test this with `-DCMAK

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684399 , @h-vetinari wrote: > It may be worth calling out that this is about C++17 core language and not > the standard library? > > libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing > vari

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686718 , @thieta wrote: > In D130689#3684399 , @h-vetinari > wrote: > >> It may be worth calling out that this is about C++17 core language and not >> the standard library? >>

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 448539. cor3ntin added a comment. Put `isInitCapture` in `ValueDecl`. This allows a few code simplification in the resst of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews

[PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. From the text you quoted: > LLVM subprojects are written using standard C++17 code and avoid unnecessary vendor-specific extensions. I don't think the standard library can be called a vendor-specific extension, and so I think this still could/should be made clearer

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686723 , @h-vetinari wrote: > I don't think the standard library can be called a vendor-specific extension, > and so I think this still could/should be made clearer (even though the > status links below would show up

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

nlopes added a comment. Would it be possible to implement this by dropping the `noundef` attribute rather than emitting a freeze? Seems like a much better option to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130224/new/ https://reviews.llvm

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 448543. cor3ntin marked 7 inline comments as done. cor3ntin added a comment. Add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/

[PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. My point boils down to: "written using standard C++17 code" does not sound at all like "core language, no stdlib", but very much like "core+stdlib". This is also the first time this split becomes relevant AFAIK, because for moving to C++14, the stdlib was ready basic

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 448544. cor3ntin added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clan

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:74 bool GCParity; +// Have we already used this node for error recovery? (prevents loops) +mutable bool Recovered = false; sammccall wrote: > hokein wrote:

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske updated this revision to Diff 448546. balazske marked an inline comment as done. balazske added a comment. Use shorter enum names, remove unneeded line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130470/new/ https://reviews.llvm.org/D13

[PATCH] D130470: [clang][analyzer] Add more wide-character functions to CStringChecker

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:136-137 {{CDF_MaybeBuiltin, "memcpy", 3}, - std::bind(&CStringChecker::evalMemcpy, _1, _2, _3, false)}, + std::bind(&CStringChecker::evalMemcpy, _1, _2, _3, +

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. After some further consideration, implementing this properly in LLVM would probably take more effort than is worthwhile (especially as this is target-specific functionality, so we'd actual

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. In D130108#3685620 , @owenpan wrote: > Can you open an issue at https://github.com/llvm/llvm-project/issues? See > https://github.com/llvm/llvm-project/issues/56736 for an example. Of course, here it is: https://github.com/llvm

[PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. In D130689#3686760 , @h-vetinari wrote: > My point boils down to: "written using standard C++17 > code" does not sound at all like "core language, no stdlib", but very much > like "core+stdlib". We're allowing C++17 library

[PATCH] D130550: [pseudo] Start rules are `_ := start-symbol EOF`, improve recovery.

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:74 bool GCParity; +// Have we already used this node for error recovery? (prevents loops) +mutable bool Recovered = false; hokein wrote: > sammccall wrot

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

yurai007 added a comment. In D130268#3684244 , @nikic wrote: > I think my only concern with this change is that it will also allow some > implicit ArrayRef constructors. For example, this will permit creating a > SmallVector from `std::array`, `std::vec

[PATCH] D130268: [NFC] Add SmallVector constructor to allow creation of SmallVector from ArrayRef of items convertible to type T

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM In D130268#3686811 , @yurai007 wrote: > In D130268#3684244 , @nikic wrote: > >> I think my only concern w

[PATCH] D130709: MSVC compatibility mode: fix error on unqualified templated base class initialization in case of partial specialization

frederic-tingaud-sonarsource updated this revision to Diff 448549. frederic-tingaud-sonarsource added a comment. Use getAs to see through ElaboratedType as recommended by https://reviews.llvm.org/D112374 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130709/new/ https://reviews.llvm.org

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. isAllowedInitiallyIDChar is only used with non-ASCII codepoints, which are handled by isAsciiIdentifierStart. To make that

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

pengfei created this revision. pengfei added a reviewer: nickdesaulniers. Herald added a subscriber: hiraditya. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This is to addre

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis updated this revision to Diff 448563. Maetveis added a comment. Updated to add missing comma after 'git ls-tree'. It broke normal (non staged) operation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 Files: clang/tools/clang-form

[PATCH] D128861: [clang-tidy] add cppcoreguidelines-symmetric-binary-operator

5chmidti added a comment. Gentle Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128861/new/ https://reviews.llvm.org/D128861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. Ping @vsapsai @Bigcheese @akyrtzi @benlangmuir @arphaman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126676/new/ https://reviews.llvm.org/D126676 ___ cfe-commits mailing list

[PATCH] D130690: [clangd][NFCI] Store TUPath inside ParsedAST

kadircet marked 2 inline comments as done. kadircet added a comment. as discussed offline, this patch stores the filepath provided by the client (e.g. vscode) which is usually the filepath seen by the user, inside the ParsedAST and later on uses that when a hint is needed for translating filepa

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:61 + +GlobalVariable *replaceCBuffer(CGHLSLRuntime::CBuffer &CB) { + const unsigned CBufferAddressSpace = 4; python3kgae wrote: > Anastasia wrote: > > I don't think I understand the

[clang-tools-extra] 3b8fb47 - [clangd][NFCI] Store TUPath inside ParsedAST

Author: Kadir Cetinkaya Date: 2022-07-29T13:23:42+02:00 New Revision: 3b8fb471cbbd704e3066b3cb7dddb755cad11b8b URL: https://github.com/llvm/llvm-project/commit/3b8fb471cbbd704e3066b3cb7dddb755cad11b8b DIFF: https://github.com/llvm/llvm-project/commit/3b8fb471cbbd704e3066b3cb7dddb755cad11b8b.dif

[PATCH] D130690: [clangd][NFCI] Store TUPath inside ParsedAST

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rG3b8fb471cbbd: [clangd][NFCI] Store TUPath inside ParsedAST (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/Analysis/AnalysisDeclContext.cpp:173 +ValueDecl *VD = LC.getCapturedVar(); +if (isSelfDecl(dyn_cast(VD))) return dyn_cast(VD); erichkeane wrote: > aaron.ballman wrote: > > This looks dangerous -

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

aaron.ballman added a comment. The change is fine by me, but you should put NFC in the patch title so it's more clear that this is simplifying code in a way that won't change behavior (and doesn't need tests). Comment at: clang/lib/Lex/Lexer.cpp:1486 static bool isAllowedIni

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin updated this revision to Diff 448581. cor3ntin added a comment. Fix asser message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 Files: clang/lib/Lex/Lexer.cpp Index: clang/lib/Lex/Lexer.cpp

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1486 static bool isAllowedInitiallyIDChar(uint32_t C, const LangOptions &LangOpts) { + assert(C > 0x7F && "isAllowedInitiallyIDChar called with a non-ASCII codepoint"); if (LangOpts.AsmPreprocessor) { -

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM assuming @tahonermann doesn't spot concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.o

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. In D129242#3686713 , @uabelho wrote: > In D129242#3686610 , @sunho wrote: > >> @uabelho Hi, that's a typeinfo symbol of libc++ abi. It's quite weird that >> __cxa_throw is availble while _Z

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

kadircet added a comment. Can you also add a test, preferably in clang/test/CodeCompletion/overrides.cpp ? Comment at: clang/lib/Parse/ParseDecl.cpp:3269 - if (getCurScope()->getFnParent() || getCurScope()->getBlockParent()) -CCC = Sema::PCC_LocalDeclarationSpeci

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

ro abandoned this revision. ro added a comment. Nick Clifton just commited a fix both to the binutils 2.39 branch and master. So the workaround certainly isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.l

[clang] fbe022f - [Libcalls] Add tests with maytrap & non-errno for math libcalls.

Author: Florian Hahn Date: 2022-07-29T13:45:34+01:00 New Revision: fbe022f18961bb2523072cf9d2649db81b0592c0 URL: https://github.com/llvm/llvm-project/commit/fbe022f18961bb2523072cf9d2649db81b0592c0 DIFF: https://github.com/llvm/llvm-project/commit/fbe022f18961bb2523072cf9d2649db81b0592c0.diff

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

dexonsmith added a comment. I haven’t reviewed the details of the patch and won’t have time to do so (at least for a while), but the description of the intended (more narrow) scope SGTM. With the scope limited to GCC directories this should be fine. There are cases where it’s safe to have misma

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

Anastasia created this revision. Anastasia added reviewers: svenvh, iliya-diyachkov. Herald added a subscriber: ebevhan. Herald added a project: All. Anastasia requested review of this revision. Herald added a subscriber: MaskRay. As discussed on RFC mapping into SPIR-V requires pointer being pres

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

Anastasia added a subscriber: linjamaki. Anastasia added a comment. CC to @linjamaki in case there is anything else/different needed for HIP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766 ___ cfe-c

[clang] b259027 - [NFCI] Propagate MLTAL through more concepts in prep of deferred inst.

Author: Erich Keane Date: 2022-07-29T05:54:04-07:00 New Revision: b25902736c2e330429278e1929cc5afd2201fb77 URL: https://github.com/llvm/llvm-project/commit/b25902736c2e330429278e1929cc5afd2201fb77 DIFF: https://github.com/llvm/llvm-project/commit/b25902736c2e330429278e1929cc5afd2201fb77.diff L

[PATCH] D130768: [OpenCL][SPIR-V] Add test for extern functions with a pointer

Anastasia created this revision. Anastasia added reviewers: svenvh, iliya-diyachkov. Herald added subscribers: ebevhan, yaxunl. Herald added a project: All. Anastasia requested review of this revision. I would like to add this test case that enhances coverage of opaque pointers particularly for t

[PATCH] D130766: [SPIR-V] Disable opaque pointers in relese 15

nikic added reviewers: jcranmer-intel, opaque-pointers. nikic added a comment. LG from my side, as a temporary workaround. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130766/new/ https://reviews.llvm.org/D130766 ___ cfe-commits mailing list

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG. Now that LLVM 15 has branched, I think it is safe to land this, and there will be enough time before LLVM 16 to convert it to the token variant. Comment at: llvm/docs/Lang

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

erichkeane added a comment. CodeGen tests is still not testing what we intend I believe (sorry if I missed the response to this!), plus I would like a quick explanation as to what is going on in 1 place, otherwise I think this is about right. Hopefully Aaron/Shafik can take a quick look throug

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

arsenm added a comment. In D130224#3686756 , @nlopes wrote: > Would it be possible to implement this by dropping the `noundef` attribute > rather than emitting a freeze? Seems like a much better option to me. See @nhaehnle's post here

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

samestep added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3963 +TEST(TransferTest, ContextSensitiveSetBothTrueAndFalse) { + std::string Code = R"( ymandel wrote: > ymandel wrote: > > samestep wrote: > > > ymandel wrote

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

nlopes added a comment. In D130224#3687351 , @arsenm wrote: > In D130224#3686756 , @nlopes wrote: > >> Would it be possible to implement this by dropping the `noundef` attribute >> rather than emitting a freeze?

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

mubarizafzal added a comment. Hi, the test cases that this patch introduces are failing on some ppc64le (Linux on Power) buildbots: https://lab.llvm.org/buildbot/#/builders/57 https://lab.llvm.org/buildbot/#/builders/230 Would you mind taking a look please? Repository: rG LLVM Github Monorep

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3687227 , @dexonsmith wrote: > I haven’t reviewed the details of the patch and won’t have time to do so (at > least for a while), but the description of the intended (more narrow) scope > SGTM. With the scope limite

[PATCH] D130777: Enable embedded lto for XCOFF.

sfertile created this revision. sfertile added reviewers: hubert.reinterpretcast, DiggerLin, nemanjai, MaskRay, tejohnson, mehdi_amini, phosek, arda. Herald added subscribers: ormris, StephenFan, steven_wu, kbarton, hiraditya, inglorion, mgorny. Herald added a project: All. sfertile requested rev

[PATCH] D127812: [AArch64] Function multiversioning support added.

danielkiss requested changes to this revision. danielkiss added a comment. This revision now requires changes to proceed. Please find the thread on the GCC mailing list here: https://gcc.gnu.org/pipermail/gcc/2022-July/239134.html Feedback there sounds positive to me. All received feedback added

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn updated this revision to Diff 448628. fhahn added a comment. In D129231#3638946 , @john.brawn wrote: > Looking at the descriptions of maths functions in C99 (and I expect C11 will > be the same) it looks like there are three kinds: > > - Those t

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:18399 + if (Diagnose) +diagnoseUncapturableValueReferenceOrBinding(S, Loc, Var); + return false; erichkeane wrote: > first, why are we checking for !CPlusPlus... aren't Bind

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/cxx20-decomposition.cpp:26 +// CHECK: %{{.*}} = load ptr, {{.*}} +// CHECK: %{{.*}} = load i32, {{.*}} +// CHECK: %{{.*}} = getelementptr {{.*}}, i32 0, i32 0 cor3ntin wrote: > erichkeane wrote:

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

tahonermann accepted this revision. tahonermann added a comment. LGTM, thanks Corentin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 ___ cfe-commits mailing

[clang] ad16268 - [Clang] Do not check for underscores in isAllowedInitiallyIDChar

Author: Corentin Jabot Date: 2022-07-29T17:46:38+02:00 New Revision: ad16268f135001bd21a805ae8acf8d8243793984 URL: https://github.com/llvm/llvm-project/commit/ad16268f135001bd21a805ae8acf8d8243793984 DIFF: https://github.com/llvm/llvm-project/commit/ad16268f135001bd21a805ae8acf8d8243793984.diff

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

This revision was automatically updated to reflect the committed changes. Closed by commit rGad16268f1350: [Clang] Do not check for underscores in isAllowedInitiallyIDChar (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/n

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Since it has been deprecated for 2 releases, it seems reasonable to cleanup. This seems good to me from the build side, please do wait a bit for anyone else to chime in on this. Reposit

[PATCH] D130750: [Clang] Do not check for underscores in isAllowedInitiallyIDChar

cor3ntin added a comment. Thank you both! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130750/new/ https://reviews.llvm.org/D130750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

thakis added a comment. Hello, this breaks a bunch of existing code over here (and I imagine elsewhere). Can we make this a warning that's mapped to an error by default, so that people can turn it off for a while while they fix their code? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

tahonermann added inline comments. Comment at: clang/docs/ReleaseNotes.rst:55-57 +- Clang will now correctly diagnose as ill-formed a constant expression where an + enum without a fixed underlying type is set to a value outside the range of + of the enumerations values. Fixes

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ckandeler updated this revision to Diff 448655. ckandeler added a comment. Addressed remaining Objective-C issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 Files: clang-tools-extra/clangd/Semantic

[PATCH] D130726: [clang][dataflow] Handle multiple context-sensitive calls to the same function

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I'd love to see some comments in the source code to make sure one will not sue these facilities for other purposes that this was not designed to do. Alternatively, `ContextSensitive` opt

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. In D54943#3681527 , @sammccall wrote: > This check is enabled by default in LLVM (`Checks: misc-*` in > `llvm-project/.clang-tidy`) > > The warning on mutable non-ref local variables is pretty noisy: a *lot* of > existing code

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3687487 , @mubarizafzal wrote: > Hi, the test cases that this patch introduces are failing on some ppc64le > (Linux on Power) buildbots: > https://lab.llvm.org/buildbot/#/builders/57 > https://lab.llvm.org/buildbot/#/bui

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D130058#3687680 , @thakis wrote: > Hello, this breaks a bunch of existing code over here (and I imagine > elsewhere). Do you have an idea on how much a bunch is and whether the fixes are particularly involved or not? D

[clang] d8352ab - Diagnose use of _Noreturn on a struct/union field

Author: Aaron Ballman Date: 2022-07-29T13:18:44-04:00 New Revision: d8352abd3a4f411828dbe46c7dfd3e935ab4dd4a URL: https://github.com/llvm/llvm-project/commit/d8352abd3a4f411828dbe46c7dfd3e935ab4dd4a DIFF: https://github.com/llvm/llvm-project/commit/d8352abd3a4f411828dbe46c7dfd3e935ab4dd4a.diff

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball accepted this revision. Mogball added a comment. This revision is now accepted and ready to land. Got a few small nits but otherwise LGTM. Thanks for all the hard work! This looks really solid now. I haven't thought too hard about the performance of that while loop but it seems good enou

[clang] 4191d66 - [clang-repl] Disable execution unittests on unsupported platforms.

Author: Sunho Kim Date: 2022-07-30T02:28:03+09:00 New Revision: 4191d661c74622c6fa72c1643e4567f45e6c9e1b URL: https://github.com/llvm/llvm-project/commit/4191d661c74622c6fa72c1643e4567f45e6c9e1b DIFF: https://github.com/llvm/llvm-project/commit/4191d661c74622c6fa72c1643e4567f45e6c9e1b.diff LOG

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4191d661c746: [clang-repl] Disable execution unittests on unsuppor

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

aaron.ballman added a comment. In D130224#3687860 , @amyk wrote: > In D130224#3687487 , @mubarizafzal > wrote: > >> Hi, the test cases that this patch introduces are failing on some ppc64le >> (Linux on Power) b

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. > . I haven't thought too hard about the performance of that while loop but it > seems good enough to land for now. What's the finality of it? That is: outside of canonicalization what is its purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mogball added a comment. I'm referring to the nitty gritty details of the while loop inside the comparator. It looks pretty tight to me right now. If the operands are already sorted, worst-case each operand is compared against only its neighbours. Unfortunately, without extra bookkeeping, BFS w

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. @uabelho The thing is we have to statically link libstdc++ in JIT stack, but this is not possible at the moment in many platforms. It's actually possible with a new generation linker called JITLink, but it has limited platform support. For now, I just sumbitted a patch di

[PATCH] D129242: [clang-repl] Add host exception support check utility flag.

sunho added a comment. https://reviews.llvm.org/D130788 this is the patch fyi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129242/new/ https://reviews.llvm.org/D129242 ___ cfe-commits mailing list cfe-

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 448682. srishti-pm marked 3 inline comments as done. srishti-pm added a comment. Addressed the final NITs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files:

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

abidh added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); zixuan-wu wrote: > I think the multilib o

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

probinson added a comment. If you're going to post a patch for review, you really should wait for someone to review it before you land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130786/new/ https://reviews.llvm.org/D130786

[PATCH] D130790: Fix failing tests for "[Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values"

skc7 created this revision. skc7 added reviewers: aaron.ballman, ronlieb, arsenm. Herald added a subscriber: pengfei. Herald added a project: All. skc7 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Add target triple x86_64-gnu-linux

[PATCH] D130786: [clang-repl] Disable execution unittests on unsupported platforms.

sunho added a comment. In D130786#3688019 , @probinson wrote: > If you're going to post a patch for review, you really should wait for > someone to review it before you land it. I rushed as bots were breaking on the upstream. Sorry about that. Reposit

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

skc7 added a comment. In D130224#3687907 , @aaron.ballman wrote: > In D130224#3687860 , @amyk wrote: > >> In D130224#3687487 , @mubarizafzal >> wrote: >> >>> Hi, the tes

[clang] 4e1fe96 - Revert "[Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values"

Author: Amy Kwan Date: 2022-07-29T13:28:48-05:00 New Revision: 4e1fe968c9de73507a1bf0c8aa57e06be457816e URL: https://github.com/llvm/llvm-project/commit/4e1fe968c9de73507a1bf0c8aa57e06be457816e DIFF: https://github.com/llvm/llvm-project/commit/4e1fe968c9de73507a1bf0c8aa57e06be457816e.diff LOG:

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

thakis added a comment. Here's a reduced repro of one case: % cat test.cc typedef enum VkResult { VK_ERROR_INVALID_OPAQUE_CAPTURE_ADDRESS = -1000257000, VK_RESULT_MAX_ENUM = 0x7FFF } VkResult; constexpr VkResult VK_FAKE_DEVICE_OOM_FOR_TESTING = static_cast(VK_RESULT_MA

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3687907 , @aaron.ballman wrote: > In D130224#3687860 , @amyk wrote: > >> In D130224#3687487 , @mubarizafzal >> wrote: >> >>> Hi, the tes

[PATCH] D130224: [Clang][Attribute] Introduce maybe_undef attribute for function arguments which accepts undef values

amyk added a comment. In D130224#3688034 , @skc7 wrote: > In D130224#3687907 , @aaron.ballman > wrote: > >> In D130224#3687860 , @amyk wrote: >> >>> In D130224#3687487

[PATCH] D130791: [clang] Short-circuit trivial constexpr array constructors

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in https://github.com/llvm/llvm-project/issues/56774 Reposito

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta updated this revision to Diff 448694. furkanusta added a comment. - [clang] Add test case for D130363 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130363/new/ https://reviews.llvm.org/D130363 Files:

[PATCH] D130363: [clang] Give priority to Class context while parsing declarations

furkanusta added a comment. I've added a test case but I have a question. This is regardless of the current issue (i.e. no function context, clang++14 with no patches) struct X { virtual void foo(); }; struct Y : public X { over }; I am trying to complete override in class Y here, b

[PATCH] D130793: [clang-tidy] adjust treating of array-of-pointers when 'AnalyzePointers' is deactivated

JonasToth created this revision. JonasToth added reviewers: njames93, aaron.ballman, alexfh. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. JonasToth requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

  1   2   >