aaron.ballman added a comment.
The change is fine by me, but you should put NFC in the patch title so it's
more clear that this is simplifying code in a way that won't change behavior
(and doesn't need tests).
================
Comment at: clang/lib/Lex/Lexer.cpp:1486
static bool isAllowedInitiallyIDChar(uint32_t C, const LangOptions &LangOpts) {
+ assert(C > 0x7F && "isAllowedInitiallyIDChar called with a non-ASCII
codepoint");
if (LangOpts.AsmPreprocessor) {
----------------
nit: 80-col limit
Also, shouldn't this say it was called with an ASCII codepoint?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130750/new/
https://reviews.llvm.org/D130750
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
