[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca495e36c1b4: [clang] Add a new flag -fexperimental-library to enable experimental library… (authored by ldionne). Repository: rG LLVM Github Mono

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

vaibhav.y added a comment. Please address the whitespace changes in `clang/lib/Driver/ToolChains/Clang.cpp`. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:80-81 Args.getLastArg(options::OPT_dynamic, options::OPT_mdynamic_no_pic)) - D.Diag(diag::err_drv_a

[PATCH] D129802: [DRAFT] Implementing new atomic orderings in LLVM and generate barriers for legacy __sync builtins. Support corresponding memory model in outline atomics as well.

jyknight added a comment. In D129802#3654943 , @Wilco1 wrote: > The general requirement is that inline and outline atomics have identical > behaviour, and that GCC and LLVM emit the same sequences. I agree sync is > badly documented, so it's hard to fig

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4009-4011 +if (StringRef(A->getValue()) == "sarif") { + D.Diag(diag::warn_drv_sarif_format_unstable); +} cjdb wrote: > aaron.ballman wrote: > > Do we want to be kind t

[PATCH] D129992: [clang][OpenMP] Add IRBuilder support for taskgroup

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5207-5209 + if (T.clauses().size() > 0) +return false; + return true; simplification Repo

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd updated this revision to Diff 445917. abrahamcd marked an inline comment as done. abrahamcd added a comment. Removed unintended formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 Files:

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif option for future SARIF output

abrahamcd added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:80-81 Args.getLastArg(options::OPT_dynamic, options::OPT_mdynamic_no_pic)) - D.Diag(diag::err_drv_argument_not_allowed_with) << A->getAsString(Args) -

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

sammccall updated this revision to Diff 445920. sammccall added a comment. Make bundle_resources less sensitive to its working directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130004/new/ https://reviews.llvm.org/D130004 Files: clang-tool

[clang] a364987 - [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

Author: Denys Petrov Date: 2022-07-19T23:10:00+03:00 New Revision: a364987368a1c586088c62eb7cffcdef0f4ee852 URL: https://github.com/llvm/llvm-project/commit/a364987368a1c586088c62eb7cffcdef0f4ee852 DIFF: https://github.com/llvm/llvm-project/commit/a364987368a1c586088c62eb7cffcdef0f4ee852.diff

[PATCH] D130029: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa364987368a1: [analyzer][NFC] Use `SValVisitor` instead of explicit helper functions (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

mwyman added a comment. Hi, I work with @dmaclach. I know this has been sitting around without much activity for two years, but we believe there is a solid use-case for this on our end and I'd like to help get the ABI nailed down and land this change (or one accomplishing the same goal). Do you

[clang-tools-extra] c91ce94 - [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

Author: Sam McCall Date: 2022-07-19T22:32:11+02:00 New Revision: c91ce941448a8c67268b3c36797cbea9ad711216 URL: https://github.com/llvm/llvm-project/commit/c91ce941448a8c67268b3c36797cbea9ad711216 DIFF: https://github.com/llvm/llvm-project/commit/c91ce941448a8c67268b3c36797cbea9ad711216.diff LO

[PATCH] D130004: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc91ce941448a: [pseudo] Add `clang-pseudo -html-forest=`, an HTML forest browser (authored by sammccall). Changed prior to commit: ht

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

plotfi added a comment. In D86049#3663726 , @mwyman wrote: > Hi, I work with @dmaclach. I know this has been sitting around without much > activity for two years, but we believe there is a solid use-case for this on > our end and I'd like to help get the

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. If you didn't apply my patch, then it works from in-tree build because it uses static libs instead of the dylib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 __

[PATCH] D130123: [Phabricator] extend ptr32 support to be applied on typedef

Ariel-Burton created this revision. Ariel-Burton added reviewers: akhuang, rnk, rsmith. Herald added a project: All. Ariel-Burton requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Earlier, if the QualType was sugared, then we would error out

[PATCH] D130123: [Phabricator] extend ptr32 support to be applied on typedef

akhuang accepted this revision. akhuang added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130123/new/ https://reviews.llvm.org/D130123 __

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne added a comment. I saw that this change broke `llvm-clang-x86_64-sie-ubuntu-fast`, and I am following up with the bot owner to understand what's special about their target. I'm not being notified of any other failures so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

hubert.reinterpretcast added a comment. In D129401#3662857 , @quinnp wrote: > @hubert.reinterpretcast please correct me if I am wrong about why this change > is needed. I think your description is correct. Comment at: llvm/lib/LTO/LT

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:174 auto L = D.getLocation(); + // Use the start of the first selector fragment instead of the -/+ location. + if (const auto *MD = dyn_cast(&D)) kadircet wrote: > can we do this in

[PATCH] D109977: LLVM Driver Multicall tool

abrachet added a comment. In D109977#3662859 , @mgorny wrote: > The actual problem is that you're passing `${USE_SHARED}` to `llvm_config()` > (in `add_llvm_executable`) before it's defined. Moving the definition earlier > fixed this error but uncovers

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445951. dgoldman added a comment. Minor grammar update to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-t

[PATCH] D129536: [CUDA][FIX] Make shfl[_sync] for unsigned long long non-recursive

jdoerfert added a comment. @tra, unsure about the crash. For me this passes fine (no gpu), is anything missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129536/new/ https://reviews.llvm.org/D129536 ___

[PATCH] D130089: update-test-checks: safely handle tests with #if's

arichardson accepted this revision. arichardson added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll:2 ; Check that we accept functions with '$' in the name. ; TO

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath updated this revision to Diff 445954. sridhar_gopinath marked 4 inline comments as done. sridhar_gopinath added a comment. Changes to the args order and changing check_call -> run Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129311

[PATCH] D129311: [clang-format] Update return code

sridhar_gopinath marked 4 inline comments as done. sridhar_gopinath added inline comments. Comment at: clang/tools/clang-format/git-clang-format:539-540 # filter. - subprocess.check_call(['git', 'diff', '--diff-filter=M', old_tree, new_tree, - '--']) +

[PATCH] D130123: Extend ptr32 support to be applied on typedef

rnk added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); This seems like a good place to use getSingleStepDesugaredType to look through all typ

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

kerbowa updated this revision to Diff 445965. kerbowa added a comment. Fix some bugs. Add better pipeline fitting. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128158/new/ https://reviews.llvm.org/D128158 Files: clang/include/

[PATCH] D128462: [HLSL] add -I option for dxc mode.

python3kgae updated this revision to Diff 445967. python3kgae added a comment. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: clang-tools-extra. Fix test fail in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

thomasetter created this revision. thomasetter added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. thomasetter requested review of this revision. Herald added a subscriber: cfe-commits. readability-avoid-const-params-in-decls.IgnoreM

[PATCH] D112103: [WIP][RFC] Sample code for containerizing offload images into one ELF.

vzakhari abandoned this revision. vzakhari added a comment. Herald added a project: All. Not working on the project any more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112103/new/ https://reviews.llvm.org/D112103 __

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, Anastasia, kuhar, bogner, beanz, pow2clk. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cbuffer A { float a; flo

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 445978. aeubanks marked an inline comment as done. aeubanks added a comment. Herald added a subscriber: arphaman. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128955/new/ https://reviews.llvm.org/D1289

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks added inline comments. Comment at: clang/test/CodeGenCXX/thinlto-distributed-type-metadata.cpp:22 // OPT-NOT: @llvm.type.test -// OPT-NOT: call void @llvm.assume // We should have only one @llvm.assume call, the one that was expanded tejohnson wrote: >

[clang] f693874 - [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

Author: Volodymyr Sapsai Date: 2022-07-19T16:29:33-07:00 New Revision: f693874c53c1b3d3a322de98c1c7557d69157d3d URL: https://github.com/llvm/llvm-project/commit/f693874c53c1b3d3a322de98c1c7557d69157d3d DIFF: https://github.com/llvm/llvm-project/commit/f693874c53c1b3d3a322de98c1c7557d69157d3d.di

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf693874c53c1: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC. (authored by vsapsai). Repository: rG LLVM Github Monorepo CHA

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 3f73c57 - Argument name support for function pointer signature hints

Author: Qwinci Date: 2022-07-19T20:02:26-04:00 New Revision: 3f73c5793515867935d59ff8c511c61ace848e79 URL: https://github.com/llvm/llvm-project/commit/3f73c5793515867935d59ff8c511c61ace848e79 DIFF: https://github.com/llvm/llvm-project/commit/3f73c5793515867935d59ff8c511c61ace848e79.diff LOG: A

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov updated this revision to Diff 445993. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/JSONNodeDumper.h clang/include/clang/

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1533 + *ReplacedOrErr, ToReplacementTypeOrErr->getCanonicalType(), + T->getPackIndex()); } shafik wrote: > I think we should have a tes

[PATCH] D130065: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

xiangzhangllvm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:746 // Indicate that we want to instrument return control flow protection. -getModule().addModuleFlag(llvm::Module::Override, "cf-protection-return", +getModule().addModuleFlag(llvm

[PATCH] D129311: [clang-format] Update return code

owenpan added inline comments. Comment at: clang/tools/clang-format/git-clang-format:579 with temporary_index_file(old_tree): - subprocess.check_call(['git', 'checkout', '--patch', new_tree]) + subprocess.run(['git', 'checkout', '--patch', new_tree], check=True)

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

ldionne added a comment. I just got notified of a failure on `clang-ppc64-aix`. I'll take a look first thing tomorrow morning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121141/new/ https://reviews.llvm.org/D121141

[PATCH] D130065: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

xiangzhangllvm added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:746 // Indicate that we want to instrument return control flow protection. -getModule().addModuleFlag(llvm::Module::Override, "cf-protection-return", +getModule().addModuleFlag(llvm

[PATCH] D130136: [clang-format] Indent tokens after hash only if it starts a line

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D128276: clang: perform deduction at the right depth on Sema::AddMethodTemplateCandidate

mizvekov planned changes to this revision. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:14176 + ParmVarDecl *Param = Method->getParamDecl(i); + if (!Param->hasDefaultArg()) { +IsError = true; shafik wrote: > Do we

[clang] 09d4dbc - [llvm-driver] Generate symlinks instead of executables for tools

Author: Alex Brachet Date: 2022-07-20T01:42:56Z New Revision: 09d4dbc3829e91397f96d7d7f243440555adee87 URL: https://github.com/llvm/llvm-project/commit/09d4dbc3829e91397f96d7d7f243440555adee87 DIFF: https://github.com/llvm/llvm-project/commit/09d4dbc3829e91397f96d7d7f243440555adee87.diff LOG:

[PATCH] D127800: [llvm-driver] Generate symlinks instead of executables for tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09d4dbc3829e: [llvm-driver] Generate symlinks instead of executables for tools (authored by abrachet). Herald added a project: clang. Herald added a

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai created this revision. vsapsai added reviewers: iains, rsmith, benlangmuir, arphaman. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Diagnostic for `-Wauto-import` shouldn't be a warning because it

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. In D129748#3662498 , @erichkeane wrote: > I'll note that I don't "like" the idea, so much as I see this patch as an > 'improvement' to unblock efforts with additional value, though not much of > one. I suspect as Aaron does

[PATCH] D130138: [modules] Replace `-Wauto-import` with `-Rmodule-include-translation`.

vsapsai added a comment. Not sure about the name of the flag `-Rmodule-include-translation`, seems to be verbose. So suggestions about the flag name are welcome. On the other hand, "auto-import" is expected to mean something else, for example, adding missing imports

[PATCH] D130123: Extend ptr32 support to be applied on typedef

Ariel-Burton added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7116 + for (;;) { +if (const TypedefType *TT = dyn_cast(Desugared)) { + Desugared = TT->desugar(); rnk wrote: > This seems like a good place to use getSingleStepDesugaredType to

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. Unsurprisingly, it fails just the same because using an undefined variable is equivalent to not using it at all, so once again you're trying to link to static libraries that are *not there*. When dylib linking is used, you can't link to static libraries here. Repositor

[clang] 41ae78e - Use has_value instead of hasValue (NFC)

Author: Kazu Hirata Date: 2022-07-19T20:15:44-07:00 New Revision: 41ae78ea3a931018cf2be58fb9eaa98bfeaf2db6 URL: https://github.com/llvm/llvm-project/commit/41ae78ea3a931018cf2be58fb9eaa98bfeaf2db6 DIFF: https://github.com/llvm/llvm-project/commit/41ae78ea3a931018cf2be58fb9eaa98bfeaf2db6.diff L

[clang] 0387da6 - Use value instead of getValue (NFC)

Author: Kazu Hirata Date: 2022-07-19T21:18:26-07:00 New Revision: 0387da6f4f68fb00183c76bfd4f4f48533bc10e1 URL: https://github.com/llvm/llvm-project/commit/0387da6f4f68fb00183c76bfd4f4f48533bc10e1 DIFF: https://github.com/llvm/llvm-project/commit/0387da6f4f68fb00183c76bfd4f4f48533bc10e1.diff L

[clang] e882ac5 - Mark test experimental-library-flag.cpp as XFAIL on PS4 and PS5 to get the bot green until the author can investigate.

Author: Douglas Yung Date: 2022-07-19T21:18:46-07:00 New Revision: e882ac54c4bf9257b6a06ab03263a9b15c640af1 URL: https://github.com/llvm/llvm-project/commit/e882ac54c4bf9257b6a06ab03263a9b15c640af1 DIFF: https://github.com/llvm/llvm-project/commit/e882ac54c4bf9257b6a06ab03263a9b15c640af1.diff

[PATCH] D130065: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

MaskRay marked 3 inline comments as done. MaskRay added a comment. Thanks:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130065/new/ https://reviews.llvm.org/D130065 ___ cfe-commits mailing list cfe-com

[clang] 23ba688 - [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

Author: Fangrui Song Date: 2022-07-19T21:20:02-07:00 New Revision: 23ba688f02ea72b0af3480cd95d31e9a79f2d92a URL: https://github.com/llvm/llvm-project/commit/23ba688f02ea72b0af3480cd95d31e9a79f2d92a DIFF: https://github.com/llvm/llvm-project/commit/23ba688f02ea72b0af3480cd95d31e9a79f2d92a.diff

[PATCH] D130065: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23ba688f02ea: [X86] Use Min behavior for cf-protection-{return,branch}/ibt-seal module flags (authored by MaskRay). Repository: rG LLVM Github Mon

[PATCH] D130136: [clang-format] Indent tokens after hash only if it starts a line

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130136/new/ https://reviews.llvm.org/D130136 __

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz updated this revision to Diff 446041. daiyousei-qz added a comment. resolve review comment produce expansion even if definition isn't available Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127082/new/ https://reviews.llvm.org/D127082

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

MaskRay created this revision. MaskRay added reviewers: danielkiss, pcc. Herald added subscribers: StephenFan, hiraditya, kristof.beyls. Herald added a project: All. MaskRay requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, s

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz marked 5 inline comments as done. daiyousei-qz added a comment. I have also moved the expansion out of the location checking branch. I think it's to find out if a macro actually has a definition which isn't always the case especially for special macros like `__FILE__`. Here's the c

[PATCH] D129401: [libLTO] Set data-sections by default in libLTO for ELF and XCOFF.

MaskRay added a comment. I am unsure about the `llvm/lib/LTO/LTOCodeGenerator.cpp` logic. Can't your downstream project set `Config.Options.DataSections = true;` instead? Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:572 CmdArgs.push_back("-plugin-opt=-function-s

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik updated this revision to Diff 446045. shafik marked 7 inline comments as done. shafik added a comment. - Added more tests - Added the calculation of the value range to `EnumDecl` so the code can be shared - Modified tests that were failing due to undefined behavior that this change catche

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/test/Sema/aarch64-sve-intrinsics/acle_sve_imm.cpp:209 svprfb(pg, const_void_ptr, svprfop(14)); - // expected-error-re@+1 {{argument value {{[0-9]+}} is outside the valid range [0, 13]}} + // expected-error-re@+1 {{must be a co

[PATCH] D130058: [Clang] Diagnose ill-formed constant expression when setting a non fixed enum to a value outside the range of the enumeration values

shafik added inline comments. Comment at: clang/include/clang/AST/Decl.h:3834 + void getValueRange(llvm::APInt &Max, llvm::APInt &Min) const; + I should add a documenting comment. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:3

[PATCH] D129016: [PowerPC] implemented @llvm.ppc.kill.canary to corrupt stack guard

shchenz added a comment. Seems current revision is not right. You select the wrong base commit when you create the diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129016/new/ https://reviews.llvm.org/D129016 __

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

barannikov88 added a comment. @ckissane I took fresh sources of LLVM and when I run cmake I get the following warning: -- Looking for compress2 -- Looking for compress2 - found CMake Warning at cmake/config-ix.cmake:149 (find_package): By not providing "Findzstd.cmake" in CMAKE_MODULE_

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1187 - if (!Definition.empty()) { + if (!Definition.empty() || !MacroExpansion.empty()) { Output.addRuler(); Sorry, I think I wasn't clear about what I was asking for... Rath

[PATCH] D130145: [AArch64] Simplify BTI/PAC-RET module flags

MaskRay updated this revision to Diff 446053. MaskRay added a comment. remove a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130145/new/ https://reviews.llvm.org/D130145 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/aarch

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1187 - if (!Definition.empty()) { + if (!Definition.empty() || !MacroExpansion.empty()) { Output.addRuler(); sammccall wrote: > Sorry, I think I wasn't clear about what I

<    1   2