mizvekov marked an inline comment as done. mizvekov added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:1533 + *ReplacedOrErr, ToReplacementTypeOrErr->getCanonicalType(), + T->getPackIndex()); } ---------------- shafik wrote: > I think we should have a test in `ASTImporterTest.cpp` to make sure we are > importing the pack index correctly. Thanks for the suggestion, implemented. It turns out we didn't even have any tests for importing `SubsTemplateTypeParmType` in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128113/new/ https://reviews.llvm.org/D128113 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
