[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driver gene

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

efriedma added a comment. Given this is an on-by-default warning already, I don't expect changing it to an error by default to have much impact in practice. Changing it fine. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.has

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd created this revision. Herald added a project: All. abrahamcd requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129886 Files: clang/include/clang/Basic/Diag

[clang] 6735773 - [AMDGPU] Add remarks to output some resource usage

Author: Vang Thao Date: 2022-07-15T11:01:53-07:00 New Revision: 67357739c6d36a61972c1fc0e829e35cb5375279 URL: https://github.com/llvm/llvm-project/commit/67357739c6d36a61972c1fc0e829e35cb5375279 DIFF: https://github.com/llvm/llvm-project/commit/67357739c6d36a61972c1fc0e829e35cb5375279.diff LOG

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67357739c6d3: [AMDGPU] Add remarks to output some resource usage (authored by vangthao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); efriedma wrote: > I'd prefer not to introduce unnece

[PATCH] D129886: Adds `-fdiagnostics-format=sarif` flag option and warning.

abrahamcd updated this revision to Diff 445073. abrahamcd added a comment. Edited commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129885/new/ https://reviews.llvm.org/D129885 ___ cfe-c

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

abrahamcd updated this revision to Diff 445077. abrahamcd retitled this revision from "Adds `-fdiagnostics-format=sarif` flag option and warning." to "[clang] Add -fdiagnostics-format=sarif for SARIF diagnostics". abrahamcd edited the summary of this revision. abrahamcd added a comment. Commit m

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

MaskRay added inline comments. Comment at: clang/test/Driver/cuda-phases.cu:270 + +// RUN: %clang -### -target powerpc64le-ibm-linux-gnu -ccc-print-phases --offload-new-driver \ +// RUN: --offload-arch=sm_52 --offload-arch=sm_70 %s %S/Inputs/empty.cpp 2>&1 | FileCheck --check-p

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman updated this revision to Diff 445086. aaron.ballman added a comment. Removed the SFINAEFailure and trap changes, added a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129881/new/ https://reviews.llvm.org/D129881 Files: clang-tools-extra/test/clang-tidy/che

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov closed this revision. ASDenysPetrov added a comment. Closed with bc08c3cb7f8e797fee14e96eedd3dc358608ada3 Comment at: clang/test/Analysis/print-ranges.cpp:1 +// RUN: %clang_analyze_cc1 -analyze

[PATCH] D129881: [C] Strengthen -Wint-conversion to default to an error

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8483 +if ((SemaRef.getLangOpts().CPlusPlus && Trap.hasErrorOccurred()) || +Res.isInvalid()) return ExprError(); aaron.ballman wrote: > efriedma wrote: > > I'd prefe

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

jhuber6 updated this revision to Diff 445087. jhuber6 added a comment. Adjusting tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129885/new/ https://reviews.llvm.org/D129885 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/cuda-phases.

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

ziqingluo-90 added a comment. Thanks @aaron.ballman , I plan to commit this patch on Monday (18th July 2022). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___ cfe-commits mailing list cfe-commits

[PATCH] D129464: [Clang][CodeGen] Set FP options of builder at entry to compound statement

rjmccall added a comment. This property adheres to a function definition, so it seems to me that an explicit *instantiation* ought to preserve it from the instantiated template definition, but an explicit *specialization* ought to be independent. i.e. #pragma float_control(precise, on, push)

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

cjdb added a comment. Thanks for getting this started! To get this ready for submission, would you be able to add a test please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 __

[clang] 5b8337c - [syntax] Some #includes cleanup, NFC.

Author: Haojian Wu Date: 2022-07-15T21:05:59+02:00 New Revision: 5b8337cf402b224c5ed310dc570aa471dcdbd116 URL: https://github.com/llvm/llvm-project/commit/5b8337cf402b224c5ed310dc570aa471dcdbd116 DIFF: https://github.com/llvm/llvm-project/commit/5b8337cf402b224c5ed310dc570aa471dcdbd116.diff LO

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

aaron.ballman created this revision. aaron.ballman added reviewers: fhahn, erichkeane, jroelofs. Herald added subscribers: kristof.beyls, mgorny. Herald added a project: All. aaron.ballman requested review of this revision. This updates the test suite to ignore `-Wint-conversion` warnings which ha

[PATCH] D129892: Fix aligning of trailing comments after comment at the end of a namespace

eoanermine created this revision. eoanermine added reviewers: owenpan, HazardyKnusperkeks, curdeius, MyDeveloperDay. eoanermine added projects: clang, clang-format. Herald added a project: All. eoanermine requested review of this revision. Herald added a subscriber: cfe-commits. - Fix aligning of

[PATCH] D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes

mstorsjo added subscribers: phosek, hans, thakis, rnk. mstorsjo added a comment. In D121141#3655323 , @ldionne wrote: > The `experimental-library-flag` test is currently failing on Windows because > on Windows, `-stdlib=libc++` seems to be ignored and we

[PATCH] D129886: [clang] Add -fdiagnostics-format=sarif for SARIF diagnostics

vaibhav.y added a comment. Might be worth hiding it from `--help`, despite the instability warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129886/new/ https://reviews.llvm.org/D129886 ___ cfe-comm

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

beanz added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2820 SourceLocation *EndLoc = nullptr); + Decl *ParseCTBuffer(SourceLocation &DeclEnd, + SourceLocation InlineLoc = SourceLocation()); nit

[PATCH] D129892: [clang-format] Fix aligning of trailing comments after comment at the end of a namespace

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17468-17470 + "// Lorem ipsum dolor sit amet, consectetur adipiscing elit. " + "Nullam cursus nunc\n" + "// non", Shouldn't this

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

ahatanak updated this revision to Diff 445130. ahatanak marked an inline comment as done. ahatanak added a comment. If a category decl doesn't have availability, inherit it from the class decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129504/ne

[PATCH] D129504: [libclang][ObjC] Inherit availability attribute from containing decls or interface decls

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129504/new/ https://reviews.llvm.org/D129504 _

[clang] bb957a8 - [CUDA] Make the new driver properly ignore non-CUDA inputs

Author: Joseph Huber Date: 2022-07-15T17:38:34-04:00 New Revision: bb957a8d524cd38d6c5f7d547302258026049438 URL: https://github.com/llvm/llvm-project/commit/bb957a8d524cd38d6c5f7d547302258026049438 DIFF: https://github.com/llvm/llvm-project/commit/bb957a8d524cd38d6c5f7d547302258026049438.diff

[PATCH] D129885: [CUDA] Make the new driver properly ignore non-CUDA inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb957a8d524c: [CUDA] Make the new driver properly ignore non-CUDA inputs (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

NoQ accepted this revision. NoQ added a comment. Looks great, thanks! Yes, I think refactoring can be done in a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 ___ cfe-commits maili

[clang] 46a6989 - [unittests/Tooling/DependencyScannerTest.cpp] Use `using namespace` instead of wrapping the `.cpp` file contents in namespaces, NFC

Author: Argyrios Kyrtzidis Date: 2022-07-15T16:10:36-07:00 New Revision: 46a69897364354c9ffcfb1f5f2341e675898d116 URL: https://github.com/llvm/llvm-project/commit/46a69897364354c9ffcfb1f5f2341e675898d116 DIFF: https://github.com/llvm/llvm-project/commit/46a69897364354c9ffcfb1f5f2341e675898d116.

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

ziqingluo-90 added a comment. In D128401#3656559 , @NoQ wrote: > Looks great, thanks! > > Yes, I think refactoring can be done in a follow-up patch. Thank you, @NoQ! Let me politely ping the rest of the commenters: @LegalizeAdulthood, @gribozavr2, @Eug

[PATCH] D129280: [analyzer] PlacementNewChecker, properly handle array overhead (cookie)

isuckatcs added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:157 "Storage provided to placement new is only {0} bytes, " -"whereas the allocated array type requires more space for " -"internal needs", -

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae updated this revision to Diff 445162. python3kgae added a comment. Code cleanup and add test for error case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129883/new/ https://reviews.llvm.org/D129883 Files: clang/include/clang/AST/De

[clang] a7789d6 - [clang-format][NFC] Replace SmallVector parameter with ArrayRef

Author: owenca Date: 2022-07-15T17:26:22-07:00 New Revision: a7789d6315ff663fb5e21698264b7b77e89312fe URL: https://github.com/llvm/llvm-project/commit/a7789d6315ff663fb5e21698264b7b77e89312fe DIFF: https://github.com/llvm/llvm-project/commit/a7789d6315ff663fb5e21698264b7b77e89312fe.diff LOG: [

[PATCH] D129883: [HLSL] Support cbuffer/tbuffer for hlsl.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/test/SemaHLSL/cbuffer_tbuffer.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s | FileCheck %s + beanz wrote: > This look

[PATCH] D129912: [Tooling/DependencyScanning] Enable passing a `vfs::FileSystem` object to `DependencyScanningTool`

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also include a unit test to validate that the `vfs::FileSystem` object is properly used. Repository: rG LLVM Github Mon

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

owenpan added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken &Tok, - const std::vector &Stack) { + const SmallVe

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 445172. omarahmed added a comment. Change removes to remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[clang] 3b0dce5 - Use value_or (NFC)

Author: Kazu Hirata Date: 2022-07-15T19:46:29-07:00 New Revision: 3b0dce5b8b1596c50360952a8fb031d52562ccf6 URL: https://github.com/llvm/llvm-project/commit/3b0dce5b8b1596c50360952a8fb031d52562ccf6 DIFF: https://github.com/llvm/llvm-project/commit/3b0dce5b8b1596c50360952a8fb031d52562ccf6.diff L

[PATCH] D129921: [clang-format] Never remove braces in macro definitions

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[clang-tools-extra] 246bf08 - Use drop_begin (NFC)

Author: Kazu Hirata Date: 2022-07-15T23:24:59-07:00 New Revision: 246bf08db3fe0c64a6f59b67a5f48d054f6f9901 URL: https://github.com/llvm/llvm-project/commit/246bf08db3fe0c64a6f59b67a5f48d054f6f9901 DIFF: https://github.com/llvm/llvm-project/commit/246bf08db3fe0c64a6f59b67a5f48d054f6f9901.diff L

<    1   2