[clang-tools-extra] 0e95921 - [clang-tidy] Improve check cert-dcl58-cpp.

Author: Balázs Kéri Date: 2022-07-14T09:04:03+02:00 New Revision: 0e95921bc303a206cc6ae1c21ee90ec223bf9e78 URL: https://github.com/llvm/llvm-project/commit/0e95921bc303a206cc6ae1c21ee90ec223bf9e78 DIFF: https://github.com/llvm/llvm-project/commit/0e95921bc303a206cc6ae1c21ee90ec223bf9e78.diff L

[PATCH] D129353: [clang-tidy] Improve check cert-dcl58-cpp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e95921bc303: [clang-tidy] Improve check cert-dcl58-cpp. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129353/new/ https://reviews.l

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. In D127187#3650824 , @iains wrote: > Hi @ChuanqiXu, > I have no comment on the technical content of the patch (it looks reasonable > to me). > > However, I wonder if we should be supplying th

[clang] 42b3a5f - [clang] Add missing header include

Author: Shoaib Meenai Date: 2022-07-14T00:21:09-07:00 New Revision: 42b3a5fb463fd616d981888abaf0f48ab0065a8d URL: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d DIFF: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d.diff

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

OikawaKirie created this revision. OikawaKirie added reviewers: vsavchenko, NoQ, ASDenysPetrov. OikawaKirie added a project: clang. Herald added subscribers: steakhal, manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a p

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

sebastian-ne added a comment. This breaks builds when LLVM is included with CMake’s `add_subdirectory`. I think the zstd target needs to be marked as imported. The following patch fixes the problem, although I’m not familiar enough with CMake to know if this is the right way to go: diff --git

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

aemerson added a comment. I just reverted this in 6e6be5f9504d because it seems to have broken macOS builds: llvm/lib/Support/Compression.cpp:24:10: fatal error: 'zstd.h' file not found #include ^~~~ Rep

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

eoanermine updated this revision to Diff 444556. eoanermine edited the summary of this revision. eoanermine added a comment. - Rename AlignRequiresClauseBody to RequiresExpressionIndentation - Introduce RequiresExpressionIndentationKind as a type of RequiresExpressionIndentation - Add more tests

[clang] 52cb972 - [CommandLine] --help: print "-o " instead of "-o="

Author: Fangrui Song Date: 2022-07-14T01:28:28-07:00 New Revision: 52cb972537dac7ac535b57ba9399d53549c027e8 URL: https://github.com/llvm/llvm-project/commit/52cb972537dac7ac535b57ba9399d53549c027e8 DIFF: https://github.com/llvm/llvm-project/commit/52cb972537dac7ac535b57ba9399d53549c027e8.diff

[clang-tools-extra] 52cb972 - [CommandLine] --help: print "-o " instead of "-o="

Author: Fangrui Song Date: 2022-07-14T01:28:28-07:00 New Revision: 52cb972537dac7ac535b57ba9399d53549c027e8 URL: https://github.com/llvm/llvm-project/commit/52cb972537dac7ac535b57ba9399d53549c027e8 DIFF: https://github.com/llvm/llvm-project/commit/52cb972537dac7ac535b57ba9399d53549c027e8.diff

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

kadircet added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1784 if (D->isInvalidDecl() || D->isUsed() || D->hasAttr()) return false; i think we can just bail out early here when the main file is a header file (i.e. lang opts have `IsHeader

[PATCH] D129742: [clang-format] Fix invalid-code-generation by RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: HazardyKnusperkeks, curdeius, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When removing

[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

whisperity added a comment. In D124447#3645197 , @sammccall wrote: > In D124447#3608747 , @aaron.ballman > wrote: > >> In general, I think this is looking pretty close to good. Whether clang-tidy >> should get t

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

sammccall added a comment. In D129642#3648197 , @sammccall wrote: > It's possible we should *only* be checking the IsHeaderFile flag here and > drop all the sourcemanager stuff, but I'm not sure of the implications - > thoughts appreciated. As discusse

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Appears that this regressed examples like this: // before int i = int{16} * 1024; // after int i = int{16}* 1024; Naively it looks like in all added examples, the token preceding the matching `{` of the `}` is one of `struct`, `class`, `union`, `enum`, or a `>`

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3650749 , @glandium wrote: > FWIW, this change also broke this check in Firefox's clang plugin: > https://searchfox.org/mozilla-central/rev/0d11f3660945ce35c49501bb44bc4f82bb2b503c/build/clang-plugin/NoPrincipalGetURI

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, vsapsai, ilya-biryukov, erichkeane, iains, v.g.vassilev. ChuanqiXu added a project: clang-modules. Herald added a reviewer: aaron.ballman. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a pr

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:1784 if (D->isInvalidDecl() || D->isUsed() || D->hasAttr()) return false; sammccall wrote: > kadirc

[PATCH] D129466: [clang-format][NFC] Replace most of std::vector with SmallVector

curdeius added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:40 static unsigned getLengthToMatchingParen(const FormatToken &Tok, - const std::vector &Stack) { + const SmallV

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

ChuanqiXu added a comment. Or is it better to add a special option `-fno-preferred-name` to ignore it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129748/new/ https://reviews.llvm.org/D129748 ___ cfe-c

[PATCH] D128921: [Sema] Merge C++20 concept definitions from different modules in same TU

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM if the comments about diagnostic get addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128921/new/ https://reviews.llvm.org/D1

[PATCH] D129691: [clang][test] fix typo in fn attr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/ https://reviews.llvm.org/D129691

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 added a comment. I think we cannot identify `struct`, `union`, `class` or `enum` by the right bracket. Clang-format will split the input into multiple lines. For instance `struct Tmp {} *tmp;` will be separated as `struct Tmp {` and `} *tmp;`. In annotating, we only handle the relat

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:74 +def FeatureFMV : SubtargetFeature<"fmv", "HasFMV", "true", + "Enable Function Multi Versioning support.">; echristo wrote: > What is this for? FMV is a target feature which is ena

[clang] bfe63ab - Thread safety analysis: Support builtin pointer-to-member operators

Author: Aaron Puchert Date: 2022-07-14T13:36:14+02:00 New Revision: bfe63ab63e22b61bd5898c65425e8ebe43189913 URL: https://github.com/llvm/llvm-project/commit/bfe63ab63e22b61bd5898c65425e8ebe43189913 DIFF: https://github.com/llvm/llvm-project/commit/bfe63ab63e22b61bd5898c65425e8ebe43189913.diff

[clang] e0c66c6 - Thread safety analysis: Don't erase TIL_Opcode type (NFC)

Author: Aaron Puchert Date: 2022-07-14T13:36:35+02:00 New Revision: e0c66c699eb000f604e24b1c4e73b899b4d942d3 URL: https://github.com/llvm/llvm-project/commit/e0c66c699eb000f604e24b1c4e73b899b4d942d3 DIFF: https://github.com/llvm/llvm-project/commit/e0c66c699eb000f604e24b1c4e73b899b4d942d3.diff

[PATCH] D129514: Thread safety analysis: Support builtin pointer-to-member operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe63ab63e22: Thread safety analysis: Support builtin pointer-to-member operators (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, efriedma. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We might have a CK_NoOp cast

[PATCH] D129752: Thread safety analysis: Handle additional cast in scoped capability construction

aaronpuchert added a comment. @efriedma, added you because this removes one of the `IgnoreParens` calls that you added in D76943 , and that I think should be dead code. (The one after `CXXBindTemporaryExpr`.) Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] b7e77ff - Rewording "static_assert" diagnostics

Author: Muhammad Usman Shahid Date: 2022-07-14T07:47:37-04:00 New Revision: b7e77ff25fb2412f6ab6d6cc75b0e2f97bd3 URL: https://github.com/llvm/llvm-project/commit/b7e77ff25fb2412f6ab6d6cc75b0e2f97bd3 DIFF: https://github.com/llvm/llvm-project/commit/b7e77ff25fb2412f6ab6d6cc75b0e2f97b

[PATCH] D129048: Rewording the "static_assert" to static assertion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7e77ff25fb2: Rewording "static_assert" diagnostics (authored by Codesbyusman, committed by aaron.ballman). Changed prior to commit: https://revie

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, delesley. Herald added a reviewer: NoQ. Herald added a project: All. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When support for copy elision

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. In D127873#3651364 , @jackhong12 wrote: > I think we cannot identify `struct`, `union`, `class` or `enum` by the right > bracket. Clang-format will split the input into multiple lines. For instance > `struct Tmp {} *tmp;` will

[PATCH] D129398: [ASTMatchers] Add a new matcher for callee declarations of Obj-C message expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129398/new/ https://reviews.llvm.org/D129398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/docs/ThreadSafetyAnalysis.rst:935 +// Same as constructors, but without tag types. (Requires C++17 copy elision.) +static MutexLocker Lock(Mutex *mu) ACQUIRE(mu) NO_THREAD_SAFETY_ANALYSIS { + return MutexLocker(m

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129737/new/ https://reviews.llvm.org/D129737

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added subscribers: efriedma, rsmith. aaronpuchert added a comment. Adding @rsmith because this essentially reverts rGe97654b2f28072ad9123006c05e03efd82852982 , and @efriedma because it partially reverts D76943

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

jackhong12 added a comment. Good point! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

aaronpuchert added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:435 /// Used to implement lazy copy and rewriting strategies. class Future : public SExpr { public: By the way, I considered using this, but it didn't seem

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

nhaehnle added a comment. I can't judge the Clang changes. On the LLVM side, can you also add the implementation and a test for the GlobalISel path? Plus, I have some minor inline comments. Comment at: llvm/docs/LangRef.rst:24546 + +The first argument is pointer, which refers

[PATCH] D129691: [clang][test] fix typo in fn attr

erichkeane accepted this revision. erichkeane added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/ https://reviews.llvm.org/D129691 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

erichkeane added a comment. Please include the full context of the patch with -U9. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 _

[PATCH] D129748: [Modules] Disable preferred_name attribute in C++20 Modules

erichkeane added a comment. I guess I don't have a good idea why this attribute would cause ODR issues? It would seem that if it appeared in 2 different TUs that we could just 'pick' whichever we wanted, right? The description in the bug report of the problem isn't clear to me what the actual

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

thakis added a comment. In D122258#3478727 , @davide wrote: > Compact unwind was developed as a goal to replace the DWARF unwind. Some apps > did not work if the OS was missing DWARF unwind, so we kept both for Intel. > The binary compatibility issue is

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

carlosgalvezp updated this revision to Diff 444633. carlosgalvezp added a comment. - Rebase onto latest main. - Remove references to std::reference_wrapper as alternative suggestions, as per: https://github.com/isocpp/CppCoreGuidelines/issues/1919 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129771: [clang-format] distinguish multiplication after brace-init from pointer

krasimir created this revision. Herald added a project: All. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After https://github.com/llvm/llvm-project/commit/b646f0955574c6ad4c156c9db522e46f597cfda9, the added regression test star

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 created this revision. int3 added reviewers: lld-macho, davide. Herald added a project: All. int3 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129772 Files: clang/d

[PATCH] D129772: [clang] Document -femit-compact-unwind flag in the User’s Manual

int3 added a comment. @davide just adding you in case you have opinions on the wording around the bincompat issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129772/new/ https://reviews.llvm.org/D129772 _

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

krasimir added a comment. Proposed https://reviews.llvm.org/D129771. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___ cfe-commits mailing list cfe-commits@li

[clang] cab3cfd - [clang] Do not crash on "requires" after a fatal error occurred.

Author: Adam Czachorowski Date: 2022-07-14T15:45:32+02:00 New Revision: cab3cfd013cf92c441c3acbfcc1844b267ab8659 URL: https://github.com/llvm/llvm-project/commit/cab3cfd013cf92c441c3acbfcc1844b267ab8659 DIFF: https://github.com/llvm/llvm-project/commit/cab3cfd013cf92c441c3acbfcc1844b267ab8659.d

[PATCH] D129499: [clang] Do not crash on "requires" after a fatal error occurred.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab3cfd013cf: [clang] Do not crash on "requires" after a fatal error occurred. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129499/new

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan updated this revision to Diff 444638. ebevhan added a comment. Herald added a subscriber: steakhal. Rebased and addressed some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 Files: clang-tools-extra/clang-tidy/bugprone/Virtu

[PATCH] D62574: Add support for target-configurable address spaces.

ebevhan added a comment. Sorry for the delay! I rebased the patch onto latest and it mostly worked, with a few hitches. Comment at: clang/lib/Sema/SemaCast.cpp:2617-2619 + (Self.getLangOpts().OpenCL && + (DestPPointee->isFunctionType() || +

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

SebastianPerta added a comment. >>But can you add some test coverage for this? In clang\test\Headers\limits.cpp there is: _Static_assert(USHRT_MAX == (unsigned short)~0ULL, ""); However as I said this needs a 16 bits target. Looking at the RUN commands at the top of the file I think I can solve

[clang] 32fe1a4 - [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

Author: Ella Ma Date: 2022-07-14T22:00:38+08:00 New Revision: 32fe1a4be95c90da9a24d63a097429ec7c3bbfba URL: https://github.com/llvm/llvm-project/commit/32fe1a4be95c90da9a24d63a097429ec7c3bbfba DIFF: https://github.com/llvm/llvm-project/commit/32fe1a4be95c90da9a24d63a097429ec7c3bbfba.diff LOG:

[PATCH] D129737: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in boolean type

This revision was automatically updated to reflect the committed changes. Closed by commit rG32fe1a4be95c: [analyzer] Fixing SVal::getType returns Null Type for NonLoc::ConcreteInt in… (authored by OikawaKirie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

aaron.ballman added a comment. In D129689#3651965 , @SebastianPerta wrote: >>>But can you add some test coverage for this? > In clang\test\Headers\limits.cpp there is: > _Static_assert(USHRT_MAX == (unsigned short)~0ULL, ""); > However as I said this ne

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_update_messages.cpp:17 -static int y; -#pragma omp declare target(y) - -void yyy() { -#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not external

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

cor3ntin added a comment. In D129689#3652010 , @aaron.ballman wrote: > In D129689#3651965 , > @SebastianPerta wrote: > But can you add some test coverage for this? >> In clang\test\Headers\limits.cpp there

[PATCH] D129694: [OPENMP] Make declare target static global externally visible

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_update_messages.cpp:17 -static int y; -#pragma omp declare target(y) - -void yyy() { -#pragma omp target update to(y) // expected-error {{the host cannot update a declare target variable that is not externally

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. One question, should the backends be passing -pie when using -r? I had adjusted the tests but cannot remember why I had changed the logic of the backend before submitting the diff. I had originally had -pie disabled with -r for Ananas and NetBSD. I noticed Fuchsia had...

[PATCH] D129640: [clang][ASTImporter] Improved handling of functions with auto return type.

martong added a comment. Thanks, nice work! Comment at: clang/lib/AST/ASTImporter.cpp:3237 + ParentMapContext &ParentC = DC->getParentASTContext().getParentMapContext(); + DynTypedNodeList P = ParentC.getParents(*S); + while (!P.empty()) { ===

[PATCH] D122768: [Clang][C++20] Support capturing structured bindings in lambdas

cor3ntin marked 4 inline comments as done. cor3ntin added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2933 + auto *FD = LambdaCaptureFields.lookup(BD); + assert(FD); + return EmitCapturedFieldLValue(*this, FD, CXXABIThisValue); shafik

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

skc7 updated this revision to Diff 444657. skc7 added a comment. Rebase and fix for review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128907/new/ https://reviews.llvm.org/D128907 Files: clang/include/clang/Basic/LangOptions.h clan

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added a comment. In D128907#3650750 , @jdoerfert wrote: > That said, I doubt this is even what we want. Throwing away the benefits of > the noundef for one special case. IIRC, I mentioned alternatives in the other > discussion already,... not tha

[PATCH] D109977: LLVM Driver Multicall tool

abrachet marked an inline comment as done. abrachet added a comment. In D109977#3611683 , @mgorny wrote: > This seems to have broken standalone builds for Gentoo. > > While building Clang, I get: > > CMake Error at /usr/lib/llvm/15/lib/cmake/llvm/LLVM-C

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. In D109977#3652091 , @abrachet wrote: > In D109977#3611683 , @mgorny wrote: > >> This seems to have broken standalone builds for Gentoo. >> >> While building Clang, I get: >> >> CMake Erro

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

martong added a comment. Very good! In D129498#3650595 , @NoQ wrote: > In D129498#3647348 , @ASDenysPetrov > wrote: > >> In D129498#3644222 , @NoQ wrote: >> >>> Maybe `c

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

v.g.vassilev added a comment. @tapaswenipathak, ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert added subscribers: RaviNarayanaswamy, Anastasia, tra, bader. jdoerfert added a comment. In D128907#3652077 , @arsenm wrote: > In D128907#3650750 , @jdoerfert > wrote: > >> That said, I doubt this is eve

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

arsenm added a comment. In D128907#3652140 , @jdoerfert wrote: > In D128907#3652077 , @arsenm wrote: > >> In D128907#3650750 , @jdoerfert >> wrote: >> >>> That said, I do

[PATCH] D129678: [analyzer][NFC] Tidy up handler-functions in SymbolicRangeInferrer

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Took a while to accept that this is indeed an NFC, but looks good! And indeed the code is better structured this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

jyknight added a comment. Just to move things forward here: I propose to continue and land this patch without mode 3 (there were only a couple comments left to address for that), and continue the discussion about whether to add mode 3 elsewhere. (I don't mind where, KSPP, gcc, or llvm issue tra

[PATCH] D104647: [analyzer] Support SVal::getType for pointer-to-member values

martong added a comment. In D104647#3643060 , @ASDenysPetrov wrote: > @vsavchenko Is this alive? I think, we could commit this and set Valery as the author (he is no longer working on CSA). Unless you find something wrong with the patch; in that case w

[PATCH] D128907: [Clang] Disable noundef attribute for languages which allow uninitialized function arguments

jdoerfert added a comment. @arsenm put this on the GPU working group agenda for tomorrow: https://docs.google.com/document/d/1m_oSe1HwtWdQ2JUmMRTAVHbUS7Dv4MRsqptiYcgK6iI/edit?usp=sharing Join in if you can! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D127270: [clang-format] Add space in placement new expression

curdeius accepted this revision. curdeius added inline comments. Comment at: clang/include/clang/Format/Format.h:3504 +enum AfterPlacementOperatorStyle : int8_t { + /// Removes space after ``new/delete`` operators and before ``(``. + /// \code We ha

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

tahonermann added a comment. > Sorry about this, I actually tried this but the patch showed a lot more than > what I've changed, not sure what I did wrong. You didn't do anything wrong; the `-U9` option will effectively include the entire file for each changed file. That is actually the int

[PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/cxx_proto.proto:1 +//===-- cxx_proto.proto - Protobuf description of C++ -===// +// Do we still need a copy of this for LLDB? CHANGES SINCE LAST A

[PATCH] D129581: [Clang] Rework LTO argument handling in the linker wrapper

jhuber6 added a comment. On second thought I'm not sure if overloading `-plugin-opt` is a good idea because we could have situations where we'd want them to be mutually exclusive, although I'd like to reuse the logic to set the arguments. I could change it to emit `-offload-opt=` instead or som

[PATCH] D129784: [HIP] Allow the new driver to compile HIP in non-RDC mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tra, yaxunl, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driver primarily allows us to support RDC-

[PATCH] D129498: [analyzer] Add new function `clang_analyzer_value` to ExprInspectionChecker

ASDenysPetrov updated this revision to Diff 444689. ASDenysPetrov added a comment. Stick to name `clang_analyzer_value`. Change function name from `printRange` to `printValue`. Make description more precise in the documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129498/new/

[clang] e71fd54 - [NFC] Move check for isEqualityOp to CheckFloatComparisons

Author: Erich Keane Date: 2022-07-14T09:30:29-07:00 New Revision: e71fd547194591fbdfb617479e47b1b7cf6e9151 URL: https://github.com/llvm/llvm-project/commit/e71fd547194591fbdfb617479e47b1b7cf6e9151 DIFF: https://github.com/llvm/llvm-project/commit/e71fd547194591fbdfb617479e47b1b7cf6e9151.diff L

[PATCH] D129691: [clang][test] fix typo in fn attr

nickdesaulniers updated this revision to Diff 444695. nickdesaulniers added a comment. - don't reset captured vars, that was a copy+paste mistake I made in the original patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129691/new/ https://review

[clang] d2792e7 - [clang][test] fix typo in fn attr

Author: Nick Desaulniers Date: 2022-07-14T09:49:11-07:00 New Revision: d2792e7d37c4b454a6b052cd569ff13ed7f22159 URL: https://github.com/llvm/llvm-project/commit/d2792e7d37c4b454a6b052cd569ff13ed7f22159 DIFF: https://github.com/llvm/llvm-project/commit/d2792e7d37c4b454a6b052cd569ff13ed7f22159.di

[PATCH] D129691: [clang][test] fix typo in fn attr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2792e7d37c4: [clang][test] fix typo in fn attr (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D109977: LLVM Driver Multicall tool

mgorny added a comment. In D109977#3652091 , @abrachet wrote: > Could I have a cmake invocation or a bot link? The exact CMake invocation for clang is: cmake -C /var/tmp/portage/sys-devel/clang-15.0.0./work/x/y/clang-abi_x86_64.amd64/gentoo_commo

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName()); W

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 444701. StephenFan added a comment. 1. Record bypassed lifetime start markers in codegenfunction class instead of lexicalscope. Since bypassed variables may be defined when lexicalscope is nullptr. This can also fix test fail of use-after-scope-goto.cpp.

[PATCH] D128955: [WPD] Use new llvm.public.type.test intrinsic for potentially publicly visible classes

aeubanks updated this revision to Diff 444706. aeubanks added a comment. make sure not to regress windows by checking HasHiddenLTOVisibility() to decide whether to emit public.type.test vs type.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 vitalybuka wrote: > It assume this will break Msan > Transforms/Instrumentation

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added a comment. Sound good to land the current form (we have sufficient tests for Sema and -fsanitize=array-bounds now) and have `=3` as a separate discussion. Comment at: clang/test/CodeGen/bounds-checking-fam.c:8 +// one-element array as the last emember of a struct

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName());

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

ckissane added a comment. In D128465#3651025 , @aemerson wrote: > I just reverted this in 6e6be5f9504d > because > it seems to have broken macOS builds: > > llvm/lib/Support/Compres

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne updated this revision to Diff 444709. ldionne marked an inline comment as done. ldionne added a comment. Herald added subscribers: pmatos, asb, abrachet, atanasyan, jrtc27, aheejin, jgravelle-google, sbc100, sdardis, dschuff, emaste. - Rebase - Rename to -fexperimental-library - Add tests

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

ldionne added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:276 + +Enable unstable and experimental language and library features. + MaskRay wrote: > The doc is auto-generated by tablegen > (https://discourse.llvm.org/t/clang-driver-optio

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:1222 + // printing multiple diagnostic location and diag opts. + EmitResourceUsageRemark("KernelName", "Kernel Name", + MF.getFunction().getName()); v

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); StephenFan wrote: > vitalybuka wrote: > > vitalybuka wrote: > > > Please check for lifetime markers, I assume case 2 will have a new one > > >

[PATCH] D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes

MaskRay added a subscriber: urnathan. MaskRay added a comment. LGTM. It may be related, @urnathan wants to add `-std=c++{current,future}` to GCC and may have opinions on the option name. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5840 - if (Args.hasArg(options::OPT_

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nathanchance added a comment. This cleans up the objtool warnings I initially reported and does not introduce any other regressions in my Linux kernel build and QEMU boot tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://rev

[PATCH] D129709: [clang][CodeGen] add fn_ret_thunk_extern to synthetic fns

nickdesaulniers updated this revision to Diff 444725. nickdesaulniers added a comment. - rebase on top of D129691 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129709/new/ https://reviews.llvm.org/D129709 Files:

  1   2   3   >