[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing my comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129057/new/ https://reviews.llvm.org/D129057 __

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske updated this revision to Diff 442024. balazske added a comment. Sorted the whole changed-check list in release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org/D118996 Files: clang-tools-extra/cl

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

carlosgalvezp added inline comments. Herald added a reviewer: NoQ. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-const-correctness.rst:10 +`CppCoreGuidelines ES.25

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng updated this revision to Diff 442025. kito-cheng marked 9 inline comments as done. kito-cheng added a comment. Changes: - Address @frasercrmck's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

kito-cheng added inline comments. Comment at: clang/lib/Sema/SemaRISCVVectorLookup.cpp:100 +switch (Type->getElementBitwidth()) { +case 64: + QT = Context.DoubleTy; aaron.ballman wrote: > kito-cheng wrote: > > aaron.ballman wrote: > > > I almost hate

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains updated this revision to Diff 442029. iains marked 4 inline comments as done. iains added a comment. rebased, factored code to address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 Files

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9363-9365 +Module *M = NewFD->getOwningModule(); +if (!M || M->isGlobalModule()) + NewFD->setImplicitlyInline(); iains wrote: > ChuanqiXu wrote: > > nit: this is not re

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains marked 3 inline comments as done. iains added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token --

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

MaskRay added a comment. Does Gentoo patch upstream to do something different? (`.../g++-v10/...`) Well, I wish that Gentoo does not do this. This adds complexity to Clang which in practice tries to provide some drop-in replacement ability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

ChuanqiXu added a comment. It looks like the tests lack the cast that the methods are attached to the global module fragment. Comment at: clang/lib/Sema/SemaDecl.cpp:9363-9365 +Module *M = NewFD->getOwningModule(); +if (!M || M->isGlobalModule()) + New

[PATCH] D128645: Update developer policy.

vext01 closed this revision. vext01 added a comment. Just pushed this to main (04f6bf482b8641533274d28af5fdac7107da3344 ) Thanks everyone! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128645/new/ https://reviews.llv

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains added a comment. In D129045#3627856 , @ChuanqiXu wrote: > It looks like the tests lack the cast that the methods are attached to the > global module fragment. (maybe I misunderstand what you are saying here) bool ImplicitInlineCXX20 = !getLangO

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Lex/Preprocessor.h:434 +/// Saw a 'module' identifier. +void handleModule(bool ATLTS) { + // This was the first module identifier and not preceded by any token iains wrote: > ChuanqiXu

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

ChuanqiXu added a comment. In D129045#3627878 , @iains wrote: > In D129045#3627856 , @ChuanqiXu > wrote: > >> It looks like the tests lack the cast that the methods are attached to the >> global module fragment.

[clang-tools-extra] 5f0a054 - [pseudo] Remove duplicated code in ClangPseudo.cpp

Author: Haojian Wu Date: 2022-07-04T11:32:56+02:00 New Revision: 5f0a054f8954d83aea66bac0ffa27887ff2eaade URL: https://github.com/llvm/llvm-project/commit/5f0a054f8954d83aea66bac0ffa27887ff2eaade DIFF: https://github.com/llvm/llvm-project/commit/5f0a054f8954d83aea66bac0ffa27887ff2eaade.diff LO

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

curdeius created this revision. curdeius added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[clang] f4dd977 - [AST] Use canonical constraint declaration for ASTContext::getAutoType

Author: Chuanqi Xu Date: 2022-07-04T17:38:05+08:00 New Revision: f4dd977537dc0fcd8605a1ce066a4c7fd271a5d7 URL: https://github.com/llvm/llvm-project/commit/f4dd977537dc0fcd8605a1ce066a4c7fd271a5d7 DIFF: https://github.com/llvm/llvm-project/commit/f4dd977537dc0fcd8605a1ce066a4c7fd271a5d7.diff LO

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain`

anton-afanasyev created this revision. anton-afanasyev added reviewers: MaskRay, kito-cheng, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D129061: [Lex] Diagnose macro in command lines

jackhong12 added a comment. Sorry, I didn't consider some cases. I'll fix it soon! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129061/new/ https://reviews.llvm.org/D129061 ___ cfe-commits mailing list

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, vsapsai, ilya-biryukov. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current impleme

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu updated this revision to Diff 442055. ChuanqiXu added a comment. Remove unnecessary changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept.cppm Index: clang/test/

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks for the update! LGTM (with very minor naming nits). Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:146 + +static bool HandleAST(StringRef astPath

[PATCH] D128608: [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM (I don't quite understand the rename and the [LLDB] tag, this is clearly in [Clang][ASTImporter]. Yes, LLDB depends on the ASTImporter). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D128535: [analyzer] Improve loads from reinterpret-cast fields

martong added a comment. I like it, but I'd like to know more about the nature of the applied "hack" and if there is a way to solve it properly in the longer term. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2014-2017 + // FIXME: This is a hack, and doesn't do a

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

martong added a comment. > I don't think any of the issues mentioned in this patch relates to strongly > connected components, thus I don't think I can answer to this question. In your example above, repeated here: #6(entry) #2(goto a;) | |^ #5(goto end;) |

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. @pengfei I am not convinced it is an issue on my side. I don't have anything particular in this area and using a stage2 build system. Anyway, this patch fixes the issue on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/snapshot/debian/patch

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129064/new/ https://reviews.llvm.org/D129064 ___ cfe-commits mailing list cfe-com

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129057/new/ https://reviews.llvm.org/D129057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D129065: [RISCV][Driver] Add libm linking to `RISCVToolchain`

anton-afanasyev updated this revision to Diff 442069. anton-afanasyev added a comment. Update summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129065/new/ https://reviews.llvm.org/D129065 Files: clang/lib/Driver/ToolChains/RISCVToolchain.cp

[PATCH] D129074: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129074 File

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added a comment. In D107082#3628120 , @sylvestre.ledru wrote: > @pengfei I am not convinced it is an issue on my side. I don't have anything > particular in this area and using a stage2 build system. > > Anyway, this patch fixes the issue on my

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains updated this revision to Diff 442072. iains added a comment. updated testcases to fix a missing new line and add included header in a GMF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 Files: cl

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

iains marked an inline comment as done. iains added a comment. In D129045#3627901 , @ChuanqiXu wrote: > In D129045#3627878 , @iains wrote: > >> In D129045#3627856 , @Chuan

[PATCH] D129074: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

sammccall added a comment. Can we make this the default value of the flag instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129074/new/ https://reviews.llvm.org/D129074 ___ cfe-commits mailing list

[PATCH] D128485: [pseudo] Store shift and goto actions in a compact structure with faster lookup.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:72 // action types, this class becomes less useful. Remove it. class Action { public:

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary updated this revision to Diff 442079. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 Files: clang/docs/ReleaseNotes.rst clang/test/CodeGen/arm-target-features.c clang/test/Driver/arm-cortex-cp

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary marked an inline comment as done. lenary added a comment. The other changes in this commit are to enable PACBTI by default, as agreed with stakeholders within Arm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.ll

[PATCH] D129074: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

hokein added a comment. In D129074#3628221 , @sammccall wrote: > Can we make this the default value of the flag instead? Yeah, the default one is the `cxx`. But I found it is a bit clearer to explicitly mention it in the code. (also happy to remove all

[PATCH] D128415: [ARM] Add Support for Cortex-M85

tschuett added a comment. The Clang release notes indicate that PACBTI is off by default. In several places, I can see PACBTI. Is the `ARM.td` missing something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D1

[PATCH] D128415: [ARM] Add Support for Cortex-M85

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Other than the release note change it might be worth adding some tests for -mcpu=cortex-m85+nopacbti and related configurations. Otherwise LGTM Comment at: clang/docs/Rel

[PATCH] D128449: [clang] Introduce -Warray-parameter

serge-sans-paille updated this revision to Diff 442084. serge-sans-paille added a comment. Fix handling of `ConstantArrayType`, thanks @aaron.ballman for the hint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128449/new/ https://reviews.llvm.org/D128449 Files: clang/docs/ReleaseNote

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary added a comment. In D128415#3628274 , @tschuett wrote: > The Clang release notes indicate that PACBTI is off by default. In several > places, I can see PACBTI. Is the `ARM.td` missing something? Nope, I should have re-checked the whole patch. Upd

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains updated this revision to Diff 442085. iains marked 7 inline comments as done. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128981/new/ https://reviews.llvm.org/D128981 Files: clan

[PATCH] D128981: [C++20][Modules] Implement include translation.

iains marked an inline comment as done. iains added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:2226-2227 + + // FIXME: We do not have a good way to disambiguate C++ clang modules from + // C++ standard modules (other than use/non-use of Header Units). + Module

[PATCH] D129074: [pseudo] Use the prebuilt cxx grammar for the lit tests, NFC.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Up to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129074/new/ https://reviews.llvm.org/D129074 ___

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

martong added a comment. In D127874#3628112 , @martong wrote: >> I don't think any of the issues mentioned in this patch relates to strongly >> connected components, thus I don't think I can answer to this question. > > In your example above, repeated he

[PATCH] D129070: [clang-tidy] Fixed an issue in readability-identifier-naming not using options specified.

njames93 updated this revision to Diff 442101. njames93 added a comment. Small tweak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129070/new/ https://reviews.llvm.org/D129070 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingChec

[PATCH] D128415: [ARM] Add Support for Cortex-M85

lenary updated this revision to Diff 442109. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128415/new/ https://reviews.llvm.org/D128415 Files: clang/docs/ReleaseNotes.rst clang/test/CodeGen/arm-target-features.c clang/test/Driver/arm-cortex-cp

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

serge-sans-paille accepted this revision. serge-sans-paille added a comment. I'm fine with these tests has they reflect current implementation. But beware that ubsan and `-Warray-bounds` don't behave the same wrt. FAM, which I find disturbing. I'll discuss that in another review. CHANGES SINCE

[clang] 9eb6572 - [LV] Add back CantReorderMemOps remark.

Author: Florian Hahn Date: 2022-07-04T17:23:47+01:00 New Revision: 9eb657278611665433d30fb37979d1df48af2ac8 URL: https://github.com/llvm/llvm-project/commit/9eb657278611665433d30fb37979d1df48af2ac8 DIFF: https://github.com/llvm/llvm-project/commit/9eb657278611665433d30fb37979d1df48af2ac8.diff

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. In D111081#3627852 , @MaskRay wrote: > Does Gentoo patch upstream to do something different? (`.../g++-v10/...`) > Well, I wish that Gentoo does not do this. > This adds complexity to Clang which in practice tries to provide

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

ksyx added a comment. ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] b37dafd - [pseudo] Store shift and goto actions in a compact structure with faster lookup.

Author: Sam McCall Date: 2022-07-04T19:40:04+02:00 New Revision: b37dafd5dc83a5f1fc4ca7e37e4944364ff9d5b7 URL: https://github.com/llvm/llvm-project/commit/b37dafd5dc83a5f1fc4ca7e37e4944364ff9d5b7 DIFF: https://github.com/llvm/llvm-project/commit/b37dafd5dc83a5f1fc4ca7e37e4944364ff9d5b7.diff LO

[PATCH] D128485: [pseudo] Store shift and goto actions in a compact structure with faster lookup.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rGb37dafd5dc83: [pseudo] Store shift and goto actions in a compact structure with faster lookup. (authored

[PATCH] D129093: [pseudo] Eliminate LRTable::Action. NFC

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. The last remaining uses

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

owenpan added a comment. In D129057#3627748 , @curdeius wrote: > LGTM. Thanks for addressing my comments. Thank you for your quick review and good comments as always! Comment at: clang/unittests/Format/FormatTest.cpp:7136

[clang] 47bdf53 - [clang-format] Break on AfterColon only if not followed by comment

Author: owenca Date: 2022-07-04T12:34:19-07:00 New Revision: 47bdf53a5dbaf16e1080d1cad8f3cc67edaad960 URL: https://github.com/llvm/llvm-project/commit/47bdf53a5dbaf16e1080d1cad8f3cc67edaad960 DIFF: https://github.com/llvm/llvm-project/commit/47bdf53a5dbaf16e1080d1cad8f3cc67edaad960.diff LOG: [

[PATCH] D129057: [clang-format] Break on AfterColon only if not followed by comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47bdf53a5dba: [clang-format] Break on AfterColon only if not followed by comment (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[clang] 1ab37d9 - [clang-format] Update documentation

Author: Nico Weber Date: 2022-07-04T21:42:08+02:00 New Revision: 1ab37d996ce376129fa435b63ca50246cc8c2f8d URL: https://github.com/llvm/llvm-project/commit/1ab37d996ce376129fa435b63ca50246cc8c2f8d DIFF: https://github.com/llvm/llvm-project/commit/1ab37d996ce376129fa435b63ca50246cc8c2f8d.diff LO

[PATCH] D129050: [clang-format] Update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ab37d996ce3: [clang-format] Update documentation (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129050/n

[PATCH] D129097: [clang][dataflow] Handle null pointers of type std::nullptr_t

li.zhe.hua created this revision. li.zhe.hua added a reviewer: gribozavr2. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-c

[clang] b6178cc - [OffloadPackager] Use appropriate kind for LTO bitcode

Author: Joseph Huber Date: 2022-07-04T17:34:14-04:00 New Revision: b6178ccfe85238e123ecf29a12af23d3b70bef22 URL: https://github.com/llvm/llvm-project/commit/b6178ccfe85238e123ecf29a12af23d3b70bef22 DIFF: https://github.com/llvm/llvm-project/commit/b6178ccfe85238e123ecf29a12af23d3b70bef22.diff

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:69-70 } else { - IndentForLevel.resize(Line.Level + 1); + if (IndentForLevel.size() < Line.Level + 1) +IndentForLevel.resize(Line.Level + 1); Indent = getIndent(Li

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-t

[PATCH] D129100: [clangd] Support external throttler for preamble builds

sammccall added a comment. I wanted to send a first version out for feedback even if incomplete. (I want to do more extensive tests, and likely we should think about having an in-tree throttler on by default) To motivate the design: - when attempting to acquire a slot, we want to wait on (acqui

[PATCH] D128981: [C++20][Modules] Implement include translation.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. Then LGTM if all the comments addressed. Comment at: clang/lib/Lex/PPDirectives.cpp:2226-2227 + + // FIXME: We do not have a good way to disambiguate C++ clang modules

[PATCH] D129045: [C++20][Modules] Update handling of implicit inlines [P1779R3]

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu updated this revision to Diff 442165. ChuanqiXu added a comment. Add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept.cppm Index: clang/test/Modules/concep

[clang] 98c6a3c - [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp

Author: phyBrackets Date: 2022-07-05T08:12:01+05:30 New Revision: 98c6a3c0c2209dd7bdb15fe6c91c507c16990bcf URL: https://github.com/llvm/llvm-project/commit/98c6a3c0c2209dd7bdb15fe6c91c507c16990bcf DIFF: https://github.com/llvm/llvm-project/commit/98c6a3c0c2209dd7bdb15fe6c91c507c16990bcf.diff L

[PATCH] D128608: [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG98c6a3c0c220: [NFC][ASTImporter] remove the unnecessary condition checks in ASTImporter.cpp (authored by phyBrackets). Changed prior to commit: https://reviews.llvm.org/D128608?vs=440059&id=442167#toc

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. BTW, after I applied the patch, the compiler crashes at https://github.com/ChuanqiXu9/stdmodules. I would try to add more tests about C++20 Modules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126694/new/ https://revi

[PATCH] D129043: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks for clean this up :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129043/new/ https://reviews.llvm.org/D129043 __

[clang] 85318d3 - [NFC] Remove unused test inputs

Author: Chuanqi Xu Date: 2022-07-05T10:55:24+08:00 New Revision: 85318d3281021f3900ee49338f6a9e2330b4a652 URL: https://github.com/llvm/llvm-project/commit/85318d3281021f3900ee49338f6a9e2330b4a652 DIFF: https://github.com/llvm/llvm-project/commit/85318d3281021f3900ee49338f6a9e2330b4a652.diff LO

[clang] 939352b - [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

Author: Yeting Kuo Date: 2022-07-05T11:02:44+08:00 New Revision: 939352b6ec31db4e8defe07856868438fbc5340d URL: https://github.com/llvm/llvm-project/commit/939352b6ec31db4e8defe07856868438fbc5340d DIFF: https://github.com/llvm/llvm-project/commit/939352b6ec31db4e8defe07856868438fbc5340d.diff LO

[PATCH] D129043: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands.

This revision was automatically updated to reflect the committed changes. Closed by commit rG939352b6ec31: [RISCV][Clang] Teach RISCVEmitter to generate BitCast for pointer operands. (authored by fakepaper56). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu created this revision. ChuanqiXu added reviewers: ilya-biryukov, erichkeane, vsapsai, rsmith. ChuanqiXu added a project: clang-modules. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Closing

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

vsapsai added a comment. I don't know enough to say if it is a good approach or not, I'll need to check what we can achieve by modifying `Profile` in `ArgLoc.getArgument().Profile`. Specifically, I'm interested to see if we can use the same `ASTContext` for profile. Also I have a few stylistic

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

vsapsai added a comment. Hmm, I'm concerned with the pieces added purely for testing. Specifically, `FileEntriesToReread` and TestHelper friend functions. Need to think how else we can test it. Do you intend to support only the error cases like clang-repl> #include "file_with_error.h" // e

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D129104: [Modules] Add ODR Check for concepts

ChuanqiXu updated this revision to Diff 442179. ChuanqiXu added a comment. Undo the format test. It breaks the testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129104/new/ https://reviews.llvm.org/D129104 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept_differ.c

[clang] 4996e3f - [test] Check for more -fsanitize=array-bounds behavior

Author: Stephan Bergmann Date: 2022-07-05T08:12:53+02:00 New Revision: 4996e3f68315f9ee7f43f2de9d368ab9979080db URL: https://github.com/llvm/llvm-project/commit/4996e3f68315f9ee7f43f2de9d368ab9979080db DIFF: https://github.com/llvm/llvm-project/commit/4996e3f68315f9ee7f43f2de9d368ab9979080db.di

[PATCH] D128783: [test] Check for more -fsanitize=array-bounds regressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sberg marked an inline comment as done. Closed by commit rG4996e3f68315: [test] Check for more -fsanitize=array-bounds behavior (authored by sberg). Repository: rG L

[PATCH] D128977: [clangd] Support "usedAsMutableReference" in member initializations

nridge requested changes to this revision. nridge added a comment. This revision now requires changes to proceed. Thanks, this seems like a useful extension of the `usedAsMutableReference` modifier Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:541 + return

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu updated this revision to Diff 442181. ChuanqiXu added a comment. Add tests for nested template parameters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129068/new/ https://reviews.llvm.org/D129068 Files: clang/lib/AST/ASTContext.cpp clang/test/Modules/concept.cppm Inde

[PATCH] D129068: [AST] Profiling on constraint expression instead of arguments for TypeConstraint in ASTContext::isSameTemplateParameter

ChuanqiXu added a comment. In D129068#3629135 , @vsapsai wrote: > I don't know enough to say if it is a good approach or not, I'll need to > check what we can achieve by modifying `Profile` in > `ArgLoc.getArgument().Profile`. I tried but I don't find

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable

ChuanqiXu added a comment. Ping @jyknight Or anyone else will review this one? I want us to fix the thread problems in clang15, which would be created on July 26th. @rjmccall @nhaehnle @danilaml @efriedma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1091 + + // Reformat Macro Expansion + if (!HI->MacroExpansion.empty()) { nridge wrote: > It would be interesting to have a couple of test cases that exercise the > reformatting in no

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442183. Codesbyusman added a comment. Updating the files as required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442184. Codesbyusman added a comment. updating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

shchenz added a comment. Sorry, I am really not familiar with these FE stuffs. Need approval from other reviewers who know more about this part. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:522 EmitCXXThreadLocalInitFunc(); + if (getTriple().isOSAIX()) { +genAssocMe

[clang-tools-extra] 7a55021 - [clang-tidy] Fix confusable identifiers interaction with DeclContext

Author: serge-sans-paille Date: 2022-07-05T08:56:26+02:00 New Revision: 7a550212e8ff5552b0bd10d0c1af459a55c36234 URL: https://github.com/llvm/llvm-project/commit/7a550212e8ff5552b0bd10d0c1af459a55c36234 DIFF: https://github.com/llvm/llvm-project/commit/7a550212e8ff5552b0bd10d0c1af459a55c36234.d

[PATCH] D128715: [clang-tidy] Fix confusable identifiers interaction with DeclContext

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a550212e8ff: [clang-tidy] Fix confusable identifiers interaction with DeclContext (authored by serge-sans-paille). Changed prior to commit: https