iains added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:9363-9365 + Module *M = NewFD->getOwningModule(); + if (!M || M->isGlobalModule()) + NewFD->setImplicitlyInline(); ---------------- iains wrote: > ChuanqiXu wrote: > > nit: this is not required. > well, the logic is required ;) .. you have suggested a different way to > write.. actually, I think you meant `!NewFD->getOwningModule() || NewFD->getOwningModule()->isGlobalModule()` but I've pulled the test out so that it's only done once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129045/new/ https://reviews.llvm.org/D129045 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
