[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440371. vaibhav.y added a comment. Use `CharSourceRange` instead of FullSourceRange so we no longer need to compute the length of the last token. This should already be encoded in the end location of the `CharSourceRange` by the caller TODO(@vaibhav.y): Onc

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 440374. vaibhav.y added a comment. Discard include: `clang/Lex/Lexer.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701 Files: clang/include/clang/Basic/Sarif.h

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > This only matters if the IRs are linked together with IPO. Otherwise, at > object level it doesn't really matter. Right. > Do you think we can get away by just documenting the incompatibility of doing > IPO with files compiled with different -ffine-grained-bitfield-

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka added a comment. This bot is broken by this patch https://lab.llvm.org/buildbot/#/builders/85/builds/8881 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-

[clang] cdfa15d - Revert "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays"

Author: Vitaly Buka Date: 2022-06-27T14:03:09-07:00 New Revision: cdfa15da94f06289dcf86173d18b6627f92ac403 URL: https://github.com/llvm/llvm-project/commit/cdfa15da94f06289dcf86173d18b6627f92ac403 DIFF: https://github.com/llvm/llvm-project/commit/cdfa15da94f06289dcf86173d18b6627f92ac403.diff L

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted with cdfa15da94f06289dcf86173d18b6627f92ac403 (inlcuding 572b08790a69f955ae0cbb1b4a7d4a215f15dad9

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall created this revision. Herald added a subscriber: mgrang. Herald added a project: All. sammccall updated this revision to Diff 440376. sammccall retitled this revision from "xxx recover" to "[pseudo] Add error-recovery framework & brace-based recovery". sammccall edited the summary of th

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 440383. sammccall added a comment. revert format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files: clang-tools-extra/pseudo/include/clang-pseudo/GLR.

[PATCH] D128248: [clang] Avoid an assertion in APValue::hasArrayFiller()

shafik added a comment. Are you sure it is failing on the line you indicated? After looking at the code, a little before that line we have: Result = APValue(APValue::UninitArray(), NumEltsToInit, NumElts); which should assure that we have an array at this point. Looking at the result of the

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440388. vitalybuka edited the summary of this revision. vitalybuka added a comment. exactly as reverted revision 886715af962de2c92fac4bd37104450345711e4a + 572b08790a69f955ae0cbb1b4a7d4

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.h:83 +KCFI_NT_CALL, +KCFI_TC_RETURN, + samitolvanen wrote: > pcc wrote: > > samitolvanen wrote: > > > joaomoreira wrote: > > > > samitolvanen wrote: > > > > > joaomoreira

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman updated this revision to Diff 440390. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 Files: clang/lib/Sema/SemaType.cpp clang/test/SemaObjCXX/Inputs/nullability-consistency-2.h Index: clang/test/SemaObjCXX/Inputs/nullability-consis

[PATCH] D128486: [pseudo] Add error-recovery framework & brace-based recovery

sammccall updated this revision to Diff 440393. sammccall edited the summary of this revision. sammccall added a comment. update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128486/new/ https://reviews.llvm.org/D128486 Files: clang-too

[PATCH] D128653: [PowerPC] Fix the check for scalar MASS conversion

bmahjour added inline comments. Comment at: clang/test/CodeGen/lower-mass-end-to-end.c:33-34 +// CHECK-MASS-AFN: __xl_sin +// CHECK-NOMASS-FAST-NOT: __xl_sin_finite +// CHECK-NOMASS-AFN-NOT: __xl_sin +// CHECK: blr Please also check for CHECK-NOMASS-FAST-NOT: __

[clang] df18167 - [docs] Restore missing blank line

Author: Vitaly Buka Date: 2022-06-27T14:21:08-07:00 New Revision: df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2 URL: https://github.com/llvm/llvm-project/commit/df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2 DIFF: https://github.com/llvm/llvm-project/commit/df18167ac56d05f2ab55f9d874aee7ab6d5bc9a2.diff L

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440396. vitalybuka added a comment. restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/do

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

rjmccall added a comment. Is there no way in LLVM to load partially-initialized memory and then freeze it that will preserve the parts of the value that are initialized? Because that seems like something that LLVM needs to be providing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:76 + +auto Methods = Arg->getType()->getAsCXXRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { denik wrote: > C

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman added a reviewer: doug.gregor. mwyman added a comment. Adding Doug Gregor who appears to have created the original warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe-commits mail

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

awarzynski added a comment. @MaskRay, thank for taking a look! In D128333#3605745 , @MaskRay wrote: > gfortran defaults to PIE as well. While we strive to be compatible with `gfortan`, there's a lot relatively "basic" things still missing in LLVM Flang

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:747 + /// Return difference with the given option set. + FPOptionsOverride diffWith(const FPOptions &Base); + Can you make direction more obvious in the method name? `diffFrom`

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hctim marked an inline comment as done. Closed by commit rGdacfa24f75c3: Delete 'llvm.asan.globals' for global metadata. (authored by hctim). Changed prior to commit:

[PATCH] D127898: [clang][dataflow] Add API to separate analysis from diagnosis

samestep updated this revision to Diff 440406. samestep added a comment. - Bring back Diagnosis.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127898/new/ https://reviews.llvm.org/D127898 Files: clang/docs/tools/clang-formatted-files.txt clan

[PATCH] D128679: [pseudo] Define a clangPseudoCLI library.

sammccall added a comment. Thanks, the split here looks good! Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:115 // Parameters for the GLR parsing. +// FIXME: refine it with the ParseLang struct. struct ParseParams { You're already touching t

[PATCH] D128333: [clang][flang] Disable defaulting to `-fpie` for LLVM Flang

MaskRay added a comment. In D128333#3613665 , @awarzynski wrote: > @MaskRay, thank for taking a look! > > In D128333#3605745 , @MaskRay wrote: > >> gfortran defaults to PIE as well. > > While we strive to be comp

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexical order before emission

ychen added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/ https://reviews.llvm.org/D127233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

sammccall marked 13 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:136 + // check whether a reduction should apply in the current context. + llvm::ArrayRef getReduceRules(StateID State) const

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

sammccall updated this revision to Diff 440415. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128472/new/ https://reviews.llvm.org/D128472 Files: clang-tools

[clang-tools-extra] 85eaecb - [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

Author: Sam McCall Date: 2022-06-28T00:36:16+02:00 New Revision: 85eaecbe8e541924b6f87dd83f169056e74ce237 URL: https://github.com/llvm/llvm-project/commit/85eaecbe8e541924b6f87dd83f169056e74ce237 DIFF: https://github.com/llvm/llvm-project/commit/85eaecbe8e541924b6f87dd83f169056e74ce237.diff LO

[PATCH] D128472: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85eaecbe8e54: [pseudo] Check follow-sets instead of tying reduce actions to lookahead tokens. (authored by sammccall). Changed prior to commit: ht

[clang] 0103d4d - [Clang][OpenMP] Don't overload "extension" in status doc

Author: Joel E. Denny Date: 2022-06-27T18:41:17-04:00 New Revision: 0103d4da740c9d2688389e2aa5e3c2f3792e6940 URL: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940 DIFF: https://github.com/llvm/llvm-project/commit/0103d4da740c9d2688389e2aa5e3c2f3792e6940.diff

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

This revision was automatically updated to reflect the committed changes. Closed by commit rG0103d4da740c: [Clang][OpenMP] Don't overload "extension" in status doc (authored by jdenny). Changed prior to commit: https://reviews.llvm.org/D126549?vs=432567&id=440419#toc Repository: rG LLVM Gith

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126549/new/ https://reviews.llvm.org/D126549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D128685: [OpenMP][NFC] Remove unused check lines in Clang/OpenMP tests

jdoerfert created this revision. jdoerfert added a reviewer: jhuber6. Herald added subscribers: mattd, asavonic, guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The ch

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, JonChesterfield, ABataev, RaviNarayanaswamy, ggeorgakoudis, tianshilei1992. Herald added subscribers: mattd, asavonic, guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald adde

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

jdoerfert added a comment. I'm not so sure but phab things this is small, so no complaints: F23600771: 2022-06-27_18-06-1656371325.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128686/new/ https://reviews.l

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123319/new/ https://reviews.llvm.org/D123319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D128687: [pseudo] Allow mixed designated/undesignated init lists.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This isn't allowed by the standard grammar but is allowed i

[PATCH] D128318: [pseudo] prototype: faster data structures for LRTable

sammccall abandoned this revision. sammccall added a comment. This is obsoleted by D128485 and D128472 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128318/new/ https://reviews.

[PATCH] D128686: [OpenMP][NFC] Reuse check lines for Clang/OpenMP tests

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128686/new/ https://reviews.llvm.org/D128686 ___

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > Is there no way in LLVM to load partially-initialized memory and then freeze > it that will preserve the parts of the value that are initialized? Because > that seems like something that LLVM needs to be providing. It's currently possible to `load <32 x i1>`, freeze

[PATCH] D128667: [WIP] Add Zstd ELF support

dblaikie added a comment. Yeah, probably worth splitting this up a bit - somewhat hard to split up generation+parsing in LLVM itself (eg: llvm-mc+llvm-objdump), so maybe they're grouped together (alternatively the objdump support gets checked in first with precompiled/binary test files - I forg

[clang] efd90ff - [test] Add -fsanitize=array-bounds test for pseudo flexible array member

Author: Fangrui Song Date: 2022-06-27T16:40:52-07:00 New Revision: efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 URL: https://github.com/llvm/llvm-project/commit/efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322 DIFF: https://github.com/llvm/llvm-project/commit/efd90ffbfc427ad4c4675ac1fcae9d53cc7f1322.diff

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Specifically, making the following changes: - Turn lambdas calculating ODR hashes into

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1143 MarshallingInfoFlag>; +def fstrict_flex_arrays_EQ : Joined<["-"], "fstrict-flex-arrays=">,Group, + MetaVarName<"">, Values<"0,1,2,3">, Comment at: clang

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440443. t-rasmud added a comment. Documentation edits and other fixes, thanks to suggestions from @ziqingluo-90 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Looks great, thanks! Comment at: clang/docs/LibASTMatchersReference.html:2041 + +Example matches "abcd" + NSString *s = @"abcd"; I think it's more appropriate for this documentation to mention the entire literal so that the reader didn't

[PATCH] D123878: [AMDGPU] Add remarks to output some resource usage

vangthao updated this revision to Diff 440447. vangthao added a comment. Remove "" delimiter. Change ScratchSize [bytes/thread] to ScratchSize [bytes/lane]. Use lambda expression to emit remarks. Do not output yaml if specific remark is not enabled. Add indentation to make it easier to t

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud updated this revision to Diff 440450. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatchers/ASTMatchers.h clang/lib/ASTMatchers/ASTMatchersInternal.cpp cla

[PATCH] D128624: [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

liaolucy accepted this revision. liaolucy added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128624/new/ https://reviews.llvm.org/D128624 ___

[PATCH] D128690: [ODRHash diagnostics] Preparation to minimize subsequent diffs. NFC.

vsapsai updated this revision to Diff 440451. vsapsai added a comment. More preparations to minimize subsequent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128690/new/ https://reviews.llvm.org/D128690 Files: clang/lib/Serialization/ASTRe

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

rjmccall added a comment. In D128501#3613890 , @efriedma wrote: >> Is there no way in LLVM to load partially-initialized memory and then freeze >> it that will preserve the parts of the value that are initialized? Because >> that seems like something th

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. PR31524 (https://github.com/llvm/llvm-project/issues/31524) discusses about the lowering of such intrinsics. According to the PR, it seems users consider undefined intrinsics as returning unknown but consistent bits. If it works, my updates in the draft (https://github.

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang added a comment. Gentle ping. Verified the patch works with latest code base, all tests green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125095/new/ https://reviews.llvm.org/D125095 ___ cfe

[PATCH] D128501: [CodeGen] Make uninitialized Lvalue bit-field stores poison compatible

efriedma added a comment. > Is that seen as a defect or as for some reason desirable? Because I worry > that optimizer people are talking themselves into something that would be a > truly beautiful model if only there were a frontend that could emit code for > it. > > Doesn't this make it e.g.

[clang] 17a36c7 - [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

Author: Craig Topper Date: 2022-06-27T20:26:54-07:00 New Revision: 17a36c7c40e99aa28d4323698f69845d92d96682 URL: https://github.com/llvm/llvm-project/commit/17a36c7c40e99aa28d4323698f69845d92d96682 DIFF: https://github.com/llvm/llvm-project/commit/17a36c7c40e99aa28d4323698f69845d92d96682.diff

[PATCH] D128624: [RISCV] Zero extend immediate for vget/vset builtins to match vector.insert/extract intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a36c7c40e9: [RISCV] Zero extend immediate for vget/vset builtins to match vector. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D128624?vs=440112&id=440459#toc Reposit

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127189/new/ https://reviews.llvm.org/D127189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

sberg added a comment. In D126864#3612149 , @sberg wrote: > see https://reviews.llvm.org/D128643 "[clang] -fsanitize=array-bounds: treat > all trailing size-1 arrays as flexible" for another regression For the record (now that the original commit has be

[PATCH] D128643: [clang] -fsanitize=array-bounds: treat all trailing size-1 arrays as flexible

sberg abandoned this revision. sberg added a comment. I'm abandoning this as the underlying https://reviews.llvm.org/D126864 "[clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays" has been reverted for now. I documented all my issues with that underlying commit (incl

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

thakis added a comment. Looks like this breaks check-clang on windows: http://45.33.8.238/win/61067/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://rev

[PATCH] D128487: [ODRHash diagnostics] Move repetetive code at lambda calls into lambdas themselves. NFC.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. I found the codes about ODR Check was repeated too. It should be good to do such refactoring. --- Is it possible to combine the several `DiagNote` into `DiagError`? So that the c

[PATCH] D128697: [clang-tidy] Add new check `bugprone-unhandled-exception-at-sto`

Sockke created this revision. Sockke added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Calls to **sto

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

ruiu added a comment. In D125624#3552770 , @tstellar wrote: > In D125624#3552463 , @ruiu wrote: > >>> OK, as I mentioned. I think we need an attorney to review this change and >>> confirm that it actually accompl

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

MaskRay added a comment. In D126864#3614235 , @sberg wrote: > In D126864#3612149 , @sberg wrote: > >> see https://reviews.llvm.org/D128643 "[clang] -fsanitize=array-bounds: treat >> all trailing size-1 arrays as

[PATCH] D128700: [AMDGPU][Clang] Skip adding noundef attribute to AMDGPU HIP device functions

skc7 created this revision. Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. skc7 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, wdng. Herald added projects: clang, LLVM. Noundef att

[clang] 527ef8c - Reland "[X86] Support `_Float16` on SSE2 and up"

Author: Phoebe Wang Date: 2022-06-28T14:38:56+08:00 New Revision: 527ef8ca981e88a35758c0e4143be6853ea26dfc URL: https://github.com/llvm/llvm-project/commit/527ef8ca981e88a35758c0e4143be6853ea26dfc DIFF: https://github.com/llvm/llvm-project/commit/527ef8ca981e88a35758c0e4143be6853ea26dfc.diff L

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

This revision was automatically updated to reflect the committed changes. Closed by commit rG527ef8ca981e: Reland "[X86] Support `_Float16` on SSE2 and up" (authored by pengfei). Herald added subscribers: Sanitizers, Enna1, mgorny. Herald added a project: Sanitizers. Changed prior to commit: ht

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Abandon this since we have rGe2a1f8ec27b88be670cd867c43588f24516d2bbf . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D128571: [X86] Support `_Float16` on SSE2 and up

pengfei added a subscriber: vitalybuka. pengfei added a comment. Thanks @vitalybuka ! I believe the fail was caused by missing `COMPILER_RT_HAS_FLOAT16` in these tests. Relanded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128571/new/ https://re

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440492. mboehme added a comment. Remove `clang-format` directives from test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/include/clang/Sema/Sema.h

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/test/SemaCXX/attr-declspec-ignored.cpp:3-6 +// For this test, we want the contents of the namespaces to be indented, which +// clang-format doesn't like. Also, clang-format reformats the lo

[PATCH] D128667: [WIP] Add Zstd ELF support

jhenderson added inline comments. Comment at: llvm/lib/ObjCopy/ELF/ELFObject.cpp:567-568 +compression::zstd::compress( +StringRef(reinterpret_cast(OriginalData.data()), + OriginalData.size()), +CompressedData); This StringRef

[PATCH] D128611: [libc++] Implement `std::ranges::merge`

huixie90 updated this revision to Diff 440493. huixie90 added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, openmp-commits, lldb-commits, Sanitizers, steakhal, nlopes, mtrofin, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, ThomasRaoux, pmatos,

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

mboehme updated this revision to Diff 440494. mboehme marked 2 inline comments as done. mboehme added a comment. Remove trailing spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128499/new/ https://reviews.llvm.org/D128499 Files: clang/inclu

[clang] 8686610 - [Clang] Fix: Restore warning inadvertently removed by D126061.

Author: Martin Boehme Date: 2022-06-28T08:52:58+02:00 New Revision: 86866107b89c0515d197ec70292ce776bce5a04b URL: https://github.com/llvm/llvm-project/commit/86866107b89c0515d197ec70292ce776bce5a04b DIFF: https://github.com/llvm/llvm-project/commit/86866107b89c0515d197ec70292ce776bce5a04b.diff

[PATCH] D128499: [Clang] Fix: Restore warning inadvertently removed by D126061.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86866107b89c: [Clang] Fix: Restore warning inadvertently removed by D126061. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES S

<    1   2   3