ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM. I found the codes about ODR Check was repeated too. It should be good to
do such refactoring.
---
Is it possible to combine the several `DiagNote` into `DiagError`? So that the
code would be further reduced. I am OK to do this kind of change in other
revisions.
================
Comment at: clang/lib/Serialization/ASTReader.cpp:9827
return false;
- };
+ };
----------------
Unitentional change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128487/new/
https://reviews.llvm.org/D128487
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
