[clang-tools-extra] 5413bf1 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:33:56-07:00 New Revision: 5413bf1bac2abb9e06901686cdc959e92940143a URL: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a DIFF: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a.diff L

[clang] ad7ce1e - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:49:10-07:00 New Revision: ad7ce1e7696148d093b96a6262ebc8fd5e216187 URL: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187 DIFF: https://github.com/llvm/llvm-project/commit/ad7ce1e7696148d093b96a6262ebc8fd5e216187.diff L

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

dexonsmith added a comment. Is there a test that can be added so this doesn’t regress? Also, I wonder if `assign` could/should add logic to be resilient to this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128207/new/ https://reviews.llvm.org/D12

[PATCH] D128223: [clang] Linkage of static locals may require inspecting visibility

cebowleratibm created this revision. cebowleratibm added a reviewer: daltenty. Herald added a project: All. cebowleratibm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An assertion failure was encountered after https://reviews.llvm.org/D1

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added a comment. It looks like misc-new-delete-overloads.cpp is failing on line 20: 1 // RUN: %check_clang_tidy %s misc-new-delete-overloads %t 2 3 typedef decltype(sizeof(int)) size_t; 4 5 struct S { 6 // CHECK-MESSAGES: :[[@LINE+1]]:9: warning: declaration of 'opera

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

sberg added a comment. In D127593#3596883 , @royjacobson wrote: > In D127593#3596601 , @sberg wrote: > >> Is it intended that a deleted copy assignment op as in `struct S { void >> operator =(S &) = delete; };`

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438486. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D128120: [Clang][VE] Add missing intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ba0a9571b3e: [Clang][VE] Add missing intrinsics (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 5ba0a95 - [Clang][VE] Add missing intrinsics

Author: Kazushi (Jam) Marukawa Date: 2022-06-21T07:30:36+09:00 New Revision: 5ba0a9571b3ee3bc76f65e16549012a440d5a0fb URL: https://github.com/llvm/llvm-project/commit/5ba0a9571b3ee3bc76f65e16549012a440d5a0fb DIFF: https://github.com/llvm/llvm-project/commit/5ba0a9571b3ee3bc76f65e16549012a440d5a

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ https://reviews.llvm.org/D126364 ___

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt created this revision. palmer-dabbelt added reviewers: reames, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt added a comment. I've never touched LLVM before, so I have no idea if I'm even in the right place here... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 __

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZawrs.td:1 +//===-- RISCVInstrInfoM.td - RISC-V 'M' instructions ---*- tablegen -*-===// +// This doesn't match the filename. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. In D128235#3597645 , @palmer-dabbelt wrote: > I've never touched LLVM before, so I have no idea if I'm even in the right > place here... Yes, you are in the right place. All LLVM patches go through the Phabricator. A patch goes i

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. - I think we will need some test coverage under `llvm/test/CodeGen/RISCV/attributes.ll` and `llvm/test/MC/RISCV/attribute-arch.s` if the extension is existing in the arch string. - Since macro is added, we need some test coverage under `clang/test/Preprocessor/riscv-targ

[clang] 7c5957a - [Driver] Pass -X to ld for riscv64-fuchsia

Author: Brad Smith Date: 2022-06-20T21:05:01-04:00 New Revision: 7c5957aedb75f381cd9996f9eba96f3add16a721 URL: https://github.com/llvm/llvm-project/commit/7c5957aedb75f381cd9996f9eba96f3add16a721 DIFF: https://github.com/llvm/llvm-project/commit/7c5957aedb75f381cd9996f9eba96f3add16a721.diff LO

[PATCH] D128134: [Driver] Pass -X to ld for riscv64-fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c5957aedb75: [Driver] Pass -X to ld for riscv64-fuchsia (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

palmer-dabbelt updated this revision to Diff 438515. palmer-dabbelt added a comment. Herald added a subscriber: jdoerfert. - Fix a whitespace issue - Fix the name of RISCVInstrInfoZawrs.td - Call the #define __riscv_zawrs instead of __riscv_wrs, to match the others - Add tests in clang/test/Driver

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

eopXD added a comment. Looks like the patch application failed, might need to rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128235/new/ https://reviews.llvm.org/D128235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:585 +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZAWRS-GOOD %s +// RV32-ZHINX-GOOD: "-target-feature" "+zawrs" + This doesn't match the RUN line Commen

[clang] 064a08c - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:05:16-07:00 New Revision: 064a08cd955019da9130f1109bfa534e79b8ec7c URL: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c DIFF: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c.diff L

[clang-tools-extra] 064a08c - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:05:16-07:00 New Revision: 064a08cd955019da9130f1109bfa534e79b8ec7c URL: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c DIFF: https://github.com/llvm/llvm-project/commit/064a08cd955019da9130f1109bfa534e79b8ec7c.diff L

[clang-tools-extra] 0916d96 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:17:57-07:00 New Revision: 0916d96d12fda355933a8f66ed2a1ccc855cab9c URL: https://github.com/llvm/llvm-project/commit/0916d96d12fda355933a8f66ed2a1ccc855cab9c DIFF: https://github.com/llvm/llvm-project/commit/0916d96d12fda355933a8f66ed2a1ccc855cab9c.diff L

[clang] d66cbc5 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T20:26:05-07:00 New Revision: d66cbc565adbea8b7362349e527ac7aa2c75788f URL: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f DIFF: https://github.com/llvm/llvm-project/commit/d66cbc565adbea8b7362349e527ac7aa2c75788f.diff L

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntry.h clang/include/clang/Basic/FileManager.h clang/include

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added a comment. > Context not available. See `-U99` on https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface or use `arc diff` (PHP 8 may need https://discourse.llvm.org/t/arcanist-deprecation-errors-on-php-8/63231) Comment at: llvm/t

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438541. tapaswenipathak added a comment. fix for build failure: cmdline: git reset --hard stderr: 'fatal: Unable to create '/var/lib/buildkite-agent/builds/llvm-project-fork/.git/index.lock': File exists. https://buildkite.com/llvm-project/diff

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

MaskRay added inline comments. Comment at: llvm/test/MC/RISCV/zawrs-invalid.s:4 +# WRS doesn't take immediates +wrs 1 # CHECK: :[[@LINE]]:5: error: invalid operand for instruction + `[[@LINE]]` is a deprecated FileCheck feature. Use `[[#@LINE]]` Note: you can p

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

craig.topper added a comment. In D126461#3596761 , @reames wrote: > Despite the comments above, the purpose of this patch remains unclear. > > Per the draft spec, the relevant wording is: > "These instructions execute as a regular load except that they wi

[PATCH] D126266: Mark the file entry invalid, until reread. Invalidate SLocEntry cache, readd it on reread. Do not use translateFile, because it pulls in parts of the pch.

tapaswenipathak updated this revision to Diff 438550. tapaswenipathak added a comment. omit an unrelated change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126266/new/ https://reviews.llvm.org/D126266 Files: clang/include/clang/Basic/FileEntr

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

Whitney added inline comments. Comment at: clang/include/clang/Driver/Options.td:2832 +def ftime_trace_path : Joined<["-"], "ftime-trace-path=">, Group, + HelpText<"Path which stores the output files of time profiler">, + Flags<[CC1Option, CoreOption]>, jamiesc

[clang] ca4af13 - [clang] Don't use Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T22:59:26-07:00 New Revision: ca4af13e480e856f8f889c1e145308fc4eb69816 URL: https://github.com/llvm/llvm-project/commit/ca4af13e480e856f8f889c1e145308fc4eb69816 DIFF: https://github.com/llvm/llvm-project/commit/ca4af13e480e856f8f889c1e145308fc4eb69816.diff L

[PATCH] D121670: [RISCV] Add zihintntl instructions

sunshaoce updated this revision to Diff 438563. sunshaoce added a comment. Herald added a subscriber: shiva0217. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 Files: clang/test/Preprocessor/ris

[clang-tools-extra] ed8fcea - Don't use Optional::getValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T23:35:53-07:00 New Revision: ed8fceaa09cd66324c6efc1070f962731a62e2dc URL: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc DIFF: https://github.com/llvm/llvm-project/commit/ed8fceaa09cd66324c6efc1070f962731a62e2dc.diff L

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

kito-cheng added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:195 + if (ISAInfo->hasExtension("zawrs")) +Builder.defineMacro("__riscv_zawrs"); } You don't need this line, that would be defined automatically once you've add `zawrs` in `RI

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. In D126461#3596769 , @khchen wrote: > Could you please purpose this implement in rvv-intrinsc-doc first? > I think this feature need to have discussion because store to nullptr is UB > but we are making it as defined behavio

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. In D127593#3597374 , @sberg wrote: > You'd only see it when compiling with Clang against MSVC's ``, where > `std::pair` has a deleted copy assignment op (something I approximated with > the `struct S` above). https://godbol

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG957014da2d27: [clang][Analyzer] Add errno state to standard functions modeling. (authored by balazske). Repository: rG LLVM Github Monorepo CHANG

[clang] 957014d - [clang][Analyzer] Add errno state to standard functions modeling.

Author: Balázs Kéri Date: 2022-06-21T08:56:41+02:00 New Revision: 957014da2d2791359181d89a04a0d27da65474d4 URL: https://github.com/llvm/llvm-project/commit/957014da2d2791359181d89a04a0d27da65474d4 DIFF: https://github.com/llvm/llvm-project/commit/957014da2d2791359181d89a04a0d27da65474d4.diff L

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. In D126461#3597862 , @craig.topper wrote: > In D126461#3596761 , @reames wrote: > >> Despite the comments above, the purpose of this patch remains unclear. >> >> Per the draft spec,

<    1   2