[PATCH] D125949: [clang-tidy] modernize-avoid-bind: Fix crash when method name is not a simple identifier

jspam updated this revision to Diff 438265. jspam added a comment. Improve fixes As suggested by njames93, use call syntax instead of operator(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125949/new/ https://reviews.llvm.org/D125949 Files:

[PATCH] D128157: cppcoreguidelines-virtual-class-destructor: Fix crash when "virtual" keyword is expanded from a macro

jspam created this revision. Herald added subscribers: carlosgalvezp, shchenz, kbarton, nemanjai. Herald added a project: All. jspam requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Check llvm::Optional before dereferencing it.

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam added a comment. Would someone be able to commit this for me, as I do not have the necessary rights? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 _

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

kerbowa created this revision. kerbowa added reviewers: rampitec, jrbyrnes, vangthao95, arsenm. Herald added subscribers: kosarev, jsilvanus, foad, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. Herald added a project: All. kerbowa requested review of this revision. Herald

[PATCH] D128158: [AMDGPU] Add amdgcn_sched_group_barrier builtin

kerbowa added a comment. Somewhat WIP needs more tests and cleanup. Posted for dependent work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128158/new/ https://reviews.llvm.org/D128158 ___ cfe-commits m

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/Homoglyph.cpp:32-35 +/** + * Build a skeleton out of the Original identifier, following the algorithm + * described in http://www.unicode.org/reports/tr39/#def-skeleton + */ `/*` -> `

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. Because of the stability issues related to `getName()`-like constructs I'm putting a temporary ❌ on this (so it doesn't show up as faux accept). However, I have to emphasise

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

jansvoboda11 added a comment. In D128098#3594637 , @tschuett wrote: > There are now several JSON fragments per file? Previously, there was one > fragment per file. > > This will fail now: > https://sarcasm.github.io/notes/dev/compilation-database.html#cl

[PATCH] D126891: [clang-tidy] The check should ignore final classes

whisperity added a comment. (Please ensure a more appropriate commit message that actually mentions the check when committing, @steakhal.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126891/new/ https://reviews.llvm.org/D126891

[PATCH] D126291: [flang][Driver] Update link job on windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26041e17006c: Update link job for flang on windows (authored by rovka). Changed prior to commit: https://reviews.llvm.org/D126291?vs=436722&id=438

[clang] 26041e1 - Update link job for flang on windows

Author: Diana Picus Date: 2022-06-20T07:25:10Z New Revision: 26041e17006cf30e9c2d06706fe6bd3fa818e356 URL: https://github.com/llvm/llvm-project/commit/26041e17006cf30e9c2d06706fe6bd3fa818e356 DIFF: https://github.com/llvm/llvm-project/commit/26041e17006cf30e9c2d06706fe6bd3fa818e356.diff LOG: U

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +} + if (PrevToken->Tok.isLiteral() || Thank you I wish more of the clauses were commented like this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873

[PATCH] D127270: [clang-format] Add space in placement new expression

MyDeveloperDay added inline comments. Comment at: clang/docs/tools/dump_format_style.py:317 pass + elif state == State.InNestedEnum: +if line.startswith('///'): Can you show us a screenshot of how these changes will look in HTML? Reposit

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553-554 + CheckerOptions<[ +CmdLineOption Well, now I see why you marked this `Hide` previously. > This is a //modeling// checker, t

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. Thanks -- the patch looks quite good to me now! I will defer to @sammccall for final approval in case he has any additional feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124690/new/ https://reviews.llvm.org/D1246

[clang] e15fef4 - [analyzer] SATest: Ensure Docker image can be built

Author: Marco Antognini Date: 2022-06-20T09:43:21+02:00 New Revision: e15fef41709a226a45d321ebb9cd58260cb97b02 URL: https://github.com/llvm/llvm-project/commit/e15fef41709a226a45d321ebb9cd58260cb97b02 DIFF: https://github.com/llvm/llvm-project/commit/e15fef41709a226a45d321ebb9cd58260cb97b02.dif

[PATCH] D126196: [analyzer] SATest: Ensure Docker image can be built

This revision was automatically updated to reflect the committed changes. Closed by commit rGe15fef41709a: [analyzer] SATest: Ensure Docker image can be built (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126196/new/ https:

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske marked an inline comment as done. balazske added a comment. I did performance measurements in the past and it showed no important difference, run time got more with at most some percent at some of the projects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 0ad4f29 - [analyzer] SATest: Weaken assumption about HTML files

Author: Marco Antognini Date: 2022-06-20T09:46:07+02:00 New Revision: 0ad4f29b545d849820f0025736c9559c5c439032 URL: https://github.com/llvm/llvm-project/commit/0ad4f29b545d849820f0025736c9559c5c439032 DIFF: https://github.com/llvm/llvm-project/commit/0ad4f29b545d849820f0025736c9559c5c439032.dif

[PATCH] D126197: [analyzer] SATest: Weaken assumption about HTML files

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ad4f29b545d: [analyzer] SATest: Weaken assumption about HTML files (authored by mantognini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126197/new/ http

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. Thank you for working on this! I've been using clangd with this patch applied for a week or so, and it seems to be working well, I haven't run into any issues. Could you please upload a patch with context, to make it easier to review? (Currently, above each hunk it says

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

nridge added a comment. In D127082#3560642 , @daiyousei-qz wrote: > Basically, anywhere the same code action isn't available. Need this be > documented somewhere? If you'd like, we could mention the ability to show macro expansions here

[PATCH] D112916: [clang-tidy] Confusable identifiers detection

cor3ntin added a comment. So that this doesn't get lost, I'm opposed to this change because it does not actually follow the TR39 guidance or algorithm. For an input string X, define skeleton(X) to be the following transformation on the string: 1. Convert X to NFD format, as described in

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

nikic added a comment. In D127579#3588626 , @Anastasia wrote: > In D127579#3586092 , @nikic wrote: > >> @Anastasia Thanks, that does sound like a legitimate reason to include the >> information. I want to double

[clang] 60f3b07 - [clang][analyzer] Add checker for bad use of 'errno'.

Author: Balázs Kéri Date: 2022-06-20T10:07:31+02:00 New Revision: 60f3b071185bf4be32d5c3376856c573975c912a URL: https://github.com/llvm/llvm-project/commit/60f3b071185bf4be32d5c3376856c573975c912a DIFF: https://github.com/llvm/llvm-project/commit/60f3b071185bf4be32d5c3376856c573975c912a.diff L

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. balazske marked an inline comment as done. Closed by commit rG60f3b071185b: [clang][analyzer] Add checker for bad use of 'errno'. (authored by balazske). Repository:

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b68da2c7d97: [mlir] move SCF headers to SCF/{IR,Transforms} respectively (authored by ftynse). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

njames93 added a comment. In D125885#3595301 , @jspam wrote: > Would someone be able to commit this for me, as I do not have the necessary > rights? Thanks I can for you, what name and email address should I use? Repository: rG LLVM Github Monorepo

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 438289. dongjunduo added a comment. [Clang] Restore the old behaviors when "-ftime-trace-path" is not specified Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://reviews.llvm.org/D128048 Fil

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

jspam added a comment. Thanks. Please use Joachim Priesner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125885/new/ https://reviews.llvm.org/D125885 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D128116: [clang][docs] Sync generated command line doc with td files.

ilinpv closed this revision. ilinpv added a comment. Commited in af6d2a0b6825e71965f3e2701a63c239fa0ad70f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128116/new/ https://revie

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke updated this revision to Diff 438295. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/test/clang-ti

[PATCH] D125349: [clang][sema] Generate builtin operator overloads for (volatile) _Atomic types

jansvoboda11 updated this revision to Diff 438296. jansvoboda11 added a comment. Extract function for building type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 Files: clang/include/clang/AST/Type.h

[PATCH] D125349: [clang][sema] Generate builtin operator overloads for (volatile) _Atomic types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb02d970b4335: [clang][sema] Generate builtin operator overloads for (volatile) _Atomic types (authored by jansvoboda11). Repository: rG LLVM Githu

[clang] b02d970 - [clang][sema] Generate builtin operator overloads for (volatile) _Atomic types

Author: Jan Svoboda Date: 2022-06-20T11:03:29+02:00 New Revision: b02d970b4335561940dd584f6e6497ab684c788d URL: https://github.com/llvm/llvm-project/commit/b02d970b4335561940dd584f6e6497ab684c788d DIFF: https://github.com/llvm/llvm-project/commit/b02d970b4335561940dd584f6e6497ab684c788d.diff L

[libunwind] 8df257a - [libunwind] Ensure test/libunwind_01.pass is not completely inlined

Author: Alex Richardson Date: 2022-06-20T09:05:49Z New Revision: 8df257a6d0b0b32e05e89874eff4c8ddd2a2a2a9 URL: https://github.com/llvm/llvm-project/commit/8df257a6d0b0b32e05e89874eff4c8ddd2a2a2a9 DIFF: https://github.com/llvm/llvm-project/commit/8df257a6d0b0b32e05e89874eff4c8ddd2a2a2a9.diff LO

[clang] 8c3fa31 - [OpenCL][TableGen] Fix type extension guard emission

Author: Sven van Haastregt Date: 2022-06-20T10:07:34+01:00 New Revision: 8c3fa31701c4b874138c52266e7ab96818092f47 URL: https://github.com/llvm/llvm-project/commit/8c3fa31701c4b874138c52266e7ab96818092f47 DIFF: https://github.com/llvm/llvm-project/commit/8c3fa31701c4b874138c52266e7ab96818092f47.

[PATCH] D97204: [RFC] Clang 64-bit source locations

lenary added a comment. Herald added a project: All. Some of this patch set has been broken by https://reviews.llvm.org/D125403 and https://reviews.llvm.org/D125952 - which are size optimisations for PCH encodings of source locations. The biggest issue is new line 90 of `clang/include/clang/Ser

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +} + if (PrevToken->Tok.isLiteral() || MyDeveloperDay wrote: > Thank you I wish more of the clauses were commented l

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo updated this revision to Diff 438303. dongjunduo marked an inline comment as done. dongjunduo added a comment. [Clang] change unclear help text pf "-ftime-trace-path" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128048/new/ https://revi

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

dongjunduo added a comment. In D128048#3591829 , @Whitney wrote: > Can you please add some test cases? I have found that new-option unit tests are not included in `clang/test` or `clang/unit-tests`. Could u tell me where I should write the test cases?

[PATCH] D128166: ManagedStatic: Destroy from destructor

nhaehnle created this revision. Herald added a reviewer: deadalnix. Herald added subscribers: bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, a

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

steakhal added a comment. I missed this commit because it was not tagged by "[analyzer]". What is the community preference about tagging CSA commits? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127643/new/ https://reviews.llvm.org/D127643 __

[PATCH] D128120: [Clang][VE] Add missing intrinsics

efocht accepted this revision. efocht added a comment. This revision is now accepted and ready to land. Looks ok for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128120/new/ https://reviews.llvm.org/D128120 ___

[PATCH] D128182: [NFC] Switch FloatModeKind enum class to use bitmask enums

jolanta.jensen created this revision. Herald added a project: All. jolanta.jensen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using bitmask enums simplifies and clarifies the code. Repository: rG LLVM Github Monorepo https://review

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Extend flow condition in the body of a do/while loop.

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + xbolva00 wrote: > ilinpv wrote: > > MaskRay wrote: > > > This file is auto-generated. Don't touch it. > > It looked out of sync with options td files

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. The CI failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128043/new/ https://reviews.llvm.org/D128043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D127655: [AArch64] Define __FP_FAST_FMA[F]

jolanta.jensen updated this revision to Diff 438344. jolanta.jensen added a comment. Removing an unnecessary test change from aarch64-target-features.c as init-aarch64.c provides enough coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127655

[PATCH] D127856: [clangd] Support multiline semantic tokens

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (My first reaction was that this belongs in semanticHighlights() rather than toSemanticTokens, but I think you got it right - the single-line restriction is pretty unnatural from clang's

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

awarzynski added a comment. In D128043#3596096 , @peixin wrote: > The CI failed. Thanks - I didn't notice any failures related to this change. Did I miss anything? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D128043: [flang][driver] Add support for `-O{0|1|2|3}`

peixin added a comment. OK. This seems not to be related to this patch. https://buildkite.com/llvm-project/premerge-checks/builds/98446#0181715d-812b-4d2a-b5d0-5c1283d78b5f I also see these failures in another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang-tools-extra] 541a50e - [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

Author: Joachim Priesner Date: 2022-06-20T13:30:30+01:00 New Revision: 541a50e20702a8046fe5076742611354cb6dd0f3 URL: https://github.com/llvm/llvm-project/commit/541a50e20702a8046fe5076742611354cb6dd0f3 DIFF: https://github.com/llvm/llvm-project/commit/541a50e20702a8046fe5076742611354cb6dd0f3.di

[PATCH] D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG541a50e20702: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals (authored by jspam, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz created this revision. sgraenitz added reviewers: rnk, theraven, DHowett-MSFT. Herald added subscribers: jsji, pengfei, hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. WinEHPr

[PATCH] D127184: [clangd] Add to header map

sammccall added a comment. Apologies for not getting to this before vacation, and thanks Nathan for looking at this. (I'll leave for you to stamp) This is fine with me as-is, but I think this mapping shouldn't be our *preferred* way to solve this problem, and should eventually go away. We also

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

pcwang-thead added a comment. Ping. Any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

jansvoboda11 updated this revision to Diff 438367. jansvoboda11 added a comment. Code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122385/new/ https://reviews.llvm.org/D122385 Files: clang/test/ClangScanDeps/cl-output.c clang/

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

asb added a comment. I've left one minor comment. My other suggestion would be to absorb in the semantic restrictions work from here . Comment at: llvm/lib/IR/Type.cpp:307 +Type *Type::getWasm_ExternrefTy(LLVMCon

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 added a comment. Is anyone up to review this? I'm mostly looking for some feedback on the interfaces I've built. If no one has time to look into it I can probably just land without review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1272

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

sammccall added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1600 - llvm::APInt LitVal(PP.getTargetInfo().getIntWidth(), 0); + llvm::APInt LitVal(PP.getTargetInfo().getChar32Width(), 0); tahonermann wrote: > I don't think this is quite righ

[PATCH] D128197: [clangd] Handle initializers that contain =

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Re

[PATCH] D128197: [clangd] Handle initializers that contain =

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:192 + continue; +// Deletion range initially spans the initializer, excluding the `=

[PATCH] D128119: [clang] enforce instantiation of constexpr template functions

serge-sans-paille added a comment. This also seems to fix https://github.com/llvm/llvm-project/issues/37522 and https://github.com/llvm/llvm-project/issues/55315 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128119/new/ https://reviews.llvm.org/D128119

[PATCH] D125728: [WebAssembly] Update supported features in -mcpu=generic

asb added a comment. One thing that's not ideal about this test case is that it still passes if you delete the changes to WebAssembly.cpp. At least for RISC-V, selecting the -mcpu also emits the relevant `-target-feature +foo` for features supported by that CPU, which doesn't seem to happen her

[PATCH] D128202: [clangd] Include "final" when printing class declaration

tom-anders created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes https://github

[PATCH] D105494: [clang] Introduce a union inside ProgramPoint.

lenary added a comment. Herald added a project: All. This change looks fine to me (though clang-format wants a reasonable change). I'm not familiar with the clang static analyzer, so I'm not sure I can +2 this, but hopefully this message will act as a ping for the existing reviewers? Repositor

[PATCH] D128202: [clangd] Include "final" when printing class declaration

sammccall added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1010 + if (D->isEffectivelyFinal()) { + Out << " final"; isEffectivelyFinal returns true for `struct X { ~X() final; }` I don't think we want to print `struct X final {}` in that

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong added a comment. Hmm, it looks like MSVC is accepting: extern "C" { static void foo(); } static int foo(); #pragma alloc_text("s", foo) static void foo() {} Ignoring the `pragma alloc_text`, it looks like GCC compiles the following `foo` with C linkage vs LLVM which comp

[PATCH] D128202: [clangd] Include "final" when printing class declaration

tom-anders added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:1010 + if (D->isEffectivelyFinal()) { + Out << " final"; sammccall wrote: > isEffectivelyFinal returns true for > `struct X { ~X() final; }` > > I don't think we want to print `s

[PATCH] D128204: [clangd] Add fix-it for inserting IWYU pragma: keep

njames93 created this revision. njames93 added reviewers: sammccall, kadircet, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, JonChesterfield, ye-luo. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. This patch updates the `--[no-]o

[PATCH] D128206: [Clang] Allow multiple comma separated arguments to `--offload-arch=`

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. LGTM. This allows me to write concise compile lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128206/new/ https://reviews.llvm.org/D128206

[PATCH] D128207: [clang-doc][NFC] Fix reference invalidation assertion failure.

MTC created this revision. MTC added reviewers: dexonsmith, mehdi_amini. MTC added a project: clang-tools-extra. Herald added subscribers: jsji, usaxena95, pengfei, kadircet, arphaman. Herald added a project: All. MTC requested review of this revision. Herald added subscribers: cfe-commits, ilya-bi

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet updated this revision to Diff 438387. kadircet added a comment. Split highlights into multiple tokens rather than trimming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127856/new/ https://reviews.llvm.org/D127856 Files: clang-tools-ext

[PATCH] D127856: [clangd] Support multiline semantic tokens

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:948 +} else { + // If a tokens length is past the end of the line, it should be treated as + // if the token ends at the end of the line and will not wrap onto the ---

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 updated this revision to Diff 438388. njames93 added a comment. Reuse implementation from D127446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126859/new/ https://reviews.llvm.org/D126859 Files: clang

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

sberg added a comment. Is it intended that a deleted copy assignment op as in `struct S { void operator =(S &) = delete; };` (though, somewhat oddly, not in `struct S { void operator =(S) = delete; };`) is now marked as trivial? I think that's the root cause why a build of PDFium with clang-cl

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +} + if (PrevToken->Tok.isLiteral() || HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > Thank you I wish more of the clauses were commented like this > +1 I'm not

[clang-tools-extra] 1c92e06 - [clangd] Handle initializers that contain =

Author: Kadir Cetinkaya Date: 2022-06-20T16:42:54+02:00 New Revision: 1c92e06ded2da33f9ad00305af281e47cf9c584f URL: https://github.com/llvm/llvm-project/commit/1c92e06ded2da33f9ad00305af281e47cf9c584f DIFF: https://github.com/llvm/llvm-project/commit/1c92e06ded2da33f9ad00305af281e47cf9c584f.dif

[PATCH] D128197: [clangd] Handle initializers that contain =

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG1c92e06ded2d: [clangd] Handle initializers that contain = (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D128197?vs=438369&id=438392

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3700 +EXPECT_TRUE(AfterLoopEnv.flowConditionImplies( +AfterLoopEnv.makeNot

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 438407. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

reames requested changes to this revision. reames added a comment. This revision now requires changes to proceed. Despite the comments above, the purpose of this patch remains unclear. Per the draft spec, the relevant wording is: "These instructions execute as a regular load except that they will

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

khchen added a comment. Could you please purpose this implement in rvv-intrinsc-doc first? I think this feature need to have discussion because store to nullptr is UB but we are making it as defined behavior only for these intrinsics. Personally I like they have consistent behavior and in documen

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

beanz updated this revision to Diff 438419. beanz added a comment. Updates based on feeback from @MaskRay. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127890/new/ https://reviews.llvm.org/D127890 Files: clang/docs/ReleaseNotes.rst

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. In D127593#3596601 , @sberg wrote: > Is it intended that a deleted copy assignment op as in `struct S { void > operator =(S &) = delete; };` (though, somewhat oddly, not in `struct S { > void operator =(S) = delete; };`) is

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz updated this revision to Diff 438425. sgraenitz added a comment. Add missing `objc_sync_exit` to fix failing test Transforms/PreISelIntrinsicLowering/objc-arc.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128190/new/ https://reviews.l

[PATCH] D128190: [WinEH] Apply funclet operand bundles to nounwind intrinsics that lower to function calls

sgraenitz added a comment. Running `check-llvm` and `check-clang` locally found no more failing tests. The issue is not limited to pre-ISel intrinsics (anymore) and I have to re-phrase a few comments. Apart from that, is there any more feedback? Thanks Repository: rG LLVM Github Monorepo CH

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev updated this revision to Diff 438427. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128183/new/ https://reviews.llvm.org/D128183 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp c

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3700 +EXPECT_TRUE(AfterLoopEnv.flowConditionImplies( +AfterLoopEnv.makeNot(AfterLoopFooVal))); + }); ---

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm (If you like, consider dropping the "-DEFAULT" part from the new filecheck prefixes. I don't think they really add much value.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438433. omarahmed added a comment. - Add version for nestedEnums and nestedFields - Make tests valid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/docs/tools/dump_format_style.py:317 pass + elif state == State.InNestedEnum: +if line.startswith('///'): MyDeveloperDay wrote: > Can you show us a screenshot of how these changes will look

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed marked 3 inline comments as done and an inline comment as not done. omarahmed added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3396 spaceRequiredBeforeParens(Right); +if (Style.SpaceBeforeParens == FormatStyle::SBPO_Custom && +

[clang] e363c59 - [clang][dataflow] Extend flow condition in the body of a do/while loop

Author: Stanislav Gatev Date: 2022-06-20T17:31:00Z New Revision: e363c5963dc3ad5d9492d3f37055ad56a84411a5 URL: https://github.com/llvm/llvm-project/commit/e363c5963dc3ad5d9492d3f37055ad56a84411a5 DIFF: https://github.com/llvm/llvm-project/commit/e363c5963dc3ad5d9492d3f37055ad56a84411a5.diff LO

[PATCH] D128183: [clang][dataflow] Extend flow condition in the body of a do/while loop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rGe363c5963dc3: [clang][dataflow] Extend flow condition in the body of a do/while loop (authored by sgatev).

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 438437. steplong added a comment. - Remove DEFAULT from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[clang] 452db15 - [clang] Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T10:51:34-07:00 New Revision: 452db157c963b2897a0882e3bb05ef845b9e4015 URL: https://github.com/llvm/llvm-project/commit/452db157c963b2897a0882e3bb05ef845b9e4015 DIFF: https://github.com/llvm/llvm-project/commit/452db157c963b2897a0882e3bb05ef845b9e4015.diff L

[clang] 5413bf1 - Don't use Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-06-20T11:33:56-07:00 New Revision: 5413bf1bac2abb9e06901686cdc959e92940143a URL: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a DIFF: https://github.com/llvm/llvm-project/commit/5413bf1bac2abb9e06901686cdc959e92940143a.diff L

  1   2   >