[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

samestep created this revision. Herald added subscribers: martong, tschuett, carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. samestep requested review of this revision. Herald added projects: clang, LLVM, clang-tools-extra. Herald added subscribers: cfe-commits, llvm-commits. Reposi

[clang] 1082285 - Rolling back tests for WG14 DR145

Author: Aaron Ballman Date: 2022-06-15T15:37:14-04:00 New Revision: 10822857b7d5218a36eb36e36b924f10d981b67c URL: https://github.com/llvm/llvm-project/commit/10822857b7d5218a36eb36e36b924f10d981b67c DIFF: https://github.com/llvm/llvm-project/commit/10822857b7d5218a36eb36e36b924f10d981b67c.diff

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:72 +- Clang is gaining support for HLSL. Basic features for the HLSL language have + started being merged during Clang-15 development, but the implementation is + incomplete a

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437303. maryammo marked an inline comment as not done. maryammo added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files:

[PATCH] D127901: [LinkerWrapper] Add PTX output to CUDA fatbinary in LTO-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added subscribers: mattd, gchakrabarti, asavonic, inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3585626 , @erichkeane wrote: > See here: https://github.com/llvm/llvm-project/issues/55673 > > This might be the same issue, the crash at least looks the same. Note: Looks to not be the same problem :/ Additionall

[clang] 2d82c9c - [clang-format][NFC] Fix braces in ClangFormat.cpp

Author: owenca Date: 2022-06-15T12:57:48-07:00 New Revision: 2d82c9ccf32c9200b1a48de613869113e8655508 URL: https://github.com/llvm/llvm-project/commit/2d82c9ccf32c9200b1a48de613869113e8655508 DIFF: https://github.com/llvm/llvm-project/commit/2d82c9ccf32c9200b1a48de613869113e8655508.diff LOG: [

[PATCH] D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d82c9ccf32c: [clang-format][NFC] Fix braces in ClangFormat.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437310. maryammo added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437311. maryammo added a comment. NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126908/new/ https://reviews.llvm.org/D126908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437313. maryammo added a comment. Herald added a subscriber: kbarton. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ cfe-commits mailing list cfe-c

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3585681 , @nikic wrote: > FYI this change had a measurable effect on compile-time > (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0

[PATCH] D127883: [clang][deps] Further canonicalize implicit modules options in dep scan

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127883/new/ https://reviews.llvm.org/D127883 __

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

rsmith added a comment. Thank you for the patch! This is certainly an improvement but I think there are still some cases where we compute the wrong range for `~` with this patch applied. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 437317. maryammo added a comment. Fixing unintentional merge from previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/

[clang] 509223d - [clang][deps] Further canonicalize implicit modules options in dep scan

Author: Ben Langmuir Date: 2022-06-15T13:29:47-07:00 New Revision: 509223da61145c3eb982751cba9ab6ddf0f48e9d URL: https://github.com/llvm/llvm-project/commit/509223da61145c3eb982751cba9ab6ddf0f48e9d DIFF: https://github.com/llvm/llvm-project/commit/509223da61145c3eb982751cba9ab6ddf0f48e9d.diff

[PATCH] D127883: [clang][deps] Further canonicalize implicit modules options in dep scan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG509223da6114: [clang][deps] Further canonicalize implicit modules options in dep scan (authored by benlangmuir). Repository: rG LLVM Github Monore

[clang] c418d0f - [Driver] Simplify -fno-builtin- handling. NFC

Author: Fangrui Song Date: 2022-06-15T13:35:08-07:00 New Revision: c418d0f1be50545daa68e5abf8771db2e1b00819 URL: https://github.com/llvm/llvm-project/commit/c418d0f1be50545daa68e5abf8771db2e1b00819 DIFF: https://github.com/llvm/llvm-project/commit/c418d0f1be50545daa68e5abf8771db2e1b00819.diff

[PATCH] D126495: [clang-tidy] Organize test docs into subdirectories by module (NFC)

LegalizeAdulthood added a comment. Ping. All review comments should be addressed in the latest diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126495/new/ https://reviews.llvm.org/D126495 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

Joe_Nash created this revision. Joe_Nash added reviewers: foad, rampitec. Herald added subscribers: kosarev, jsilvanus, hsmhsm, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm. Herald added a project: All. Joe_Nash requested review of this revision. Herald ad

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

arsenm added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.fdot2.f16.f16.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1100 -verify-machineinstrs < %s | FileCheck

[PATCH] D127904: [AMDGPU] gfx11 new dot instruction codegen support

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-dl-insts-err.cl:1 // REQUIRES: amdgpu-registered-target Also need positive tests like in builtins-amdgcn-dl-insts.cl. Comment at: llvm/include/llvm/IR/Intri

[clang] 78747bd - [clang][WebAssembly] Loosen restriction on `main` symbol mangling

Author: Sam Clegg Date: 2022-06-15T13:56:05-07:00 New Revision: 78747bd39af807eb6b56709b9713c303704c47ad URL: https://github.com/llvm/llvm-project/commit/78747bd39af807eb6b56709b9713c303704c47ad DIFF: https://github.com/llvm/llvm-project/commit/78747bd39af807eb6b56709b9713c303704c47ad.diff LOG

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78747bd39af8: [clang][WebAssembly] Loosen restriction on `main` symbol mangling (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson added a comment. In D127593#3585073 , @erichkeane wrote: > The OMP failures are still there though, which is a touch concerning. Yeah, I rerun the CI and it still fails. I couldn't reproduce the failures locally, though, and the CI logs don

[PATCH] D127863: [clang] Dont print implicit forrange initializer

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127863/new/ https://reviews.llvm.org/D127863 __

[clang] 3071092 - unbreak Modules/cxx20-export-import.cpp with LLVM_APPEND_VC_REV=OFF after 45d88cd00846

Author: Nico Weber Date: 2022-06-15T17:42:35-04:00 New Revision: 307109266f6c7598dfc69b6388fa271662de9388 URL: https://github.com/llvm/llvm-project/commit/307109266f6c7598dfc69b6388fa271662de9388 DIFF: https://github.com/llvm/llvm-project/commit/307109266f6c7598dfc69b6388fa271662de9388.diff LO

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

thakis added a comment. FYI: If you change serialized opts in a def file, you have to bump the pch version, else with builds that don't embed the llvm revision (LLVM_APPEND_VC_REV=OFF) won't notice they have to invalidate pchs. (In this case, I did this in https://github.com/llvm/llvm-project/

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. Right now I'm not yet understanding all of the algorithm (haven't spent enough time on it), but I'm mostly concerned by the runtime cost of this normalization. Comment at: mlir/lib/Transforms/Utils/CommutativityUtils.cpp:371 +// assigned a sort

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim updated this revision to Diff 437355. hctim marked 6 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127544/new/ https://reviews.llvm.org/D127544 Files: clang/lib/Sema/SemaDeclAttr.cpp

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

hctim added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8849 break; - // HLSL attributes: aaron.ballman wrote: > Spurious whitespace change? unfortunately there's no way in my editor to trim trailing whitespace only on changed lines :(

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim added a comment. In D127163#3587115 , @thakis wrote: > FYI: If you change serialized opts in a def file, you have to bump the pch > version, else with builds that don't embed the llvm revision > (LLVM_APPEND_VC_REV=OFF) won't notice they have to i

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added a comment. In D127812#3585249 , @erichkeane wrote: > I'm concerned as to the design of this addition, I don't particularly > appreciate the reasons for making 'target_clones' different, nor the purpose > for adding a new attribute instead

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

rnk added a comment. I don't have a great answer here, but yes, dllexport macro norms sort of run directly counter to the normal ways that people use PCH. It seems like projects will need to have a library module / PCH file for building a DLL and then a PCH / module for consuming the DLL. Rep

[PATCH] D127860: [msan] Allow KMSAN to use -fsanitize-memory-param-retval

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127860/new/ https://reviews.llvm.org/D127860 _

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

phosek updated this revision to Diff 437372. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127887/new/ https://reviews.llvm.org/D127887 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/F

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim created this revision. hctim added a reviewer: vitalybuka. Herald added subscribers: Enna1, ormris, hiraditya. Herald added a project: All. hctim requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits.

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

hctim updated this revision to Diff 437385. hctim added a comment. Small test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127911/new/ https://reviews.llvm.org/D127911 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/SanitizerM

[PATCH] D96147: [SEMA] Added warn_decl_shadow support for structured bindings

smeenai added a comment. Herald added a project: All. This is very belated, sorry :) Our shadowing warnings have special behavior for lambdas and local variables: the warning for lambdas shadowing uncaptured local variables falls under `-Wshadow-uncaptured-local`, which isn't turned on for `-Ws

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + MaskRay wrote: > This file is auto-generated. Don't touch it. It looked out of sync with options td files: ``` +.. option:: -gen-reproducer=, -fno-c

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk accepted this revision. amyk added a comment. This revision is now accepted and ready to land. Thanks for the updates. Unless @lei has any other additional comments, I think LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ http

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. Okay, it seems reasonable enough to have the `[[clang::lto_visibility_public]]` attribute override the `--lto-whole-program-visibility` flag. What I'm not sure about though is whether `__declspec(uu

[PATCH] D127812: [AArch64] Function multiversioning support added.

ilinpv added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3090 + std::vector + filterFunctionTargetVersionAttrs(const TargetVersionAttr *TV) const; erichkeane wrote: > It is concerning that this differs from the above. target_version su

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added subscribers: ChuanqiXu, EricWF. ahatanak added a comment. Adding more people to get more eyes on the changes I made to SemaCoroutine.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

vangthao created this revision. Herald added a subscriber: martong. Herald added a project: All. vangthao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Accept newlines when the diagnostic string is being given by an outside source instead

[clang] 1694175 - [Clang][Modules] Merge availability attributes on imported decls

Author: Michael Spencer Date: 2022-06-15T17:46:16-07:00 New Revision: 169417531578501e955f12c79ecb8ff05333ae15 URL: https://github.com/llvm/llvm-project/commit/169417531578501e955f12c79ecb8ff05333ae15 DIFF: https://github.com/llvm/llvm-project/commit/169417531578501e955f12c79ecb8ff05333ae15.dif

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG169417531578: [Clang][Modules] Merge availability attributes on imported decls (authored by Bigcheese). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks updated this revision to Diff 437420. aeubanks added a comment. update docs to only mention `[[clang::lto_visibility_public]]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127876/new/ https://reviews.llvm.org/D127876 Files: clang/docs/

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

lei added a comment. LGTM, just a few nit that can be addressed on commit. Comment at: clang/lib/Sema/SemaExpr.cpp:7723 + + if (SrcTy->isVectorType()) { +VectorType::VectorKind SrcVecKind = do we really need this check since we have an assert above?

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ChuanqiXu added a comment. In D125936#3587542 , @ahatanak wrote: > Adding more people to get more eyes on the changes I made to > SemaCoroutine.cpp. The change to SemaCoroutine.cpp might be good. But I feel like it is irreverent to the revision. If you

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7723 + + if (SrcTy->isVectorType()) { +VectorType::VectorKind SrcVecKind = lei wrote: > do we really need this check since we have an assert above? Yes, without this check there is gonna

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7723 + + if (SrcTy->isVectorType()) { +VectorType::VectorKind SrcVecKind = maryammo wrote: > lei wrote: > > do we really need this check since we have an assert above? > Yes, without thi

[PATCH] D126676: [clang] Disallow differences in defines used for creating and using PCH

mstorsjo added a comment. In D126676#3587243 , @rnk wrote: > I don't have a great answer here, but yes, dllexport macro norms sort of run > directly counter to the normal ways that people use PCH. It seems like > projects will need to have a library mod

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. In D124750#3587161 , @mehdi_amini wrote: > Right now I'm not yet understanding all of the algorithm (haven't spent > enough time on it), but I'm mostly concerned by the runtime cost of this > normalization. I understand you

<    1   2   3