pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land.
Okay, it seems reasonable enough to have the `[[clang::lto_visibility_public]]` attribute override the `--lto-whole-program-visibility` flag. What I'm not sure about though is whether `__declspec(uuid)` and `std`/`stdext` in `/MT`/`/MTd` should also override it. Fortunately we don't need to solve that now because those are Windows-specific attributes/features and we don't support passing `--lto-whole-program-visibility` to Windows linkers. So LGTM if you only mention `[[clang::lto_visibility_public]]` in your change to the documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127876/new/ https://reviews.llvm.org/D127876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
