[clang] 6c4f999 - [analyzer] Fix StreamErrorState hash bug

Author: Balazs Benics Date: 2022-06-15T16:50:12+02:00 New Revision: 6c4f9998ae383d69e97a0d977585f2cb55ff92ed URL: https://github.com/llvm/llvm-project/commit/6c4f9998ae383d69e97a0d977585f2cb55ff92ed DIFF: https://github.com/llvm/llvm-project/commit/6c4f9998ae383d69e97a0d977585f2cb55ff92ed.diff

[clang] 481f860 - [analyzer][NFC] Remove dead field of UnixAPICheckers

Author: Balazs Benics Date: 2022-06-15T16:50:12+02:00 New Revision: 481f8603246c725a27f937ec5fde4d68fa4584ae URL: https://github.com/llvm/llvm-project/commit/481f8603246c725a27f937ec5fde4d68fa4584ae DIFF: https://github.com/llvm/llvm-project/commit/481f8603246c725a27f937ec5fde4d68fa4584ae.diff

[PATCH] D127839: [analyzer] Fix StreamErrorState hash bug

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c4f9998ae38: [analyzer] Fix StreamErrorState hash bug (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D127838: [analyzer][NFC] Remove dead field of UnixAPICheckers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f8603246c: [analyzer][NFC] Remove dead field of UnixAPICheckers (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

nikic added a reviewer: opaque-pointers. nikic added a comment. Could you please add some context directly to the patch description that explains why this is necessary? Being unfamiliar with SPRIV, I don't really get what is significant about the code example. Repository: rG LLVM Github Mono

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6642 // -fsized-deallocation is off by default, as it is an ABI-breaking change for - // most platforms. - Args.addOptInFlag(CmdArgs, options::OPT_fsized_deallocation, -options

[PATCH] D127863: [clang] Dont print implicit forrange initializer

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/1158 Repository: rG

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

beanz added a comment. @nikic the most important thing you need to know about SPIR-V is that it is a virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just like LLVM IR would. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127

[clang] 96ccb69 - [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

Author: Balazs Benics Date: 2022-06-15T16:58:13+02:00 New Revision: 96ccb690a0efef09382a40e19b96b549e97dc39e URL: https://github.com/llvm/llvm-project/commit/96ccb690a0efef09382a40e19b96b549e97dc39e DIFF: https://github.com/llvm/llvm-project/commit/96ccb690a0efef09382a40e19b96b549e97dc39e.diff

[PATCH] D127742: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG96ccb690a0ef: [analyzer][NFC] Prefer using isa<> instead getAs<> in conditions (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127742/n

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz updated this revision to Diff 437179. sgraenitz added a comment. Fix accidental functional change that failed Clang test CodeGenCXX/microsoft-abi-eh-inlineasm.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124762/new/ https://reviews.

[PATCH] D124762: [WinEHPrepare] Avoid truncation of EH funclets with GNUstep ObjC runtime

sgraenitz updated this revision to Diff 437180. sgraenitz added a comment. Drop GNUstep assertion from getBundlesForFunclet(). Indeed a similar issue was observed before. See: D44640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

nikic added a comment. In D127579#3585516 , @beanz wrote: > @nikic the most important thing you need to know about SPIR-V is that it is a > virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just > like LLVM IR would. Okay ... I gu

[clang] f4fc3f6 - [analyzer] Treat system globals as mutable if they are not const

Author: Balazs Benics Date: 2022-06-15T17:08:27+02:00 New Revision: f4fc3f6ba319c3c571b6a713a1c38ca1e1e3aae5 URL: https://github.com/llvm/llvm-project/commit/f4fc3f6ba319c3c571b6a713a1c38ca1e1e3aae5 DIFF: https://github.com/llvm/llvm-project/commit/f4fc3f6ba319c3c571b6a713a1c38ca1e1e3aae5.diff

[clang] 929e60b - [analyzer] Relax constraints on const qualified regions

Author: Balazs Benics Date: 2022-06-15T17:08:27+02:00 New Revision: 929e60b6bd2f463321b6e98db85a3d9c89236996 URL: https://github.com/llvm/llvm-project/commit/929e60b6bd2f463321b6e98db85a3d9c89236996 DIFF: https://github.com/llvm/llvm-project/commit/929e60b6bd2f463321b6e98db85a3d9c89236996.diff

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4fc3f6ba319: [analyzer] Treat system globals as mutable if they are not const (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D127763: [analyzer] Relax constraints on const qualified regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG929e60b6bd2f: [analyzer] Relax constraints on const qualified regions (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 437184. cor3ntin added a comment. Add unicode license notice to generated file derived fromn the unicode data Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files:

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

bader added a comment. In D127579#3585516 , @beanz wrote: > @nikic the most important thing you need to know about SPIR-V is that it is a > virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just > like LLVM IR would. And in additi

[PATCH] D127865: [clang][dataflow] Make `Value` and `StorageLocation` non-copyable

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. This makes it harder to misuse APIs that return referen

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:5984 +for (unsigned Idx = 0; Idx < Elm; ++Idx) { + InitArgs.emplace_back(new (Context) ArraySubscriptExpr( + Arg, Huh, interesting -- I didn't realize we ha

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin updated this revision to Diff 437186. cor3ntin added a comment. Fix wrapping in file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123064/new/ https://reviews.llvm.org/D123064 Files: clang/include/clang/Basic/DiagnosticLexKinds.t

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} aa

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

cor3ntin added a comment. In D123064#3585074 , @aaron.ballman wrote: > I had a discussion about the license file on IRC (but not with @tstellar) and > the thinking there was: add the license file. It seems to either be required > or would be harmless t

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. See here: https://github.com/llvm/llvm-project/issues/55673 This might be the same issue, the crash at least looks the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126907/new/ https://reviews.llvm.org/D126907 _

[PATCH] D127865: [clang][dataflow] Make `Value` and `StorageLocation` non-copyable

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127865/new/ https://reviews.llvm.org/D127865 __

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 437191. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. @rjmccall I made some progress on the requests above. There are still a few things that need to be nailed down. The comma && ternary cases for EmitPromoted, I am not sure what needs to happen there? I am also not quite sure about the ComplexExpr’s generated IR . I upd

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

nikic added a comment. FYI this change had a measurable effect on compile-time (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0cd6bb&stat=instructions), about 0.5% regression for `O0` builds. Not sure if that's

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 437194. upsj marked 9 inline comments as done. upsj added a comment. - improve documentation - add more edge case tests - fix reference hints for parameter packs - remove unnecessary headers - fix bug in handling of tail parameters Repository: rG LLVM Github

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:682 + if (const auto *TTPD = + dyn_cast(TemplateParams.back())) { +const auto *TTPT = nridge wrote: > I don't think there is any requirement that a pack be a traili

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} ---

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:12 + float3 BrokenNormie = float3(3.0, 4.0); // expected-error{{too few elements in vector initialization (expected 3 elements, have 2)}} + float3 OverwhemledNormie = float3(3.

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! But given the number of people who've expressed opinions on this, please wait a day or two before landing in case other reviewers have additional feedback. Repository:

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 437202. jolanta.jensen added a comment. Updated Release Notes. Renamed RealTypeUsesObjCFPRet to RealTypeUsesObjCFPRetMask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.o

[PATCH] D127802: [HLSL] Support HLSL vector initializers

aaron.ballman added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:12 + float3 BrokenNormie = float3(3.0, 4.0); // expected-error{{too few elements in vector initialization (expected 3 elements, have 2)}} + float3 OverwhemledNormie = f

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. In D127579#3585537 , @nikic wrote: > In D127579#3585516 , @beanz wrote: > >> @nikic the most important thing you need to know about SPIR-V is that it is >> a virtual ISA based on LLVM I

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. So to sum up.. #pragma optimize("", off) disables all optimizations, right? #pragma optimize("

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added a comment. In D125723#3585726 , @aaron.ballman wrote: > LGTM! But given the number of people who've expressed opinions on this, > please wait a day or two before landing in case other reviewers have > additional feedback. In term of cod

[clang] 0c2edf2 - [clang][dataflow] Make `Value` and `StorageLocation` non-copyable

Author: Stanislav Gatev Date: 2022-06-15T16:14:27Z New Revision: 0c2edf27a22efb648b36343d49a5dbe72903b549 URL: https://github.com/llvm/llvm-project/commit/0c2edf27a22efb648b36343d49a5dbe72903b549 DIFF: https://github.com/llvm/llvm-project/commit/0c2edf27a22efb648b36343d49a5dbe72903b549.diff LO

[PATCH] D127865: [clang][dataflow] Make `Value` and `StorageLocation` non-copyable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c2edf27a22e: [clang][dataflow] Make `Value` and `StorageLocation` non-copyable (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

aaron.ballman added a comment. In D125723#3585788 , @xbolva00 wrote: > In D125723#3585726 , @aaron.ballman > wrote: > >> LGTM! But given the number of people who've expressed opinions on this, >> please wait a d

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:223-224 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : (1 << (int)FloatModeKind::Float) | +

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479 ___ cfe-commits mailing list cfe-comm

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. xbolva00 wrote: > So to sum up.. #pragma optimize("", off) disables all optimizations, right? >

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

jackhong12 created this revision. jackhong12 added a reviewer: clang-format. Herald added a project: All. jackhong12 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #55810 Star tokens should be categorized as TT_PointerOrReference in

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. xbolva00 wrote: > xbolva00 wrote: > > So to sum up.. #pragma optimize("", off) disables all opt

[PATCH] D127874: [analyzer] Reimplement UnreachableCodeChecker using worklists

steakhal created this revision. steakhal added reviewers: NoQ, martong, balazske, ASDenysPetrov, Szelethus, frederic-tingaud-sonarsource. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All.

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks created this revision. aeubanks added reviewers: pcc, tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks updated this revision to Diff 437224. aeubanks added a comment. update some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127876/new/ https://reviews.llvm.org/D127876 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CGV

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks added a comment. I realize that this is not a full fix for the general problem involving `-lto-whole-program-visibility`, but I believe if you ignore `-lto-whole-program-visibility` (which Chrome doesn't use) then this fix makes sense. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

amyk added a comment. Some additional minor comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7572 + "Current bitcast for incompatible vector types (%0 and %1) are deprecated. " + "The default behaviour will change to what implied by the " + "-fno-lax-ve

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. In D126864#3584536 , @serge-sans-paille wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 does toward > `-fstrict-flex-arrays=` with > > - `n=0` ⇒ `-fno-strict-flex-arrays`, current state (the default) > - `n=1` ⇒ only c

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

nikic added a comment. @Anastasia Thanks, that does sound like a legitimate reason to include the information. I want to double check though, does linking the modules actually fail if the functions have signatures that differ only by pointer types? At least for normal LLVM IR this would work fi

[clang] 45d88cd - [clang] Add -fsanitize=memtag-globals (no-op).

Author: Mitch Phillips Date: 2022-06-15T10:07:53-07:00 New Revision: 45d88cd008463be54b8f907bd6eea6c65c8049b6 URL: https://github.com/llvm/llvm-project/commit/45d88cd008463be54b8f907bd6eea6c65c8049b6 DIFF: https://github.com/llvm/llvm-project/commit/45d88cd008463be54b8f907bd6eea6c65c8049b6.diff

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45d88cd00846: [clang] Add -fsanitize=memtag-globals (no-op). (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. This diverges from the documented behavior of `-lto-whole-program-visibility`. The flag is meant to give all classes hidden LTO visibility, but now it only does that to some of them. Rep

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks added a comment. In D127876#3586134 , @pcc wrote: > This diverges from the documented behavior of > `-lto-whole-program-visibility`. The flag is meant to give all classes hidden > LTO visibility, but now it only does that to some of them. perh

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

pcc added a comment. In D127876#3586154 , @aeubanks wrote: > In D127876#3586134 , @pcc wrote: > >> This diverges from the documented behavior of >> `-lto-whole-program-visibility`. The flag is meant to give all c

Re: [clang] f13019f - [clang] Use any_of and none_of (NFC)

Hi David, On Mon, Jun 13, 2022 at 2:00 PM David Blaikie wrote: > On Sun, Jun 12, 2022 at 10:17 AM Kazu Hirata via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> - return args_end() != std::find_if( >> - args_begin(), args_end(), >> - [=](const ParamIdx &Idx) { ret

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 437243. steplong added a comment. `https://docs.microsoft.com/en-us/cpp/build/reference/zc-sizeddealloc-enable-global-sized-dealloc-functions?view=msvc-170` says it implements this by default starting on MSVC 2015. I don't have an older version of MSVC, so

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

dblaikie added a comment. In D111521#3584439 , @alok wrote: > Re-based and updated to include one negative testcase. > I could not find a test for VarDecl with DynamicInitKind::NoStub. There are > constructors for other DynamicInitKind but not for NoStub

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

lei added a comment. Please document all new functions added. Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); amyk wrote: > Can we

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); amyk wrote: > Can we add some brief documentation fo

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl added a comment. In D127798#3585025 , @tyb0807 wrote: > The patch looks correct to me, but looking at > https://github.com/ARM-software/acle/blob/main/main/acle.md where all the > ACLE macros are defined, I'm not sure that `__ARM_FEATURE_RCPC`

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 437249. srishti-pm marked 20 inline comments as done. srishti-pm added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: mli

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. Addressed most of the comments. A few remaining. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 ___ cfe-commits mailing list cfe-co

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 437248. ahatanak added a comment. Stop wrapping a `GCCAsmStmt` with an `ExprWithCleanups`. Instead, just pop the cleanups after the asm statement to destruct the temporaries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D127883: [clang][deps] Further canonicalize implicit modules options in dep scan

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disable or canonicalize compiler options that are not relevant

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:7715 +bool Sema::areAnyVectorTypesAltivec(QualType SrcTy, QualType DestTy) { + assert(DestTy->isVectorType() || SrcTy->isVectorType()); lei wrote: > maryammo wrote: > > amyk wrote: > > > C

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak added a comment. I've removed the call to `ActOnFinishFullStmt` in `CoroutineStmtBuilder::makeOnFallthrough` too. `BuildCoreturnStmt` calls `ActOnFinishFullExpr`, so I don't think it's necessary to call `ActOnFinishFullStmt` after that. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks updated this revision to Diff 437258. aeubanks added a comment. update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127876/new/ https://reviews.llvm.org/D127876 Files: clang/docs/LTOVisibility.rst clang/lib/CodeGen/CGClass.cpp

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

aeubanks added a comment. > We documented the feature in D75655 and > there it says "all classes" (and still does). I've updated the documentation. It was already slightly inaccurate in that we weren't emitting type test/assumes for `std`/`stdext` namespace cla

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437260. steplong added a comment. - Add documentation on difference btwn MSVC and Clang's implementation of pragma optimize Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

phosek created this revision. phosek added reviewers: abrachet, mcgrathr. Herald added a subscriber: mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fuchsia already uses libunwind, but it does so

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55ba0830e459: [Clang] Let the linker choose shared or static libunwind unless specified (authored by phosek). Repository: rG LLVM Github Monorepo

[clang] 55ba083 - [Clang] Let the linker choose shared or static libunwind unless specified

Author: Petr Hosek Date: 2022-06-15T18:22:13Z New Revision: 55ba0830e4591c9767bbd4530639976f1242a61a URL: https://github.com/llvm/llvm-project/commit/55ba0830e4591c9767bbd4530639976f1242a61a DIFF: https://github.com/llvm/llvm-project/commit/55ba0830e4591c9767bbd4530639976f1242a61a.diff LOG: [C

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks Jolanta! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126479/new/ https://reviews.llvm.org/D126479

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

jcranmer-intel added a comment. In D127579#3585553 , @bader wrote: > And in addition to that ISA defines types, which are not natively supported > by LLVM IR e.g. image. To represent those types clang in OpenCL language mode > emits a pointer to an opaq

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

xbolva00 added a comment. Thanks Comment at: clang/docs/LanguageExtensions.rst:3800 +``g``, ``t``, and ``y``. Clang's current implementation of the pragma behaves in +the same way as the clang pragma. All functions between ``off`` and ``on`` will +be decorated with the ``optno

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

MyDeveloperDay added a comment. what about (may not be useful but compiles) struct { int foo; } &&ptr2 = {}; https://godbolt.org/z/rbb8x3hKP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Thank you for the patch, just some observations Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:93 + EXPECT_EQ(Tokens.size(), 10u) << Tok

[PATCH] D127876: [clang] Don't emit type test/assume for virtual classes that should never participate in WPD

tejohnson added a comment. I prefer the way proposed here, which was what I initially intended to do in fact. @pcc, I recall from our early internal conversations about my proposal that you felt the new mechanism should apply to all classes, so that's why the final design did that. I do tend to

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

sbc100 created this revision. Herald added subscribers: pmatos, wingo, ecnelises, sunfish, jgravelle-google, dschuff. Herald added a project: All. sbc100 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Remove the `hasPrototype()` r

[PATCH] D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks

nicovank created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. nicovank added reviewers: alexfh, aaron.ballman, njames93. nicovank published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits.

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

beanz created this revision. beanz added reviewers: tstellar, aaron.ballman, MaskRay, hans. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added projects: clang, LLVM. Adding release note entries for LLVM & Clang to int

[PATCH] D127888: [clang][WebAssembly] Loosen restriction on `main` symbol mangling

sbc100 updated this revision to Diff 437272. sbc100 edited the summary of this revision. sbc100 added a comment. Herald added a subscriber: asb. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127888/new/ https://reviews.llvm.org/D127888 F

[PATCH] D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks

gribozavr2 added a comment. Could you provide more context? There seems to be plenty of ways to access the SourceManager from a ClangTidy check, for example, see `clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127886: [clang-tidy] Allow access to the SourceManager in clang-tidy checks

nicovank planned changes to this revision. nicovank added a comment. Thanks! Looks like `registerPPCallbacks` might be what I am looking for, I was not aware of it. I will mark this as planning changes temporarily, then abandon if solved. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 437276. srishti-pm added a comment. Increasing pattern benefit + minor typo correction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: mlir/include/mlir/

[PATCH] D127887: [CMake][Fuchsia] Use libunwind as the default unwinder

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127887/new/ https://reviews.llvm.org/D127887 ___

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3800 +``g``, ``t``, and ``y``. Clang's current implementation of the pragma behaves in +the same way as the clang pragma. All functions between ``off`` and ``on`` will +be decorated with the ``optnone`

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

steplong updated this revision to Diff 437280. steplong added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D127125: [clangd] Improve ObjC protocol suggestions from the index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1f24332af3: [clangd] Improve ObjC protocol suggestions from the index (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] bc1f243 - [clangd] Improve ObjC protocol suggestions from the index

Author: David Goldman Date: 2022-06-15T15:02:37-04:00 New Revision: bc1f24332af3dedccb84a975e57adca495ea016d URL: https://github.com/llvm/llvm-project/commit/bc1f24332af3dedccb84a975e57adca495ea016d DIFF: https://github.com/llvm/llvm-project/commit/bc1f24332af3dedccb84a975e57adca495ea016d.diff

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3586475 , @MyDeveloperDay wrote: > what about (may not be useful but compiles) > > struct { > int foo; > } &&ptr2 = {}; > > https://godbolt.org/z/rbb8x3hKP Let's ask why it was set to a binary

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

HazardyKnusperkeks added a comment. Could you please either directly link to the github issue or better use llvm.org/pr55810 than just #55810 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___

[clang] 61a649c - Update the status of more C DRs

Author: Aaron Ballman Date: 2022-06-15T15:25:47-04:00 New Revision: 61a649ca3556b24c88f5697660a850b7486ad691 URL: https://github.com/llvm/llvm-project/commit/61a649ca3556b24c88f5697660a850b7486ad691 DIFF: https://github.com/llvm/llvm-project/commit/61a649ca3556b24c88f5697660a850b7486ad691.diff

[PATCH] D127890: [Docs] Update clang & llvm release notes for HLSL

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for adding the release notes! LGTM aside from some minor nits (take em or leave em). Comment at: clang/docs/ReleaseNotes.rst:72 +- Clang is gaining supp

<    1   2   3   >