aaron.ballman added a comment. In D125723#3585788 <https://reviews.llvm.org/D125723#3585788>, @xbolva00 wrote:
> In D125723#3585726 <https://reviews.llvm.org/D125723#3585726>, @aaron.ballman > wrote: > >> LGTM! But given the number of people who've expressed opinions on this, >> please wait a day or two before landing in case other reviewers have >> additional feedback. > > In term of code, implementation ok, some concerns related to documentation > added. Good call! We could add documentation for this pragma to https://github.com/llvm/llvm-project/blob/main/clang/docs/LanguageExtensions.rst and document the differences there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
