[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:6463 Alias, AliasArgs<["no-invalid-source-encoding"]>; +def _SLASH_external_W0 : CLFlag<"external:W0">, HelpText<"Ignore

[clang] 9073b53 - [Clang,ARM] Add release note for D127197.

Author: Simon Tatham Date: 2022-06-10T15:19:33+01:00 New Revision: 9073b53e5d7f0bdc603a5c816300ac27644bc6a8 URL: https://github.com/llvm/llvm-project/commit/9073b53e5d7f0bdc603a5c816300ac27644bc6a8 DIFF: https://github.com/llvm/llvm-project/commit/9073b53e5d7f0bdc603a5c816300ac27644bc6a8.diff

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov updated this revision to Diff 435908. ilya-biryukov added a comment. - Do not introduce empty branches on asserts - Test whether specialization or primary template gets picked Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127487/new/

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

thieta requested changes to this revision. thieta added a comment. This revision now requires changes to proceed. Thanks for fixing - but it's not completely accurate right now. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for deb

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

ilya-biryukov added a comment. In D127487#3573180 , @erichkeane wrote: > I'm not quite understanding this yet, so I'll have to take another look early > next week. However, I AM intending to get https://reviews.llvm.org/D126907 > committed in the next

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

Kai created this revision. Kai added reviewers: uweigand, jnspaulsson, abhina.sreeskantharajan, yusra.syeda. Herald added a project: All. Kai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The DWARF version was raised to 5 for all

[PATCH] D127487: [Sema] Fix assertion failure when instantiating requires expression

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:352 + [this](const Expr *AtomicExpr) -> ExprResult { +// We only do this to immitate lvalue-to-rvalue conversion. +return PerformContextuallyConvertToBool(const_cast(AtomicExpr)); --

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

aaron.ballman added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake -DLLVM_EN

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

steplong updated this revision to Diff 435910. steplong added a comment. - Change helptext for /external:W0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 Files: clang/include/clang/Driver/Options.td

[PATCH] D127498: [SystemZ/z/OS] Set DWARF version to 4 for z/OS.

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127498/new/ https://reviews.llvm.org/D127498 _

[PATCH] D126859: [clangd] Validate clang-tidy CheckOptions in clangd config

njames93 planned changes to this revision. njames93 added a comment. Gonna wait for the infrastructure from D127446 to land first, can reuse most of that implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] d5daa5c - [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Author: John Ericson Date: 2022-06-10T14:35:18Z New Revision: d5daa5c5b091cafb9b7ffd19b5dfa2daadef3229 URL: https://github.com/llvm/llvm-project/commit/d5daa5c5b091cafb9b7ffd19b5dfa2daadef3229 DIFF: https://github.com/llvm/llvm-project/commit/d5daa5c5b091cafb9b7ffd19b5dfa2daadef3229.diff LOG:

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5daa5c5b091: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore (authored by Ericson2314). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435914. quinnp added a comment. Herald added a subscriber: ormris. Addressing review comments. Removing path without `/root/usr` prefix and changing unit test to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp added a comment. Thanks @tbaeder, @MaskRay, and @nemanjai. > I did not remove that on purpose, so adding it back makes sense to me. I've updated the patch to remove the path without the `/root/usr` suffix and exclusively add the path with the `root/usr` suffix. > This change also needs

[PATCH] D126960: [clang][sema] Unary not boolean to int conversion

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:12328 return IntRange::forValueOfType(C, GetExprType(E)); +case UO_Not: erichkeane wrote: > Richard mentions UO_PreInc, UO_PreDec, UO_Minus, and UO_Not. What about the

<    1   2   3