[PATCH] D123450: [clang-format] Parse Verilog if statements

2022-06-09 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 435777. sstwcw added a comment. - add brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123450/new/ https://reviews.llvm.org/D123450 Files: clang/docs/ClangFormat.rst clang/include/clang/Format/Format.h

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

2022-06-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 435779. junaire added a subscriber: Purva-Chaudhari. junaire added a comment. Merge D126684 into this patch. Consider D126684 is almost @Purva-Chaudhari 's work, I'll list her as co-author

[PATCH] D126684: [Interpreter] Implment Interpreter::Restore to clean up lookup table

2022-06-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire abandoned this revision. junaire added a comment. work moved to D126682 , so abandon this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126684/new/ https://reviews.llvm.org/D126684

[PATCH] D126934: [clang-format] NFC Sort names of format token types

2022-06-09 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126934/new/ https://reviews.llvm.org/D126934 _

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

2022-06-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 435781. junaire added a comment. Restore PTU in Interpreter::Undo, this should fix the broken tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clang/in

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

2022-06-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 435782. junaire added a comment. Allow undo command failed in the edge cases like undoed too many times. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126682/new/ https://reviews.llvm.org/D126682 Files: clan

[PATCH] D127471: [Coroutines] Convert coroutine.presplit to enum attr

2022-06-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: nikic, rjmccall, ezhulenev. Herald added subscribers: Peiming, bzcheeseman, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, jdoerfert, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

2022-06-09 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 435788. sstwcw added a comment. - add `kw_` prefix to symbols treated as keywords - use lambda instead of breaking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 File

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

2022-06-09 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/FormatToken.h:1142 +VerilogExtraKeywords = +std::unordered_set({kw_always, + kw_always_comb, Now that I ad

[PATCH] D126682: [Interpreter][ClangRepl] Implement undo command

2022-06-09 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180 DiagnosticsEngine &Diags = getCI()->getDiagnostics(); if (Diags.hasErrorOccurred()) { TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl(); We sho

[clang] 0ecbedc - Also move WeakRefReferences in CodeGenModule::moveLazyEmssionStates

2022-06-09 Thread Jun Zhang via cfe-commits
Author: Jun Zhang Date: 2022-06-10T13:11:09+08:00 New Revision: 0ecbedc0986bd4b7b90a60a5f31d32337160d4c4 URL: https://github.com/llvm/llvm-project/commit/0ecbedc0986bd4b7b90a60a5f31d32337160d4c4 DIFF: https://github.com/llvm/llvm-project/commit/0ecbedc0986bd4b7b90a60a5f31d32337160d4c4.diff LOG

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

2022-06-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.h:1500 + +assert(WeakRefReferences.empty() && + "Not all WeakRefRefs have been applied"); v.g.vassilev wrote: > It seems that we forgot to move the `WeakRefReferences`? Thank

[clang] e9f2d47 - [clang-format][NFC] Remove unused FormatStyle members

2022-06-09 Thread via cfe-commits
Author: owenca Date: 2022-06-09T22:34:31-07:00 New Revision: e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad URL: https://github.com/llvm/llvm-project/commit/e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad DIFF: https://github.com/llvm/llvm-project/commit/e9f2d47bfe29c31c7a1b43a2cc503ed9cdc0fbad.diff LOG: [

[PATCH] D127390: [clang-format][NFC] Remove unused FormatStyle members

2022-06-09 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9f2d47bfe29: [clang-format][NFC] Remove unused FormatStyle members (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127390/new/ https:/

[clang-tools-extra] b831786 - [clang-tidy][NFC] Tweak identifier-naming options reading/writiing

2022-06-09 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2022-06-10T07:07:21+01:00 New Revision: b8317862921d8ef5f54804f2d8d5b5af92c530d3 URL: https://github.com/llvm/llvm-project/commit/b8317862921d8ef5f54804f2d8d5b5af92c530d3 DIFF: https://github.com/llvm/llvm-project/commit/b8317862921d8ef5f54804f2d8d5b5af92c530d3.diff

[PATCH] D127446: [clang-tidy] Add `-verify-config` command line argument

2022-06-09 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. This sounds like great functionality, surely saving a lot of headaches! Any reason why we wouldn't want this active by default? I'd personally even go one step further and make it hard errors - warnings are easy to miss and ignore - but I can see how it can be pro

[PATCH] D127409: Fix GCC intrinsics "round_mask" names

2022-06-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei requested changes to this revision. pengfei added a comment. This revision now requires changes to proceed. We had a discussion about the builtins between GCC and Clang on D109658 last year. We tried to make sure the same builtins have the same argument

<    1   2   3