v.g.vassilev added inline comments.
================
Comment at: clang/lib/Interpreter/IncrementalParser.cpp:180
DiagnosticsEngine &Diags = getCI()->getDiagnostics();
if (Diags.hasErrorOccurred()) {
TranslationUnitDecl *MostRecentTU = C.getTranslationUnitDecl();
----------------
We should call Restore here.
================
Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:251
+TEST(InterpreterTest, UndoBasic) {
+ Args ExtraArgs = {"-Xclang", "-diagnostic-log-file", "-Xclang", "-"};
----------------
Can we move this as a regular test called code-undo.cpp?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126682/new/
https://reviews.llvm.org/D126682
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
