[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

owenpan updated this revision to Diff 435181. owenpan added a comment. Update `IfLeftBrace` in `parseLevel()` only if the level is a simple block. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127260/new/ https://reviews.llvm.org/D127260 Files: clang/lib/Format/UnwrappedLineParser.cp

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

aaron.ballman added a comment. In D126832#3554816 , @cjdb wrote: > In D126832#3553569 , @aaron.ballman > wrote: > >> Can you post some examples of the output from this option so we can see what >> the end result

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: clang/test/Sema/large-bit-int.c:1 +// RUN: %clang_cc1 -fexperimental-max-bitint-width=1024 -fsyntax-only -verify %s -Wno-unused -t

[PATCH] D127207: [flang][driver] Fix support for `-x`

ekieri added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) awarzynski wrote: > rovk

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim marked 5 inline comments as done. hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:397 + // GV's mentioned in -fsanitize-ignorelist=. + kw_no_sanitize, + // GV's with __attribute__((no_sanitize("address"))). vitalybuka wrote

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 435219. hctim marked 5 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/include/llvm/AsmParser/LLPa

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 435223. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/print-diagnostic-opti

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added inline comments. Comment at: clang/include/clang/Driver/Options.td:829 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones ide

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

browneee updated this revision to Diff 435224. browneee marked an inline comment as done. browneee added a comment. Added release notes and fixed variable naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126944/new/ https://reviews.llvm.org/D1

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

erichkeane accepted this revision. erichkeane added a comment. LGTM! Thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126944/new/ https://reviews.llvm.org/D126944 ___ cfe-commits mailing l

[clang] c7689fd - [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

Author: Andrew Browne Date: 2022-06-08T09:58:25-07:00 New Revision: c7689fd552cdf2b37e804a59322bd0661ccdd3c5 URL: https://github.com/llvm/llvm-project/commit/c7689fd552cdf2b37e804a59322bd0661ccdd3c5 DIFF: https://github.com/llvm/llvm-project/commit/c7689fd552cdf2b37e804a59322bd0661ccdd3c5.diff

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7689fd552cd: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node. (authored by browneee). Repository: rG LLVM Github Monorep

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 435230. philnik added a comment. Fix Patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Papers.csv

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Basic/DiagnosticIDs.cpp:656 std::vector DiagnosticIDs::getDiagnosticFlags() { - std::vector Res; + std::vector Res{"-W", "-Wno-"}

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

rjmccall added a comment. In D126781#3565173 , @junaire wrote: > I believe that `OldBuilder` is always valid in the normal cases, so > remove the if condition and replace it with an assertion. Is `StartModule` not called for the first time we start emitt

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

benlangmuir updated this revision to Diff 435237. benlangmuir added a comment. Removed use of std::unique_ptr in DependencyScanningTool.cpp, per review feedback. @jansvoboda11 Note: there is another map containing `std::unique_ptr` in `ModuleDepCollector`, but that one is required for correct

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp updated this revision to Diff 435239. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https://reviews.llvm.org/D127310 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Thanks for explaining this, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127243/new/ https://reviews.llvm.org/D127243 __

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp marked 2 inline comments as done. quinnp added a comment. Thank you @nemanjai! I've updated the patch based on your suggestion and tested it for both the existing testcase and the RHEL buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.h:35 +TransformPointersAsValues( +Options.get("TransformPointersAsValues", false)) {} + JonasToth wrote: > njames93 wrote: > > It may be worth

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-pro-type-member-init.cpp:558 + S1() {} + // CHECK-MESSAGES-NOT: warning: + union { This line is redundant and likely to cause unintended test failures, sa

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:338 +// always true for a driver invocation. +bool DisableFree = true; DependencyScanningActi

[clang] aff679a - [WebAssembly] Implement remaining relaxed SIMD instructions

Author: Thomas Lively Date: 2022-06-08T10:32:10-07:00 New Revision: aff679a48c438924c4fca4e9eaa38f91c022ffe3 URL: https://github.com/llvm/llvm-project/commit/aff679a48c438924c4fca4e9eaa38f91c022ffe3 DIFF: https://github.com/llvm/llvm-project/commit/aff679a48c438924c4fca4e9eaa38f91c022ffe3.diff

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

This revision was automatically updated to reflect the committed changes. Closed by commit rGaff679a48c43: [WebAssembly] Implement remaining relaxed SIMD instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127170/new/ h

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

rjmccall added a comment. This seems like the right idea to me, yeah. It doesn't look like the patch handles `volatile _Atomic` correctly, though. I know we do a lot of candidate prefiltering, and that that can be difficult because of uesr-defined conversions. How do those things interact wit

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:338 +// always true for a driver invocation. +

[clang] 28aa7d1 - [docs][clang] Minor typo fix

Author: Jose Manuel Monsalve Diaz Date: 2022-06-08T17:41:04Z New Revision: 28aa7d188492223eb600317239f97b3f76dff1ee URL: https://github.com/llvm/llvm-project/commit/28aa7d188492223eb600317239f97b3f76dff1ee DIFF: https://github.com/llvm/llvm-project/commit/28aa7d188492223eb600317239f97b3f76dff1e

[PATCH] D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:53 +static bool indirectionEquivalentValues(Value *Val1, Value *Val2) { + if (auto *IndVal1 = dyn_cast(Val1)) { WDYT about "areEquivalentIndirectionValues"?

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:28 /// Base class for all values computed by abstract interpretation. +/// Don't use `Value` instances by value. All `Value` instances are alloca

[clang] 288c1bf - [clang][driver] adds `-print-diagnostics`

Author: Christopher Di Bella Date: 2022-06-08T17:55:31Z New Revision: 288c1bff96fc9042d01b7055dc6e1049d8b54b26 URL: https://github.com/llvm/llvm-project/commit/288c1bff96fc9042d01b7055dc6e1049d8b54b26 DIFF: https://github.com/llvm/llvm-project/commit/288c1bff96fc9042d01b7055dc6e1049d8b54b26.dif

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG288c1bff96fc: [clang][driver] adds `-print-diagnostics` (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/D126796?vs=435223&id

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

MaskRay added a comment. Do you have more authoritative answer when /root/usr is used and when it isn't? I'd wish that we have comments for them. This change also needs a unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127310/new/ https:/

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Still looks good. Was there a particular case where the previous version didn't work? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127260/new/ https://reviews.llvm.org/D127260

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb updated this revision to Diff 435255. cjdb marked 2 inline comments as done. cjdb added a comment. applies feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126832/new/ https://reviews.llvm.org/D126832 Files: clang/include/clang/Basic/

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim marked 3 inline comments as done. hctim added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2767-2781 + if (NoSanitizeL.containsGlobal(LangOpts.Sanitize.Mask, GV->getName(), Category)) return true; - if (NoSanitizeL.containsLocation(EnabledAsanMas

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 435257. hctim marked 3 inline comments as done. hctim added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/SanitizerMetad

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb added a comment. In D126832#3567035 , @aaron.ballman wrote: > In D126832#3554816 , @cjdb wrote: > >> In D126832#3553569 , >> @aaron.ballman wrote: >> >>> Can you po

[clang] 7a72dca - [clang][deps] Set -disable-free for module compilations

Author: Ben Langmuir Date: 2022-06-08T11:09:17-07:00 New Revision: 7a72dca74a27f1f6198cfabb064dc43274ee005d URL: https://github.com/llvm/llvm-project/commit/7a72dca74a27f1f6198cfabb064dc43274ee005d DIFF: https://github.com/llvm/llvm-project/commit/7a72dca74a27f1f6198cfabb064dc43274ee005d.diff

[clang] 835fcf2 - [clang][deps] Make order of module dependencies deterministic

Author: Ben Langmuir Date: 2022-06-08T11:09:17-07:00 New Revision: 835fcf2aa5127bf99a1e6397c72153f00a0497b2 URL: https://github.com/llvm/llvm-project/commit/835fcf2aa5127bf99a1e6397c72153f00a0497b2 DIFF: https://github.com/llvm/llvm-project/commit/835fcf2aa5127bf99a1e6397c72153f00a0497b2.diff

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a72dca74a27: [clang][deps] Set -disable-free for module compilations (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG835fcf2aa512: [clang][deps] Make order of module dependencies deterministic (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong updated this revision to Diff 435264. steplong added a comment. Herald added a subscriber: jdoerfert. - Fix up docs and comments - Fix failing pragma-attribute-supported-attributes-list.test - Remove debug print - Change to StringMap Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 49ed5bf - [clang][dataflow] Enable use of synthetic properties on all Value instances.

Author: Wei Yi Tee Date: 2022-06-08T20:20:26+02:00 New Revision: 49ed5bf51958aaeb209804da794c85d06207c3ed URL: https://github.com/llvm/llvm-project/commit/49ed5bf51958aaeb209804da794c85d06207c3ed DIFF: https://github.com/llvm/llvm-project/commit/49ed5bf51958aaeb209804da794c85d06207c3ed.diff LO

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

This revision was automatically updated to reflect the committed changes. Closed by commit rG49ed5bf51958: [clang][dataflow] Enable use of synthetic properties on all Value instances. (authored by wyt, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D127196?vs=435121&

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. In D126864#3564519 , @efriedma wrote: > Do we want some builtin define so headers can check if we're in > -fstrict-flex-arrays mode? It might be hard to mess with the definitions > otherwise. Hm, maybe? It wonder if that's more c

[PATCH] D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

wyt updated this revision to Diff 435271. wyt marked 2 inline comments as done. wyt added a comment. Rename function as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127312/new/ https://reviews.llvm.org/D127312 Files: clang/include/cla

[PATCH] D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

wyt added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:63 -auto *IndVal2 = cast(Val2); -assert(IndVal1->getKind() == IndVal2->getKind()); -if (&IndVal1->getPointeeLoc() == &IndVal2->getPointeeLoc()) gribozavr2

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

nickdesaulniers added a comment. In D126864#3564519 , @efriedma wrote: >> As for SOCK_MAXADDRLEN, that's a horrid hack, and the definition of struct >> sockaddr needs to change. :) > > Do we want some builtin define so headers can check if we're in > -f

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. In D126864#3567647 , @nickdesaulniers wrote: > @kees maybe we should think about what would be needed for toolchains that > don't yet support `-fstrict-flex-arrays` in kernel sources? Does this become > a toolchain portability iss

[PATCH] D112661: [clangd] reuse preambles from other files when possible

qchateau added a comment. @nridge after rebasing this change for several months, I find it less and less useful. It seems both clangd and the IDE I'm using are making significant improvements that make this changes less and less impactful. I closed this revision as I feel that it now passed the

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

kamaub added a comment. In D125499#3541689 , @tstellar wrote: > I'm curious what is your system configuration where this patch actually > allows for detection of devtoolset? I noticed that if clang and gcc are both > installed to /usr/, then driver wil

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. Two final (I hope) nits! One is in the code, the other is that this should have a release note for the new attribute. Assuming precommit CI pipeline passes, then I think this is all set. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4860 + if (It

[PATCH] D127217: [include-cleaner] Fix build error in unit test

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127217/new/ https://reviews.llvm.org/D127217

[PATCH] D112579: Allow non-variadic functions to be attributed with `__attribute__((format))`

fcloutier updated this revision to Diff 435302. fcloutier added a comment. Herald added a project: All. Apologies the long delay: things happened and I was pulled away. I have some time to finish this change now. I recommend re-reading the discussion up to now since it's not _that_ long and it p

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

bruno created this revision. bruno added reviewers: vsk, zequanwu. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D83592 ad

[clang] b685426 - Add missing entries for Annex F and Annex H to the C status page

Author: Aaron Ballman Date: 2022-06-08T15:53:54-04:00 New Revision: b685426970df3b12ac3640110e43db2ee3f340c6 URL: https://github.com/llvm/llvm-project/commit/b685426970df3b12ac3640110e43db2ee3f340c6 DIFF: https://github.com/llvm/llvm-project/commit/b685426970df3b12ac3640110e43db2ee3f340c6.diff

[clang] f0a6a57 - Switch links to use https consistently

Author: Aaron Ballman Date: 2022-06-08T15:53:55-04:00 New Revision: f0a6a573309b1807de057f032a6db5e8d4a3c10d URL: https://github.com/llvm/llvm-project/commit/f0a6a573309b1807de057f032a6db5e8d4a3c10d DIFF: https://github.com/llvm/llvm-project/commit/f0a6a573309b1807de057f032a6db5e8d4a3c10d.diff

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. In D126929#3567491 , @hctim wrote: > Update. Sorry if it want clear that I some changes. You undone my snapshot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein updated this revision to Diff 435309. hokein marked an inline comment as done. hokein added a comment. switch to the previous simple version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125677/new/ https://reviews.llvm.org/D125677 Files:

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params, [&](const GSS::Node *NewHead) { --

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1389 + + if (GV.hasSanitizerMetadata()) +Vals.push_back(serializeSanitizerMetadata(GV.getSaniti

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added a comment. No need to recover my snapshot, I'll just comment here. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:20 +using GlobalVariable = llvm::GlobalVariable; +using GVSanitizerMetadata = GlobalVariable::SanitizerMetadata; Seems inco

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong updated this revision to Diff 435313. steplong added a comment. - Add Arg when creating Attr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126984/new/ https://reviews.llvm.org/D126984 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:55 + + bool IsExcluded = CGM.isInNoSanitizeList(GV, Loc, Ty); + IsExcluded |= (NoSanitizeMask == SanitizerKind::All); vitalybuka wrote: > it can be in some weird ubsan check i

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338 __

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

zequanwu added a comment. Just noticed that 3 test cases failed. Please fix them before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338 ___ cfe-commits

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

bruno added a comment. > Just noticed that 3 test cases failed. Please fix them before landing. Sure thing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338 ___

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

rsmith added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:242-246 +Decl = ParseDeclaration(DeclaratorContext::Block, DeclEnd, CXX11Attrs, +GNUAttrs, &GNUAttributeLoc); } else { -Decl = ParseDeclaration(Declarato

[clang-tools-extra] dd2f290 - Add llvm's Support lib to the psuedoCXX library

Author: Nathan Lanza Date: 2022-06-08T17:12:02-04:00 New Revision: dd2f2909188bf56716248675c58e4699c1c6b903 URL: https://github.com/llvm/llvm-project/commit/dd2f2909188bf56716248675c58e4699c1c6b903 DIFF: https://github.com/llvm/llvm-project/commit/dd2f2909188bf56716248675c58e4699c1c6b903.diff

[PATCH] D127269: Add llvm's Support lib to the psuedoCXX library

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd2f2909188b: Add llvm's Support lib to the psuedoCXX library (authored by lanza). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127269/new/ https://reviews

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added a comment. In D126984#3567822 , @aaron.ballman wrote: > Two final (I hope) nits! One is in the code, the other is that this should > have a release note for the new attribute. Assuming precommit CI pipeline > passes, then I think this is

[PATCH] D126536: [pseudo] Add grammar annotations support.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:91 +// attribute value (all attributes share a namespace). +// An ExtensionID is the index into

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:86 + const ForestNode *Result = nullptr; + StateID AcceptState = Params.Table.getGoToState(StartState, StartSymbol); + glrReduce(PendingReduce, Params, [&](const

[clang-tools-extra] 93bcff8 - [pseudo] Invert rows/columns of LRTable storage for speedup. NFC

Author: Sam McCall Date: 2022-06-08T23:35:14+02:00 New Revision: 93bcff8aa85512f2b24e822d857b426c31b6d051 URL: https://github.com/llvm/llvm-project/commit/93bcff8aa85512f2b24e822d857b426c31b6d051 DIFF: https://github.com/llvm/llvm-project/commit/93bcff8aa85512f2b24e822d857b426c31b6d051.diff LO

[PATCH] D127006: [pseudo] Invert rows/columns of LRTable storage for speedup. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93bcff8aa855: [pseudo] Invert rows/columns of LRTable storage for speedup. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANG

[clang-tools-extra] bbc58c5 - [pseudo] Restore accidentally removed debug print

Author: Sam McCall Date: 2022-06-08T23:39:34+02:00 New Revision: bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f URL: https://github.com/llvm/llvm-project/commit/bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f DIFF: https://github.com/llvm/llvm-project/commit/bbc58c5e9ba39b234b6f526b313bbc35cbc2ba0f.diff LO

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:78 +// We need to copy the list: Roots is consumed by the GC. +Roots = NewHeads; +GSS.gc(std::move(Roots)); hokein wrote: > nit: I'd rather pass the NewHeads as a vector

[clang-tools-extra] 94b2ca1 - [pseudo] GC GSS nodes, reuse them with a freelist

Author: Sam McCall Date: 2022-06-08T23:39:59+02:00 New Revision: 94b2ca18c10bfb4107a850d63148fc51e65d9512 URL: https://github.com/llvm/llvm-project/commit/94b2ca18c10bfb4107a850d63148fc51e65d9512 DIFF: https://github.com/llvm/llvm-project/commit/94b2ca18c10bfb4107a850d63148fc51e65d9512.diff LO

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94b2ca18c10b: [pseudo] GC GSS nodes, reuse them with a freelist (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks

jmciver added a comment. This patch is associated to: https://github.com/llvm/llvm-project/issues/55935 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127271/new/ https://reviews.llvm.org/D127271 ___ cfe-

[PATCH] D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127271/new/ https://reviews.llvm.org/D127271 __

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

owenpan added a comment. In D127260#3567476 , @curdeius wrote: > Still looks good. Was there a particular case where the previous version > didn't work? The assertion I added on line 2626, which would ensure that the `RemoveBraces` lambda on line 898 d

[PATCH] D127271: [pseudo] Fix link time undefined reference to llvm::EnableABIBreakingChecks

jmciver added a comment. Thanks @sammccall for taking the time to review! Can you please commit on my behalf? Name: `John McIver` Email: `john.mciver@gmail.com` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127271/new/ https://reviews.llvm.o

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a comment. I don't expect this change to affect the compiler behavior by itself -- is there a particular test that should be written? The code that I'm moving into NVPTXTargetInfo::setAuxTarget is already tested via clang/test/Preprocessor/cuda-types.cu. Aside: There are only t

[PATCH] D127357: [pseudo] wip/prototype: use LR0 instead of SLR1 table

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. This ignores the lookahead token when deciding what to redu

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

rprichard added a comment. In D127267#3568388 , @rprichard wrote: > Aside: There are only two calls to AllocateTarget: one in > TargetInfo::CreateTargetInfo and one in NVPTXTargetInfo::NVPTXTargetInfo. > This change removes NVPTXTargetInfo's call. Ther

[PATCH] D127361: [NFC] clang: add test for PR55886

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127361 Files: clang/

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2769 - if (Style.isCSharp()) { do { owenpan wrote: > curdeius wrote: > > owenpan wrote: > > > From > > > https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-si

[clang] 5ead1f1 - [clang-format] Remove braces of else blocks that embody an if block

Author: owenca Date: 2022-06-08T16:05:20-07:00 New Revision: 5ead1f13a2d8ca33e9e93c06acee941a857905c6 URL: https://github.com/llvm/llvm-project/commit/5ead1f13a2d8ca33e9e93c06acee941a857905c6 DIFF: https://github.com/llvm/llvm-project/commit/5ead1f13a2d8ca33e9e93c06acee941a857905c6.diff LOG: [

[PATCH] D127260: [clang-format] Remove braces of else blocks that embody an if block

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ead1f13a2d8: [clang-format] Remove braces of else blocks that embody an if block (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127260

[PATCH] D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:63 -auto *IndVal2 = cast(Val2); -assert(IndVal1->getKind() == IndVal2->getKind()); -

[clang] cfda534 - [NFC] clang: add test for PR55886

Author: Matheus Izvekov Date: 2022-06-09T01:20:58+02:00 New Revision: cfda534b9944571bf55f0b275982d578361ab7d7 URL: https://github.com/llvm/llvm-project/commit/cfda534b9944571bf55f0b275982d578361ab7d7 DIFF: https://github.com/llvm/llvm-project/commit/cfda534b9944571bf55f0b275982d578361ab7d7.dif

[PATCH] D127361: [NFC] clang: add test for PR55886

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfda534b9944: [NFC] clang: add test for PR55886 (authored by mizve

[clang] a1b2b7d - [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

Author: Wei Yi Tee Date: 2022-06-09T01:29:16+02:00 New Revision: a1b2b7d9790b8a150d798fcc672387607986dbe0 URL: https://github.com/llvm/llvm-project/commit/a1b2b7d9790b8a150d798fcc672387607986dbe0 DIFF: https://github.com/llvm/llvm-project/commit/a1b2b7d9790b8a150d798fcc672387607986dbe0.diff LO

[PATCH] D127312: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into PointerValue and ReferenceValue

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1b2b7d9790b: [clang][dataflow] Remove IndirectionValue class, moving PointeeLoc field into… (authored by wyt, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] d6f6cd5 - [docs][clang] Fixing minor typo

Author: Jose Manuel Monsalve Diaz Date: 2022-06-08T23:35:11Z New Revision: d6f6cd5cd52bbfe91444226ef8a9687288d939b1 URL: https://github.com/llvm/llvm-project/commit/d6f6cd5cd52bbfe91444226ef8a9687288d939b1 DIFF: https://github.com/llvm/llvm-project/commit/d6f6cd5cd52bbfe91444226ef8a9687288d939b

[PATCH] D127363: [Lex] Fix for char32_t literal truncation on 16 bit architectures

SebastianPerta created this revision. SebastianPerta added reviewers: aaron.ballman, sammccall, DaanDeMeyer. Herald added a subscriber: dylanmckay. Herald added a project: All. SebastianPerta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D127338: [Clang][CoverageMapping] Fix compile time explosions by adjusting only appropriated skipped ranges

bruno updated this revision to Diff 435388. bruno added a comment. Empty lines handling should also make it skipped, fix the 3 failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127338/new/ https://reviews.llvm.org/D127338 Files: clang/lib/

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov added a comment. @rsmith , I have marked the few spots where the change is meaningful. Comment at: clang/include/clang/Sema/Template.h:488-497 +bool EarlySubstitution; + public: TemplateDeclInstantiator(Sema &SemaRef, DeclContext *Owner, -

<    1   2   3   >