[PATCH] D126891: [clang-tidy] The check should ignore final classes

steakhal updated this revision to Diff 435054. steakhal marked an inline comment as done. steakhal added a comment. - rebase - use double-backticks for the keyword `final` in the Release Notes. polite ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal added a comment. I believe, the silence from the code owner means that he agrees with this change. I'll land it tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

steakhal added a comment. Submitted a backport request to land this in `clang-14.0.5`, since many `llvm` devs might be affected by this crash due to `clangd` and `clang-tidy` integration. https://github.com/llvm/llvm-project/issues/55937 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127269: Add llvm's Support lib to the psuedoCXX library

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127269/new/ https://reviews.llvm.org/D127269

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just a couple points but not essential. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.cpp:184-187 + if (ScopesCache.find(LocalScope) == Scope

[PATCH] D127224: [flang][OpenMP] Lowering support for atomic capture

NimishMishra updated this revision to Diff 435060. NimishMishra added a comment. Herald added subscribers: cfe-commits, llvm-commits, libc-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jsji, Enna1, kosarev, mravishankar, jsilvanus, mattd, gchakrabarti, hsmhsm, pmatos, asb, p

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. In D126694#3565417 , @ChuanqiXu wrote: > In D126694#3564629 , @iains wrote: > >> the first failure is like this: >> >> x-h.h: >> struct A { >> friend int operator+(const A &lhs, cons

[PATCH] D127229: [clang][deps] Set -disable-free for module compilations

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:338 +// always true for a driver invocation. +bool DisableFree = true; DependencyScanningAct

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:181 std::vector PrebuiltModuleDeps; -std::map ClangModuleDeps; +llvm::MapVector, +llvm::StringMap> What's the reason f

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG20ca739701d7: [doc] Add release notes about SEH unwind information on ARM (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127150/new/

[clang] 20ca739 - [doc] Add release notes about SEH unwind information on ARM

Author: Martin Storsjö Date: 2022-06-08T11:32:17+03:00 New Revision: 20ca739701d7b2e2aa4028f1a7853f6d0fa0c412 URL: https://github.com/llvm/llvm-project/commit/20ca739701d7b2e2aa4028f1a7853f6d0fa0c412 DIFF: https://github.com/llvm/llvm-project/commit/20ca739701d7b2e2aa4028f1a7853f6d0fa0c412.diff

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

steakhal added a comment. New assertion failure: llvm-project/clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:72: bool isLeftShiftResultUnrepresentable(const clang::BinaryOperator *, clang::ento::CheckerContext &): Assertion `LHS && RHS && "Values unknown, inconsistent state"' faile

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong added a comment. In D126215#3565572 , @steakhal wrote: > I believe, the silence from the code owner means that he agrees with this > change. > I'll land it tomorrow. I believe there is a misconception about the role of a code owner, we cannot e

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:616 +setOperationAction(ISD::FROUNDEVEN, MVT::f16, Promote); +setOperationAction(ISD::FP_ROUND, MVT::f16, Expand); +setOperationAction(ISD::FP_EXTEND, MVT::f32, Expand); -

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

martong added a comment. Thanks for the report. I am looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 435081. balazske marked 5 inline comments as done. balazske added a comment. applied review comments, test improvement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122150/new/ https://reviews.llvm.org/D122150

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 435082. balazske added a comment. small test change, removed a compile warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/StaticAnalyzer/Chec

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All. balazske requested revie

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:558 + InAlpha, + Hide>, // ?? + ]>, steakhal wrote: > I think we have 'Hidden', but not 'Hide'. > It means that it is a modeling

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

curdeius added a comment. @Eitot, do you need help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead added a comment. In D126461#3565305 , @khchen wrote: >> Store to null will be changed to unreachable, so all instructions after >> vleff intrinsic call will be deleted and it causes runtime errors. If >> destination to store is null, we won

[PATCH] D127283: [pseudo] Simplify the glrReduce implementation.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. glrReduce maintains two priority queues (one for bases, and the other for Seq

[PATCH] D127284: [WIP] [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, rjmccall, lhames, sgraenitz. Herald added a subscriber: StephenFan. Herald added a project: All. v.g.vassilev requested review of this revision. This patch teaches clang to parse statements on the global scope to allow: .

[PATCH] D127285: [analyzer] Fix assertion failure after getKnwonValue call

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. LGTM Schedule a measurement to see what changes. Let's hope it won't introduce more crashes. If everything checks out, it gets approved. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether t

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. Check the summary for typos. Try to mark named entities like `this`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://reviews.llvm.org/D127285 ___ cfe-commits m

[PATCH] D127207: [flang][driver] Fix support for `-x`

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. LGTM, thanks. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +

[clang] b3c0918 - [AST] Make header self-contained

Author: Benjamin Kramer Date: 2022-06-08T12:36:36+02:00 New Revision: b3c0918fb4809ebb681daaf1910e171b204b93ea URL: https://github.com/llvm/llvm-project/commit/b3c0918fb4809ebb681daaf1910e171b204b93ea DIFF: https://github.com/llvm/llvm-project/commit/b3c0918fb4809ebb681daaf1910e171b204b93ea.dif

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

mgehre-amd created this revision. mgehre-amd added a reviewer: aaron.ballman. Herald added a project: All. mgehre-amd requested review of this revision. Herald added a project: clang. This splits of the introduction of -fexperimental-max-bitint-width from https://reviews.llvm.org/D122234 because

[PATCH] D122234: [clang] Link libbitint for large division of _BitInt

mgehre-amd marked an inline comment as done. mgehre-amd added a comment. I split the introduction of -fexperimental-max-bitint-width into https://reviews.llvm.org/D127287 because there is still discussion about the bitint libraries in the backend PRs. Repository: rG LLVM Github Monorepo CHA

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: jkorous. jansvoboda11 added a comment. Jan has asked me to take over. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 ___ cfe-c

[PATCH] D127283: [pseudo] Simplify the glrReduce implementation.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Very nice! Not sure why I didn't see this before :-) Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:266 using Sequence = llvm::SmallVector; - KeyedQueue Sequences

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang marked an inline comment as done. tingwang added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:688 +updateAssociatedFunc(VFInitTermAssoc, LocalCXXGlobalInits, GetElem, Fn); +updateAssociatedFunc(FFDtorTermAssoc, LocalCXXGlobalInits, GetEle

[clang] bf21cda - Add the 2022 papers to the C status tracking page

Author: Aaron Ballman Date: 2022-06-08T07:42:39-04:00 New Revision: bf21cda7f260d2643ff7fa4e9520ba63114b59fc URL: https://github.com/llvm/llvm-project/commit/bf21cda7f260d2643ff7fa4e9520ba63114b59fc DIFF: https://github.com/llvm/llvm-project/commit/bf21cda7f260d2643ff7fa4e9520ba63114b59fc.diff

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein updated this revision to Diff 435103. hokein added a comment. pull out the logic of detecting acceptable state out of glrReduce callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125677/new/ https://reviews.llvm.org/D125677 Files: cl

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() << llvm::formatv("Accept: {0} accepted result:\n", - PendingAccept.size()); -

[PATCH] D125095: [Clang][AIX] Add .ref in frontend for AIX XCOFF to support `-bcdtors:csect` linker option

tingwang updated this revision to Diff 435107. tingwang added a comment. Herald added subscribers: llvm-commits, jdoerfert. Update according to comments: (1) Update docs (2) Use `addVarTermAssoc` (3) Remove redundant call to `updateAssociatedFunc(FFDtorTermAssoc...` (4) Remove unnecessary `llvm::a

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566034 , @steakhal wrote: > ... Try to mark named entities like `this`. Could you please elaborate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://r

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3498 +/// \endcode +bool AfterPlacementNew; /// If ``true``, put a space between operator overloading and opening Please sort after `AfterOver...` here and all

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

Sockke created this revision. Sockke added reviewers: aaron.ballman, MTC. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. Sockke requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 updated this revision to Diff 435108. jansvoboda11 added a comment. Herald added a project: clang. Add operators for atomic types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 Files: clan

[PATCH] D125349: [Sema] Fix crash for C11 atomic in gnu++ mode

jansvoboda11 added a comment. I tried the approach suggested by @ahatanak. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125349/new/ https://reviews.llvm.org/D125349 ___ cfe-commits mailing list cf

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee updated this revision to Diff 435113. nlee added a comment. Updated diff to pass clang-format test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125402/new/ https://reviews.llvm.org/D125402 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/Diagnos

[PATCH] D126944: [Clang] Fix memory leak due to TemplateArgumentListInfo used in AST node.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; I think it's reasonable to not have test coverage specific to the changes here (the existing test coverage already uncovered this issue). It might be worth mentioning that

[PATCH] D126937: Fix memleak in VarTemplateSpecializationDecl

aaron.ballman added a comment. In D126937#3555731 , @aaron.ballman wrote: > In D126937#3555243 , @browneee > wrote: > >> I was also looking into fixing this: https://reviews.llvm.org/D126944 >> >> I'm not yet su

[PATCH] D127207: [flang][driver] Fix support for `-x`

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:268 + // pre-processed inputs. +.Case("f95", Language::Fortran) +.Case("f95-cpp-input", Language::Fortran) rovka wrote: > ekier

[PATCH] D127207: [flang][driver] Fix support for `-x`

awarzynski updated this revision to Diff 435115. awarzynski added a comment. Remove redundant `CHECK` line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127207/new/ https://reviews.llvm.org/D127207 Files: clang/include/clang/Driver/Options.td

[clang] 98d4f06 - Correcting some links in the C status page

Author: Aaron Ballman Date: 2022-06-08T08:52:31-04:00 New Revision: 98d4f0651a7f90df161167362e2060e0b4de7969 URL: https://github.com/llvm/llvm-project/commit/98d4f0651a7f90df161167362e2060e0b4de7969 DIFF: https://github.com/llvm/llvm-project/commit/98d4f0651a7f90df161167362e2060e0b4de7969.diff

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435118. jhuber6 added a comment. There was a problem where the Triple and Arch data would be deallocated when the LTO pass took ownership of every single file. Add a UniqueStringSaver to make sure they are still accessible after linking. Repository: rG L

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. In D126907#3565491 , @ChuanqiXu wrote: > Oh, the diff part is small really. The change looks good to me and I've > tested it for libcxx. > > But it crashed at "clang/lib/Sema/SemaTemplateInstantiate.cpp:1852: > clang::QualTyp

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

wyt updated this revision to Diff 435121. wyt added a comment. Remove cast to StructValues since get/setProperty can be used directly on Values now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127196/new/ https://reviews.llvm.org/D127196 Files:

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

wyt marked 2 inline comments as done. wyt added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:29 /// Base class for all values computed by abstract interpretation. +/// All Value instances should be separately allocated and stored by pointer +//

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/ConstCorrectnessCheck.h:35 +TransformPointersAsValues( +Options.get("TransformPointersAsValues", false)) {} + njames93 wrote: > It may be worth adding some validati

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126779/new/ https://reviews.llvm.org/D126779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435122. jhuber6 added a comment. Add use of bitcode libraries so this works on AMD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127246/new/ https://reviews.llvm.org/D127246 Files: clang/tools/clang-linker-

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

aaron.ballman added a comment. Given that this is a hidden option we expect to remove... do we add a release note for it? I think we probably should (for user awareness in case more users are in the same situation as the original reporter), and that gives a place to document that we will be rem

[PATCH] D127246: [LinkerWrapper] Rework the linker wrapper and use owning binaries

jhuber6 updated this revision to Diff 435124. jhuber6 added a comment. Sorry for this noise. This is a pretty large change but shouldn't affect any functionality and passes all the tests I know of, so this should be good to land. Let me know if you have any objections to how I've structured this

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Note in the summary that this patch affects: - `mkdir`, `mkdirat` - `mknod`, `mknodat` > The checker modeled these functions with a >= 0 return value on success which > is incorrect. Tec

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal added a comment. In D127285#3566198 , @martong wrote: > In D127285#3566034 , @steakhal > wrote: > >> ... Try to mark named entities like `this`. > > Could you please elaborate? Oh sure. The `SimpleSValB

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added a comment. In D127285#3566397 , @steakhal wrote: > In D127285#3566198 , @martong wrote: > >> In D127285#3566034 , @steakhal >> wrote: >> >>> ... Try to mark

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

steakhal added a comment. Oh I forgot to submit my review. My bad. Please investigate why we have two double casts there. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082 + // FIXME support cast from non-integers. + // E.g (char)(double)(double x) -> (char)(dou

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added a comment. Pending D127279 before making sure that all `EmitTargetCodeForMemset` implementations are enforcing `AlwaysInline`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://rev

[PATCH] D127304: [LinkerWrapper] Embed OffloadBinaries for OpenMP offloading images

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, saiislam, JonChesterfield, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project:

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

aaron.ballman added a comment. I think this is getting close -- mostly just nits at this point. Comment at: clang/include/clang/Basic/AttrDocs.td:3463 +The ``optimize`` attribute, when attached to a function, indicates that the +function be compiled with a different optimizatio

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane marked 11 inline comments as done. erichkeane added inline comments. Comment at: clang/include/clang/Sema/Template.h:221-226 +ArgListsIterator begin() { return TemplateArgumentLists.rbegin(); } +ConstArgListsIterator begin() const { + return TemplateArgume

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal created this revision. steakhal added reviewers: NoQ, martong, ASDenysPetrov, balazske, Szelethus, gamesh411. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

khchen added a comment. IMO, if I'm an user, I would not expected intrinsic function will generate the condition code to impact the performance, maybe we need to raise a issue in rvv-intrinsic-doc. maybe another way is adding a note in intrinsic document to address that the vl could not be a n

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane updated this revision to Diff 435148. erichkeane marked 2 inline comments as done. erichkeane added a comment. All of the comments from @ChuanqiXu done, thank you so much! As far as the crash you're seeing: That is typically a 'depth mismatch' kinda thing. They sadly only show up whe

[PATCH] D124244: [analyzer] add StoreToImmutable and ModelConstQualifiedReturn checkers

steakhal added a comment. In D124244#3521728 , @steakhal wrote: > I found this report at `vim/src/term.c` (https://github.com/vim/vim.git at > `v8.2.1920`): > F23102904: image.png > > I'm not sure what the exact type

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:616 +setOperationAction(ISD::FROUNDEVEN, MVT::f16, Promote); +setOperationAction(ISD::FP_ROUND, MVT::f16, Expand); +setOperationAction(ISD::FP_EXTEND, MVT::f32, Expand); ---

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 435151. pengfei marked 3 inline comments as done. pengfei added a comment. Address Yuanke's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 Files:

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() << llvm::formatv("Accept: {0} accepted result:\n", -

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.h:29 + void check(const ast_matchers::MatchFinder::MatchResult &Result) override; +}; + Please add `isLanguageVersionSupported`. =

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

martong updated this revision to Diff 435152. martong added a comment. - Rebase to llvm/main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117229/new/ https://reviews.llvm.org/D117229 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka updated this revision to Diff 435150. rovka edited the summary of this revision. rovka added a comment. - Fixed test - Unconditionally added the subsystem arg - Incorporated the MinGW toolchain changes (Thanks again @mmuetzel, I'm adding you as co-author) @awarzynski I agree that the other

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

aaron.ballman added a comment. Thanks for this! Just some fairly minor nits from me. FWIW, the changes should also come with a release note so users know about the new command line option. Comment at: clang/include/clang/Driver/Options.td:829 def Xoffload_linker : JoinedAndSe

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong updated this revision to Diff 435154. martong marked an inline comment as done. martong added a comment. - Add one more sentence in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127285/new/ https://reviews.llvm.org/D127285 Fi

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether the SVal has only one possible + // (integer) value. If that is the case, the value is returned. Otherwise, + // returns NULL. + cons

[PATCH] D127285: [analyzer] Fix assertion failure after getKnownValue call

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:25-28 + // Query the constraint manager whether the SVal has only one possible + // (integer) value.

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

LuoYuanke added inline comments. Comment at: llvm/test/Analysis/CostModel/X86/fptoi_sat.ll:852 +; SSE2-NEXT: Cost Model: Found an estimated cost of 3 for instruction: %f16u1 = call i1 @llvm.fptoui.sat.i1.f16(half undef) +; SSE2-NEXT: Cost Model: Found an estimated cost of 5 fo

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 435157. pratlucas added a comment. Avoid scavenging extra register when accessing const pool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files: clang/include

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked an inline comment as done. pratlucas added inline comments. Comment at: llvm/test/CodeGen/Thumb/frame-access.ll:335 +; CHECK-FP-AAPCS: mov r1, r11 +; CHECK-FP-AAPCS: ldr r0, [r0, r1] +; CHECK: bl i efriedma wrote: > This sequence requires, in gen

[PATCH] D117229: [Analyzer] Produce SymbolCast for pointer to integer cast

steakhal added a comment. Looks correct to me. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:110-112 + SVal simplifySymbolCast(SymbolRef SE, QualType CastTy); + You don't need to have gap between these two. They belong in t

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

martong added a comment. > In theory, the engine should propagate taint in default eval call. If that > would be the case, we would still have this report. How complex would it be to add the taint propagation to the engine/evalCall? Do you see that feasible as a parent patch of this? Reposito

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

mgehre-amd updated this revision to Diff 435161. mgehre-amd marked 4 inline comments as done. mgehre-amd added a comment. Used Optional Added entry to release notes Modifed help text according to suggestion Added comment to LANGOPT that it will be removed in the future Repository: rG LLVM Gith

[PATCH] D127287: clang: Introduce -fexperimental-max-bitint-width

mgehre-amd added a comment. Thanks for the quick review! Comment at: clang/test/Sema/large-bit-int.c:1 +// RUN: %clang_cc1 -fexperimental-max-bitint-width=1024 -fsyntax-only -verify %s -Wno-unused -triple x86_64-gnu-linux + aaron.ballman wrote: > Thoughts on a

[PATCH] D127267: [NVPTX] Add setAuxTarget override rather than make a new TargetInfo

yaxunl added a comment. need a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127267/new/ https://reviews.llvm.org/D127267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

quinnp created this revision. Herald added a project: All. quinnp requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch correctly sets the devtoolset on RHEL. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[clang] 4f8668d - [clang] co_return cleanup

Author: Nathan Sidwell Date: 2022-06-08T08:08:42-07:00 New Revision: 4f8668d9f73a0dc234ebf9938bcf24061991e9ae URL: https://github.com/llvm/llvm-project/commit/4f8668d9f73a0dc234ebf9938bcf24061991e9ae DIFF: https://github.com/llvm/llvm-project/commit/4f8668d9f73a0dc234ebf9938bcf24061991e9ae.diff

[PATCH] D125542: [clang] co_return cleanup

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8668d9f73a: [clang] co_return cleanup (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D127310: [clang][driver] fix to correctly set devtoolset on RHEL

nemanjai added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2152 ChosenToolsetVersion = ToolsetVersion; -ChosenToolsetDir = "/opt/rh/" + ToolsetDir.str(); +ChosenToolsetDir = "/opt/rh/" + ToolsetDir.str() + "/root/usr"; } --

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

nemanjai added subscribers: quinnp, nemanjai. nemanjai added a comment. The original toolchain detection added `root/usr` to the paths which was certainly necessary on PowerPC. Since that suffix is removed in this patch, our Redhat buildbot is now broken (https://lab.llvm.org/buildbot/#/builder

[PATCH] D127312: [clang][dataflow] Move PointeeLoc field from IndirectionValue into PointerValue and ReferenceValue classes

wyt created this revision. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127312 Fi

[clang] 9d6d069 - Add a parameter to LoadFromASTFile that accepts a file system and defaults to the real file-system.

Author: Andy Soffer Date: 2022-06-08T15:37:52Z New Revision: 9d6d069f4e9a6dd6882aaf896f73f234b3dd7194 URL: https://github.com/llvm/llvm-project/commit/9d6d069f4e9a6dd6882aaf896f73f234b3dd7194 DIFF: https://github.com/llvm/llvm-project/commit/9d6d069f4e9a6dd6882aaf896f73f234b3dd7194.diff LOG: A

[PATCH] D126888: Add a parameter to LoadFromASTFile that accepts a file system and defaults to the real file-system.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d6d069f4e9a: Add a parameter to LoadFromASTFile that accepts a file system and defaults to… (authored by asoffer, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D127243: [clang][deps] Make order of module dependencies deterministic

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:181 std::vector PrebuiltModuleDeps; -std::map ClangModuleDeps; +llvm::MapVector, +llvm::StringMap> jansvoboda11 wrote:

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3566692 , @rovka wrote: > @mmuetzel are you going to upload it to Phab? I gave it a try on my machine > and I can't compile the runtime with it, but I'll try to fix it on my end and > we can continue the discussion i

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal added a comment. In D127306#3566761 , @martong wrote: >> In theory, the engine should propagate taint in default eval call. If that >> would be the case, we would still have this report. > > How complex would it be to add the taint propagation t

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

steakhal added a comment. This looks like a standalone patch. Feel free to rebase to `main` and land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127277/new/ https://reviews.llvm.org/D127277 ___ cfe

  1   2   3   >