benlangmuir added inline comments.
================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:181
std::vector<PrebuiltModuleDep> PrebuiltModuleDeps;
- std::map<std::string, ModuleDeps> ClangModuleDeps;
+ llvm::MapVector<std::string, std::unique_ptr<ModuleDeps>,
+ llvm::StringMap<unsigned>>
----------------
jansvoboda11 wrote:
> What's the reason for wrapping `ModuleDeps` in `unique_ptr`?
Oh hmm, my thinking was that DenseMap is optimized for small values, but I
guess in this setup the map only stores integers and the values are in a
vector. I'll change this to values, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127243/new/
https://reviews.llvm.org/D127243
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
