[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: Jim, dberris. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan, MaskRay. Herald added a project: clang. Repository:

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434706. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu updated this revision to Diff 434707. ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 Files: clang/include/clang/AST/DeclBase.h clang/includ

[PATCH] D127006: [pseudo] Invert rows/columns of LRTable storage for speedup. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. oh, this looks nice, and makes the code simplier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127006/new/ https://reviews.llvm.org/D127006 __

[PATCH] D126723: [pseudo] GC GSS nodes, reuse them with a freelist

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:78 +// We need to copy the list: Roots is consumed by the GC. +Roots = NewHeads; +GSS.gc(std::move(Roots)); -

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434709. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu marked 2 inline comments as done. ChuanqiXu added a comment. In D113545#3560940 , @iains wrote: > the test-suite changes could be made easier to read by using the file-split > stuff we've been using for recent changes (I guess this is an older

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

johannes accepted this revision. johannes added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/ASTDiff/ASTDiff.cpp:477 + } else if (String->isUTF16()) { +const auto *Chars = reinterpret_cast(Bytes); +if (!conve

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire updated this revision to Diff 434714. junaire added a comment. Try to address @rjmccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126781/new/ https://reviews.llvm.org/D126781 Files: clang/lib/CodeGen/CodeGenModule.h cla

[PATCH] D126781: [CodeGen] Keep track info of lazy-emitted symbols in ModuleBuilder

junaire added inline comments. Comment at: clang/lib/CodeGen/ModuleBuilder.cpp:163 for (auto &&Lib : CodeGenOpts.DependentLibraries) Builder->AddDependentLib(Lib); I left I may doing something wrong here, after invoking `Initialize` we set `Bui

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

PRESIDENT810 updated this revision to Diff 434717. PRESIDENT810 added a comment. Sorry! I'm a novice at LLVM and I just didn't realize that those types can be implicitly cast to ArrayRef ... I have changed those and it should be fine now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D127187: [C++20] [Modules] Implement AllAdditionalTUReachable

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, rsmith, clang-language-wg. ChuanqiXu added a project: clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. [modu

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. thanks for amending the test cases they are now much easier to read and maintain. This looks like a useful step forward, hopefully we can resolve any outstanding issue soon and get it landed. Did you try wider testing (e.g. with lldb and other parts of the toolchain?)

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. In D113545#3562658 , @iains wrote: > Did you try wider testing (e.g. with lldb and other parts of the toolchain?) Yeah, I tried some other testing including using modules slightly in SPEC2017 and some other C++ performance ben

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. ping :) @njames93 I added more `CHECK-FIXES` and `CHECK-FIXES-NOT` statements in the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list cfe

[PATCH] D127189: [clang][AIX] Add option to control quadword lock free atomics ABI on AIX

lkail created this revision. lkail added reviewers: hubert.reinterpretcast, cebowleratibm, xingxue, PowerPC. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. lkail requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: cla

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1947 + // DeclModule if it isn't (transitively) imported. + if (DeclModule->getTopLevelModule()->isModuleInterfaceUnit()) +return true; iains wrote: > ChuanqiXu wrote: > > iains wrot

[PATCH] D126991: [pseudo] Fix the member-specification grammar rule.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a6a17a4f9fd: [pseudo] Fix the member-specification grammar rule. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang-tools-extra] 0a6a17a - [pseudo] Fix the member-specification grammar rule.

Author: Haojian Wu Date: 2022-06-07T10:18:18+02:00 New Revision: 0a6a17a4f9fd7bb14ca263893922bb56ac0887e8 URL: https://github.com/llvm/llvm-project/commit/0a6a17a4f9fd7bb14ca263893922bb56ac0887e8 DIFF: https://github.com/llvm/llvm-project/commit/0a6a17a4f9fd7bb14ca263893922bb56ac0887e8.diff LO

[PATCH] D126992: [pseudo] Fix noptr-abstract-declarator rule.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG58b33bc8c48a: [pseudo] Fix noptr-abstract-declarator rule. (authored by hokein). Changed prior to commit:

[clang-tools-extra] 58b33bc - [pseudo] Fix noptr-abstract-declarator rule.

Author: Haojian Wu Date: 2022-06-07T10:22:23+02:00 New Revision: 58b33bc8c48ab1640e93bbad5d2c5b80504f67b5 URL: https://github.com/llvm/llvm-project/commit/58b33bc8c48ab1640e93bbad5d2c5b80504f67b5 DIFF: https://github.com/llvm/llvm-project/commit/58b33bc8c48ab1640e93bbad5d2c5b80504f67b5.diff LO

[PATCH] D126291: [flang][Driver] Update link job on windows

awarzynski added a comment. In D126291#3562542 , @mstorsjo wrote: > In D126291#3562471 , @mmuetzel > wrote: > >> Found why I thought building on Windows wasn't supported: >> https://github.com/llvm/llvm-project

[PATCH] D127190: [analyzer][NFC] Add LLVM_UNLIKELY to assumeDualImpl

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: All

[PATCH] D127190: [analyzer][NFC] Add LLVM_UNLIKELY to assumeDualImpl

martong added a comment. F23340695: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127190/new/ https://reviews.llvm.org/D127190 ___ cfe-commits mailing list

[clang-tools-extra] 90dab04 - [pseudo] Handle the language predefined identifier __func__

Author: Haojian Wu Date: 2022-06-07T10:34:37+02:00 New Revision: 90dab0473ef0141c3cdbacc9990f98db8c956f90 URL: https://github.com/llvm/llvm-project/commit/90dab0473ef0141c3cdbacc9990f98db8c956f90 DIFF: https://github.com/llvm/llvm-project/commit/90dab0473ef0141c3cdbacc9990f98db8c956f90.diff LO

[PATCH] D126996: [pseudo] Handle the language predefined identifier __func__

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90dab0473ef0: [pseudo] Handle the language predefined identifier __func__ (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] ecd7ff5 - [pseudo] Fix the type-parameter rule.

Author: Haojian Wu Date: 2022-06-07T10:36:45+02:00 New Revision: ecd7ff53b53368d84767ceeda6b238ef467b4625 URL: https://github.com/llvm/llvm-project/commit/ecd7ff53b53368d84767ceeda6b238ef467b4625 DIFF: https://github.com/llvm/llvm-project/commit/ecd7ff53b53368d84767ceeda6b238ef467b4625.diff LO

[PATCH] D126998: [pseudo] Fix the type-parameter rule.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGecd7ff53b533: [pseudo] Fix the type-parameter rule. (authored by hokein). Changed prior to commit: https:

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

hokein updated this revision to Diff 434733. hokein added a comment. pull out a separate test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125479/new/ https://reviews.llvm.org/D125479 Files: clang-tools-extra/pseudo/lib/cxx.bnf clang-to

[clang-tools-extra] cf88150 - [pseudo] Fix the incorrect parameters-and-qualifiers rule.

Author: Haojian Wu Date: 2022-06-07T10:47:07+02:00 New Revision: cf88150c48df4e779edb91a8facf838bea3bd1b7 URL: https://github.com/llvm/llvm-project/commit/cf88150c48df4e779edb91a8facf838bea3bd1b7 DIFF: https://github.com/llvm/llvm-project/commit/cf88150c48df4e779edb91a8facf838bea3bd1b7.diff LO

[PATCH] D125479: [pseudo] Fix the incorrect parameters-and-qualifiers rule.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf88150c48df: [pseudo] Fix the incorrect parameters-and-qualifiers rule. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1947 + // DeclModule if it isn't (transitively) imported. + if (DeclModule->getTopLevelModule()->isModuleInterfaceUnit()) +return true; ChuanqiXu wrote: > iains wrote: > > ChuanqiXu wrot

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme updated this revision to Diff 434739. mboehme added a comment. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126853/new/ https://reviews.llvm.org/D126853 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck

[clang-tools-extra] 28eeea1 - [pseudo]Pull out the operator< test, NFC

Author: Haojian Wu Date: 2022-06-07T11:00:08+02:00 New Revision: 28eeea1e2787a8491b9c636cdf31fc81e3aca1fb URL: https://github.com/llvm/llvm-project/commit/28eeea1e2787a8491b9c636cdf31fc81e3aca1fb DIFF: https://github.com/llvm/llvm-project/commit/28eeea1e2787a8491b9c636cdf31fc81e3aca1fb.diff LO

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

mboehme added a comment. The reviewer on https://reviews.llvm.org/D126780 reminded me to add release notes, so I've done so here as well. I assume this does not require another round of review. In D126853#3556029 , @njames93 wrote: > LGTM. > > I feel t

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#3561257 , @iains wrote: > so standard 10.4 ex 2 gives the expected output with this patch stack Cool, and I think we should add that one as a test if it works. Tests are always good. --- BTW, I guess we could remo

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1947 + // DeclModule if it isn't (transitively) imported. + if (DeclModule->getTopLevelModule()->isModuleInterfaceUnit()) +return true; iains wrote: > ChuanqiXu wrote: > > iains wrot

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers updated this revision to Diff 434746. vabridgers added a comment. Use QualType::getAsString() per suggestion from martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.org/D127105 Files: clang/lib/Stat

[PATCH] D126878: [analyzer] Remove NotifyAssumeClients

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Great! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126878/new/ https://reviews.llvm.org/D126878 _

[clang] d8b540c - Cleanup sema checking for buitlin_memcpy_inline

Author: Guillaume Chatelet Date: 2022-06-07T09:49:36Z New Revision: d8b540cd312cf924b1904047b56cf8a1cea333f9 URL: https://github.com/llvm/llvm-project/commit/d8b540cd312cf924b1904047b56cf8a1cea333f9 DIFF: https://github.com/llvm/llvm-project/commit/d8b540cd312cf924b1904047b56cf8a1cea333f9.diff

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434750. gchatelet marked 2 inline comments as done. gchatelet added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126903/new/ https://reviews.llvm.org/D126903 Files: clang/docs/Language

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet added inline comments. Comment at: clang/test/Sema/builtins-memcpy-inline.cpp:11 +void test_memcpy_inline_invalid_arg_types() { + __builtin_memcpy_inline(1, 2, 3); // expected-error {{cannot initialize a parameter of type 'void *' with an rvalue of type 'int'}} +} ---

[clang] ec90bc0 - [clang-format][NFC] Clean up the unwrapped line parser

Author: owenca Date: 2022-06-07T02:58:57-07:00 New Revision: ec90bc0ea4386849f9eea54f44d25b49d4673cd6 URL: https://github.com/llvm/llvm-project/commit/ec90bc0ea4386849f9eea54f44d25b49d4673cd6 DIFF: https://github.com/llvm/llvm-project/commit/ec90bc0ea4386849f9eea54f44d25b49d4673cd6.diff LOG: [

[PATCH] D127005: [clang-format][NFC] Clean up the unwrapped line parser

This revision was automatically updated to reflect the committed changes. Closed by commit rGec90bc0ea438: [clang-format][NFC] Clean up the unwrapped line parser (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127005/new/ https:

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

JohnTitor added a comment. > It took me a moment, but this actually removes a 0xC2AD and not a 0x00AD. > It's still correct, but I was wondering why no character was printed in the > text -- 0xC2AD is not a defined Unicode character. Oh, my editor said it 0x00AD, it's weird. Anyway thanks for c

[clang] aa9b338 - [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript`

Author: Yuki Okushi Date: 2022-06-07T19:29:01+09:00 New Revision: aa9b3389ffd85533b4e7d27f2dac242046f41e8e URL: https://github.com/llvm/llvm-project/commit/aa9b3389ffd85533b4e7d27f2dac242046f41e8e DIFF: https://github.com/llvm/llvm-project/commit/aa9b3389ffd85533b4e7d27f2dac242046f41e8e.diff L

[PATCH] D127066: [clang] Remove some `U+00AD`s in `__cpp_multidimensional_subscript`

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa9b3389ffd8: [clang] Remove some `U+C2AD`s in `__cpp_multidimensional_subscript` (authored by JohnTitor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1270

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

wyt created this revision. Herald added subscribers: tschuett, steakhal, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch moves the implementation of synthetic properties from the Struct

[PATCH] D127183: [clang-format] Skip parsing a block if it's nested too deep

owenpan updated this revision to Diff 434761. owenpan edited the summary of this revision. owenpan added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127183/new/ https://reviews.llvm.org/D127183 Files: clang/lib/Format/UnwrappedLineParser.cpp Index: clang/lib/F

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

jolanta.jensen updated this revision to Diff 434762. jolanta.jensen added a comment. Addressing review comments: 1. Added the test for mode(HF) 2. Moved Half before Float in FloatModeKind enum class to preserve precision ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 17e9ea6 - [analyzer][NFC] Add LLVM_UNLIKELY to assumeDualImpl

Author: Gabor Marton Date: 2022-06-07T12:48:48+02:00 New Revision: 17e9ea61389411f3142b1a34989d3a1a42a5f1fb URL: https://github.com/llvm/llvm-project/commit/17e9ea61389411f3142b1a34989d3a1a42a5f1fb DIFF: https://github.com/llvm/llvm-project/commit/17e9ea61389411f3142b1a34989d3a1a42a5f1fb.diff

[PATCH] D127190: [analyzer][NFC] Add LLVM_UNLIKELY to assumeDualImpl

This revision was automatically updated to reflect the committed changes. Closed by commit rG17e9ea613894: [analyzer][NFC] Add LLVM_UNLIKELY to assumeDualImpl (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127190/new/ https://r

[clang-tools-extra] 1b66446 - [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

Author: Martin Boehme Date: 2022-06-07T12:53:03+02:00 New Revision: 1b664460fa4cb507e2af87c48cd269964f3ad747 URL: https://github.com/llvm/llvm-project/commit/1b664460fa4cb507e2af87c48cd269964f3ad747 DIFF: https://github.com/llvm/llvm-project/commit/1b664460fa4cb507e2af87c48cd269964f3ad747.diff

[PATCH] D126853: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b664460fa4c: [clang-tidy] `bugprone-use-after-move`: Don't warn on self-moves. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126853/n

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

steakhal added a comment. Likely related to https://github.com/llvm/llvm-project/issues/55715. Mention this in the summary as `Fixes #55715`. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:168 -CastToTy->getAsCXXRecordDecl()->getNameAsString() :

[PATCH] D127197: [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

simon_tatham created this revision. simon_tatham added reviewers: asl, rsmith, lenary, john.brawn. Herald added a subscriber: kristof.beyls. Herald added a project: All. simon_tatham requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By both A

[clang] 8131ee4 - [analyzer] Remove NotifyAssumeClients

Author: Gabor Marton Date: 2022-06-07T13:02:03+02:00 New Revision: 8131ee4c43a8e33547628a313bf5ced9daed0045 URL: https://github.com/llvm/llvm-project/commit/8131ee4c43a8e33547628a313bf5ced9daed0045 DIFF: https://github.com/llvm/llvm-project/commit/8131ee4c43a8e33547628a313bf5ced9daed0045.diff

[PATCH] D126878: [analyzer] Remove NotifyAssumeClients

This revision was automatically updated to reflect the committed changes. Closed by commit rG8131ee4c43a8: [analyzer] Remove NotifyAssumeClients (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126878/new/ https://reviews.llvm.or

[clang-tools-extra] f4baf63 - [clang-tidy] Fix syntax error in release notes.

Author: Martin Boehme Date: 2022-06-07T13:04:56+02:00 New Revision: f4baf63155daa7ab3ebd2d773687313d5fdebddc URL: https://github.com/llvm/llvm-project/commit/f4baf63155daa7ab3ebd2d773687313d5fdebddc DIFF: https://github.com/llvm/llvm-project/commit/f4baf63155daa7ab3ebd2d773687313d5fdebddc.diff

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

martong added inline comments. Comment at: clang/test/Analysis/cast-value-state-dump.cpp:26 if (dyn_cast_or_null(S)) { -// expected-note@-1 {{Assuming 'S' is not a 'Square'}} +// expected-note@-1 {{Assuming 'S' is not a 'const class clang::Square *'}} // expected-

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[clang] 19647e5 - Fix change of variable name in test

Author: Guillaume Chatelet Date: 2022-06-07T11:20:57Z New Revision: 19647e5b3b77b1c2089756e99abf88205d534ba4 URL: https://github.com/llvm/llvm-project/commit/19647e5b3b77b1c2089756e99abf88205d534ba4 DIFF: https://github.com/llvm/llvm-project/commit/19647e5b3b77b1c2089756e99abf88205d534ba4.diff

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

iains updated this revision to Diff 434774. iains added a comment. rebased and tidied (still changes planned). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126959/new/ https://reviews.llvm.org/D126959 Files: clang/include/clang/Basic/Module.h

[PATCH] D127183: [clang-format] Skip parsing a block if it's nested too deep

owenpan updated this revision to Diff 434773. owenpan added a comment. Inadvertently moved the added code down when rebasing. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127183/new/ https://reviews.llvm.org/D127183 Files: clang/lib/Format/UnwrappedLineParser.cpp Index: cla

[PATCH] D127201: [clang] Add tests for statement expression in initializers

wanders created this revision. wanders added reviewers: cor3ntin, rsmith. wanders added a project: clang. Herald added a project: All. wanders requested review of this revision. Herald added a subscriber: cfe-commits. The commit 683e83c5

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains updated this revision to Diff 434781. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126189/new/ https://reviews.llvm.org/D126189 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/Module.

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

steakhal added a comment. Vince, please update the summary - it looks really weird. Along with that the content of it might not be much useful, as we have a test case to demonstrate the crash; you can probably remove those dumps etc. Otherwise LGTM. Comment at: clang/test/Ana

[PATCH] D127207: [flang][driver] Fix support for `-x`

awarzynski created this revision. awarzynski added reviewers: rovka, kiranchandramohan, schweitz, peixin, ekieri, Leporacanthicus. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert,

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:168 -CastToTy->getAsCXXRecordDecl()->getNameAsString() : -CastToTy->getPointeeCXXRecordDecl()->getNameAsString(); Out << ' ' << ((CastToTyVec.si

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource added a comment. It might also be interesting to think about cases that went through transitive assignment stripping when talking about the diagnostic position: Before my patch, a dead store on variable `a` was displayed as follows: B b; A a = static_cast(b = cre

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

ymandel added a comment. In D126973#3558304 , @gribozavr2 wrote: >> using the StructValue for its properties, while modeling a non-struct type. > > Could you explain the use case in more details? A `StructValue` is used to model a complex underlying typ

[PATCH] D125677: [pseudo] Remove the explicit Accept actions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is a great simplification, thanks! Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:85 - if (!PendingAccept.empty()) { -LLVM_DEBUG({ - llvm::dbgs() <<

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

gchatelet updated this revision to Diff 434793. gchatelet marked 8 inline comments as done. gchatelet added a comment. Herald added subscribers: pmatos, asb, aheejin, jgravelle-google, sbc100, dschuff. - Address comments, add more codegen tests, rebase Repository: rG LLVM Github Monorepo CHA

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

steakhal added inline comments. Comment at: clang/test/Analysis/cast-value-notes.cpp:311 +public: + template void b() { isa(*this); } +}; vabridgers wrote: > steakhal wrote: > > This gotta be the `getAs`. Please try to reconstruct the 'feel' of it; > > like re

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Ping! @ChuanqiXu : i was hoping you could take a look at this, since you did such a great job reviewing the rest of this (note this is mostly the same patch as the last one, just with the 'friends' stuff dealt with). CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

ymandel accepted this revision. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127196/new/ https://reviews.llvm.org/D127196 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

erichkeane added a comment. In D126818#3562355 , @tahonermann wrote: >> Note we might be confused, the parens there aren't completely clear as to >> what your intent is. > > Well, I know that I'm confused and not clear what my intent is :) > > I asked t

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 434802. vaibhav.y added a comment. Update tests to check serialization as well - SARIF text generated is validated externally against [Microsoft's online validator][1] [1]: https://sarifweb.azurewebsites.net/Validation Repository: rG LLVM Github Monor

[clang] e3a6784 - [clang-cl] Add support for /kernel

Author: Pengxuan Zheng Date: 2022-06-07T06:42:35-07:00 New Revision: e3a6784ac9672506ba69c1754a5e6b7712e1fba7 URL: https://github.com/llvm/llvm-project/commit/e3a6784ac9672506ba69c1754a5e6b7712e1fba7 DIFF: https://github.com/llvm/llvm-project/commit/e3a6784ac9672506ba69c1754a5e6b7712e1fba7.diff

[PATCH] D126719: [clang-cl] Add support for /kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3a6784ac967: [clang-cl] Add support for /kernel (authored by pzheng, committed by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ http

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:29 /// Base class for all values computed by abstract interpretation. +/// All Value instances should be separately allocated and stored by pointer +/// fo

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. @aaron.ballman Would it be possible that I add `::validate` through a follow-up PR? I'm currently checking the JSON output from the writer using Microsoft's online validator , and it is passing. Though it tends to compla

[PATCH] D127196: [clang][dataflow] Enable use of synthetic properties on all Value instances.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:29-30 /// Base class for all values computed by abstract interpretation. +/// All Value instances should be separately allocated and stored by pointer +/// for pointer stability. cl

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:485 "amdhip64.lib"}); + CmdArgs.push_back(Args.MakeArgString("clang_rt.builtins-" + + getTriple().getA

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl updated this revision to Diff 434807. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. use getCompilerRT to get compiler-rt lib path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127142/new/ https://reviews.llvm.org/D127

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

c-rhodes added a comment. @DavidTruby thanks for updating, just one last comment otherwise LGTM Comment at: clang/lib/Sema/SemaChecking.cpp:13591-13595 +if (!Target->isVLSTBuiltinType() && !isa(OriginalTarget)) { + if (S.SourceMgr.isInSystemMacro(CC)) +return;

[PATCH] D127217: [include-cleaner] Fix build error in unit test

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: All. ckandeler requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers updated this revision to Diff 434821. vabridgers added a comment. address @steakhal comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.org/D127105 Files: clang/lib/StaticAnalyzer/Checkers/CastValue

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers marked 8 inline comments as done. vabridgers added a comment. I think all comments have been addressed, please let me know if I missed some detail :) Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov updated this revision to Diff 434828. ppluzhnikov marked 4 inline comments as done. ppluzhnikov added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 Files:

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Comments addressed in new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-commits mailing

[PATCH] D127221: [Clang] Enable -print-pipeline-passes in clang.

jcranmer-intel created this revision. Herald added a subscriber: ormris. Herald added a project: All. jcranmer-intel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127221 Fi

[PATCH] D126479: [Clang] Allow 'Complex float __attribute__((mode(HC)))'

tahonermann added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:222 unsigned HasAlignMac68kSupport : 1; - unsigned RealTypeUsesObjCFPRet : 3; + unsigned RealTypeUsesObjCFPRet : 6; unsigned ComplexLongDoubleUsesFP2Ret : 1; Good find.

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains updated this revision to Diff 434834. iains marked 8 inline comments as done. iains added a comment. rebased and removed dependency on p1874 initializer patch. Some tidying - added 104. ex2 testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. again, thanks for review - but please do not spend any effort on style points yet - the debug and dump stuff is intentionally present this is "for comment on the approach" i.e. what is important is to establish that this is a reasonable approach. As of now we have the fo

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742

[PATCH] D127197: [ARM] Fix how size-0 bitfields affect homogeneous aggregates.

simon_tatham updated this revision to Diff 434838. simon_tatham added a comment. Added tests with `extern "C"`, at @lenary's (offline) suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127197/new/ https://reviews.llvm.org/D127197 Files:

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ppluzhnikov added a comment. Thanks for the review. Could you commit this? I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125742/new/ https://reviews.llvm.org/D125742 ___ cfe-

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:650 + cast(NewVL->getType(; +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasic

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:651 +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasicBlock("newvl.isNull", this->CurFn); +Builder.CreateCo

  1   2   >