[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 updated this revision to Diff 432478. kpdev42 edited the summary of this revision. kpdev42 added a comment. Well, after some investigation it turned out that: 1. ARMv5 has DMB instruction in the form of mcr p15, #0, , c7, c10, #5 2. There is SWP instruction (deprecated on ARMv6), which do

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365 _

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

owenpan added a comment. In D126365#3536736 , @curdeius wrote: > Would it be possible to add a test please? There are no tests for this script, but I have tested this patch on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Prefer https://reviews.llvm.org/D126189 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. @iains Do you agree to submit this one first? Since all the discussions/questions I see in this page now it not about the patch itself. The patch itself should be good personally I thought. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://re

[clang] 7a2d6de - [analyzer][NFC] Inline ExprEngine::evalComplement

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 7a2d6dea73b594a42b83ed48bd19bd232c29f2b8 URL: https://github.com/llvm/llvm-project/commit/7a2d6dea73b594a42b83ed48bd19bd232c29f2b8 DIFF: https://github.com/llvm/llvm-project/commit/7a2d6dea73b594a42b83ed48bd19bd232c29f2b8.diff

[PATCH] D126124: [analyzer][NFC] Inline ExprEngine::evalComplement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a2d6dea73b5: [analyzer][NFC] Inline ExprEngine::evalComplement (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] ee8987d - [analyzer][NFC] Inline ExprEngine::evalMinus

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: ee8987d585e799ec056da364220e81d97258ddec URL: https://github.com/llvm/llvm-project/commit/ee8987d585e799ec056da364220e81d97258ddec DIFF: https://github.com/llvm/llvm-project/commit/ee8987d585e799ec056da364220e81d97258ddec.diff

[clang] f6eab43 - [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: f6eab4376432fffe99b6699e6b604a38a8906bfe URL: https://github.com/llvm/llvm-project/commit/f6eab4376432fffe99b6699e6b604a38a8906bfe DIFF: https://github.com/llvm/llvm-project/commit/f6eab4376432fffe99b6699e6b604a38a8906bfe.diff

[clang] 8106660 - [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 81066603a8b91ec3edf59622d153ba40f0b4a169 URL: https://github.com/llvm/llvm-project/commit/81066603a8b91ec3edf59622d153ba40f0b4a169 DIFF: https://github.com/llvm/llvm-project/commit/81066603a8b91ec3edf59622d153ba40f0b4a169.diff

[PATCH] D126125: [analyzer][NFC] Inline ExprEngine::evalMinus

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee8987d585e7: [analyzer][NFC] Inline ExprEngine::evalMinus (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 813acb1 - [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 813acb12972eceabd2b5b06f2c11d3a1f34579bd URL: https://github.com/llvm/llvm-project/commit/813acb12972eceabd2b5b06f2c11d3a1f34579bd DIFF: https://github.com/llvm/llvm-project/commit/813acb12972eceabd2b5b06f2c11d3a1f34579bd.diff

[clang] 3a666dd - [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 3a666dd37a06fd5ff74b9e8fea15e31a80398233 URL: https://github.com/llvm/llvm-project/commit/3a666dd37a06fd5ff74b9e8fea15e31a80398233 DIFF: https://github.com/llvm/llvm-project/commit/3a666dd37a06fd5ff74b9e8fea15e31a80398233.diff

[clang] 3a7a465 - [analyzer][docs] Fix typo in checker name

Author: Balazs Benics Date: 2022-05-27T10:07:06+02:00 New Revision: 3a7a465def4a7faae41467893276910b1faa6152 URL: https://github.com/llvm/llvm-project/commit/3a7a465def4a7faae41467893276910b1faa6152 DIFF: https://github.com/llvm/llvm-project/commit/3a7a465def4a7faae41467893276910b1faa6152.diff

[PATCH] D126128: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6eab4376432: [analyzer][NFC] Inline loc::ConcreteInt::evalBinOp (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D126128

[PATCH] D126129: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81066603a8b9: [analyzer][NFC] Remove unused nonloc::ConcreteInt::evalBinOp (authored by steakhal). Changed prior to commit: https://reviews.llvm.o

[PATCH] D126130: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG813acb12972e: [analyzer][NFC] Remove unused SVal::hasConjuredSymbol (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126130/new/ https:

[PATCH] D126123: [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a666dd37a06: [analyzer][NFC] Use MemRegion::getRegion()'s return value unconditionally (authored by steakhal). Repository: rG LLVM Github Monore

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead added a comment. In D126461#3541577 , @craig.topper wrote: > What if it isn't known to be null at compile time but gets optimized to it. Thanks, I haven't thought it clearly and I just wanted to solve found bugs. :-) I changed it to generat

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor created this revision. Herald added a project: All. JohnTitor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes llvm#53545 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D126524 Files: clang/lib/Frontend/

[clang] e37b287 - [analyzer][NFC] Use idiomatic classof instead of isKind

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: e37b287998a72b028fbcf623f06685ed2b6b48e2 URL: https://github.com/llvm/llvm-project/commit/e37b287998a72b028fbcf623f06685ed2b6b48e2 DIFF: https://github.com/llvm/llvm-project/commit/e37b287998a72b028fbcf623f06685ed2b6b48e2.diff

[clang] d8def22 - [analyzer][NFC] Remove unused friend SVal declarations

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: d8def22f7be120ab159220a9e6d450b26bf50bca URL: https://github.com/llvm/llvm-project/commit/d8def22f7be120ab159220a9e6d450b26bf50bca DIFF: https://github.com/llvm/llvm-project/commit/d8def22f7be120ab159220a9e6d450b26bf50bca.diff

[clang] 7727d2a - [analyzer][NFC] Remove unused default SVal constructors

Author: Balazs Benics Date: 2022-05-27T10:54:25+02:00 New Revision: 7727d2abece6855ec6486ca0600998bfa35882a1 URL: https://github.com/llvm/llvm-project/commit/7727d2abece6855ec6486ca0600998bfa35882a1 DIFF: https://github.com/llvm/llvm-project/commit/7727d2abece6855ec6486ca0600998bfa35882a1.diff

[PATCH] D125707: [analyzer][NFC] Remove unused friend SVal declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8def22f7be1: [analyzer][NFC] Remove unused friend SVal declarations (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D125706: [analyzer][NFC] Use idiomatic classof instead of isKind

This revision was automatically updated to reflect the committed changes. Closed by commit rGe37b287998a7: [analyzer][NFC] Use idiomatic classof instead of isKind (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D125706?vs=429767&id=432493#toc Repository: rG LLVM Git

[PATCH] D125708: [analyzer][NFC] Remove unused default SVal constructors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7727d2abece6: [analyzer][NFC] Remove unused default SVal constructors (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 6ab69ef - [analyzer][NFC] Rename GREngine->CoreEngine, GRExprEngine->ExprEngine in comments and txt files

Author: Gabor Marton Date: 2022-05-27T11:04:35+02:00 New Revision: 6ab69efe61f2db50d72416a59fafa427249cb91b URL: https://github.com/llvm/llvm-project/commit/6ab69efe61f2db50d72416a59fafa427249cb91b DIFF: https://github.com/llvm/llvm-project/commit/6ab69efe61f2db50d72416a59fafa427249cb91b.diff

[clang] f13050e - [analyzer][NFCi] Annotate major nonnull returning functions

Author: Balazs Benics Date: 2022-05-27T11:05:50+02:00 New Revision: f13050eca3564ebccc04ea39eb34a312f063c4e9 URL: https://github.com/llvm/llvm-project/commit/f13050eca3564ebccc04ea39eb34a312f063c4e9 DIFF: https://github.com/llvm/llvm-project/commit/f13050eca3564ebccc04ea39eb34a312f063c4e9.diff

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGf13050eca356: [analyzer][NFCi] Annotate major nonnull returning functions (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D126198?vs=431379&id=432498#toc Repository: rG LLVM

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

mstorsjo added a comment. Regarding building native tools while cross compiling - for other tools so far, we’ve also had the option to pass an option like `-DLLVM_TABLEGEN=path/to/llvm-tblgen`. If all the needed native tools are provided that way, the build doesn’t need to set up the nested nat

[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3988bd13988a: [llvm][clang][bolt][NFC] Use llvm::less_first() when

[clang] 3988bd1 - [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

Author: Balazs Benics Date: 2022-05-27T11:15:23+02:00 New Revision: 3988bd13988aad72ec979beb2361e8738584926b URL: https://github.com/llvm/llvm-project/commit/3988bd13988aad72ec979beb2361e8738584926b DIFF: https://github.com/llvm/llvm-project/commit/3988bd13988aad72ec979beb2361e8738584926b.diff

[PATCH] D126291: [flang][Driver] Update link job on windows

rovka added a comment. In D126291#3536718 , @kiranchandramohan wrote: > @rovka in case you missed this, the test is failing in windows. Yeah, thanks, I was out of office a bit so I couldn't get to it sooner. I'll give it a try without lld. Repository

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal added a comment. I'm hesitating about landing this. I think I'll mark this flag deprecated instead, to emit a warning when using this flag. So, `clang-15` would emit a warning for this, and `clang-16` and above we can remove this flag completely. WDYT @martong ? Repository: rG LLVM

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

steakhal updated this revision to Diff 432509. steakhal edited the summary of this revision. steakhal added a comment. - Specify exactly that we propose one release deprecation, then removal. - Test the help message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 7df2597 - [Doc][OpenCL] Misc wording improvements for SPIR-V

Author: Anastasia Stulova Date: 2022-05-27T11:13:06+01:00 New Revision: 7df25978ef7882a3d793eecee854ec5d961c02d2 URL: https://github.com/llvm/llvm-project/commit/7df25978ef7882a3d793eecee854ec5d961c02d2 DIFF: https://github.com/llvm/llvm-project/commit/7df25978ef7882a3d793eecee854ec5d961c02d2.d

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:257 +} else if (Scope != "none") { + D.Diag(diag::err_invalid_sls_hardening) << Scope << A->getAsString(Args); +} nickdesaulniers wrote: > MaskRay wrote: > > The conv

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

pengfei updated this revision to Diff 432511. pengfei marked 5 inline comments as done. pengfei added a comment. Address @MaskRay 's comments. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org

[PATCH] D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument

pengfei added a comment. This is also fine to me. I'll rebase on it if @nickdesaulniers accept this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126511/new/ https://reviews.llvm.org/D126511 ___ cfe-com

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

iains added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:621 +void CodeGenModule::EmitCXXModuleInitFunc(Module *Primary) { + while (!CXXGlobalInits.empty() && !CXXGlobalInits.back()) ChuanqiXu wrote: > iains wrote: > > ChuanqiXu wrote: > > > Re

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

rengolin added a comment. In D126451#3541590 , @zixuan-wu wrote: > I don't think it is largely similar to RISCV implementation except for the > code structure and test reuse. And the test result is big different. Sorry, that's what I meant. There are no

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj updated this revision to Diff 432518. upsj added a comment. Of course, I forgot to create a new diff. There is some debug output and logic errors for some of the tests, but the simple ones already show the issue. The function in question is `getPackTemplateParameter`, which provides similar

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev closed this revision. v.g.vassilev added a comment. Herald added a subscriber: StephenFan. Landed in https://github.com/llvm/llvm-project/commit/788e0f7f3e96a9d61c2412e452c4589e2693b79a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/ https://reviews.llvm.org/D121

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 432520. Sockke added a comment. Rebased and added '-fno-delayed-template-parsing' option for the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3540673 , @efriedma wrote: > For FENV_ROUND, I think we should try to stick to the standard as closely as > possible in Sema; since the standard models FENV_ROUND as a separate state, > Sema should also model it as

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

Sockke updated this revision to Diff 432522. Sockke added a comment. rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 Files: clang-tools-extra/clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h c

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal updated this revision to Diff 432525. steakhal retitled this revision from "[analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag" to "[analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag". steakhal edited the summary of this revision. steakhal

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor updated this revision to Diff 432526. JohnTitor added a comment. [CompilerInstance] Tweak the condition on `createCodeCompletionConsumer` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files:

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

JohnTitor updated this revision to Diff 432527. JohnTitor added a comment. Fix the indention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llvm.org/D126524 Files: clang/lib/Frontend/CompilerInstance.cpp Index: clang

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:621 +void CodeGenModule::EmitCXXModuleInitFunc(Module *Primary) { + while (!CXXGlobalInits.empty() && !CXXGlobalInits.back()) iains wrote: > ChuanqiXu wrote: > > iains wrote: > > > Ch

[clang] 8c0eb32 - Also remove the empty StoredDeclsList entry from the lookup table

Author: Vassil Vassilev Date: 2022-05-27T12:36:37Z New Revision: 8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b URL: https://github.com/llvm/llvm-project/commit/8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b DIFF: https://github.com/llvm/llvm-project/commit/8c0eb32d2aa0bc73c176d7b25f47bdf37f967d3b.diff LO

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c0eb32d2aa0: Also remove the empty StoredDeclsList entry from the lookup table (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126215: [analyzer] Deprecate `-analyzer-store region` flag

martong accepted this revision. martong added a comment. Still looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126215/new/ https://reviews.llvm.org/D126215 ___ cfe-commits mailing list cfe-comm

[PATCH] D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend

xbolva00 added inline comments. Herald added a reviewer: MaskRay. Herald added subscribers: vporpo, pmatos, asb. Herald added a project: All. Comment at: lld/ELF/LTO.cpp:96 + c.PTO.LoopVectorization = c.OptLevel > 1; + c.PTO.SLPVectorization = c.OptLevel > 1;

[PATCH] D126534: Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource created this revision. frederic-tingaud-sonarsource added a reviewer: dcoughlin. Herald added a subscriber: martong. Herald added a project: All. frederic-tingaud-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D126067: [analyzer] Deprecate the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal added a comment. I plan to land this stack next Wednesday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: mgrang, mgorny. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang-tools-extra. - Add annotation handling ([key=val

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432539. egorzhdan added a comment. - Change arg type from `std::string` to `StringRef` - Remove unnecessary `//` • Remove unneeded test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://revie

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added a comment. This patch might cover too many things (at least we could split the guide/glr implementation bit), but want to give you an overview of the picture first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126536/new/ https://rev

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan marked 2 inline comments as done. egorzhdan added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string &Path, + const Twine &A, const Twine &B, -

[PATCH] D126536: [pseudo] Add grammar annotations support.

hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Grammar.h:87 +// Defines the built-in attribute keys. +enum class AttributeKey : uint8_t { + // A guard controls whether a reduction of a rule will be conducted by the GLR n

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Nice. This is the patch that makes the condition obsolete: D60871 . You might also remove the `else`, since the first `if` now has an unconditional

[PATCH] D126524: [CompilerInstance] Fix weird condition on `createCodeCompletionConsumer`

jansvoboda11 added a comment. The differential I linked doesn't contain the right diff. Here's the commit I meant to point out: 3a75330f573a31c7e0f7e27c5d34501c293673a5. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126524/new/ https://reviews.llv

[PATCH] D126420: [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG67136d0e8fb5: [clang][dataflow] Remove private-field filtering from `StorageLocation`… (authored by ymandel

[clang] 67136d0 - [clang][dataflow] Remove private-field filtering from `StorageLocation` creation.

Author: Yitzhak Mandelbaum Date: 2022-05-27T13:39:53Z New Revision: 67136d0e8fb57251dece4be0907414fdbe081f7a URL: https://github.com/llvm/llvm-project/commit/67136d0e8fb57251dece4be0907414fdbe081f7a DIFF: https://github.com/llvm/llvm-project/commit/67136d0e8fb57251dece4be0907414fdbe081f7a.diff

[clang] 3682e22 - [clang][dataflow] Improve handling of constructor initializers.

Author: Yitzhak Mandelbaum Date: 2022-05-27T13:54:11Z New Revision: 3682e22ef404e1314ee1eab9daf6de99dc9ea8ee URL: https://github.com/llvm/llvm-project/commit/3682e22ef404e1314ee1eab9daf6de99dc9ea8ee DIFF: https://github.com/llvm/llvm-project/commit/3682e22ef404e1314ee1eab9daf6de99dc9ea8ee.diff

[PATCH] D126419: [clang][dataflow] Improve handling of constructor initializers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3682e22ef404: [clang][dataflow] Improve handling of constructor initializers. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo created this revision. Herald added subscribers: shchenz, nemanjai. Herald added a project: All. maryammo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is the last prerequisite to switch the default behaviour to -fno-

[clang] e651ed8 - [analyzer] Fix wrong annotation of LazyCompoundVal::getStore

Author: Balazs Benics Date: 2022-05-27T16:07:33+02:00 New Revision: e651ed8621c3719937517ddb0b0815b18ec888e4 URL: https://github.com/llvm/llvm-project/commit/e651ed8621c3719937517ddb0b0815b18ec888e4 DIFF: https://github.com/llvm/llvm-project/commit/e651ed8621c3719937517ddb0b0815b18ec888e4.diff

[PATCH] D126198: [analyzer][NFCi] Annotate major nonnull returning functions

steakhal added a comment. A sanitizer buildbot caught a wrong annotation, fixed by e651ed8621c3719937517ddb0b0815b18ec888e4 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126198

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource updated this revision to Diff 432552. frederic-tingaud-sonarsource added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker.cpp

[PATCH] D126540: PowerPC] Emit warning for incompatible vector types that are currently diagnosed with -fno-lax-vector-conversions

maryammo updated this revision to Diff 432553. maryammo added a comment. NFC update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126540/new/ https://reviews.llvm.org/D126540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Se

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

steakhal added a comment. I haven't checked the implementation; the Deadstores checker was always a nemesis for me. Off the top of my head, I think in the analyzer we have the `elide-constructors=true/false` analyzer config option, which quotes: > Whether elidable C++ copy-constructors and mov

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource updated this revision to Diff 432558. frederic-tingaud-sonarsource added a comment. Document tests better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126534/new/ https://reviews.llvm.org/D126534 Files: clang/lib/StaticAnalyzer/Checkers/DeadStoresChecker

[PATCH] D126534: [analyzer] Deadstore static analysis: Fix false positive on C++17 assignments

frederic-tingaud-sonarsource marked an inline comment as done. frederic-tingaud-sonarsource added a comment. Thanks for looking at the PR! In D126534#3542402 , @steakhal wrote: > You also mentioned this copy elision, but I don't see anywhere checks for t

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 432563. python3kgae added a comment. Add hlsl-entry for cc1 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/Attr.td c

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11721 + Diag(FD->getLocation(), diag::err_hlsl_missing_numthreads) << "Compute"; + FD->setInvalidDecl(); +} bruno wrote: > Since

[PATCH] D126547: [OpenACC][OpenMP] Document atomic-in-teams extension

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, clementval. jdenny added projects: OpenMP, OpenACC. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald ad

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

egorzhdan updated this revision to Diff 432568. egorzhdan marked an inline comment as done. egorzhdan added a comment. Rebase & fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/ https://reviews.llvm.org/D126289 Files: clan

[PATCH] D126549: [Clang][OpenMP] Don't overload "extension" in status doc

jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, RaviNarayanaswamy. jdenny added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project

[PATCH] D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend

tejohnson added inline comments. Herald added a subscriber: StephenFan. Comment at: lld/ELF/LTO.cpp:96 + c.PTO.LoopVectorization = c.OptLevel > 1; + c.PTO.SLPVectorization = c.OptLevel > 1; xbolva00 wrote: > COFF? This came up recently on discourse: https://

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432574. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driver/Options.td c

[clang] 684c080 - [Clang] Extend -gen-reproducer flag

Author: Alex Brachet Date: 2022-05-27T15:49:13Z New Revision: 684c080108766b4f112f172fed4a49059484614d URL: https://github.com/llvm/llvm-project/commit/684c080108766b4f112f172fed4a49059484614d DIFF: https://github.com/llvm/llvm-project/commit/684c080108766b4f112f172fed4a49059484614d.diff LOG:

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG684c08010876: [Clang] Extend -gen-reproducer flag (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Cha

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

abrachet marked an inline comment as done. abrachet added inline comments. Comment at: clang/test/Driver/emit-reproducer.c:1 +// RUN: rm -rf %t; mkdir %t + hans wrote: > I'm not sure if lit handles that semicolon, or if it hands this over to the > shell, in whic

[clang] e917801 - [Clang][Driver] Fix include paths for `--sysroot /` on Linux

Author: Egor Zhdan Date: 2022-05-27T16:51:36+01:00 New Revision: e917801eddbe1b32f1adc81391fd434557391b5e URL: https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e DIFF: https://github.com/llvm/llvm-project/commit/e917801eddbe1b32f1adc81391fd434557391b5e.diff LO

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe917801eddbe: [Clang][Driver] Fix include paths for `--sysroot /` on Linux (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126289/new/

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + probinson wrote: > dblaikie wrote: > > probinson wrote: > > > dblaikie wrote: > > > > probinson wrote: > > > > > Does this mean `-fcla

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1359 + return cache(S, + SVB.evalCast(Op, S->getType(), S->getOperand()->getType())); +} steakhal wrote: > Hoist this common subexpression. O

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

martong updated this revision to Diff 432588. martong marked 7 inline comments as done. martong added a comment. - Hoist S->getOperand, rework the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126481/new/ https://reviews.llvm.org/D126481

[clang] bf1ab1f - cmake: use llvm dir variables for clang/utils/hmaptool

Author: Matheus Izvekov Date: 2022-05-27T18:44:58+02:00 New Revision: bf1ab1f0eb9578914343f48096229ecccd0ecf52 URL: https://github.com/llvm/llvm-project/commit/bf1ab1f0eb9578914343f48096229ecccd0ecf52 DIFF: https://github.com/llvm/llvm-project/commit/bf1ab1f0eb9578914343f48096229ecccd0ecf52.dif

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf1ab1f0eb95: cmake: use llvm dir variables for clang/utils/hmaptool (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D120201: [Clang] Extend -gen-reproducer flag

thakis added a comment. Looks like this breaks tests on (at least) Mac and window, see eg http://45.33.8.238/macm1/36198/step_7.txt (passes on my Linux bit though). Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 4dc3893 - Revert "[Clang] Extend -gen-reproducer flag"

Author: Alex Brachet Date: 2022-05-27T17:03:32Z New Revision: 4dc3893eeb47bef9298c34cdc993165af88721a5 URL: https://github.com/llvm/llvm-project/commit/4dc3893eeb47bef9298c34cdc993165af88721a5 DIFF: https://github.com/llvm/llvm-project/commit/4dc3893eeb47bef9298c34cdc993165af88721a5.diff LOG:

[libunwind] 719bf2d - [runtimes] Officially deprecate the legacy testing configuration system

Author: Louis Dionne Date: 2022-05-27T13:15:48-04:00 New Revision: 719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36 URL: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36 DIFF: https://github.com/llvm/llvm-project/commit/719bf2d9d9fdb8792b15d93364c9c6b2ddd68a36.diff

[PATCH] D126137: [X86] Add support for `-mharden-sls=[none|all|return|indirect-jmp]`

nickdesaulniers requested changes to this revision. nickdesaulniers added a subscriber: aaron.ballman. nickdesaulniers added a comment. This revision now requires changes to proceed. Let's get this rebased on top of D126511 . Comment at: clang/

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isExternCContext()` is returning false for functions in C files Change-Id: I51cccb476aa19dc0a0a78e951d7f482befdb78ca R

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:563 + } else if (IsInstantiation || getContext().GetGVALinkageForVariable(D) == GVA_DiscardableODR || D->hasAttr()) { rsmith wrote: > rnk wrote: > > @rsmith , if i

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. I mean that ActOnPragmaFEnvAccess shouldn't call hasRoundingModeOverride()/setRoundingModeOverride(), and setRoundingMode shouldn't call getAllowFEnvAccess(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ htt

[PATCH] D126481: [analyzer] Handle SymbolCast in SValBuilder

ASDenysPetrov added a comment. @martong As you said, my solution D103096 suppose to pass these and more other tests cases. So how it will help in combination with my solution D103096 ? Although, your patch is really simple but

  1   2   >