abrachet marked an inline comment as done.
abrachet added inline comments.

================
Comment at: clang/test/Driver/emit-reproducer.c:1
+// RUN: rm -rf %t; mkdir %t
+
----------------
hans wrote:
> I'm not sure if lit handles that semicolon, or if it hands this over to the 
> shell, in which case it won't work on windows.
> Instead, `rm -rf %t && mkdir %t` seems common among clang tests.
> 
> Otherwise, this is a nice test file :-)
Thanks :) updated it in the commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120201/new/

https://reviews.llvm.org/D120201

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to