[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 432355. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Add library to HLSLShaderAttr to help convert ShaderType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://revie

[PATCH] D126494: [clang] avoid assert due to device treated long double as double

cchen added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4654 + bool IsLongDouble = BType && BType->getKind() == BuiltinType::LongDouble; + bool IsDevice = getLangOpts().HIP || getLangOpts().CUDA || + getLangOpts().OpenMPIsDevice

[libunwind] 92bbcfa - [libunwind] Tidy-up the testing configuration for libunwind

Author: Louis Dionne Date: 2022-05-26T15:29:39-04:00 New Revision: 92bbcfaa97408991813fda5c56e864c629f67a01 URL: https://github.com/llvm/llvm-project/commit/92bbcfaa97408991813fda5c56e864c629f67a01 DIFF: https://github.com/llvm/llvm-project/commit/92bbcfaa97408991813fda5c56e864c629f67a01.diff

[PATCH] D126494: [clang] avoid assert due to device treated long double as double

efriedma added a comment. This doesn't make sense to me. If clang and LLVM disagree about the layout of a type, you are going to run into trouble. If you haven't yet, it's a matter of time. Looking at AMDGPUTargetInfo::setAuxTarget, maybe LongDoubleFormat is somehow inconsistent with LongDou

[clang] b58a420 - [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

Author: Argyrios Kyrtzidis Date: 2022-05-26T12:49:51-07:00 New Revision: b58a420ff4f92b085fd718600fda162059171a58 URL: https://github.com/llvm/llvm-project/commit/b58a420ff4f92b085fd718600fda162059171a58 DIFF: https://github.com/llvm/llvm-project/commit/b58a420ff4f92b085fd718600fda162059171a58.

[clang] b4c83a1 - [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

Author: Argyrios Kyrtzidis Date: 2022-05-26T12:50:06-07:00 New Revision: b4c83a13f664582015ea22924b9a0c6290d41f5b URL: https://github.com/llvm/llvm-project/commit/b4c83a13f664582015ea22924b9a0c6290d41f5b DIFF: https://github.com/llvm/llvm-project/commit/b4c83a13f664582015ea22924b9a0c6290d41f5b.

[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens

This revision was automatically updated to reflect the committed changes. akyrtzi marked an inline comment as done. Closed by commit rGb58a420ff4f9: [Tooling/DependencyScanning] Rename refactorings towards transitioning… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D125486: [Tooling/DependencyScanning] Remove `ExcludedPreprocessorDirectiveSkipMapping` and related functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c83a13f664: [Tooling/DependencyScanning & Preprocessor] Refactor dependency scanning to… (authored by akyrtzi). Changed prior to commit: https:/

Call for an assistance pushing patch review forward

Hi, Some time ago I submitted a Clang patch for review: https://reviews.llvm.org/D123532 It's been some time and I can't make progress with it. I'm aware that there is failed build. But, as I mentioned in one of the comments, I can't reproduce it locally. Tried to reach out to the people mentione

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

gkll created this revision. gkll added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. gkll requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:371 +- Support ``-mharden-sls=all`` for X86. + nickdesaulniers wrote: > pengfei wrote: > > nickdesaulniers wrote: > > > This should be updated if additional options are supported. > > > > >

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added inline comments. Comment at: clang/test/Driver/x86-target-features.c:317 +// SLS-IND: "-target-feature" "+harden-sls-ind" +// SLS-ALL: "-target-feature" "+harden-sls-ind" "-target-feature" "+harden-sls-ret" +// SLS-NONE-NOT: harden-sls The pattern

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + dblaikie wrote: > probinson wrote: > > dblaikie wrote: > > > probinson wrote: > > > > Does this mean `-fclang-abi-compat` will overri

[clang] 5221875 - [clang-format] Fix an invalid code generation in RemoveBracesLLVM

Author: owenca Date: 2022-05-26T13:38:04-07:00 New Revision: 5221875a957da927a889a705276d4e073ff737b1 URL: https://github.com/llvm/llvm-project/commit/5221875a957da927a889a705276d4e073ff737b1 DIFF: https://github.com/llvm/llvm-project/commit/5221875a957da927a889a705276d4e073ff737b1.diff LOG: [

[PATCH] D126438: [clang-format] Fix an invalid code generation in RemoveBracesLLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5221875a957d: [clang-format] Fix an invalid code generation in RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:229-232 +// store value of these variables (i.e. offload archs) into a custom +// section which will be used by "offload-arch -f". It won't be +// removed during binary stri

[PATCH] D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChain.cpp:917 +/*static*/ std::string ToolChain::concat(const std::string &Path, + const Twin

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi closed this revision. akyrtzi marked an inline comment as done. akyrtzi added a comment. b4c83a13f664582015ea22924b9a0c6290d41f5b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

RE: Call for an assistance pushing patch review forward

Hi Mateusz, I wouldn’t worry too much about the failed build. I took a peek and it looks like the failures are mostly in places very unrelated to your patch. If your own testing shows no problems, it’s very likely you’re fine. Regarding lack of response, this is unfortunately more common than

[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

akyrtzi closed this revision. akyrtzi added a comment. b4c83a13f664582015ea22924b9a0c6290d41f5b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125488/new/ https://reviews.llvm.or

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:368 -Select straight-line speculation hardening scope +Select straight-line speculation hardening scope (AArch64/X86 only). must be 'all', 'none', 'retbr'(AArch64), 'blr'(AArch64), 'return'(X8

[clang] 5bf44aa - [clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

Author: owenca Date: 2022-05-26T13:56:47-07:00 New Revision: 5bf44aa434ffe4d2e49806be20683e32135f4e16 URL: https://github.com/llvm/llvm-project/commit/5bf44aa434ffe4d2e49806be20683e32135f4e16 DIFF: https://github.com/llvm/llvm-project/commit/5bf44aa434ffe4d2e49806be20683e32135f4e16.diff LOG: [

[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bf44aa434ff: [clang-format][NFC] Refactor UnwrappedLineParser::parseBlock() (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126358/new/

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:257 +} else if (Scope != "none") { + D.Diag(diag::err_invalid_sls_hardening) << Scope << A->getA

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added a comment. > [X86] Add support for `-mharden-sls=all` The subject should list all supported values, or just say `Support -mharden-sls=` (don't list the values). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://revie

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:563 + } else if (IsInstantiation || getContext().GetGVALinkageForVariable(D) == GVA_DiscardableODR || D->hasAttr()) { @rsmith , if inline global variable initializ

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added inline comments. Comment at: llvm/lib/Target/X86/X86AsmPrinter.cpp:355 +void X86AsmPrinter::emitBasicBlockEnd(const MachineBasicBlock &MBB) { + AsmPrinter::emitBasicBlockEnd(MBB); + if (Subtarget->hardenSlsRet() || Subtarget->hardenSlsInd()) { Thi

[PATCH] D125974: [clang] Limit bitcode option ignorelist to Darwin

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125974/new/ https://reviews.llvm.org/D125974

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

MaskRay added a comment. gcc has renamed indirect-branch to indirect-jmp. The rationale is that something like `call *(%rbx)` does not need `int3`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126137/new/ https://reviews.llvm.org/D126137 ___

[PATCH] D126137: [X86] Add support for `-mharden-sls=all`

nickdesaulniers added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:368 -Select straight-line speculation hardening scope +Select straight-line speculation hardening scope (AArch64/X86 only). must be 'all', 'none', 'retbr'(AArch64), 'blr'(AArch64), 're

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mehdi_amini added a comment. I hit a config failure after f8c8bda965dd0f622de1ad3863b728661af6eb72 CMake Error at /var/lib/buildkite-agent/builds/buildkite-588bd64db9-mk2vq-1/mlir/mlir-core/libcxx/CMakeLists.txt:225 (messa

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mehdi_amini added a comment. Forgot to mention, we configure this build with: cmake -G Ninja ${src_dir}/llvm -DLLVM_TARGETS_TO_BUILD="X86;NVPTX;AMDGPU" -DLLVM_ENABLE_PROJECTS="lld;clang;mlir" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=Off -DLIBCXX_CXX_ABI=default -DLLVM_ENABLE_RUNTI

[clang] 056dec5 - [Driver][test] Change -target i386-unknown-linux-gnu to --target=i386 and remove unused -o %t.o

Author: Fangrui Song Date: 2022-05-26T14:41:04-07:00 New Revision: 056dec5dc821114d5b6cfee482a1c7a49bb41902 URL: https://github.com/llvm/llvm-project/commit/056dec5dc821114d5b6cfee482a1c7a49bb41902 DIFF: https://github.com/llvm/llvm-project/commit/056dec5dc821114d5b6cfee482a1c7a49bb41902.diff

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/entry.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -Efoo -fcgl -Fo - %s | FileCheck %s + Anastasia wrote: > Is this test here accidental? This

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 432393. python3kgae added a comment. Move addHLSLFunctionAttributes to ConstructAttributeList. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752 Files: clang/lib/

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

kstoimenov accepted this revision. kstoimenov added a comment. This revision is now accepted and ready to land. LGTM, but get one from vitalybuka@ too. Sorry about delayed review, I missed it. Next time ping me if I don't respond within a day. Comment at: llvm/lib/IR/Globals.

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

ahatanak updated this revision to Diff 432398. ahatanak edited the summary of this revision. ahatanak added a comment. Add a codegen test that checks destructors for temporaries inside asm statements are called. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added inline comments. Comment at: flang/test/Driver/flang-linker-flags-windows.f90:16 +! Linker invocation to generate the executable +! CHECK-LABEL: lld-link.exe +! CHECK-NOT: libcmt This is failing for me. Instead of `lld-link.exe`, it is using `li

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

rsmith added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:563 + } else if (IsInstantiation || getContext().GetGVALinkageForVariable(D) == GVA_DiscardableODR || D->hasAttr()) { rnk wrote: > @rsmith , if inline global va

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

nridge added a comment. In D124690#3540704 , @upsj wrote: > Example where this pops up: > > cpp > namespace std { template T&& forward(T&); } > struct S { S(int a); }; > template > T bar(Args&&... args) { return T{std::forward(

[PATCH] D81404: [AArch64] Add clang command line support for -mharden-sls=

MaskRay added a comment. Herald added a project: All. The convention is to use `err_drv_unsupported_option_argument` instead of adding a new diagnostic kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81404/new/ https://reviews.llvm.org/D81404

[clang] edcd06b - [test/ClangScanDeps] Add a target triple for `macro-expansions.cpp`

Author: Argyrios Kyrtzidis Date: 2022-05-26T17:18:32-07:00 New Revision: edcd06ba8b4123af83274845316b037b3864f8cb URL: https://github.com/llvm/llvm-project/commit/edcd06ba8b4123af83274845316b037b3864f8cb DIFF: https://github.com/llvm/llvm-project/commit/edcd06ba8b4123af83274845316b037b3864f8cb.

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rsmith added inline comments. Comment at: clang/test/CodeGenCXX/asm.cpp:22 + asm("" : : "r"(foo(a)) ); +} + Please add another statement here after the `asm` statement to check that the destructor is called at the end of the `asm` statement, not at the `}`. R

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rsmith added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15746 ExprResult Sema::BuildStmtExpr(SourceLocation LPLoc, Stmt *SubStmt, SourceLocation RPLoc, unsigned TemplateDepth) { assert(SubStmt && isa(SubStmt) && "Invalid action i

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432429. python3kgae added a comment. Add test for main is not entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp

[PATCH] D126511: [ARM][AArch64] Change -mharden-sls= to use err_drv_unsupported_option_argument

MaskRay created this revision. MaskRay added reviewers: kristof.beyls, ostannard, nickdesaulniers, pengfei. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update t

[PATCH] D125373: [pp-trace] Print HashLoc in InclusionDirective callback

oToToT added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125373/new/ https://reviews.llvm.org/D125373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. + const Arg* A = Args.getLastArg(options::OPT_fuse_

[PATCH] D126192: [Driver] Support linking with lld for target AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:530 + if (AVRLibcRoot && FamilyName) { +std::string Prefix(*AVRLibcRoot + "/lib/ldscripts/"); +if (llvm::sys::fs::is_directory(Prefix)) { I am concerned with the m

[PATCH] D124751: [HLSL] Support -E option for HLSL.

bruno added a comment. Hi, nice to see this getting in. Comments inline! Comment at: clang/lib/Sema/SemaDecl.cpp:11720 +if (!FD->hasAttr()) { + Diag(FD->getLocation(), diag::err_hlsl_missing_numthreads) << "Compute"; + FD->setInvalidDecl(); You ca

[PATCH] D125694: [clang][DebugInfo] Allow function-local statics to be scoped within a lexical block (4/5)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks very good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125694/new/ https://reviews.llvm.org/D125694

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Sgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125695/new/ https://reviews.llvm.org/D125695

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

rprichard added a comment. @mgorny Do you mind if I commandeer this Phabricator revision (and also D29542 , which I would abandon in favor of D59566 which is already merged)? I need this CL to get libc++ tests passing on i686-li

[PATCH] D124751: [HLSL] Support -E option for HLSL.

MaskRay added inline comments. Comment at: clang/test/SemaHLSL/entry.hlsl:2 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -Efoo -DWITH_NUM_THREADS -ast-dump -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-compute -x hlsl -Efoo -o -

[PATCH] D124753: [HLSL] Set main as default entry.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:194 +const StringRef DefaultEntry = "main"; +DAL->AddSeparateArg(nullptr, Opts.getOption(options::OPT_hlsl_entrypoint), +DefaultEntry); Instead of lett

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

aprantl added a comment. In D121100#3530683 , @alok wrote: > GNU gdb is now modified to accept functions with linkage name. > > commit 6f9b09edaee43ea34d34b1998fe7b844834f251a > Author: Alok Kumar Sharma > Date: Sun May 22 21:46:06 2022 +0530 Ni

[clang] 52992f1 - Add !nosanitize to FixedMetadataKinds

Author: Enna1 Date: 2022-05-27T09:46:13+08:00 New Revision: 52992f136b3bd421533ac909c520525e34058468 URL: https://github.com/llvm/llvm-project/commit/52992f136b3bd421533ac909c520525e34058468 DIFF: https://github.com/llvm/llvm-project/commit/52992f136b3bd421533ac909c520525e34058468.diff LOG: Ad

[PATCH] D126294: Add !nosanitize to FixedMetadataKinds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52992f136b3b: Add !nosanitize to FixedMetadataKinds (authored by Enna1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added a comment. What is it isn't known to be null at compile time but gets optimized to it. Are we trying to make passing a null pointer defined behavior for these intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539656 , @rengolin wrote: > This looks good to me, but wait to make sure others see it, too. > > My reasons are: it is largely similar to RISCV implementation, it seems to > follow what I expected of the ABI (which

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:11708 + case llvm::Triple::csky: { +bool IsSoftFloat = !getTarget().hasFeature("hard-float-abi"); +bool hasFP64 = getTarget().hasFeature("fpuv2_df") || DavidSpickett wrote: > I

[PATCH] D105584: [MLIR][OpenMP] Distribute Construct Operation

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:29 llvm_gtest + clangBasic + clangFrontend abidmalikwaterloo wrote: > shraiysh wrote: > > abidmalikwaterloo wrote: > > > shraiysh wrote: > > > > unrelated change? > > > When I rebas

[PATCH] D105255: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

shraiysh added inline comments. Comment at: clang/lib/Testing/CMakeLists.txt:33 + clangBasic + clangFrontend ) abidmalikwaterloo wrote: > Are these okay? In D105584 these were not No, this is not okay. There is some issue with these patches and I don't know

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. BTW, I have run llvm-test-suite, it passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D126189: [C++20][Modules] Build module static initializers per P1874R1.

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:621 +void CodeGenModule::EmitCXXModuleInitFunc(Module *Primary) { + while (!CXXGlobalInits.empty() && !CXXGlobalInits.back()) iains wrote: > ChuanqiXu wrote: > > Recommend to comment

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432457. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld clang/test/Driver/Inputs/basic_avr_tree/usr/l

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:435 - std::string Linker = getToolChain().GetProgramPath(getShortName()); + // Compute the linker program path, and use GNU "avr-ld" as default. + con

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432459. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/avr/lib/ldscripts/avr5.xn clang/test/Driver/avr-tool

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added a comment. I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../ Repository: rG LLVM Github

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:461 << CPU; - } else if (TC.getGCCInstallPath().empty()) { -// We can not link since there is no avr-ld. benshi001 wrote: > This check is no longer needed,

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432460. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:528 + CmdArgs.push_back(Args.MakeArgString("-T")); + CmdArgs.push_back(Args.MakeArgString(Prefix + *FamilyName + ".x")); +} Though I can seperate my AVR pro

[PATCH] D126522: Create specialization of `-Wgnu-statement-expression` for expressions found in macros.

mwyman created this revision. mwyman added reviewers: stephanemoore, hokein, ymandel, dmaclach. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. `-Wgnu-statement-expression` currently warns for both direct

[PATCH] D126192: [Driver] Support linking with lld for target AVR

benshi001 updated this revision to Diff 432468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/Inputs/basic_avr_tree/usr/lib/a

[libunwind] e251fb4 - [libunwind][CMake] Fix name of LIBUNWIND_SUPPORTS_NODEFAULTLIBS_FLAG

Author: Pavel Samolysov Date: 2022-05-27T09:20:57+03:00 New Revision: e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 URL: https://github.com/llvm/llvm-project/commit/e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7 DIFF: https://github.com/llvm/llvm-project/commit/e251fb4cdeb723eff5507be1efeb3fc69f7a2ce7.dif

[PATCH] D126522: Create specialization of `-Wgnu-statement-expression` for expressions found in macros.

mwyman updated this revision to Diff 432471. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126522/new/ https://reviews.llvm.org/D126522 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/lib/Parse/ParseExpr.cpp clang/test/

<    1   2