[clang] 9698a44 - Fix warning by handling OMPC_fail in switch statement.

Author: Adrian Kuegel Date: 2022-05-25T09:33:41+02:00 New Revision: 9698a445c664e6f0da5727364338ee99de537d6a URL: https://github.com/llvm/llvm-project/commit/9698a445c664e6f0da5727364338ee99de537d6a DIFF: https://github.com/llvm/llvm-project/commit/9698a445c664e6f0da5727364338ee99de537d6a.diff

[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 431909. balazske marked 13 inline comments as done. balazske added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/StaticAnalyze

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:454-460 + std::string Result = "Assuming that function '"; + Result.append(FunctionName.str()); + Result.append("' fails, in this case the value 'errno' be

[clang] f75bc5b - [analyzer] Fix symbol simplification assertion failure

Author: Gabor Marton Date: 2022-05-25T10:55:50+02:00 New Revision: f75bc5bfc8f898de10e14163998c63eeb2b9f705 URL: https://github.com/llvm/llvm-project/commit/f75bc5bfc8f898de10e14163998c63eeb2b9f705 DIFF: https://github.com/llvm/llvm-project/commit/f75bc5bfc8f898de10e14163998c63eeb2b9f705.diff

[PATCH] D126281: [analyzer] Fix symbol simplification assertion failure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf75bc5bfc8f8: [analyzer] Fix symbol simplification assertion failure (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 0d7f8d4 - [OpenCL] Remove argument names from async copy builtins

Author: Sven van Haastregt Date: 2022-05-25T10:05:25+01:00 New Revision: 0d7f8d42fd170a434006a928a7106b894bdbdd16 URL: https://github.com/llvm/llvm-project/commit/0d7f8d42fd170a434006a928a7106b894bdbdd16 DIFF: https://github.com/llvm/llvm-project/commit/0d7f8d42fd170a434006a928a7106b894bdbdd16.

[clang-tools-extra] cd2292e - [pseudo] A basic implementation of compiling cxx grammar at build time.

Author: Haojian Wu Date: 2022-05-25T11:26:06+02:00 New Revision: cd2292ef824591cc34cc299910a3098545c840c7 URL: https://github.com/llvm/llvm-project/commit/cd2292ef824591cc34cc299910a3098545c840c7 DIFF: https://github.com/llvm/llvm-project/commit/cd2292ef824591cc34cc299910a3098545c840c7.diff LO

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2292ef8245: [pseudo] A basic implementation of compiling cxx grammar at build time. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D125667?vs=431746&id=431917#toc Repository:

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

khchen added inline comments. Comment at: clang/lib/Sema/SemaRVVLookup.cpp:175 + for (auto &Record : RVVIntrinsicRecords) { +// Create Intrinsics for each type and LMUL. +BasicType BaseType = BasicType::Unknown; Those code logic need to sync with createR

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431919. mboehme added a comment. Changes in response to review comments. One major change is that Declaration now has a reference to the declaration attributes instead of owning them by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431921. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Files: clang/include/clang/Basic/AttributeC

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431923. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Files: clang/include/clang/Basic/AttributeC

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 431924. balazske edited the summary of this revision. balazske added a comment. fixed some problems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/li

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff created this revision. sepavloff added reviewers: aaron.ballman, andrew.w.kaylor, rjmccall, efriedma, kpn. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Previously `#pragma STDC FENV_ACCESS ON` always set dynamic rounding mode a

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 431928. tbaeder added a comment. @MaskRay Ignored the new test on Windows hosts now like you suggested. Does this look good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolC

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431929. mboehme marked 2 inline comments as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Fil

[clang-tools-extra] f1df651 - [pseudo] Add missing dependency, fix shared library build.

Author: Haojian Wu Date: 2022-05-25T12:38:23+02:00 New Revision: f1df6515e3fe54f688739927c57cb6adec01c307 URL: https://github.com/llvm/llvm-project/commit/f1df6515e3fe54f688739927c57cb6adec01c307 DIFF: https://github.com/llvm/llvm-project/commit/f1df6515e3fe54f688739927c57cb6adec01c307.diff LO

[PATCH] D126291: [flang][Driver] Update link job on windows

kiranchandramohan added a comment. @rovka in case you missed this, the test is failing in windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126291/new/ https://reviews.llvm.org/D126291 ___ cfe-commi

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders updated this revision to Diff 431933. wanders added a comment. Diff updated to be git-clang-format clean and to (hopefully) accommodate for differences in test output on w64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126324/new/ https:

[PATCH] D126365: [clang-format] Stop ignoring changes for files with space in path

Eitot created this revision. Eitot added a project: clang-format. Herald added a project: All. Eitot requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `git-clang-format` does not format files with spaces in their path. % git diff -p -U0

[PATCH] D126365: [clang-format] Stop ignoring changes for files with space in path

curdeius added a comment. Would it be possible to add a test please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126365/new/ https://reviews.llvm.org/D126365 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D126358: clang-format][NFC] Refactor UnwrappedLineParser::parseBlock()

curdeius added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:874 - if (SimpleBlock && !KeepBraces) { + auto RemoveBraces = [=]() mutable { +if (KeepBraces || !SimpleBlock) Are there many captures here? Wouldn't it be better to be e

[PATCH] D125679: [Clang] Added options for integrated backend only used for SPIR-V for now

This revision was automatically updated to reflect the committed changes. Closed by commit rG730dc4e9bce8: [Clang] Added options for integrated backend. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D125679?vs=429676&id=431938#toc Rep

[clang] 730dc4e - [Clang] Added options for integrated backend.

Author: Anastasia Stulova Date: 2022-05-25T12:07:33+01:00 New Revision: 730dc4e9bce8189c037a32e520d18b141250d265 URL: https://github.com/llvm/llvm-project/commit/730dc4e9bce8189c037a32e520d18b141250d265 DIFF: https://github.com/llvm/llvm-project/commit/730dc4e9bce8189c037a32e520d18b141250d265.d

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

aaron.ballman added a comment. The changes so far look sensible, but I think we should add some more tests for a few situations. 1) Using a const weak symbol as a valid initializer should be diagnosed (with a warning? with an error?) so users are alerted to the behavioral quirks. 2) Using a con

[PATCH] D126369: [LLVM] Add rcp.approx.ftz.f32 intrinsic

csigg created this revision. csigg added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic, sanjoy.google, hiraditya. Herald added a project: All. csigg requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jholewinski. Herald add

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg added a comment. In D126158#3534750 , @tra wrote: > I would suggest separating it into separate LLVM and MLIR patches. Thanks Artem. I separated out the LLVM changes in https://reviews.llvm.org/D126369. Repository: rG LLVM Github Monorepo CHA

[PATCH] D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

njames93 updated this revision to Diff 431945. njames93 added a comment. Add note to docs that this new option has no effect if SimplifyDeMorgan is false. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126162/new/ https://reviews.llvm.org/D126162

[clang-tools-extra] f3c1d28 - [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

Author: Nathan James Date: 2022-05-25T13:09:00+01:00 New Revision: f3c1d281767a5849b9f3e712e3c3406bd9410c81 URL: https://github.com/llvm/llvm-project/commit/f3c1d281767a5849b9f3e712e3c3406bd9410c81 DIFF: https://github.com/llvm/llvm-project/commit/f3c1d281767a5849b9f3e712e3c3406bd9410c81.diff

[PATCH] D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3c1d281767a: [clang-tidy] Extend SimplifyBooleanExpr demorgan support. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D102122: Support warn_unused_result on typedefs

aaron.ballman added a comment. Thank you for the ping, this fell entirely off my radar! In D102122#3344317 , @dblaikie wrote: > I don't recall all the context, but did try discussing this with the > committee folks and got a variety of strong opinions/w

[clang-tools-extra] 09ef6da - [clang-tidy] Update docs for SimplifyDeMorganRelaxed

Author: Nathan James Date: 2022-05-25T13:12:20+01:00 New Revision: 09ef6da8dcd848258c9f876ba9298c7db0d589a9 URL: https://github.com/llvm/llvm-project/commit/09ef6da8dcd848258c9f876ba9298c7db0d589a9 DIFF: https://github.com/llvm/llvm-project/commit/09ef6da8dcd848258c9f876ba9298c7db0d589a9.diff

[clang] f96aa83 - Test C DR conformance (part three of many)

Author: Aaron Ballman Date: 2022-05-25T08:18:16-04:00 New Revision: f96aa834d7d77bb875d5bb727b89ab4af7940a0c URL: https://github.com/llvm/llvm-project/commit/f96aa834d7d77bb875d5bb727b89ab4af7940a0c DIFF: https://github.com/llvm/llvm-project/commit/f96aa834d7d77bb875d5bb727b89ab4af7940a0c.diff

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme updated this revision to Diff 431948. mboehme marked 30 inline comments as done. mboehme added a comment. Changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 Fi

[PATCH] D126373: [pseudo-gen] Add -o flag, make --grammar required

thakis created this revision. thakis added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. thakis requested review of this revision. Herald added a project: clang-tools-extra. Virtually all LLVM tools accept a `-o` flag, so add one. This will make it possible to

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme marked 6 inline comments as done. mboehme added a comment. Thank you @rsmith and @aaron.ballman for the detailed review comments! I hope I've addressed everything -- do let me know if there's anything I've missed. In D126061#3528966 , @rsmith wr

[PATCH] D126373: [pseudo-gen] Add -o flag, make --grammar required

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126373/new/ https://reviews.llvm.org/D126373 ___ cfe-commits mailing list cfe-commit

[clang-tools-extra] 788463e - [pseudo-gen] Add -o flag, make --grammar required

Author: Nico Weber Date: 2022-05-25T09:11:42-04:00 New Revision: 788463e72af847d11476793fdd5d57a104b18b3d URL: https://github.com/llvm/llvm-project/commit/788463e72af847d11476793fdd5d57a104b18b3d DIFF: https://github.com/llvm/llvm-project/commit/788463e72af847d11476793fdd5d57a104b18b3d.diff LO

[PATCH] D126373: [pseudo-gen] Add -o flag, make --grammar required

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG788463e72af8: [pseudo-gen] Add -o flag, make --grammar required (authored by thakis). Changed prior to commit: https://reviews.llvm.org/D126373?vs

[clang] c673d67 - [AST] Dont invalidate a ref-type var decl if it has no initializer.

Author: Haojian Wu Date: 2022-05-25T15:14:35+02:00 New Revision: c673d67bc76bfa31b78e3eee23899b9f262158ea URL: https://github.com/llvm/llvm-project/commit/c673d67bc76bfa31b78e3eee23899b9f262158ea DIFF: https://github.com/llvm/llvm-project/commit/c673d67bc76bfa31b78e3eee23899b9f262158ea.diff LO

[PATCH] D122935: [AST] Dont invalidate a ref-type var decl if it has no initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc673d67bc76b: [AST] Dont invalidate a ref-type var decl if it has no initializer. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122935/

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5596 + DefaultedSMFArePOD = false; + } + Does this mean `-fclang-abi-compat` will override the PS4/Darwin special case? I think we don't want to do that. Repository: rG

[clang] a17fc7f - Fix unused-variable warning, NFC.

Author: Haojian Wu Date: 2022-05-25T15:25:03+02:00 New Revision: a17fc7fd865096f4be6b8b4a7e6e0834aae6c048 URL: https://github.com/llvm/llvm-project/commit/a17fc7fd865096f4be6b8b4a7e6e0834aae6c048 DIFF: https://github.com/llvm/llvm-project/commit/a17fc7fd865096f4be6b8b4a7e6e0834aae6c048.diff LO

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

nikic added a comment. Looks reasonable to me, but probably @MaskRay should review. We could add a `-fno-opaque-pointers` driver option that covers both the compiler backend and LTO, but we can probably get away without it as well. Comment at: lld/ELF/Options.td:311 + "Use o

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

Eitot added a comment. In D126365#3536736 , @curdeius wrote: > Would it be possible to add a test please? Could you tell me what kind of test you would like me to add? I have edited the description above to include my result. I can add a basic shell scr

[clang] d8dda57 - [PS5] Default to -fno-rtti

Author: Paul Robinson Date: 2022-05-25T06:48:21-07:00 New Revision: d8dda57ae7798a052e52ef5979980e815d2e4bc5 URL: https://github.com/llvm/llvm-project/commit/d8dda57ae7798a052e52ef5979980e815d2e4bc5 DIFF: https://github.com/llvm/llvm-project/commit/d8dda57ae7798a052e52ef5979980e815d2e4bc5.diff

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby added a comment. In D124860#3533878 , @c-rhodes wrote: > can the diagnostics improvements be broke out into separate patches? I think > it would make this easier to review I've split the diagnostic changes from this out as D126377

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong updated this revision to Diff 431970. martong added a comment. - Fix Assertion `*Solver->getSort(LHS) == *Solver->getSort(RHS) && "AST's must have the same sort!"' failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://r

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

saiislam updated this revision to Diff 431975. saiislam added a comment. Changed the embedding scheme to add ImageInfo field in __tgt_device_image. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124525/new/ https://reviews.llvm.org/D124525 Files:

[PATCH] D125604: [FileCheck] Catch missspelled directives.

kosarev updated this revision to Diff 431979. kosarev added a comment. Rebased on top of fixes for non-trivial cases. Going to submit this tomorrow, if no objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.or

[PATCH] D124081: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme added a comment. It appears that we are converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124081/new/ https://reviews.llvm.org/D124081 __

[PATCH] D124083: [clang] [WIP] Reject C++ 11 attributes appertaining to the wrong entity type.

mboehme abandoned this revision. mboehme added a comment. It appears that we're converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124083/new/ https://review

[PATCH] D124919: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

mboehme abandoned this revision. mboehme added a comment. It appears that we're converging on the approach in https://reviews.llvm.org/D126061, so I'm abandoning this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124919/new/ https://reviews.llvm.org/D124919 ___

[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. LGTM but please get a second approval before submitting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101471/new/ https://reviews.llvm.org/D10147

[PATCH] D126380: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby created this revision. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. DavidTruby requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch all

[PATCH] D124860: [clang][AArch64][SVE] Implicit conversions for vector-scalar operations

DavidTruby abandoned this revision. DavidTruby added a comment. I've resubmitted this split from the diagnostic changes as D126380 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124860/new/ https://reviews.llvm.or

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

steakhal accepted this revision. steakhal added a comment. I think it looks greatt There are a couple questions you need to think about, but I don't insist about changing anything if the code works passed widescale testing. Comment at: clang/include/clang/StaticAnalyzer/Core/P

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

jyknight added a comment. In D126324#3536785 , @aaron.ballman wrote: > The changes so far look sensible, but I think we should add some more tests > for a few situations. 1) Using a const weak symbol as a valid initializer > should be diagnosed (with a

[PATCH] D124758: [analyzer] Implement assume in terms of assumeDual

steakhal added a comment. This commit introduced a serious runtime regression on this code: #define DEMONSTRATE_HANG typedef unsigned char uint8_t; typedef unsigned short uint16_t; typedef unsigned long uint64_t; void clang_analyzer_numTimesReached(void); int filter_slice_wor

[PATCH] D125788: [flang][driver] Rename `flang-new` as `flang`

kiranchandramohan added a comment. In D125788#3535199 , @sscalpone wrote: > My proposal is: > > If the compiler compiles it, it ought to run. > If the compiler can't compile it, it ought to clearly say why. > > 1. All tests of legal Fortran that compile &

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

wanders added a comment. In D126324#3536785 , @aaron.ballman wrote: > The changes so far look sensible, but I think we should add some more tests > for a few situations. 1) Using a const weak symbol as a valid initializer > should be diagnosed (with a

[clang] 6f4644d - [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

Author: Martin Boehme Date: 2022-05-25T17:15:41+02:00 New Revision: 6f4644d194da594562027a5d458d9fb7a20ebc39 URL: https://github.com/llvm/llvm-project/commit/6f4644d194da594562027a5d458d9fb7a20ebc39 DIFF: https://github.com/llvm/llvm-project/commit/6f4644d194da594562027a5d458d9fb7a20ebc39.diff

[PATCH] D126062: [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f4644d194da: [clang] Don't parse MS attributes in `ParseExportDeclaration()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126062/ne

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

kda added a comment. This has broken sanitizer buildbot: https://lab.llvm.org/buildbot/#/builders/5/builds/24074 Relevant log snippet: FAIL: Clang :: OpenMP/atomic_messages.cpp (9696 of 66080) TEST 'Clang :: OpenMP/atomic_messages.cpp' FAILED Scri

[PATCH] D125904: [Cuda] Use fallback method to mangle externalized decls if no CUID given

jhuber6 added a comment. Also, for the OpenMP case, we already pass the host-IR as a dependency for the device compilation. So it would be relatively easy for us to just generate these names on the host and then read them from the IR for the device. The problem is that CUDA / HIP doesn't use th

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

herhut added inline comments. Comment at: mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp:158 +// by the same divisor. +struct ExpandDivF16 : public ConvertOpToLLVMPattern { + using ConvertOpToLLVMPattern::ConvertOpToLLVMPattern; This pattern is a bit mis

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

jhuber6 added a comment. Where is the code to change the target registration? We need a new initialization runtime call to use and change the old one to reallocate the `__tgt_device_image` array. Did you work around that some other way? Comment at: clang/tools/clang-linker-wr

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h:463 + // has a different type than the unary itself. + if (OperandTy != Sym->getType()) { +if (hasComparison) ---

[PATCH] D125547: [analyzer][solver] Handle UnarySymExpr in SMTConv

martong updated this revision to Diff 432019. martong marked an inline comment as done. martong added a comment. - Compare the size of the types instead of the type pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125547/new/ https://reviews.

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

aaron.ballman added a comment. In D126324#3537282 , @jyknight wrote: > In D126324#3536785 , @aaron.ballman > wrote: > >> The changes so far look sensible, but I think we should add some more tests >> for a few s

[PATCH] D125291: Introduce @llvm.threadlocal.address intrinsic to access TLS variable (1/3)

wenlei added a subscriber: weiwang. wenlei added a comment. +@weiwang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125291/new/ https://reviews.llvm.org/D125291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432023. python3kgae added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp clang/test/C

[PATCH] D126324: [clang] Allow const variables with weak attribute to be overridden

aaron.ballman added a comment. In D126324#3537373 , @wanders wrote: > In D126324#3536785 , @aaron.ballman > wrote: > >> The changes so far look sensible, but I think we should add some more tests >> for a few si

[PATCH] D125814: Improve the strict prototype diagnostic behavior

aaron.ballman updated this revision to Diff 432020. aaron.ballman added a comment. Update based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125814/new/ https://reviews.llvm.org/D125814 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/Sema

[PATCH] D125814: Improve the strict prototype diagnostic behavior

aaron.ballman added a comment. In D125814#3535452 , @jyknight wrote: > Good improvement, but an additional change to wording for just the zero-arg > non-prototype function declaration case could help a lot. The fact that > zero-arg it's only being warne

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added subscribers: cchen, dreachem, tianshilei1992, jdoerfert, soumitra. koops added a comment. Hello Kevin, I am not sure why it is indicating an uninitialized variable at that point. The code at " llvm-project/clang/lib/Sema/SemaOpenMP.cpp:12060 " is as below: for (const OMPClause *C

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. This breaks cross-compilation, because we're building `pseudo-gen` for the target but then trying to run it on the build machine. You'll need to do something like TableGen does (see https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/CrossCompile.cmake an

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. In D123235#3537580 , @koops wrote: > I am not sure why it is indicating an uninitialized variable at that point. > The code at " llvm-project/clang/lib/Sema/SemaOpenMP.cpp:12060 " is as below: FWIW, it's outright crashing

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

sammccall added a comment. I'll see if I can fix it quickly, else will revert (there are a couple of fixes stacked on top already, so revert isn't quite clean) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125667/new/ https://reviews.llvm.org/D125

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. Adding the language WG as a reviewer in case others have opinions. > The underlying problem is basically wg21.link/cwg362 which has no concensus > yet. According to https://www.open-std.org/jtc1/sc22/wg21/docs/cwg

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. In D125667#3537655 , @sammccall wrote: > I'll see if I can fix it quickly, else will revert (there are a couple of > fixes stacked on top already, so revert isn't quite clean) Thank you! I'll have some time to look at this a bit

[PATCH] D126170: C++ DR2394: Const-default-constructible for members.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (minor nit with release notes, take it or leave it at your discretion). Comment at: clang/docs/ReleaseNotes.rst:155 This fixes Issue `Issue 54881

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai created this revision. smeenai added reviewers: hokein, sammccall. Herald added a subscriber: mgorny. Herald added a project: All. smeenai requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. Use the LLVM build s

[PATCH] D125667: [pseudo] A basic implementation of compiling cxx grammar at build time.

smeenai added a comment. In D125667#3537678 , @smeenai wrote: > In D125667#3537655 , @sammccall > wrote: > >> I'll see if I can fix it quickly, else will revert (there are a couple of >> fixes stacked on top alr

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

dang added a comment. In D125678#3517174 , @zixuw wrote: > In D125678#3517168 , > @QuietMisdreavus wrote: > >> clang-format failed: >> >> --- clang-format >> >> changed files: >> >> clang/test/Ex

[PATCH] D126084: [Sema] Reject implicit conversions between different scoped enum types in list initialization

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. Please add more details to the summary and remove the rdar link (nobody outside of Apple can access that anyway). Also, this should have a release note for the bug fix. Comment at: clang/lib/Sem

[PATCH] D126398: [Clang] Introduce `-dl` option to perform offload device linking

jhuber6 created this revision. jhuber6 added reviewers: MaskRay, jdoerfert, yaxunl, tra. Herald added a subscriber: StephenFan. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The new driver use

[PATCH] D126369: [LLVM] Add rcp.approx.ftz.f32 intrinsic

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Do you need me to land it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126369/new/ https://reviews.llvm.org/D126369 _

[clang] 8a1984c - [Clang][Docs] Document `-Xoffload-linker` flag

Author: Joseph Huber Date: 2022-05-25T13:33:10-04:00 New Revision: 8a1984c25e2c982a9388c14bdaf99bdcd3e26bd4 URL: https://github.com/llvm/llvm-project/commit/8a1984c25e2c982a9388c14bdaf99bdcd3e26bd4 DIFF: https://github.com/llvm/llvm-project/commit/8a1984c25e2c982a9388c14bdaf99bdcd3e26bd4.diff

[clang] ba3f853 - [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

Author: Mike Rice Date: 2022-05-25T10:34:07-07:00 New Revision: ba3f85390bde10eab1cbdb68f744b8f5ab31859b URL: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b DIFF: https://github.com/llvm/llvm-project/commit/ba3f85390bde10eab1cbdb68f744b8f5ab31859b.diff LOG

[clang] 69da3b6 - Revert "[OpenMP] atomic compare fail : Parser & AST support"

Author: Aaron Ballman Date: 2022-05-25T13:34:34-04:00 New Revision: 69da3b6aead2e7a18a2578aad661d6d36b8d30cf URL: https://github.com/llvm/llvm-project/commit/69da3b6aead2e7a18a2578aad661d6d36b8d30cf DIFF: https://github.com/llvm/llvm-project/commit/69da3b6aead2e7a18a2578aad661d6d36b8d30cf.diff

[PATCH] D126331: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target'

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3f85390bde: [OpenMP] Add diagnostic for unterminated 'omp [begin] declare target' (authored by mikerice). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. In D123235#3537636 , @aaron.ballman wrote: > Please revert the changes while investigating how to resolve the crashes > though. I just noticed that you needed someone to commit on your behalf for this, so I went ahead an

[PATCH] D123924: [clang-apply-replacements] Added an option to ignore insert conflict.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this has sat for long enough and my LGTM will have to suffice. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123924/new/ https://reviews.llvm.org/D123924 __

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! I have been banging my head against this, I'm not entirely sure why this works and my version doesn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D126397: [pseudo] Fix pseudo-gen usage when cross-compiling

smeenai added a comment. In D126397#3537843 , @sammccall wrote: > Thank you! I have been banging my head against this, I'm not entirely sure > why this works and my version doesn't. Ah, sorry for the duplicated work :( Thanks for the review! Repositor

[PATCH] D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order

ychen added a comment. In D126341#3537675 , @aaron.ballman wrote: > Adding the language WG as a reviewer in case others have opinions. > >> The underlying problem is basically wg21.link/cwg362 which has no concensus >> yet. > > According to > https://w

[clang] 9368bf9 - Removing this as part of the revert done in 69da3b6aead2e7a18a2578aad661d6d36b8d30cf

Author: Aaron Ballman Date: 2022-05-25T13:45:17-04:00 New Revision: 9368bf9023eee0dc6fcfa007e157fe30e1540fcc URL: https://github.com/llvm/llvm-project/commit/9368bf9023eee0dc6fcfa007e157fe30e1540fcc DIFF: https://github.com/llvm/llvm-project/commit/9368bf9023eee0dc6fcfa007e157fe30e1540fcc.diff

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. In D123235#3537820 , @aaron.ballman wrote: > In D123235#3537636 , @aaron.ballman > wrote: > >> Please revert the changes while investigating how to resolve the crashes >> though.

  1   2   >