aaron.ballman added a comment.

In D125814#3535452 <https://reviews.llvm.org/D125814#3535452>, @jyknight wrote:

> Good improvement, but an additional change to wording for just the zero-arg 
> non-prototype function declaration case could help a lot. The fact that 
> zero-arg it's only being warned about because of the "...because of" note 
> isn't particularly clear -- especially when the "because of" isn't emitted.
>
> So, suggestion for zero-arg-specific warning text:

Thanks for the suggestion! I've implemented something along these lines in this 
patch and I think the diagnostics are better this way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125814/new/

https://reviews.llvm.org/D125814

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to