[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125635: Make CompoundStmtBitfields::NumStmts not a bit-field

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125635/new/ https://reviews.llvm.org/D125635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] 5537b22 - Make CompoundStmtBitfields::NumStmts not a bit-field

Author: Serge Pavlov Date: 2022-05-20T14:20:09+07:00 New Revision: 5537b22ccbdc562929949844f9f816cf720e5205 URL: https://github.com/llvm/llvm-project/commit/5537b22ccbdc562929949844f9f816cf720e5205 DIFF: https://github.com/llvm/llvm-project/commit/5537b22ccbdc562929949844f9f816cf720e5205.diff

[PATCH] D125635: Make CompoundStmtBitfields::NumStmts not a bit-field

This revision was automatically updated to reflect the committed changes. Closed by commit rG5537b22ccbdc: Make CompoundStmtBitfields::NumStmts not a bit-field (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125635/new/ https:

[PATCH] D107082: [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430897. pengfei added a comment. Adjust libcall lowering according to GCC code generation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107082/new/ https://reviews.llvm.org/D107082 Files: llvm/docs/ReleaseN

[clang] 83c431f - [amdgpu] Add amdgpu_kernel calling conv attribute to clang

Author: Jon Chesterfield Date: 2022-05-20T08:50:37+01:00 New Revision: 83c431fb9e72abbd2eddf26388245eb4963370e2 URL: https://github.com/llvm/llvm-project/commit/83c431fb9e72abbd2eddf26388245eb4963370e2 DIFF: https://github.com/llvm/llvm-project/commit/83c431fb9e72abbd2eddf26388245eb4963370e2.di

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83c431fb9e72: [amdgpu] Add amdgpu_kernel calling conv attribute to clang (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

nikic added inline comments. Comment at: llvm/include/llvm/LTO/Config.h:182 + /// unless already set by the `-opaque-pointers` commandline option. + bool OpaquePointers = false; + The default should be true here and for the LLD/LLVMgold flags, to match the Cla

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4861 + ToUsingPack->setLexicalDeclContext(LexicalDC); + LexicalDC->addDeclInternal(ToUsingPack); + Why don't we use `addDeclToContexts`? Comment at: clang/unittests/AST/

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. A clangd buildbot (https://lab.llvm.org/buildbot/#/builders/131/builds/27770) failed on this with [ RUN ] SerializationTest.NoCrashOnBadArraySize ==384111==ERROR: ThreadSanitizer failed to allocate 0x1 (65536) bytes of stack depot (error code: 12)

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

kito-cheng updated this revision to Diff 430911. kito-cheng added a comment. Changes: - Apply @craig.topper's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893 Files: clang/include/clang/Supp

[clang] 632cfbc - [NFC][test] Fix the line num of expected-error for CSKY at builtin-alloca-with-align.c

Author: Zi Xuan Wu Date: 2022-05-20T16:54:23+08:00 New Revision: 632cfbc9f933afc9956f7e0b26086fb1cb7294b5 URL: https://github.com/llvm/llvm-project/commit/632cfbc9f933afc9956f7e0b26086fb1cb7294b5 DIFF: https://github.com/llvm/llvm-project/commit/632cfbc9f933afc9956f7e0b26086fb1cb7294b5.diff LO

[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

fhahn added a comment. Thanks for breaking this up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121093/new/ https://reviews.llvm.org/D121093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not remove

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops updated this revision to Diff 430933. koops added a comment. changes to support clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 Files: clang/lib/Basic/OpenMPKinds.cpp clang/lib/Parse/ParseOpenMP.cpp clang/test/OpenMP/

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3513797 , @tianshilei1992 wrote: > Can we have test for right usage? I do not understand "test for right usage". From the specifications the only right usage for "omp nothing" will be in the metadirective. If you have

[PATCH] D126052: [clang-format] Handle "complex" conditionals in RemoveBracesLLVM

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126052/new/ https://reviews.llvm.org/D126052 ___

[PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

aaron.ballman added a comment. In D123667#3524711 , @aaron.ballman wrote: > In D123667#3524614 , @tcanabrava > wrote: > >> This affects all released versions of llvm14, and potentially llvm13 too (I >> got a cr

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth added a comment. friendly ping :) (maybe @njames93 ?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D126061: [clang] [WIP] Reject non-declaration C++11 attributes on declarations

mboehme created this revision. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. mboehme requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. (

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { rsmith wrote: > mboehme wrote: > > rsmith wrote: > > > mboehme wrote: > > > > aaron.ballman wrote: > > > > > m

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

mboehme added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { mboehme wrote: > rsmith wrote: > > mboehme wrote: > > > rsmith wrote: > > > > mboehme wrote: > > > > > aaron.b

[PATCH] D125961: [clang-format] Don't break lines after pragma region

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Thanks for the patch! Could you please add a unit test in unittest/Format/FormatTest.cpp instead of in lit-based test/? Is there a bug report that your patch fixes? ===

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta added a comment. In D125961#3527447 , @curdeius wrote: > Thanks for the patch! > Could you please add a unit test in unittest/Format/FormatTest.cpp instead of > in lit-based test/? > Is there a bug report that your patch fixes? Sure - I didn't kn

[PATCH] D126062: [clang] Don't parse MS attributes in `ParseExportDeclaration()`.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As @rsmith commented on https://reviews.llvm.org/D111548: "That looks like it's simply a bug as far as I can tell, and that

Re: [PATCH] D123667: [clang][AST] Fix crash getting name of a template decl

thank you, this is really appreciated. On Fri, May 20, 2022 at 12:32 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D123667#3524711 , > @aaron.ballman wrote: > > > In D123667#3524614

[PATCH] D125961: [clang-format] Don't break lines after pragma region

curdeius added a comment. In D125961#3527452 , @thieta wrote: > In D125961#3527447 , @curdeius > wrote: > >> Thanks for the patch! >> Could you please add a unit test in unittest/Format/FormatTest.cpp instead >>

[clang-tools-extra] 5b0022a - [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

Author: Haojian Wu Date: 2022-05-20T14:54:17+02:00 New Revision: 5b0022a9df3f3a35661f71b23a66c667e8501c32 URL: https://github.com/llvm/llvm-project/commit/5b0022a9df3f3a35661f71b23a66c667e8501c32 DIFF: https://github.com/llvm/llvm-project/commit/5b0022a9df3f3a35661f71b23a66c667e8501c32.diff LO

[PATCH] D125684: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG5b0022a9df3f: [clangd] Support UnresolvedUsingTypeLoc AST node in FindTarget. (authored by hokein). Changed

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3526810 , @ChuanqiXu wrote: > In D119544#3494281 , @erichkeane > wrote: > >> Updated to include the fix for the libcxx issue, which was that we weren't >> properly differen

[PATCH] D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430953. thieta added a comment. Switched to unit test over lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/FormatToken.h clang/lib

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430954. thieta added a comment. Removed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotat

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

ymandel added a comment. In D125931#3525699 , @xazax.hun wrote: > Actually, I think in most cases we want to be consistent on how to merge bool > values. So I wonder whether instead of reimplementing the merge operation in > this check we should just ca

[PATCH] D125961: [clang-format] Don't break lines after pragma region

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 __

[clang] 0ef7ca8 - Fix test from df2a4e to work with 32 bit windows targets.

Author: Erich Keane Date: 2022-05-20T06:21:52-07:00 New Revision: 0ef7ca86cf1e28d91113dcf834a61ad155dbb7cb URL: https://github.com/llvm/llvm-project/commit/0ef7ca86cf1e28d91113dcf834a61ad155dbb7cb DIFF: https://github.com/llvm/llvm-project/commit/0ef7ca86cf1e28d91113dcf834a61ad155dbb7cb.diff L

[libunwind] 422ec52 - [libunwind] Introduce a cmake-bridge.cfg.in file to reduce test config duplication

Author: Louis Dionne Date: 2022-05-20T09:36:29-04:00 New Revision: 422ec524388b524f48d49fccd436105bb848f833 URL: https://github.com/llvm/llvm-project/commit/422ec524388b524f48d49fccd436105bb848f833 DIFF: https://github.com/llvm/llvm-project/commit/422ec524388b524f48d49fccd436105bb848f833.diff

[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

frederic-tingaud-sonarsource added a comment. @rnk Here is the test case that was broken: https://godbolt.org/z/Gef7PcqMf One point where I was wrong in my initial analysis is that the behavior doesn't actually change based on `/std:c++17` VS `/std:c++latest`, but based on `/permissive` VS `/pe

[clang] ae80024 - [clang] Honor __attribute__((no_builtin("foo"))) on functions

Author: Stephen Long Date: 2022-05-20T06:41:47-07:00 New Revision: ae80024fbe51339afabfa2ff43ae532356fa3c93 URL: https://github.com/llvm/llvm-project/commit/ae80024fbe51339afabfa2ff43ae532356fa3c93 DIFF: https://github.com/llvm/llvm-project/commit/ae80024fbe51339afabfa2ff43ae532356fa3c93.diff

[PATCH] D124701: [clang] Honor __attribute__((no_builtin("foo"))) on functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGae80024fbe51: [clang] Honor __attribute__((no_builtin("foo"))) on functions (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124701/new

[PATCH] D126066: [clang] Don't plumb access specifier attributes through Parser unnecessarily.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. I noticed that a lot of functions in the parser take an `AccessAttrs` parameter

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. > The primary application is for more rapid debugging of the amdgpu backend by > permuting a C or C++ test file instead of manually updating an IR file. Given that this is adding a calling convention, which has significant impacts on our type system: is this use c

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

aaron.ballman added a comment. In D125970#3527624 , @aaron.ballman wrote: >> The primary application is for more rapid debugging of the amdgpu backend by >> permuting a C or C++ test file instead of manually updating an IR file. > > Given that this is a

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal created this revision. steakhal added reviewers: NoQ, martong, Szelethus. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal requested review

[PATCH] D125893: [RISCV][NFC] Change interface of RVVIntrinsic::getSuffixStr

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125893/new/ https://reviews.llvm.org/D125893 ___

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

steakhal added a comment. In D125920#3524586 , @martong wrote: > LGTM. Are there any other `getPersistentLoc` function definitions in other > SVals? Might they be also unused? IDK, might be. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D125920: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

This revision was automatically updated to reflect the committed changes. Closed by commit rG5450db5f54b8: [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc() (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125920

[clang] 5450db5 - [analyzer][NFC] Remove the unused LocAsInteger::getPersistentLoc()

Author: Balazs Benics Date: 2022-05-20T16:06:46+02:00 New Revision: 5450db5f54b86f908ce67cb681fbdf86b88abc54 URL: https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54 DIFF: https://github.com/llvm/llvm-project/commit/5450db5f54b86f908ce67cb681fbdf86b88abc54.diff

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

steakhal marked an inline comment as done. steakhal added a comment. WDYT, are there any blocker issues with this patch stack? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209 _

[clang] 749fb33 - [clang-format] Don't break lines after pragma region

Author: Tobias Hieta Date: 2022-05-20T16:11:20+02:00 New Revision: 749fb33e82ff19d656af9c9205f3ac81c1ce52d8 URL: https://github.com/llvm/llvm-project/commit/749fb33e82ff19d656af9c9205f3ac81c1ce52d8 DIFF: https://github.com/llvm/llvm-project/commit/749fb33e82ff19d656af9c9205f3ac81c1ce52d8.diff

[PATCH] D125961: [clang-format] Don't break lines after pragma region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG749fb33e82ff: [clang-format] Don't break lines after pragma region (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

steakhal added a comment. There is one minor problem with this patch. At `SVal` member function's context one needs to call `llvm::isa<...>()` with by the qualified name, otherwise, the `isa` is ambiguous. The compiler won't know if we want to refer to the free-function or the variadic member f

[PATCH] D125970: [amdgpu] Add amdgpu_kernel calling conv attribute to clang

JonChesterfield added a comment. If it was adding a calling convention, sure - caution warranted. There's no llvm change here though, an existing CC is exposed to C++. No change to the type system either. I'll propose a patch with some documentation for it if you wish, but it'll just say "For

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. > However, this arises a couple of burning questions. > > Should the cc1 frontend still accept this flag - to keep tools/users passing > this flag directly to cc1 (which is unsupported, unadv

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

martong added a comment. Uhh, ohh, don't forget to reflect this change in the ReleaseNotes.rst, so urers will be notified! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067

[PATCH] D125931: [clang][dataflow] Add support for correlated branches to optional model

xazax.hun added a comment. In D125931#3527584 , @ymandel wrote: > 1. In this patch, we go with a widening operation, but put the relevant logic > in the core, so it can be reused for booleans in general. Depending on how much simplicity are we willing t

[PATCH] D126068: [llvm][clang][bolt][NFC] Use llvm::less_first() when applicable

steakhal created this revision. steakhal added reviewers: aaron.ballman, lattner. Herald added subscribers: ayermolo, jdoerfert, martong, mgrang, hiraditya. Herald added a reviewer: JDevlieghere. Herald added a reviewer: jhenderson. Herald added a reviewer: Szelethus. Herald added a reviewer: rafau

[PATCH] D126065: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedc7a0814575: [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs (authored by sammccall). Changed prior to commit: https://r

[clang-tools-extra] edc7a08 - [clangd] Provide links to clang-tidy and include-cleaner diagnostic docs

Author: Sam McCall Date: 2022-05-20T16:33:48+02:00 New Revision: edc7a0814575002abecb8ac7b49c669bf5f5ab7a URL: https://github.com/llvm/llvm-project/commit/edc7a0814575002abecb8ac7b49c669bf5f5ab7a DIFF: https://github.com/llvm/llvm-project/commit/edc7a0814575002abecb8ac7b49c669bf5f5ab7a.diff LO

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman updated this revision to Diff 430974. dgoldman marked an inline comment as done. dgoldman added a comment. Go through chunks in getName and add missed FilterText place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/ https://revie

[PATCH] D126067: [analyzer] Drop the unused 'analyzer-opt-analyze-nested-blocks' cc1 flag

steakhal updated this revision to Diff 430978. steakhal added a comment. Mention this removal in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126067/new/ https://reviews.llvm.org/D126067 Files: clang-tools-extra/clang-tidy/Cl

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 430979. steplong added a comment. The assembly for LLVM now looks like: __writex18byte: strbw1, [x18, w0, uxtw] ret __writex18word: strhw1, [x18, w0, uxtw]

[PATCH] D107082: [X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI

pengfei updated this revision to Diff 430985. pengfei retitled this revision from "[X86][RFC] Enable `_Float16` type support on X86 following the psABI" to "[X86][RFC][WIP] Enable `_Float16` type support on X86 following the psABI". pengfei added a comment. Fix a few minor issues. I think it's m

[PATCH] D125773: [Driver] Do not auto-enable header modules with -std=c++20

ilya-biryukov added a comment. In D125773#3525215 , @tahonermann wrote: >> So the proposal is that -fheader-modules=parse would parse #include of >> header unit in the same TU, and import .pcm on import, right? > > Per cpp.includep7

[clang-tools-extra] 322e2a3 - [clangd][ObjC] Filter ObjC method completions on the remaining selector

Author: David Goldman Date: 2022-05-20T11:49:16-04:00 New Revision: 322e2a3b40fa5f6bfcb868e827960c812b185710 URL: https://github.com/llvm/llvm-project/commit/322e2a3b40fa5f6bfcb868e827960c812b185710 DIFF: https://github.com/llvm/llvm-project/commit/322e2a3b40fa5f6bfcb868e827960c812b185710.diff

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322e2a3b40fa: [clangd][ObjC] Filter ObjC method completions on the remaining selector (authored by dgoldman). Repository: rG LLVM Github Monorepo

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske added a reviewer: martong. balazske added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/AST/ASTImporter.cpp:4861 + ToUsingPack->setLexicalDeclContext(LexicalDC); + LexicalDC->addDeclInternal(ToUsingPack); + martong wrote:

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1844 +for (const auto &MI : MBB) + if (MI.getOpcode() == ARM::tSTRspi || MI.getOpcode() == ARM::tSTRi) +for (const auto &Op : MI.oper

[PATCH] D125986: [clang][ASTImporter] Add support for import of UsingPackDecl.

balazske updated this revision to Diff 430990. balazske added a comment. Use of addDeclToContexts, added new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125986/new/ https://reviews.llvm.org/D125986 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

pratlucas updated this revision to Diff 430991. pratlucas marked 2 inline comments as done. pratlucas added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 Files:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { dgoldman wrote:

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 430994. steplong added a comment. The assembly for LLVM is now: __readx18byte: ldrbw0, [x18, w0, uxtw] __readx18word: ldrhw0, [x18, w0, uxtw] __readx18dword: ldr w0, [x18, w0, uxtw] __readx18qword: ldr

[clang] 1f12718 - [clang] Fixing arm-common, windows only and openmp header install targets

Author: Qiongsi Wu Date: 2022-05-20T12:29:10-04:00 New Revision: 1f12718ccfd660f01ac0e444d4632cf8ce6b98e2 URL: https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2 DIFF: https://github.com/llvm/llvm-project/commit/1f12718ccfd660f01ac0e444d4632cf8ce6b98e2.diff LO

[PATCH] D126002: [clang] Fixing arm-common, windows only and openmp header install targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f12718ccfd6: [clang] Fixing arm-common, windows only and openmp header install targets (authored by qiongsiwu1). Repository: rG LLVM Github Monor

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > oops, I forgot one

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

egorzhdan added a comment. Looks like `index-concepts.cpp` is failing on Windows, @arphaman could you please take a look? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list

[PATCH] D125771: [clang-tidy] Add a useful note about -std=c++11-or-later

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:22 [-check-suffixes=] \ +[-std=(c++11-or-later|c++17)] \ \ These aren't the only two valid options for this argument Valid values are:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) dgoldman wrote: > sammccall wrote: >

[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

datacompboy created this revision. datacompboy added reviewers: bixia, aartbik. Herald added a project: All. datacompboy requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Protect classIsDerivedFrom from run-out-of-stack cras

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:180 + the ``CheckHeaderFile=true`` option if header files of the project only + included by c++ source files. Capitalize to `C++` Comment at: clan

[PATCH] D125769: [clang-tidy] Introduce the CheckHeaderFile option to modernize-deprecated-headers

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Address one nit and ship. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125769/new/ https://reviews.llvm.org/D125769

[PATCH] D125209: [clang-tidy] modernize-deprecated-headers check should respect extern "C" blocks

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125209/new/ https://reviews.llvm.org/D125209 _

[PATCH] D117409: [clang-tidy] Move IncludeInserter into ClangTidyContext

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. Herald added a project: All. If the only thing holding this up is my comments about following the Law of Demeter, I don't think that should block submitting this change.

[PATCH] D117460: [clang-tidy][NFC] Reduce map lookups in IncludeSorter

LegalizeAdulthood added a comment. Herald added a project: All. Are we waiting on some sort of benchmark before accepting/rejecting this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117460/new/ https://reviews.llvm.org/D117460 ___

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

rnk added a comment. I was unable to find any documentation for the meaning of AArch64 addrspace(256), and I wasn't able to figure it out after studying the code in llvm/lib/Target/AArch64 for ten minutes or so. The change seems fine, but please add some documentation as a follow-up. X86 has so

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong added a comment. In D126023#3528077 , @rnk wrote: > I was unable to find any documentation for the meaning of AArch64 > addrspace(256), and I wasn't able to figure it out after studying the code in > llvm/lib/Target/AArch64 for ten minutes or s

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

vvereschaka added a comment. Hi @void , the `zero-call-used-regs.ll` test gets failed on `llvm-clang-x86_64-expensive-checks-ubuntu` builder with the following errors: ... *** Bad machine code: Illegal physical register for instruction *** - function:all_arg - basic block: %bb.0 ent

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

steven_wu added a comment. Is there any issues currently if we just always use opaque pointer in LTO? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ https://reviews.llvm.org/D125847 ___ cfe-co

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

aeubanks added a comment. I'm still looking into a whole program devirtualization bug that only repros with opaque pointers, and there are still potential performance issues to look into Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125847/new/ h

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 431011. steplong added a comment. - Change addrspace(256) to the default addrspace 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024 Files: clang/include/clang/Bas

[PATCH] D125847: LTO: Decide upfront whether to use opaque/non-opaque pointer types

steven_wu added a comment. In D125847#3528111 , @aeubanks wrote: > I'm still looking into a whole program devirtualization bug that only repros > with opaque pointers, and there are still potential performance issues to > look into Thanks. Maybe here i

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 431013. steplong added a comment. - Changed addrspace(256) to the default addrspace 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 Files: clang/include/clang/Ba

[clang-tools-extra] 1fef69d - Avoid uninitialized Diag.ID (which we pass but never read)

Author: Sam McCall Date: 2022-05-20T20:29:47+02:00 New Revision: 1fef69da0bfd51de916f0a869f97740c51211cc1 URL: https://github.com/llvm/llvm-project/commit/1fef69da0bfd51de916f0a869f97740c51211cc1 DIFF: https://github.com/llvm/llvm-project/commit/1fef69da0bfd51de916f0a869f97740c51211cc1.diff LO

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

tianshilei1992 added a comment. LGTM, but please fix the build error first. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { koops wrote: > tianshilei1992 wrote: > > koops

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1863 // to combine multiple loads / stores. - bool CanEliminateFrame = true; + bool CanEliminateFrame = !requiresAAPCSFrameRecord(MF); bool CS1Spilled = false; Should thi

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9977 +StoreInst *Store = Builder.CreateAlignedStore( +Val, Ptr, getContext().getTypeAlignInChars(E->getType())); +return Store; I think I'd prefer just "CharUnits::One()",

[PATCH] D111199: [Clang][LLVM][Attr] support btf_type_tag attribute

compnerd added a comment. Herald added a project: All. The sema portions of this change are still causing an issue. Although the revert (rGf95bd18b5faa6a5af4b5786312c373c5b2dce687 ) and the subsequent re-application in rG3466

[PATCH] D126023: [MSVC, ARM64] Add __writex18 intrinsics

steplong updated this revision to Diff 431019. steplong added a comment. - Switch to `CharUnits::One()` instead of `getContext().getTypeInChars()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 Files:

[PATCH] D126024: [MSVC, ARM64] Add __readx18 intrinsics

steplong updated this revision to Diff 431021. steplong added a comment. - Use `CharUnits::One()` instead of `getTypeAlignInChars()` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126024/new/ https://reviews.llvm.org/D126024 Files: clang/include/

  1   2   >