efriedma added inline comments.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9977 + StoreInst *Store = Builder.CreateAlignedStore( + Val, Ptr, getContext().getTypeAlignInChars(E->getType())); + return Store; ---------------- I think I'd prefer just "CharUnits::One()", rather than getTypeAlignInChars(); given the lack of documentation, it's not clear if the offset is required to be properly aligned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126023/new/ https://reviews.llvm.org/D126023 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
