[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

aaronpuchert added inline comments. Comment at: clang/docs/ReleaseNotes.rst:173 effect. - ``-Wmisexpect`` warns when the branch weights collected during profiling Or maybe I should add it here? Not sure why there is a blank line. Repository: rG LLVM Git

[clang] af4cf1c - [clang-format][NFC] Make all TokenAnnotator member functions const

Author: owenca Date: 2022-05-06T14:46:32-07:00 New Revision: af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7 URL: https://github.com/llvm/llvm-project/commit/af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7 DIFF: https://github.com/llvm/llvm-project/commit/af4cf1c6b8ed0d8102fc5e69acdc2fcbbcdaa9a7.diff LOG: [

[PATCH] D125064: [clang-format][NFC] Make all TokenAnnotator member functions const

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4cf1c6b8ed: [clang-format][NFC] Make all TokenAnnotator member functions const (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125064/

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable entry. +

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70 +enum OffloadRegionEntryKindFlag : uint32_t { + /// Mark the region entry as a kernel. + OffloadRegionKernelEntry = 0x0, +}; + +/// The kind flag of the global variable entry.

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 427764. samitolvanen added a comment. Based on LKML feedback: - Fixed a bug in `Twine` usage. - Changed AArch64 to encode register information into the ESR and dropped `.kcfi_traps` generation for the arch. - Changed X86 to generate valid instructions f

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 updated this revision to Diff 427766. jhuber6 added a comment. removing enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/new/ https://reviews.llvm.org/D123471 Files: clang/include/clang/Basic/LangOptions.def clang/include/clan

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reimplement th

[PATCH] D125138: [clang] Add the flag -ffile-reproducible

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When Clang generates the path prefix (i.e. the path of the directory where the file is) when generating __FILE__, __bu

[PATCH] D125138: [clang] Add the flag -ffile-reproducible

ayzhao abandoned this revision. ayzhao added a comment. Duplicate of D122766 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125138/new/ https://reviews.llvm.org/D125138

[PATCH] D122766: [clang] Use forward slash as the path separator for Windows in __FILE__, __builtin_FILE(), and std::source_location

ayzhao updated this revision to Diff 427771. ayzhao added a comment. Implement -ffile-reproducible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h clang/

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427773. ayzhao added a comment. missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao updated this revision to Diff 427774. ayzhao added a comment. another missing newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122766/new/ https://reviews.llvm.org/D122766 Files: clang/include/clang/Basic/LangOptions.h clang/includ

[PATCH] D122766: [clang] Add the flag -ffile-reproducible

ayzhao added a comment. In D122766#3450348 , @dexonsmith wrote: > In D122766#3450298 , @ayzhao wrote: > >> So, the general consensus seems to be that we should use backslashes when >> targeting Windows. >> >> I

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. We're still using the same numeric value for two d

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. tra wrote: > We're still using the same numeri

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees created this revision. kees added reviewers: jfb, nickdesaulniers, aaron.ballman. Herald added a project: All. kees requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. GCC 12 has been released and contains unconditional support for

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. jhuber6 wrote: > tra wrote: > > We're still using

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

xbolva00 added a comment. Strong +1. It would be great to backport it to llvm 14.0.x as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits m

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGCUDARuntime.h:58 + /// Mark the entry as a global variable. + OffloadGlobalEntry = 0x0, + /// Mark the entry as a managed global variable. tra wrote: > jhuber6 wrote: > > tra wrote: > >

[clang] 57636c2 - [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

Author: Petr Hosek Date: 2022-05-06T16:55:05-07:00 New Revision: 57636c25904e05c6b94370c82e52a89f5baf80f1 URL: https://github.com/llvm/llvm-project/commit/57636c25904e05c6b94370c82e52a89f5baf80f1 DIFF: https://github.com/llvm/llvm-project/commit/57636c25904e05c6b94370c82e52a89f5baf80f1.diff LO

[PATCH] D125082: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit rG57636c25904e: [CMake] Include llvm-debuginfod-find in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125082/new/ http

[PATCH] D125149: [Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is generally a better default for tools

[PATCH] D118355: Add -mmanual-endbr switch to allow manual selection of control-flow protection

xiangzhangllvm added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:156-161 if (needsPrologueENDBR(MF, M)) { -auto MBB = MF.begin(); -Changed |= addENDBR(*MBB, MBB->begin()); +if (!ManualENDBR || MF.getFunction().doesCfCheck()) { +

[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:528 + + //FIXME: Hash other interface-specific elements like protocols, etc. + vsapsai wrote: > jansvoboda11 wrote: > > Is this important to implement

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} This method decides the file

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_

[PATCH] D123612: [Driver] Support linking to compiler-rt on AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 + // libgcc distributed with avr-gcc always named 'libgcc.a' even on windows. + return (Twine("libclang_rt.") + Component + Arch + ".a").str(); +} benshi001 wrote: > This method

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

Jeroen added a comment. Will it also add braces if they where not there yet? Comment at: clang/unittests/Format/FormatTest.cpp:25374 verifyFormat("if (a) {\n" " b = c >= 0 ? d\n" " : e;\n" Will it also add braces

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25374 verifyFormat("if (a) {\n" " b = c >= 0 ? d\n" " : e;\n" Jeroen wrote: > Will it also add braces if they where not there yet? No,

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

Pretty-box created this revision. Pretty-box added reviewers: benshi001, craig.topper. Pretty-box added projects: All, LLVM. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei

[PATCH] D124816: [Tooling] use different FileManager for each CWD

Kale updated this revision to Diff 427820. Kale added a comment. Reimplement ToolFileManager as a container of filemanagers which ToolInvocation takes by parameter. Also invalidate all file managers when using FileManager::setVirtualFileSystem(). Repository: rG LLVM Github Monorepo CHANGES

<    1   2   3