vsapsai planned changes to this revision. vsapsai added inline comments.
================ Comment at: clang/lib/AST/ODRHash.cpp:528 + + //FIXME: Hash other interface-specific elements like protocols, etc. + ---------------- vsapsai wrote: > jansvoboda11 wrote: > > Is this important to implement now, or are you fine leaving this be for the > > time being? > When I was posting this patch, I thought it wasn't critical to cover > everything immediately. Now I'm thinking about the ways to minimize the > uncovered elements. Specifically, I'm thinking about adding support for > protocols first and then for interfaces. Protocols aren't as useful as > interfaces but they are simpler and can be easier to add. > > And `AddSubDecl` should cover some of the nested decls already, need to add > more cases to the test. I've made good progress at handling anonymous RecordDecl. So think I should add handling ivars instead of the lame FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124287/new/ https://reviews.llvm.org/D124287 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
