[clang] b9f3b7f - [flang][driver] Add support for consuming LLVM IR/BC files

Author: Andrzej Warzynski Date: 2022-05-05T15:11:50Z New Revision: b9f3b7f89a4cb4cf541b7116d9389c73690f78fa URL: https://github.com/llvm/llvm-project/commit/b9f3b7f89a4cb4cf541b7116d9389c73690f78fa DIFF: https://github.com/llvm/llvm-project/commit/b9f3b7f89a4cb4cf541b7116d9389c73690f78fa.diff

[PATCH] D124667: [flang][driver] Add support for consuming LLVM IR/BC files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f3b7f89a4c: [flang][driver] Add support for consuming LLVM IR/BC files (authored by awarzynski). Changed prior to commit: https://reviews.llvm.o

[PATCH] D124932: [clang][dataflow] Track `optional` contents in `optional` model.

xazax.hun added a comment. Thanks for the clarifications! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124932/new/ https://reviews.llvm.org/D124932 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427333. awarzynski marked an inline comment as done. awarzynski added a comment. Rebase on top of main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669 Files: cla

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

frederic-tingaud-sonarsource updated this revision to Diff 427332. frederic-tingaud-sonarsource added a comment. Applying recommendations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124845/new/ https://reviews.llvm.org/D124845 Files: clang/include/clang/Analysis/ConstructionContext

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

ldionne accepted this revision. ldionne added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124708/new/ https://reviews.llvm.org/D124708 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

frederic-tingaud-sonarsource marked an inline comment as done. frederic-tingaud-sonarsource added inline comments. Comment at: clang/include/clang/Analysis/ConstructionContext.h:122-124 assert(isa(E) || isa(E) || - isa(E) || isa(E)); + isa(E) || isa(E) ||

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added a comment. Most checks in Clang Tidy will run relatively quickly as they usually can do most/all of their work in a single traversal. I wonder whether flow sensitive checks will prove to be a bit slower. I think adding slower checks to Tidy is fine, but it would be nice to prope

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 _

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

MattDevereau updated this revision to Diff 427335. MattDevereau added a comment. set `CXCallingConv_AArch64SVEPcs= 17` to 18 to resolve ABI break renamed CC_AArch64SVEPcs to CC_AArch64SVEPCS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

aaron.ballman added a reviewer: clang-language-wg. aaron.ballman added a comment. In D124996#3493930 , @tahonermann wrote: > I think changes are needed to make this behavior dependent on whether > `char8_t` support is active or not. Good catch Tom, I f

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

erichkeane added a comment. In the future, when doing Concepts stuff, do you mind adding me as a reviewer? This ended up being a somewhat surprising/painful merge conflict with the deferred concepts implementation that I've been trying to get in (D119544 ). R

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Thanks for the update, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124845/new/ https://reviews.llvm.org/D124845 ___

[PATCH] D124955: [clang-tidy] Make header-guard check a little looser on comment whitespace

sammccall added a comment. In D124955#3493761 , @hokein wrote: > I think `"// FOO_BAR_H"` in your message should be `"// FOO_BAR_H" ` (two > space). It's actually correct in the commit message, just phab renders it wrong :-( Repository: rG LLVM Git

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3493791 , @paulwalker-arm wrote: > Just wanted to say this is not a new calling convention as such, but rather > an existing one that is generally auto-detected based on function signature. > The problem we're

[clang-tools-extra] 7cf97d6 - [clang-tidy] Make header-guard check a little looser on comment whitespace

Author: Sam McCall Date: 2022-05-05T17:42:35+02:00 New Revision: 7cf97d62f40990c2f86f75eb5a1d9cf2bd9de71e URL: https://github.com/llvm/llvm-project/commit/7cf97d62f40990c2f86f75eb5a1d9cf2bd9de71e DIFF: https://github.com/llvm/llvm-project/commit/7cf97d62f40990c2f86f75eb5a1d9cf2bd9de71e.diff LO

[PATCH] D124955: [clang-tidy] Make header-guard check a little looser on comment whitespace

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cf97d62f409: [clang-tidy] Make header-guard check a little looser on comment whitespace (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D124983: [HLSL} add -fcgl option flag.

aaron.ballman added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">; beanz wrote: > aaron.ball

[PATCH] D124845: StaticAnalyzer should inline overridden delete operator the same way as overridden new operator

frederic-tingaud-sonarsource marked an inline comment as not done. frederic-tingaud-sonarsource added a comment. As I don't have merge rights, would it be possible for you to merge it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124845/new/ https://reviews.llvm.org/D124845 __

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel added a comment. In D121120#3494085 , @xazax.hun wrote: > Most checks in Clang Tidy will run relatively quickly as they usually can do > most/all of their work in a single traversal. I wonder whether flow sensitive > checks will prove to be a bi

[clang] f0d6cb4 - [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

Author: Tomasz Kamiński Date: 2022-05-05T17:48:49+02:00 New Revision: f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d URL: https://github.com/llvm/llvm-project/commit/f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d DIFF: https://github.com/llvm/llvm-project/commit/f0d6cb4a5cf5723d7ddab2c7dab74f2f62116a6d.dif

[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0d6cb4a5cf5: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible (authored by tomasz-kaminski-sonarsource, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:38 + + auto HasOptionalCallDescendant = hasDescendant(callExpr(callee(cxxMethodDecl( + ofClass(anyOf(hasName("std::optional"), hasName("absl::optional"), ---

[clang] 87a5513 - Fix "the the" typo in documentation and user facing strings

Author: Brian Tracy Date: 2022-05-05T17:52:08+02:00 New Revision: 87a55137e2a2a6684a20223494ad46d2fa33aca8 URL: https://github.com/llvm/llvm-project/commit/87a55137e2a2a6684a20223494ad46d2fa33aca8 DIFF: https://github.com/llvm/llvm-project/commit/87a55137e2a2a6684a20223494ad46d2fa33aca8.diff L

[PATCH] D124708: Fix "the the" typo in documentation and user facing strings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87a55137e2a2: Fix "the the" typo in documentation and user facing strings (authored by briantracy, committed by Mordante). Repository: rG LLVM Git

[clang] e13c28e - [Driver] Remove -fno-concept-satisfaction-caching

Author: Ilya Biryukov Date: 2022-05-05T15:53:00Z New Revision: e13c28ec595d99e694cb7e2589e7574dcda628ef URL: https://github.com/llvm/llvm-project/commit/e13c28ec595d99e694cb7e2589e7574dcda628ef DIFF: https://github.com/llvm/llvm-project/commit/e13c28ec595d99e694cb7e2589e7574dcda628ef.diff LOG:

[PATCH] D125014: [Driver] Remove -fno-concept-satisfaction-caching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe13c28ec595d: [Driver] Remove -fno-concept-satisfaction-caching (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D124983: [HLSL} add -fcgl option flag.

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Options.td:6765 "as_6_5, as_6_6, as_6_7">; +def fcgl : DXCFlag<"fcgl">, + HelpText<"Generate high-level code only. Without any dxil related passes.">

[PATCH] D124923: [Sema] Simplify CheckConstraintSatisfaction. NFC

ilya-biryukov added a comment. @erichkeane sure, will do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124923/new/ https://reviews.llvm.org/D124923 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] 1e95d1b - [clang] Fix Clang release notes

Author: Ilya Biryukov Date: 2022-05-05T16:11:45Z New Revision: 1e95d1bee63837cd40e6ea5ecc95eb8854ba8d21 URL: https://github.com/llvm/llvm-project/commit/1e95d1bee63837cd40e6ea5ecc95eb8854ba8d21 DIFF: https://github.com/llvm/llvm-project/commit/1e95d1bee63837cd40e6ea5ecc95eb8854ba8d21.diff LOG:

[clang] 199dfb4 - Silence a false positive about an unevaluated expr w/side effects

Author: Aaron Ballman Date: 2022-05-05T12:12:30-04:00 New Revision: 199dfb4d0cca0aaa217e79bd2371f96f6336bbc5 URL: https://github.com/llvm/llvm-project/commit/199dfb4d0cca0aaa217e79bd2371f96f6336bbc5 DIFF: https://github.com/llvm/llvm-project/commit/199dfb4d0cca0aaa217e79bd2371f96f6336bbc5.diff

[PATCH] D124816: [Tooling] use different FileManager for each CWD

dexonsmith added reviewers: benlangmuir, bnbarham, jansvoboda11. dexonsmith added a comment. Two high-level comments: - Making these functions `virtual` makes it harder to reason about possible implementations, but I don't think that's necessary for what you're doing here. Why not expose `ToolF

[PATCH] D124816: [Tooling] use different FileManager for each CWD

dexonsmith added a comment. In D124816#3494243 , @dexonsmith wrote: > - AFAICT, every call to `FileManager::setVirtualFileSystem()` is > fundamentally unsound unless the new FS is equivalent to the old one or the > filemanager hasn't been used yet. Mo

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. Can we add a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124974/new/ https://reviews.llvm.org/D124974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane updated this revision to Diff 427359. erichkeane added a comment. Updated to include the fix for the libcxx issue, which was that we weren't properly differentiating between 'friend' functions based on concepts. I'll likely be submitting this early monday or so, but would like to giv

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added a comment. I found LLDB have this feature. LLDB uses "..." to indicate that only part of the string is now printed, and it also have a command to modify length limit. This approach is similar to the idea of @erichkeane, can we do the same？what do you all think? typedef signed

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

erichkeane added a comment. I was thinking of that, but I don't have a good way using just format strings to get us to print the '...' after. I think if someone wants that part of the feature, they'll have to wrap printf/etc in a wrapper that does that. Repository: rG LLVM Github Monorepo

[clang-tools-extra] 6385c03 - [clangd] Fix inlayhints crash, don't assume functions have FunctionTypeLocs

Author: Sam McCall Date: 2022-05-05T18:51:36+02:00 New Revision: 6385c039b821c76c215c3ae6202f9e702a01fd92 URL: https://github.com/llvm/llvm-project/commit/6385c039b821c76c215c3ae6202f9e702a01fd92 DIFF: https://github.com/llvm/llvm-project/commit/6385c039b821c76c215c3ae6202f9e702a01fd92.diff LO

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski updated this revision to Diff 427367. awarzynski added a comment. Mark the tests as unsupported on Windows Pre-merge testing is failing on Windows. Here is the error message: flang-new: error: there is no external assembler that can be used on this platform I will update the commi

[PATCH] D124221: Reimplement `__builtin_dump_struct` in Sema.

yihanaa added a comment. This is unfortunately true, unless we generate some code that calculates the length of the string at runtime. I find it difficult to draw the line between defining this built-in functionality and developers developing printf-like functionality, if built-in does too much

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427374. ymandel marked 2 inline comments as done. ymandel added a comment. Herald added a project: clang. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.o

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

sammccall added a comment. In D124974#3494279 , @dexonsmith wrote: > Can we add a test for this? I think the problem with testing it is that this variable comes from the CMake config, and in the default configuration (as used by all the bots) it's not

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427377. ymandel marked 2 inline comments as done. ymandel added a comment. added fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files: clang-tools-extra/clan

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:38 + + auto HasOptionalCallDescendant = hasDescendant(callExpr(callee(cxxMethodDecl( + ofClass(anyOf(hasName("std::optional"), hasName("absl::optional"), -

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

paulwalker-arm added a comment. In D124998#3494127 , @aaron.ballman wrote: > In D124998#3493791 , > @paulwalker-arm wrote: > >> Just wanted to say this is not a new calling convention as such, but rather >> an

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494388 , @paulwalker-arm wrote: > In D124998#3494127 , @aaron.ballman > wrote: > >> In D124998#3493791 , >> @paulwalker-arm wrot

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427381. ymandel added a comment. Factor out analysis code into separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files: clang-tools-extra/clang-tid

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; Could the size of the

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; xazax.hun wrote: > Co

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. If you're really concerned about the size of FunctionProtoType increasing, can we just shove the infrequently used calling convention bits into TrailingObjects? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124998/new/ h

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494424 , @efriedma wrote: > If you're really concerned about the size of FunctionProtoType increasing, > can we just shove the infrequently used calling convention bits into > TrailingObjects? I don't believe so.

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall this looks good to me. However, I think this might not use the full potential of the check itself. With the information that the dataflow framework have it could distinguish betw

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. In D124998#3494426 , @erichkeane wrote: > In D124998#3494424 , @efriedma > wrote: > >> If you're really concerned about the size of FunctionProtoType increasing, >> can we just shove t

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

tschuett added inline comments. Comment at: clang/include/clang-c/Index.h:3448 + CXCallingConv_AArch64SVEPcs= 17, + CXCallingConv_SwiftAsync = 18, tschuett wrote: > aaron.ballman wrote: > > peterwaller-arm wrote: > > > peterwaller-arm wrote: > > > > It should

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 created this revision. njames93 added reviewers: alexfh, klimek, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. R

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494442 , @efriedma wrote: > In D124998#3494426 , @erichkeane > wrote: > >> In D124998#3494424 , @efriedma >> wrote: >> >>> If you

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. I would be interested in adding some kind of test for this, but am not sure how. I think the robust general-purpose check here would be to ensure that no file is referring to symbols defined by the various `config.h` etc. files without including those files, but am n

[clang] 967137c - No longer accept scoped enumerations in C

Author: Aaron Ballman Date: 2022-05-05T14:00:01-04:00 New Revision: 967137ca3cb7cf38b2fedf0415946ff3ffd0ef50 URL: https://github.com/llvm/llvm-project/commit/967137ca3cb7cf38b2fedf0415946ff3ffd0ef50 DIFF: https://github.com/llvm/llvm-project/commit/967137ca3cb7cf38b2fedf0415946ff3ffd0ef50.diff

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427396. int3 retitled this revision from "[MC] Omit DWARF unwind info if compact unwind is present for all archs" to "[MC] Omit DWARF unwind info if compact unwind is present where eligible". int3 edited the summary of this revision. int3 added a comment. Herald

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:368 void Environment::setStorageLocation(const Expr &E, StorageLocation &Loc) { - assert(!isa

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 updated this revision to Diff 427398. int3 added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D124669: [flang][driver] Add support for -save-temps

awarzynski added a comment. Pre-merge CI is 🍏 . If there are no new comments, I'd like to merge this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124669/new/ https://reviews.llvm.org/D124669

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

phyBrackets added a comment. Thanks @martong @balazske for the Review . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124774/new/ https://reviews.llvm.org/D124774 ___ cfe-commits mailing list cfe-commits

[clang] f6dff93 - Pedantically warn about // comments in gnu89 mode

Author: Aaron Ballman Date: 2022-05-05T14:35:47-04:00 New Revision: f6dff93641b2259623e686eb13a1884b8b9f4a00 URL: https://github.com/llvm/llvm-project/commit/f6dff93641b2259623e686eb13a1884b8b9f4a00 DIFF: https://github.com/llvm/llvm-project/commit/f6dff93641b2259623e686eb13a1884b8b9f4a00.diff

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[clang] dcb9067 - [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

Author: phyBrackets Date: 2022-05-06T00:14:32+05:30 New Revision: dcb906757ada24edf8da89439c72d015b53f204b URL: https://github.com/llvm/llvm-project/commit/dcb906757ada24edf8da89439c72d015b53f204b DIFF: https://github.com/llvm/llvm-project/commit/dcb906757ada24edf8da89439c72d015b53f204b.diff L

[PATCH] D124774: [clang][ASTImporter][NFC]: Move clang::ImportError into own header.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdcb906757ada: [clang][ASTImporter][NFC]: Move clang::ImportError into own header. (authored by phyBrackets). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427412. ymandel added a comment. reorder examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cp

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unchecked-optional-access.rst:29 + +Checking if a value exists, then accessing the value + -

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unchecked-optional-access.rst:29 + +Checking if a value exists, then accessing the value + ymandel wrote: > xazax.h

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua updated this revision to Diff 427417. li.zhe.hua marked 3 inline comments as done. li.zhe.hua added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124965/new/ https://reviews.llvm.org/D124965 Files:

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS, SkipPast::Refe

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427418. njames93 added a comment. Remove redundant traversal of CompoundStmt in a replace method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files: clang-tool

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494500 , @erichkeane wrote: > In D124998#3494442 , @efriedma > wrote: > >> In D124998#3494426 , @erichkeane >> wrote: >> >>>

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

erichkeane added a comment. In D124998#3494785 , @aaron.ballman wrote: > In D124998#3494500 , @erichkeane > wrote: > >> In D124998#3494442 , @efriedma >> wrote: >> >>>

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

smeenai added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll;

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible

int3 added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:456 Options.MCOptions.SplitDwarfFile = CodeGenOpts.SplitDwarfFile; + Options.MCOptions.EmitDwarfUnwind = CodeGenOpts.getEmitDwarfUnwind(); Options.MCOptions.MCRelaxAll = CodeGenOpts.RelaxAll; ---

[PATCH] D117829: [Clang] Add integer mul reduction builtin

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! IIRC @scanon had some opinions about `__builtin_reduce_mul` during some earlier discussions. Please wait a few days in case there are additional comments. Repository: rG LLVM G

[PATCH] D125037: [pseudo] Add fuzzer for the pseudoparser.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. As confirmation, running

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_cast_or_null(Env.getValue(RHS, SkipPast::Referen

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

efriedma added a comment. I don't want to change with the distinction between FunctionProtoType and FunctionNoProtoType; that would involve auditing a bunch of code we don't really want to mess with. FunctionProtoType and FunctionNoProtoType don't have any member variables at the moment, thoug

[PATCH] D124998: [AArch64][SVE] Add aarch64_sve_pcs attribute to Clang

aaron.ballman added a comment. In D124998#3494814 , @erichkeane wrote: > First: I care very little about `FunctionNoProtoType`. I care insomuch as it doesn't break valid user code. > Second, it is used only in "C" afaik, where our memory pressure isn't

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth updated this revision to Diff 427423. JonasToth marked 3 inline comments as done. JonasToth added a comment. - addressing review comments and remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://review

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

JonasToth marked an inline comment as done. JonasToth added a comment. Thank you for the review! I adjusted the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54943/new/ https://reviews.llvm.org/D54943 ___

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; ymandel wrote: > xaza

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:84 + if (!BlockToOutputState || + BlockToOutputState->size() <= Context->getCFG().getExit().getBlockID()) +return; xazax.hun wrote: > ym

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:38-41 + if (auto *LHSValue = + dyn_cast_or_null(Env.getValue(LHS, SkipPast::Reference))) +if (auto *RHSValue = +dyn_c

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel updated this revision to Diff 427429. ymandel marked an inline comment as done. ymandel added a comment. add assert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120 Files: clang-tools-extra/clang

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

ymandel marked an inline comment as done. ymandel added a comment. In D121120#3494427 , @xazax.hun wrote: > Overall this looks good to me. However, I think this might not use the full > potential of the check itself. With the information that the dataflo

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427430. njames93 added a comment. Transform final matcher, Benchmark -> 0.82s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files: clang-tools-extra/clang-tidy/

[clang] 45643cf - [clang][dataflow] Centralize expression skipping logic

Author: Eric Li Date: 2022-05-05T20:28:11Z New Revision: 45643cfcc12ea6152fb9516ed24f5adf7469eb4c URL: https://github.com/llvm/llvm-project/commit/45643cfcc12ea6152fb9516ed24f5adf7469eb4c DIFF: https://github.com/llvm/llvm-project/commit/45643cfcc12ea6152fb9516ed24f5adf7469eb4c.diff LOG: [clan

[PATCH] D124965: [clang][dataflow] Centralize expression skipping logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45643cfcc12e: [clang][dataflow] Centralize expression skipping logic (authored by li.zhe.hua). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D121120: [clang-tidy] New check for safe usage of `std::optional` and like types.

xazax.hun accepted this revision. xazax.hun added a comment. It looks like all of my comments are resolved now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121120/new/ https://reviews.llvm.org/D121120

[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

njames93 updated this revision to Diff 427436. njames93 added a comment. Remove SimplifyBoolExprMatchers header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125026/new/ https://reviews.llvm.org/D125026 Files: clang-tools-extra/clang-tidy/readab

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

aaron.ballman added a comment. Thanks for working on this compatibility extension! This is missing all of the lexing tests which validate that we correctly diagnose malformed pragmas. We're also missing all sema tests for the diagnostics added or emitted from there. When you add the sema tests,

[clang] 16dcbb5 - [ORC] Return ExecutorAddrs rather than JITEvaluatedSymbols from LLJIT::lookup.

Author: Lang Hames Date: 2022-05-05T13:56:00-07:00 New Revision: 16dcbb53dc7968a3752661aac731172ebe0faf64 URL: https://github.com/llvm/llvm-project/commit/16dcbb53dc7968a3752661aac731172ebe0faf64 DIFF: https://github.com/llvm/llvm-project/commit/16dcbb53dc7968a3752661aac731172ebe0faf64.diff LO

<    1   2   3   >