[clang-tools-extra] cce7951 - [clang-tidy] Reduce false positives for `bugprone-infinite-loop` with dependent expressions

Author: Fabian Wolff Date: 2022-04-20T17:17:54+02:00 New Revision: cce79514ff405d93ab7aab79974e6f80ced85980 URL: https://github.com/llvm/llvm-project/commit/cce79514ff405d93ab7aab79974e6f80ced85980 DIFF: https://github.com/llvm/llvm-project/commit/cce79514ff405d93ab7aab79974e6f80ced85980.diff

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman updated this revision to Diff 423912. aaron.ballman added a comment. Fixes some failing tests found by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122983/new/ https://reviews.llvm.org/D122983 Files: clang-tools-extra/clangd/IncludeFixer.cpp clang-tools

[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

paulkirth added a comment. Hi I think this patch is the root cause of https://github.com/llvm/llvm-project/issues/54968 The issue first appears in our builders here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8816803488685972465/overview based on

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:420-422 +def ext_implicit_function_decl_c99 : ExtWarn< + "implicit declaration of function %0 is invalid in C99 and later and " + "unsupported in C2x">, InGroup, DefaultError;

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

fwolff added a comment. Ping @aaron.ballman. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113804/new/ https://reviews.llvm.org/D113804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d644e1215b3: [C11/C2x] Change the behavior of the implicit function declaration warning (authored by aaron.ballman). Herald added a project: Sanitiz

[clang] a5c847e - [PS4][NFC] Rename classes to align with prevailing practice

Author: Paul Robinson Date: 2022-04-20T08:35:52-07:00 New Revision: a5c847e8cf2a60fe09d4016788c4944ab4739e45 URL: https://github.com/llvm/llvm-project/commit/a5c847e8cf2a60fe09d4016788c4944ab4739e45 DIFF: https://github.com/llvm/llvm-project/commit/a5c847e8cf2a60fe09d4016788c4944ab4739e45.diff

[PATCH] D123957: Update the developer policy to mention release notes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG009048ab314f: Update the developer policy to mention release notes (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a comment. Thank you to everyone for the great feedback! In D123957#3459975 , @xbolva00 wrote: > Can you please add link to RFC to commit message? Good call, I added that when landing. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks updated this revision to Diff 423923. aeubanks added a comment. take suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124036/new/ https://reviews.llvm.org/D124036 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/unitte

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

aeubanks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:310-313 for (; J != AnnotatedLines.begin(); --J) -if (!(*J)->InPPDirective && (*J)->Level < TheLine->Level) +if ((TheLine->InPPDirective || !(*J)->InPPDirect

[clang] 19884d6 - [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

Author: Arthur Eubanks Date: 2022-04-20T08:42:30-07:00 New Revision: 19884d62c44cdcf236cdf4a55e8a50437070c4fc URL: https://github.com/llvm/llvm-project/commit/19884d62c44cdcf236cdf4a55e8a50437070c4fc DIFF: https://github.com/llvm/llvm-project/commit/19884d62c44cdcf236cdf4a55e8a50437070c4fc.diff

[PATCH] D124036: [clang-format] Don't skip PP lines if original line was a PP line when trying to merge lines

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19884d62c44c: [clang-format] Don't skip PP lines if original line was a PP line when trying… (authored by aeubanks). Repository: rG LLVM Github Mo

[clang] 9f075c3 - Revert "[Clang][Sema] Fix invalid redefinition error in if/switch/for statement"

Author: Jun Zhang Date: 2022-04-20T23:45:44+08:00 New Revision: 9f075c3d84fb359efb6496535ab397a6f09609e2 URL: https://github.com/llvm/llvm-project/commit/9f075c3d84fb359efb6496535ab397a6f09609e2 DIFF: https://github.com/llvm/llvm-project/commit/9f075c3d84fb359efb6496535ab397a6f09609e2.diff LOG

[PATCH] D123571: [clang-format] Clean up unit tests for AlignArrayOfStructures

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Thanks for taking this on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123571/new/ https://reviews.llvm.org/D123571 ___ cfe-commit

[clang] dfdb2cc - [PS5][NFC] Fix a test with a misplaced -x option

Author: Paul Robinson Date: 2022-04-20T08:56:50-07:00 New Revision: dfdb2cc0fbc91feeaa95d3651728df36a975912e URL: https://github.com/llvm/llvm-project/commit/dfdb2cc0fbc91feeaa95d3651728df36a975912e DIFF: https://github.com/llvm/llvm-project/commit/dfdb2cc0fbc91feeaa95d3651728df36a975912e.diff

[clang] 4f843f9 - Removing some ancient, unused testing functionality

Author: Aaron Ballman Date: 2022-04-20T11:57:25-04:00 New Revision: 4f843f9a9e758b16a153690987897ba625c9b22e URL: https://github.com/llvm/llvm-project/commit/4f843f9a9e758b16a153690987897ba625c9b22e DIFF: https://github.com/llvm/llvm-project/commit/4f843f9a9e758b16a153690987897ba625c9b22e.diff

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6667 +// have an identifier list. +HasProto = ParamInfo.size() || getLangOpts().requiresStrictPrototypes() || + getLangOpts().OpenC

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124054/new/ https://reviews.llvm.org/D124054

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. Well, crud. @cor3ntin broke me again :) I went to rebase to get pre-commit to run again, and now the problem is the lambda captures. Taking a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203

[PATCH] D119544: Deferred Concept Instantiation Implementation

cor3ntin added a comment. Oh no. Let me know if i can help in any way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119544/new/ https://reviews.llvm.org/D119544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

Mordante added a comment. I've a fix in D124103 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 ___ cfe-commits mailing list

[PATCH] D124104: [clang][dataflow] Fix join implementation to handle flow conditions correctly.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The current implementation mutates the environment as it perform

[clang] 1d3ba05 - [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

Author: Jan Svoboda Date: 2022-04-20T18:52:27+02:00 New Revision: 1d3ba05e4a288b49287fe997763e90234b8c62db URL: https://github.com/llvm/llvm-project/commit/1d3ba05e4a288b49287fe997763e90234b8c62db DIFF: https://github.com/llvm/llvm-project/commit/1d3ba05e4a288b49287fe997763e90234b8c62db.diff L

[PATCH] D123771: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d3ba05e4a28: [clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*() (authored by jansvoboda11). Repository: rG LLVM Github Monorepo C

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. The `VD->getAnyInitializer()->IgnoreCasts()` is the part that's wrong. We want to allow something like the following: constexpr int *q = (int *)(int[1]){3}; constexpr int *q2 = q; To catch the bad cases specifically, we have to wait until we actually reach the co

[clang] ba118f3 - [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile()

Author: Jan Svoboda Date: 2022-04-20T18:54:39+02:00 New Revision: ba118f30676d44025885f422e29fe853a84495f8 URL: https://github.com/llvm/llvm-project/commit/ba118f30676d44025885f422e29fe853a84495f8 DIFF: https://github.com/llvm/llvm-project/commit/ba118f30676d44025885f422e29fe853a84495f8.diff L

[PATCH] D123853: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba118f30676d: [clang] NFCI: Use DirectoryEntryRef in FrontendAction::BeginSourceFile() (authored by jansvoboda11). Repository: rG LLVM Github Mono

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

ymandel updated this revision to Diff 423945. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123858/new/ https://reviews.llvm.org/D123858 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis

[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:607 // If the framework dir doesn't exist, we fail. auto Dir = FileMgr.getDirectory(FrameworkName); if (!Dir) bnbarham wro

[clang] f43ce51 - [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

Author: Jan Svoboda Date: 2022-04-20T19:01:02+02:00 New Revision: f43ce5199df328c0acd3bc1d56d481b22d681ca8 URL: https://github.com/llvm/llvm-project/commit/f43ce5199df328c0acd3bc1d56d481b22d681ca8 DIFF: https://github.com/llvm/llvm-project/commit/f43ce5199df328c0acd3bc1d56d481b22d681ca8.diff L

[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jansvoboda11 marked an inline comment as done. Closed by commit rGf43ce5199df3: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry (authored by jansvoboda1

[clang] c8f822a - [clang][dataflow] Ensure well-formed flow conditions.

Author: Yitzhak Mandelbaum Date: 2022-04-20T17:01:55Z New Revision: c8f822ad51951094504866049546bd2c3446728f URL: https://github.com/llvm/llvm-project/commit/c8f822ad51951094504866049546bd2c3446728f DIFF: https://github.com/llvm/llvm-project/commit/c8f822ad51951094504866049546bd2c3446728f.diff

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8f822ad5195: [clang][dataflow] Ensure well-formed flow conditions. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane planned changes to this revision. erichkeane added a comment. If anyone can help here, it would be vastly appreciated... I'm simply out of ideas on how to make this work. Comment at: clang/lib/Sema/SemaConcept.cpp:496 +llvm::Optional +Sema::SetupConstraintCheckingTe

[clang] 9c06937 - Reland "[Clang][Sema] Fix invalid redefinition error in if/switch/for statement"

Author: Jun Zhang Date: 2022-04-21T01:18:58+08:00 New Revision: 9c069374cebe0162bc4f0b9d0397cf2b1c5febf6 URL: https://github.com/llvm/llvm-project/commit/9c069374cebe0162bc4f0b9d0397cf2b1c5febf6 DIFF: https://github.com/llvm/llvm-project/commit/9c069374cebe0162bc4f0b9d0397cf2b1c5febf6.diff LOG

[clang] 9955f14 - [C2x] Disallow functions without prototypes/functions with identifier lists

Author: Aaron Ballman Date: 2022-04-20T13:28:15-04:00 New Revision: 9955f14aaf9995f6f0f7bf058ac740463003c470 URL: https://github.com/llvm/llvm-project/commit/9955f14aaf9995f6f0f7bf058ac740463003c470 DIFF: https://github.com/llvm/llvm-project/commit/9955f14aaf9995f6f0f7bf058ac740463003c470.diff

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9955f14aaf99: [C2x] Disallow functions without prototypes/functions with identifier lists (authored by aaron.ballman). Changed prior to commit: ht

[PATCH] D123926: [clang] Add a raw_ostream operator<< overload for QualType

njames93 updated this revision to Diff 423955. njames93 added a comment. Address nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123926/new/ https://reviews.llvm.org/D123926 Files: clang/include/clang/AST/Type.h clang/include/clang/StaticA

[clang] 0f5dbfd - Revert D123909 "[Clang] Use of decltype(capture) in parameter-declaration-clause"

Author: Fangrui Song Date: 2022-04-20T10:32:41-07:00 New Revision: 0f5dbfd29ae0df215a01aff80d29255bb799fed0 URL: https://github.com/llvm/llvm-project/commit/0f5dbfd29ae0df215a01aff80d29255bb799fed0 DIFF: https://github.com/llvm/llvm-project/commit/0f5dbfd29ae0df215a01aff80d29255bb799fed0.diff

[PATCH] D123926: [clang] Add a raw_ostream operator<< overload for QualType

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/AST/Type.h:1319 +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, const clang::QualType &QT); + aaron.ballman wrote: > Cleaning up the declaration a

[PATCH] D123235: atomic compare fail : Parser & AST support

koops updated this revision to Diff 423956. koops added a comment. 1. changes in flang/lib/Semantics/check-omp-structure.cpp to avoid build failure 2. prevent "requires" directive test from failing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D1232

[PATCH] D119544: Deferred Concept Instantiation Implementation

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13002 + ExprResult NewTrailingRequiresClause = + E->getCallOperator()->getTrailingRequiresClause(); That doesn't look right. At best if you don't transform the trailing return type

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

aaron.ballman added a comment. FWIW, I changed the patch summary as a drive-by because I originally thought this was adding a global pragma named `atomic compare fail` and was very confused. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 __

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:496 +llvm::Optional +Sema::SetupConstraintCheckingTemplateArgumentsAndScope( +FunctionDecl *FD, llvm::Optional> TemplateArgs, erichkeane wrote: > Ugh... it looks like all of this mig

[clang] 3d612a9 - [NFC] Avoid unnecessary duplication of code generating diagnostic.

Author: Dan Liew Date: 2022-04-20T10:50:21-07:00 New Revision: 3d612a930dce229c887cd9a731084df419f43791 URL: https://github.com/llvm/llvm-project/commit/3d612a930dce229c887cd9a731084df419f43791 DIFF: https://github.com/llvm/llvm-project/commit/3d612a930dce229c887cd9a731084df419f43791.diff LOG:

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d612a930dce: [NFC] Avoid unnecessary duplication of code generating diagnostic. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12405

[PATCH] D124054: [NFC] Avoid unnecessary duplication of code generating diagnostic.

delcypher added a comment. @aaron.ballman Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124054/new/ https://reviews.llvm.org/D124054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. Btw, if there are no new comments, I would like to merge this in the coming days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122008/new/ https://reviews.llvm.org/D122008 _

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

dblaikie added a comment. In D123534#3454749 , @hctim wrote: > In D123534#3454354 , @dblaikie > wrote: > >> This seems like it would significantly introduce debug info size for at >> least some kinds of code - h

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added a subscriber: MaskRay. aaron.ballman added a comment. In D123909#3461716 , @hokein wrote: > Hi, this patch seems to break the following code which was previously > compiled: > > #include > #include > #include > > templat

[clang] c79e600 - Revert D119136 "[clang] Implement Change scope of lambda trailing-return-type" and its follow-up

Author: Fangrui Song Date: 2022-04-20T10:57:12-07:00 New Revision: c79e6007edef4b0044be93c464dc806ac687 URL: https://github.com/llvm/llvm-project/commit/c79e6007edef4b0044be93c464dc806ac687 DIFF: https://github.com/llvm/llvm-project/commit/c79e6007edef4b0044be93c464dc806ac687.diff

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

dblaikie added a comment. Perhaps GlobalModuleIndex should create the cursor itself - it's being handed the buffer anyway? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

MaskRay added a comment. Sorry but I've reverted this patch and all its fixups in c79e6007edef4b0044be93c464dc806ac687 and 0f5dbfd29ae0df215a01aff80d29255bb799fed0

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13002 + ExprResult NewTrailingRequiresClause = + E->getCallOperator()->getTrailingRequiresClause(); erichkeane wrote: > cor3ntin wrote: > > That doesn't look right. > > At best i

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. In D119136#3462570 , @MaskRay wrote: > Sorry but I've reverted this patch and all its fixups in > c79e6007edef4b0044be93c464dc806ac687 > and > 0f5d

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:553-554 + if (LangOpts.Sanitize.has(SanitizerKind::KCFI)) { +EmitKCFIConstants(); +ClearUnusedKCFIPrefixes(); + } This is the only call site for these two methods, an

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. I didn't look at the code, but I have some hints how we can test libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commi

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

MaskRay added a comment. In D119136#3462579 , @aaron.ballman wrote: > In D119136#3462570 , @MaskRay wrote: > >> Sorry but I've reverted this patch and all its fixups in >> c79e6007edef4b0044be93c464dc806ac68

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin updated this revision to Diff 423972. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/includ

[clang] 8a9b4fb - [COFF, ARM64] Add __break intrinsic

Author: Pengxuan Zheng Date: 2022-04-20T11:20:26-07:00 New Revision: 8a9b4fb4aa6d2dde026d9ae08459aa9e7a1edb05 URL: https://github.com/llvm/llvm-project/commit/8a9b4fb4aa6d2dde026d9ae08459aa9e7a1edb05 DIFF: https://github.com/llvm/llvm-project/commit/8a9b4fb4aa6d2dde026d9ae08459aa9e7a1edb05.diff

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a9b4fb4aa6d: [COFF, ARM64] Add __break intrinsic (authored by pzheng). Changed prior to commit: https://reviews.llvm.org/D124032?vs=423754&id=423

[PATCH] D123856: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG99cfccdcb371: [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion() (authored by jansvoboda11). Repository: rG LLVM Github M

[clang] 99cfccd - [clang][lex] NFCI: Use FileEntryRef in ModuleMap::diagnoseHeaderInclusion()

Author: Jan Svoboda Date: 2022-04-20T20:27:13+02:00 New Revision: 99cfccdcb371cd6769169538098c3c3539cf9498 URL: https://github.com/llvm/llvm-project/commit/99cfccdcb371cd6769169538098c3c3539cf9498 DIFF: https://github.com/llvm/llvm-project/commit/99cfccdcb371cd6769169538098c3c3539cf9498.diff L

[clang] 340654e - Revert "[clang][lex] NFCI: Use DirectoryEntryRef in HeaderSearch::load*()"

Author: Jan Svoboda Date: 2022-04-20T20:27:14+02:00 New Revision: 340654e0f246cddb3fb6ebddb843ade9bfcff0a5 URL: https://github.com/llvm/llvm-project/commit/340654e0f246cddb3fb6ebddb843ade9bfcff0a5 DIFF: https://github.com/llvm/llvm-project/commit/340654e0f246cddb3fb6ebddb843ade9bfcff0a5.diff L

[clang] 61e36e8 - [safestack] Support safestack in stack size diagnostics

Author: Paul Kirth Date: 2022-04-20T18:29:40Z New Revision: 61e36e87df1a4ad11f752d66c90e124101fe4023 URL: https://github.com/llvm/llvm-project/commit/61e36e87df1a4ad11f752d66c90e124101fe4023 DIFF: https://github.com/llvm/llvm-project/commit/61e36e87df1a4ad11f752d66c90e124101fe4023.diff LOG: [s

[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. paulkirth marked an inline comment as done. Closed by commit rG61e36e87df1a: [safestack] Support safestack in stack size diagnostics (authored by paulkirth). Repositor

[clang] ecc8479 - Look through calls to std::addressof to compute pointer alignment.

Author: Eli Friedman Date: 2022-04-20T11:30:11-07:00 New Revision: ecc8479a01d3bee1c145a0f7990271651db72ab0 URL: https://github.com/llvm/llvm-project/commit/ecc8479a01d3bee1c145a0f7990271651db72ab0 DIFF: https://github.com/llvm/llvm-project/commit/ecc8479a01d3bee1c145a0f7990271651db72ab0.diff

[PATCH] D123950: Look through calls to std::addressof to compute pointer alignment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecc8479a01d3: Look through calls to std::addressof to compute pointer alignment. (authored by efriedma). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

aaron.ballman added a comment. In D119136#3462609 , @MaskRay wrote: > In D119136#3462579 , @aaron.ballman > wrote: > >> In D119136#3462570 , @MaskRay >> wrote: >> >>> So

[PATCH] D122008: [flang][driver] Add support for generating executables

klausler added a comment. In D122008#3462550 , @awarzynski wrote: > Btw, if there are no new comments, I would like to merge this in the coming > days. New comments or not, this step remains premature from my perspective. Repository: rG LLVM Github

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

thakis added a comment. As far as I can tell, this broke tests everywhere, e.g. http://45.33.8.238/linux/74221/step_7.txt https://lab.llvm.org/buildbot/#/builders/109/builds/36986 etc Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHA

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

amyk added a comment. In D119136#3459738 , @alanphipps wrote: > We've also been seeing failures in our downstream Arm compiler when running > the Perennial C++14 compliance tests related to this change. Specifically, > the tests expect a diagnostic to

[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13165 +// when checking satisfaction. +NewTrailingRequiresClause = getDerived().TransformExpr(TRC); + So I just noticed this: What happens when NewTrailingRequir

[clang] bff8356 - Revert "[COFF, ARM64] Add __break intrinsic"

Author: Pengxuan Zheng Date: 2022-04-20T11:57:49-07:00 New Revision: bff8356b1969d2edd02e22c73d1c3d386f862937 URL: https://github.com/llvm/llvm-project/commit/bff8356b1969d2edd02e22c73d1c3d386f862937 DIFF: https://github.com/llvm/llvm-project/commit/bff8356b1969d2edd02e22c73d1c3d386f862937.diff

[PATCH] D124032: [COFF, ARM64] Add __break intrinsic

pzheng added a comment. Thanks for the heads-up, @thakis. I have reverted the patch for now and will try to reproduce the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124032/new/ https://reviews.llvm.org/D124032

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module --dry-run

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts and

DiggerLin added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80 +static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) { + for (size_t i = 0, Size = CmdArgs.size(); i < Size; ++i) { +llvm::StringRef ArgString(CmdArgs[i]); stev

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. Sorry for the delayed reply. In D119136#3462660 , @aaron.ballman wrote: > In D119136#3462609 , @MaskRay wrote: > >> In D119136#3462579 , >> @a

[PATCH] D124033: [NFC] Adding a note about the macro __FLT_EVAL_METHOD__

aaron.ballman added inline comments. Comment at: clang/docs/UsersManual.rst:1610-1618 The macro ``__FLT_EVAL_METHOD__`` will expand to either the value set from the command line option ``ffp-eval-method`` or to the value from the target info -setting. The ``__FLT_EVAL_METHOD__`

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

lichray added a comment. In D119136#3462660 , @aaron.ballman wrote:> > Thanks for the apology, but I still think the reverts were premature, so > hopefully we don't do this again. The issue with reverting all of these is > that you put the burden back

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. In D119136#3462707 , @amyk wrote: > In D119136#3459738 , @alanphipps > wrote: > >> We've also been seeing failures in our downstream Arm compiler when running >> the Perennial C++14 com

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

rsmith added a comment. In D123909#3462560 , @aaron.ballman wrote: > This looks like a true positive to me, at least for the moment (Core is still > trying to decide what to do about CWG2569 which may relax some restrictions > in this area). > > @MaskR

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/test/Driver/linker-wrapper-image.c:32 +// RUN: %clang -cc1 %s -emit-obj -o %t.o \ +// RUN: -fembed-offload-object=%S/Inputs/dummy-elf.o,cuda,nvptx64-nvida-cuda,sm_70 +// RUN: clang-linker-wrapper --print-wrapped-module --dry-run

[PATCH] D119136: [clang] Implement Change scope of lambda trailing-return-type

MaskRay added a comment. Thanks for being willing to wait a bit and collect usage. Given current feedback, I am not going to simply undo the reverts. @cor3ntin To get one patch other folks can try: git revert -n c79e6007edef4b0044be93c464dc806ac687 git revert -n 0f5dbfd29ae0df215a01aff8

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 updated this revision to Diff 423993. jhuber6 added a comment. Herald added a subscriber: sstefan1. Adjusting tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 Files: clang/test/Driver/link

[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

aaron.ballman added a comment. In D123909#3462791 , @rsmith wrote: > In D123909#3462560 , @aaron.ballman > wrote: > >> This looks like a true positive to me, at least for the moment (Core is >> still trying to d

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13002 + ExprResult NewTrailingRequiresClause = + E->getCallOperator()->getTrailingRequiresClause(); erichkeane wrote: > erichkeane wrote: > > cor3ntin wrote: > > > That doesn't l

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

probinson added a comment. > What's the DW_AT_type referring to? (why is there a type called ".str"?) I'd expect it to point to a base type, in this case character string. A typeless variable with a location would be pretty weird. But I agree the name/linkage_name would be unnecessary. Reposi

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added a comment. In D123958#3461714 , @aaron.ballman wrote: > In D123958#3461020 , @void wrote: > >> In D123958#3459205 , >> @aaron.ballman wrote: >> >>> I think yo

[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:69 /// Attempts to merge distinct values `Val1` and `Val1` in `Env1` and `Env2`, /// respec

[clang] af7b98c - [clang-tblgen] Automatically document options values

Author: serge-sans-paille Date: 2022-04-20T22:00:06+02:00 New Revision: af7b98c383df62c0a749c3394b1670a1ed54c9d4 URL: https://github.com/llvm/llvm-project/commit/af7b98c383df62c0a749c3394b1670a1ed54c9d4 DIFF: https://github.com/llvm/llvm-project/commit/af7b98c383df62c0a749c3394b1670a1ed54c9d4.d

[PATCH] D123682: [clang-tblgen] Automatically document options values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7b98c383df: [clang-tblgen] Automatically document options values (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 38612fb - Reland "[COFF, ARM64] Add __break intrinsic"

Author: Pengxuan Zheng Date: 2022-04-20T13:01:30-07:00 New Revision: 38612fbc8990fe609b08b63f82845f546c22bcff URL: https://github.com/llvm/llvm-project/commit/38612fbc8990fe609b08b63f82845f546c22bcff DIFF: https://github.com/llvm/llvm-project/commit/38612fbc8990fe609b08b63f82845f546c22bcff.diff

[PATCH] D123907: [HLSL] Add shader attribute

bogner added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like I'm guessing you meant to act

[PATCH] D124066: [clang-tidy] Ignore macros defined within declarations in modernize-macro-to-enum

aaron.ballman added a comment. This seems like a case where we might want a configuration option (maybe). Some of the test cases where you silence the diagnostic look like places I would expect us to be able to use a (local) enumeration. e.g., void g(int x) { if (x != 0) { #define INS

[PATCH] D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit. Comment at: clang-tools-extra/clang-tidy/modernize/UseUsingCheck.cpp:39-48 + Finder->addMatcher( + tagDecl( + anyOf(allOf(

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:162-164 + /// 2. If we are annotating an Objective-C method, and not a function, we + ///want to use the `nullable` form instead of `_Nullable`. + ///When \p SyntaxS

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

MosheBerman updated this revision to Diff 424010. MosheBerman edited the summary of this revision. MosheBerman added a comment. - Improved handling of `NS_ASSUME` and other edge cases/ - Added test cases, and changed the test to actually validate the output (not just the presence of fixits.) - Cl

<    1   2   3   >