Re: [PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

@sammccall ping On Tue, Apr 12, 2022 at 4:39 PM Kirill Bobyrev via Phabricator < revi...@reviews.llvm.org> wrote: > kbobyrev added a comment. > > Oops, sorry, I linked the wrong revision; here's the prototype: we plan to > start rolling it out gradually https://reviews.llvm.org/D122677 and then >

[clang] cd149db - [NFC] Remove unused variable

Author: Chuanqi Xu Date: 2022-04-19T15:19:40+08:00 New Revision: cd149dbf8ed8334e68e0f69d819bac3d400e8ba7 URL: https://github.com/llvm/llvm-project/commit/cd149dbf8ed8334e68e0f69d819bac3d400e8ba7 DIFF: https://github.com/llvm/llvm-project/commit/cd149dbf8ed8334e68e0f69d819bac3d400e8ba7.diff LO

[PATCH] D123682: [clang-tblgen] Automatically document options values

jhenderson added a comment. In D123682#3455793 , @aaron.ballman wrote: > In D123682#3454627 , > @serge-sans-paille wrote: > >> @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt >> any of

[clang] 33ec653 - [clang][lexer] Allow u8 character literal prefixes in C2x

Author: Timm Bäder Date: 2022-04-19T09:57:51+02:00 New Revision: 33ec65305525626d5d93bd794c1c9cfa55d0ca8f URL: https://github.com/llvm/llvm-project/commit/33ec65305525626d5d93bd794c1c9cfa55d0ca8f DIFF: https://github.com/llvm/llvm-project/commit/33ec65305525626d5d93bd794c1c9cfa55d0ca8f.diff LO

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33ec65305525: [clang][lexer] Allow u8 character literal prefixes in C2x (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

steakhal added a comment. What happens if the import fails? Or alternatively the `InitializeImportedDecl(FromD, ToD)` fails? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123685/new/ https://reviews.llvm.org/D123685 __

[PATCH] D123685: [clang][ASTImporter] Add isNewDecl

steakhal added inline comments. Comment at: clang/include/clang/AST/ASTImporterSharedState.h:69-75 llvm::Optional getImportDeclErrorIfAny(Decl *ToD) const { auto Pos = ImportErrors.find(ToD); if (Pos != ImportErrors.end()) return Pos->second; else

[PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. If it's possible, maybe this could be worded in a way that strongly suggests the release notes should ideally be updated in the same patch as the code change? I think we're generally good at doing this for tests. It would be great if we could treat release notes the same.

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. The Arm/AArch64 split and the generated files check looks good to me. Unless I'm missing an existing check, is it possible to check for the existing files too? I guess not nicely because along with the resource headers there are lots of internal headers, so we'd h

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead updated this revision to Diff 423555. pcwang-thead added a comment. - Disable sized deallocation for Apple targets. - Update tests and don't use `-fno-sized-deallocation` any more. - With one exception: `clang/test/SemaCXX/builtin-operator-new-delete.cpp`, which will generate two n

[clang] 454d1df - [Concepts] Fix overload resolution bug with constrained candidates

Author: Roy Jacobson Date: 2022-04-19T04:45:28-04:00 New Revision: 454d1df9423c95e54c3a2f5cb58d864096032d09 URL: https://github.com/llvm/llvm-project/commit/454d1df9423c95e54c3a2f5cb58d864096032d09 DIFF: https://github.com/llvm/llvm-project/commit/454d1df9423c95e54c3a2f5cb58d864096032d09.diff

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG454d1df9423c: [Concepts] Fix overload resolution bug with constrained candidates (authored by royjacobson). Repository: rG LLVM Github Monorepo C

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

pcwang-thead added a comment. In D112921#3453114 , @MaskRay wrote: > Beside the concern raised by platform maintainers: the cc1 default switch > part should be made separately from the patch. > This makes revert easy and leaves fewer churn to the test su

[PATCH] D122008: [flang][driver] Add support for generating executables

awarzynski added a comment. In D122008#3456445 , @clementval wrote: > Do you plan to discuss this again during the next call? Note that today is a > holiday in various country in Europe (maybe elsewhere too) so the one on 4/27 > is probably better. To

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

sammccall added a comment. Not to fix in this patch, but the move constructor of llvm::Regex is suspicious - there's no move assignment operator. This putting them in a vector seems likely to copy them when the vector reallocates. Think you could fix this? :-) Comment at: cla

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Oops, LG with comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 ___

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

iains added inline comments. Comment at: clang/include/clang/Basic/Module.h:537-543 + static StringRef getPrimaryModuleInterfaceName(StringRef Name) { +return Name.split(':').first; + } + /// Get the primary module interface name from a partition. StringRef getPrimary

[PATCH] D123957: Update the developer policy to mention release notes

jhenderson accepted this revision. jhenderson added a comment. LGTM, with suggested nits. Comment at: llvm/docs/DeveloperPolicy.rst:188 +notes, typically found in ``docs/ReleaseNotes.rst`` for the project. Changes to +a project that are user-facing or users may wish to know abo

[clang] f3ee0af - [OpenCL] opencl-c.h: Add const to get_image_num_samples

Author: Sven van Haastregt Date: 2022-04-19T10:16:44+01:00 New Revision: f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d URL: https://github.com/llvm/llvm-project/commit/f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d DIFF: https://github.com/llvm/llvm-project/commit/f3ee0afc6739bf2990f9d302ff6b28dbb0429e8d.

[PATCH] D122728: [OpenCL] opencl-c.h: Add const to get_image_num_samples

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3ee0afc6739: [OpenCL] opencl-c.h: Add const to get_image_num_samples (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122728/new/ https:

[PATCH] D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace

whisperity created this revision. whisperity added reviewers: aaron.ballman, njames93, PaulkaToast. whisperity added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. Herald added a project: All. whisperity requested

[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/WorkList.cpp:204-207 // Compare by number of times the location was visited first (negated // to prefer less often visited locations), then by insertion time (prefer // expanding nodes inserted soo

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Herald added a project: All. @aaron.ballman Alright, I think this can go. The `ReleaseNotes.rst` needs a rebase anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/ne

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. > A recent review emphasized the preference to use DefaultBool instead of bool > for checker options. What I wanted to highlight is that we should aim for consistency. We should

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423572. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/Basic/Module.h clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaLoo

[PATCH] D123352: [analyzer] Add FixItHint to `nullability.NullReturnedFromNonnull` and `nullability.NullableReturnedFromNonnull`

steakhal added a subscriber: whisperity. steakhal added a comment. In D123352#3439649 , @MosheBerman wrote: > In D123352#3439390 , @steakhal > wrote: > >> tldr; static-analyzer fixits are not completely implemen

[clang] b7c9888 - [analyzer][NFC] Introduce the checker package separator character

Author: Balazs Benics Date: 2022-04-19T12:14:27+02:00 New Revision: b7c988811d50f0f068a375292fb5f2b6df384400 URL: https://github.com/llvm/llvm-project/commit/b7c988811d50f0f068a375292fb5f2b6df384400 DIFF: https://github.com/llvm/llvm-project/commit/b7c988811d50f0f068a375292fb5f2b6df384400.diff

[clang] 63c4ca9 - [analyzer] Turn missing tablegen doc entry of a checker into fatal error

Author: Balazs Benics Date: 2022-04-19T12:14:27+02:00 New Revision: 63c4ca9d14bad909f92ef019ec85f7a1c42311f2 URL: https://github.com/llvm/llvm-project/commit/63c4ca9d14bad909f92ef019ec85f7a1c42311f2 DIFF: https://github.com/llvm/llvm-project/commit/63c4ca9d14bad909f92ef019ec85f7a1c42311f2.diff

[clang] 744e2a3 - [analyzer] ClangSA should tablegen doc urls refering to the main doc page

Author: Balazs Benics Date: 2022-04-19T12:14:27+02:00 New Revision: 744e2a3e2232db87cb68b201739956ca205dc946 URL: https://github.com/llvm/llvm-project/commit/744e2a3e2232db87cb68b201739956ca205dc946 DIFF: https://github.com/llvm/llvm-project/commit/744e2a3e2232db87cb68b201739956ca205dc946.diff

[clang] 7984189 - [analyzer] Remove HasAlphaDocumentation tablegen enum value

Author: Balazs Benics Date: 2022-04-19T12:14:27+02:00 New Revision: 798418982630b5e3acdfc7ba398993aef2071f32 URL: https://github.com/llvm/llvm-project/commit/798418982630b5e3acdfc7ba398993aef2071f32 DIFF: https://github.com/llvm/llvm-project/commit/798418982630b5e3acdfc7ba398993aef2071f32.diff

[PATCH] D122244: [analyzer] Turn missing tablegen doc entry of a checker into fatal error

This revision was automatically updated to reflect the committed changes. Closed by commit rG63c4ca9d14ba: [analyzer] Turn missing tablegen doc entry of a checker into fatal error (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D122243: [analyzer][NFC] Introduce the checker package separator character

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7c988811d50: [analyzer][NFC] Introduce the checker package separator character (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122243/

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

This revision was automatically updated to reflect the committed changes. steakhal marked an inline comment as done. Closed by commit rG744e2a3e2232: [analyzer] ClangSA should tablegen doc urls refering to the main doc page (authored by steakhal). Changed prior to commit: https://reviews.llvm.o

[PATCH] D121459: [analyzer] Remove HasAlphaDocumentation tablegen enum value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG798418982630: [analyzer] Remove HasAlphaDocumentation tablegen enum value (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/Module.h:547-548 +// is the default name showed in module map. +if (isGlobalModule()) + return ""; + I thought to add an assertion here. But I feel like it is not so necessary an

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu updated this revision to Diff 423579. ChuanqiXu added a comment. Rename Sema::CurrentModuleUnitsCache to Sema::UsableModuleUnitsCache CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123837/new/ https://reviews.llvm.org/D123837 Files: clang/include/clang/Basic/Module.h clang

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1579 + (M->getPrimaryModuleInterfaceName() == + llvm::StringRef(getLangOpts().CurrentModule).split(':').first)) { +CurrentModuleUnitsCache.insert(M); I thought to add a comm

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

steakhal added a comment. In D123155#3433715 , @tomrittervg wrote: > Just a note - I was able to test this finally and it works for what I was > trying to do. Do you have commit access? Or we shall commit this on your behalf? If the latter, please tell

[PATCH] D123837: [C++20] [Modules] Judge isInCurrentModule currently

iains added a comment. it would be good to add tests for GMF and PMF cases? Comment at: clang/include/clang/Basic/Module.h:550-553 if (isModulePartition()) { auto pos = Name.find(':'); return StringRef(Name.data(), pos); } if we find thi

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423582. kwk added a comment. - Make functions lowercase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Tooling/Inclusions/HeaderIncludes.h

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk marked 2 inline comments as done. kwk added a comment. In D121370#3456223 , @owenpan wrote: > Should we handle `#import` and `@import` for Object-C only so as to simply > the regex for C++? @owenpan my counter question probably reveals how few thing

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 423584. kwk added a comment. - typo: @include bar; -> @import bar; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 Files: clang/include/clang/Tooling/Inclusions/HeaderI

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:184-186 - // FIXME: The initializer expression must always be assigned a value. - // Replace this with an assert when we have sufficient coverage of - // language features.

[PATCH] D123858: [clang][dataflow] Ensure well-formed flow conditions.

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:112-113 cast_or_null(Env.getValue(Cond, SkipPast::Reference)); -if (Val == nullptr) - return; +// Value merging depends on flow conditions from differe

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423593. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. Fixed some grammar issues, added a bullet for fixing bugs, modified the bullet about diagnostics to include regrouping under a new

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman updated this revision to Diff 423594. aaron.ballman added a comment. Something went funny during a rebase, so this is the full update, not just changes since last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 Files: ll

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added a subscriber: xbolva00. aaron.ballman added a comment. In D123957#3458354 , @hans wrote: > If it's possible, maybe this could be worded in a way that strongly suggests > the release notes should ideally be updated in the same patch as

[PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. Looks great to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] 7641004 - Revert "[Concepts] Fix overload resolution bug with constrained candidates"

Author: Roy Jacobson Date: 2022-04-19T07:51:21-04:00 New Revision: 76410040b9f391185c7df48c14519860e1cf75e5 URL: https://github.com/llvm/llvm-project/commit/76410040b9f391185c7df48c14519860e1cf75e5 DIFF: https://github.com/llvm/llvm-project/commit/76410040b9f391185c7df48c14519860e1cf75e5.diff

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson added a subscriber: Mordante. royjacobson added a comment. So, it seems like this broke one of `basic_arg_format`'s private constructors.. Sorry for that. //format_arg.h:167 explicit basic_format_arg(_Tp __v) noexcept requires(same_as<_Tp, char_type> || (

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked an inline comment as not done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "require function types to have a prototy

[PATCH] D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace

whisperity updated this revision to Diff 423595. whisperity added a comment. **[NFC]** Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123992/new/ https://reviews.llvm.org/D123992 Files: clang-tools-extra/clang-tidy/llvmlibc/CalleeNa

[PATCH] D123957: Update the developer policy to mention release notes

nikic requested changes to this revision. nikic added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database

[PATCH] D123957: Update the developer policy to mention release notes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:195 +* Adding, removing, or regrouping a diagnostic. +* Fixing a bug (please link to the issue fixed in the bug database). +* Adding or removing an optimization. nikic wrote: > I disag

[clang] 944b25a - [OpenMP] Make Xopenmp-target args compile-only to silence warnings

Author: Joseph Huber Date: 2022-04-19T08:42:43-04:00 New Revision: 944b25aee393ceb31d847fb4d3b98695852eecc9 URL: https://github.com/llvm/llvm-project/commit/944b25aee393ceb31d847fb4d3b98695852eecc9 DIFF: https://github.com/llvm/llvm-project/commit/944b25aee393ceb31d847fb4d3b98695852eecc9.diff

[clang] 0f8b8d7 - [OpenMP][Docs] Remove old 14.0 release information

Author: Joseph Huber Date: 2022-04-19T08:45:51-04:00 New Revision: 0f8b8d79af8bf97a414986cdebfa728ce5018f80 URL: https://github.com/llvm/llvm-project/commit/0f8b8d79af8bf97a414986cdebfa728ce5018f80 DIFF: https://github.com/llvm/llvm-project/commit/0f8b8d79af8bf97a414986cdebfa728ce5018f80.diff

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added a comment. In D123831#3455048 , @cishida wrote: >> we might not always want to transform an absolute path because the resulting >> relative include name might get remapped in a headermap, for example in test >> known_files_only_hmap.c. But ho

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 423601. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[clang-tools-extra] bdf0b75 - [clangd] IncludeCleaner: Add filtering mechanism

Author: Kirill Bobyrev Date: 2022-04-19T14:56:27+02:00 New Revision: bdf0b757d5938a9f774d17e81be226da3229d3e5 URL: https://github.com/llvm/llvm-project/commit/bdf0b757d5938a9f774d17e81be226da3229d3e5 DIFF: https://github.com/llvm/llvm-project/commit/bdf0b757d5938a9f774d17e81be226da3229d3e5.diff

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf0b757d593: [clangd] IncludeCleaner: Add filtering mechanism (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D123961: [clang][dataflow] Do not crash on missing `Value` for struct-typed variable init.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:184-186 - // FIXME: The initializer expression must always be assigned a value. - // Replace this with an assert when we have sufficient coverage of - // language features. ---

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. I went to commit this, and found that a recently lit test now fails with a crash during constraint instantiation! I'll be looking into that. The example reduces to: template constexpr bool constraint = true; template void dependent(U&& u) { []() re

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks, LGTM! With minor revisions. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:749 +// E.g. char{1,3,5,127} -> uint{1,3,5,127} +// Interrupt the f

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

tomrittervg added a comment. Please commit on my behalf; you can use "Tom Ritter " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123155/new/ https://reviews.llvm.org/D123155 ___ cfe-commits mailing list

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3458357 , @DavidSpickett wrote: > Unless I'm missing an existing check, is it possible to check for the > existing files too? I guess not nicely because along with the resource > headers there are lots of internal

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

DavidSpickett added a comment. > Therefore I am keeping this patch in its current shape at this stage. Sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 _

[clang] 218b5c8 - [clang][AArch64] Remove BTI after setjmp from release notes

Author: David Spickett Date: 2022-04-19T13:49:55Z New Revision: 218b5c83940d469424564ba6f1ec488c4970a5e5 URL: https://github.com/llvm/llvm-project/commit/218b5c83940d469424564ba6f1ec488c4970a5e5 DIFF: https://github.com/llvm/llvm-project/commit/218b5c83940d469424564ba6f1ec488c4970a5e5.diff LOG

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

MyDeveloperDay added a comment. The hard part about doing 2 separate cases is where we miss-interpret a .hpp or .h file as being the wrong language (C/C++/ObjC/ObjC++), I don't think I have a problem with a single regex (its not like we change it that often). Is there a use case for having them

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Accepting but please wait for @owenpan Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D12137

[PATCH] D124004: Define __FLT_EVAL_METHOD__ when input source is stdin.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor. Herald added a subscriber: dschuff. Herald added a project: All. zahiraam requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. When the input source is stdin,

[clang] 2512a87 - [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Author: Qiongsi Wu Date: 2022-04-19T10:10:07-04:00 New Revision: 2512a875ccac158bc9b654b09e3347db167e33df URL: https://github.com/llvm/llvm-project/commit/2512a875ccac158bc9b654b09e3347db167e33df DIFF: https://github.com/llvm/llvm-project/commit/2512a875ccac158bc9b654b09e3347db167e33df.diff LO

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2512a875ccac: [clang] Adding Platform/Architecture Specific Resource Header Installation… (authored by qiongsiwu1, committed by daltenty). Repositor

[PATCH] D119544: Deferred Concept Instantiation Implementation

cor3ntin added a comment. In D119544#3458848 , @erichkeane wrote: > I went to commit this, and found that a recently lit test now fails with a > crash during constraint instantiation! I'll be looking into that. The > example reduces to: > > templat

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

pengfei added a comment. > Maybe I can ask cmake to check for architecture/targets during configuration > and select the headers automatically, but that is beyond the scope of this > patch. I'm not familar with cmake, but I guess it might be doable. I once verified the X86 headers by command `

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3458966 , @cor3ntin wrote: > In D119544#3458848 , @erichkeane > wrote: > >> I went to commit this, and found that a recently lit test now fails with a >> crash during const

[PATCH] D123300: [Clang] Enable opaque pointers by default

markus added a comment. With $ ./bin/clang -cc1 -emit-llvm BBI-68673.c the IR contains the following @a2_ldm_i64 = global [4 x [18 x { i64, i64 }]] zeroinitializer, align 16 %arrayidx = getelementptr inbounds [4 x [18 x { i64, i64 }]], ptr @a2_ldm_i64, i64 0, i64 %idxprom %.real = load

[PATCH] D123992: [clang-tidy] Fix crash on calls to overloaded operators in llvmlibc-callee-namespace

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123992/new/ https://reviews.llvm.org/D123992

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

aaron.ballman accepted this revision. aaron.ballman added a comment. Oh, yeah, this fell off my radar. Agreed, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/new/ https://reviews.llvm.org/D114292 ___ cfe-commits mailing list cfe-c

[PATCH] D123300: [Clang] Enable opaque pointers by default

nikic added a comment. @markus Without tracing through it in detail, I'd guess that without opaque pointers this creates two getelementptr constant expressions that get folded together. With opaque pointers, the first one (which would be a zero-index GEP) is omitted, and only the second one is

[clang] 82f3ed9 - [analyzer] Expose Taint.h to plugins

Author: Tom Ritter Date: 2022-04-19T16:55:01+02:00 New Revision: 82f3ed99045de9a2f06981621a485c5a47546270 URL: https://github.com/llvm/llvm-project/commit/82f3ed99045de9a2f06981621a485c5a47546270 DIFF: https://github.com/llvm/llvm-project/commit/82f3ed99045de9a2f06981621a485c5a47546270.diff LO

[PATCH] D123155: [analyzer] Expose Taint.h to plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rG82f3ed99045d: [analyzer] Expose Taint.h to plugins (authored by tomrittervg, committed by steakhal). Changed prior to commit: https://reviews.llvm.org/D123155?vs=420616&id=423622#toc Repository: rG L

[clang] 4aa5dc1 - [SystemZ] Handle SystemZ specific inline assembly address operands.

Author: Jonas Paulsson Date: 2022-04-19T16:55:45+02:00 New Revision: 4aa5dc15f0869f8a5fb6fe760c517d2d5d4c710e URL: https://github.com/llvm/llvm-project/commit/4aa5dc15f0869f8a5fb6fe760c517d2d5d4c710e DIFF: https://github.com/llvm/llvm-project/commit/4aa5dc15f0869f8a5fb6fe760c517d2d5d4c710e.diff

[PATCH] D110267: [InlineAsm, SystemZ] Handle inline assembly address operands.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4aa5dc15f086: [SystemZ] Handle SystemZ specific inline assembly address operands. (authored by jonpa). Herald added a project: clang. Herald added a

[PATCH] D119544: Deferred Concept Instantiation Implementation

tahonermann added a comment. > This is a case where the function is a template instantiation but does NOT > have a primary template, so I have to figure out what THAT means/what I > should be using instead. I think that is not supposed to be possible. For example, `FunctionDecl::isFunctionTemp

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3459045 , @tahonermann wrote: >> This is a case where the function is a template instantiation but does NOT >> have a primary template, so I have to figure out what THAT means/what I >> should be using instead. >

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

martong added a subscriber: vabridgers. martong added a comment. First of all, thanks Denys for working on this, nice work! Here are my concerns and remarks. I think this fixed set of types in `NominalTypeList` is too rigid. I don't like the fact that we have to iterate over all four types when

[PATCH] D85528: [analyzer] Fix cast evaluation on scoped enums in ExprEngine

steakhal updated this revision to Diff 423624. steakhal edited the summary of this revision. steakhal added a comment. Herald added a subscriber: manas. Herald added a project: All. rebased; I'm still interested in this. WDYT @martong BTW we have this downstream for about two years now without any

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman updated this revision to Diff 423629. aaron.ballman marked an inline comment as not done. aaron.ballman added a comment. Updated based on review feedback. - Added `-fstrict-prototypes` command line option (but there is NO `-fno-strict-prototypes` support) - Changed the way the lang

[PATCH] D123955: [C2x] Disallow functions without prototypes/functions with identifier lists

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:124 BENIGN_LANGOPT(ImplicitInt, 1, 0, "C89 implicit 'int'") +LANGOPT(StrictPrototypes , 1, 0, "require function types to have a prototype")

[PATCH] D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.

MaggieYi created this revision. MaggieYi added reviewers: echristo, jmorse, wolfgangp, probinson, dblaikie, aprantl. Herald added a project: All. MaggieYi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The detailed description of the issu

[PATCH] D123325: [Clang] Make enabling the new driver more generic

yaxunl added a comment. should we have a test to show the effect of -foffload-new-driver on -ccc-print-phases for CUDA/HIP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123325/new/ https://reviews.llvm.org/D123325 ___

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

qiongsiwu1 added a comment. In D123498#3458967 , @pengfei wrote: >> Maybe I can ask cmake to check for architecture/targets during configuration >> and select the headers automatically, but that is beyond the scope of this >> patch. > > I'm not familar

[PATCH] D123325: [Clang] Make enabling the new driver more generic

jhuber6 added a comment. In D123325#3459108 , @yaxunl wrote: > should we have a test to show the effect of -foffload-new-driver on > -ccc-print-phases for CUDA/HIP? We probably should, it's tested w/ OpenMP but we should check the bound architectures a

[PATCH] D123783: [clang] Eliminate TypeProcessingState::trivial.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:170 /// Whether we saved the attributes in the decl spec. bool hasSavedAttrs; mboehme wrote: > aaron.ballman wrote: > > Isn't the same true for this variable? It seems like:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added a comment. need a CodeGenCUDA test for the registering. Also need a Driver test for the subcommands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org/D123812 _

[PATCH] D119544: Deferred Concept Instantiation Implementation

tahonermann added a comment. > I wouldn't think so either? In this case the problem is that 'u' is not in > the re-manufactured scope, I think there is a bit of work to make sure that > lambdas ALSO get the scope of their containing function, if they are in a > functiondecl. I wouldn't expect

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

yaxunl added a comment. Also, I am wondering whether we should document the new embedding scheme: section names, symbol names, entries, etc, if it has not bee done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123812/new/ https://reviews.llvm.org

[PATCH] D119544: Deferred Concept Instantiation Implementation

erichkeane added a comment. In D119544#3459169 , @tahonermann wrote: >> I wouldn't think so either? In this case the problem is that 'u' is not in >> the re-manufactured scope, I think there is a bit of work to make sure that >> lambdas ALSO get the sc

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added a comment. In D123812#3459164 , @yaxunl wrote: > need a CodeGenCUDA test for the registering. Also need a Driver test for the > subcommands. Testing things inside the linker wrapper is a little hairy. I may need to add a special option fo

[PATCH] D123958: [randstruct] Randomize all elements of a record

aaron.ballman added a comment. I think you'll need a more targeted approach than assuming the only kinds of declarations in a struct are field-like in C. It seems that the issue you've got is with anonymous objects in a structure where the inner fields are available for lookup in the outer stru

  1   2   3   >