jhenderson added a comment. In D123682#3455793 <https://reviews.llvm.org/D123682#3455793>, @aaron.ballman wrote:
> In D123682#3454627 <https://reviews.llvm.org/D123682#3454627>, > @serge-sans-paille wrote: > >> @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt >> any of those :-) > > I'd go with: > > More than two choices: `<arg> should be 'return', 'branch', 'full', or 'none'` > Only two choices: `<arg> should be 'split' or 'single'.` FWIW, I'd actually use "must" rather than "should", but otherwise I agree with this. "should" implies there are cases where it is okay to use a different value, which is obviously not the intent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
