[PATCH] D123682: [clang-tblgen] Automatically document options values

serge-sans-paille added a comment. @aaron.ballman Any thoughs on the above suggestion? I'd be happy to adopt any of those :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123682/new/ https://reviews.llvm.org/D123682 _

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

rsmith added a comment. In D122983#3454508 , @aaron.ballman wrote: > In D122983#3454494 , @jyknight > wrote: > >> In D122983#3454406 , >> @aaron.ballman wrote: >> >>> O

[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

aaron.ballman added a comment. In D122983#3454632 , @rsmith wrote: > In D122983#3454508 , @aaron.ballman > wrote: > >> In D122983#3454494 , @jyknight >> wrote: >> >>> In

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

nickdesaulniers created this revision. nickdesaulniers added a reviewer: MaskRay. Herald added subscribers: StephenFan, dexonsmith, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D123300: [Clang] Enable opaque pointers by default

fhahn added a comment. In D123300#3454215 , @aeubanks wrote: > $ cat /tmp/a.ll > target triple = "thumbv8-unknown-linux-gnueabihf" > > define void @zot() { > bb: > br label %bb1 > > bb1: ;

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay added a comment. I wish we don't do this. https://sourceware.org/pipermail/binutils/2022-March/119940.html (`RFC: GAS: Add option to generate unused section symbols`): > This problem was fixed in the kernel (and backported by distros to their kernels if binutils was updated); it's fair

[PATCH] D123642: [clang codegen] Assume arguments of __atomic_* are aligned.

rsmith added a comment. In D123642#3450129 , @xbolva00 wrote: > Do you have any comments related to this issue by gcc devs that this is a > "known" bug? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87237#c1, from someone in the GCC MAINTAINERS file, su

[PATCH] D123300: [Clang] Enable opaque pointers by default

aeubanks added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123300/new/ https://reviews.llvm.org/D123300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith updated this revision to Diff 423164. rsmith marked 3 inline comments as done. rsmith added a comment. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 Files: clang/docs

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6577-6578 +// FIXME: This should also be in -Wc++23-compat once we have it. +def warn_use_of_unaddressable_function : Warning< + "taking address of non-addressable standard library functio

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

MaskRay added a comment. > Add support to clang (-Wa,-generate-unused-section-symbols={yes|no}) and > llvm-mc. > This feature might be used by the Linux kernel. > https://lore.kernel.org/linux-toolchains/ylluqpk4cwzeh...@hirez.programming.kicks-ass.net/ > This has been supported by GNU bin

[clang] 64c045e - Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

Author: Richard Smith Date: 2022-04-15T14:09:45-07:00 New Revision: 64c045e25b8471bbb572bd29159c294a82a86a25 URL: https://github.com/llvm/llvm-project/commit/64c045e25b8471bbb572bd29159c294a82a86a25 DIFF: https://github.com/llvm/llvm-project/commit/64c045e25b8471bbb572bd29159c294a82a86a25.diff

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64c045e25b84: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins. (authored by rsmith). Changed prior to commit: https://reviews.llv

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. In D109239#3454084 , @zahiraam wrote: > In D109239#3453770 , @glandium > wrote: > >> Is it expected that `__FLT_EVAL_METHOD__` is not set at all anymore by >> default after this change?

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

glandium added a comment. The updates in `clang/test/Preprocessor` kind of suggest this was an expected change, though... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109239/new/ https://reviews.llvm.org/D109239 ___ cfe-commits mailing list

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 423169. royjacobson marked an inline comment as done. royjacobson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/Rele

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3454354 , @dblaikie wrote: > This seems like it would significantly introduce debug info size for at least > some kinds of code - have you done any size measurements of this change? With `-DCMAKE_BUILD_TYPE=RelWithDebIn

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. section : increase in bytes for clang built with full debuginfo : %% of total binary size .debug_loclists 317782 0.0250% .debug_abbrev 88590 0.0070% .debug_info 100708340.7929% .debug_rnglists

[clang] a571f82 - Update test to handle opaque pointers flag flip.

Author: Richard Smith Date: 2022-04-15T14:51:30-07:00 New Revision: a571f82a50416b767fd3cce0fb5027bb5dfec58c URL: https://github.com/llvm/llvm-project/commit/a571f82a50416b767fd3cce0fb5027bb5dfec58c DIFF: https://github.com/llvm/llvm-project/commit/a571f82a50416b767fd3cce0fb5027bb5dfec58c.diff

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert added inline comments. Comment at: clang/test/Frontend/embed-object.ll:6 +; CHECK: @[[OBJECT:.+]] = private constant [120 x i8] c"\10\FF\10\AD{{.*}}\00", section ".llvm.offloading", align 8 +; CHECK: @llvm.compiler.used = appending global [2 x i8*] [i8* @x, i8* getele

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin abandoned this revision. cor3ntin added a comment. Herald added a project: All. Richard committed a better approach so this is no longer needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99893/new/ https://reviews.llvm.org/D99893 _

[clang] 2a404cd - [randstruct] Force errors for all platforms

Author: Bill Wendling Date: 2022-04-15T15:17:07-07:00 New Revision: 2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c URL: https://github.com/llvm/llvm-project/commit/2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c DIFF: https://github.com/llvm/llvm-project/commit/2a404cdfd8bc75de593ce0e15fff0a7a0a18ec1c.diff

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jhuber6 updated this revision to Diff 423176. jhuber6 added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122683/new/ https://reviews.llvm.org/D122683 ___

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae created this revision. python3kgae added a project: clang. Herald added subscribers: ormris, dexonsmith, okura, jdoerfert, kuter, arphaman, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423189. python3kgae edited reviewers, added: steven_wu, JonChesterfield, sscalpone, rnk, bogner, MaskRay, dexonsmith, nikic; removed: jdoerfert, sstefan1, baziotis. python3kgae edited subscribers, added: beanz; removed: mgorny, arphaman, kuter, jdoerfert,

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:6701 + class DXCJoinedOrSeparate : Option<["/", "-"], name, delete Comment at: clang/include/clang/Driver/Options.td:6715 + Group, Flags<[DXCOption, NoXarchOpt

[clang] fc30901 - Extend support for std::move etc to also cover std::as_const and

Author: Richard Smith Date: 2022-04-15T16:31:39-07:00 New Revision: fc3090109643af8d2da9822d0f99c84742b9c877 URL: https://github.com/llvm/llvm-project/commit/fc3090109643af8d2da9822d0f99c84742b9c877 DIFF: https://github.com/llvm/llvm-project/commit/fc3090109643af8d2da9822d0f99c84742b9c877.diff

[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 423190. python3kgae added a comment. Fix format in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123884/new/ https://reviews.llvm.org/D123884 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D123885: Revert "Revert "Revert "[clang][pp] adds '#pragma include_instead'"""

cjdb created this revision. cjdb added reviewers: rsmith, aaron.ballman. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits.

[clang] cac8116 - [OpenMP] Don't manually strip sections in the linker wrapper

Author: Joseph Huber Date: 2022-04-15T20:35:25-04:00 New Revision: cac81161ed1386b32443e13ab513c6a3d081d6a7 URL: https://github.com/llvm/llvm-project/commit/cac81161ed1386b32443e13ab513c6a3d081d6a7 DIFF: https://github.com/llvm/llvm-project/commit/cac81161ed1386b32443e13ab513c6a3d081d6a7.diff

[clang] 984a0dc - [OpenMP] Use new offloading binary when embedding offloading images

Author: Joseph Huber Date: 2022-04-15T20:35:26-04:00 New Revision: 984a0dc386553f28068716a087d65ccf8a92889b URL: https://github.com/llvm/llvm-project/commit/984a0dc386553f28068716a087d65ccf8a92889b DIFF: https://github.com/llvm/llvm-project/commit/984a0dc386553f28068716a087d65ccf8a92889b.diff

[PATCH] D122683: [OpenMP] Use new offloading binary when embedding offloading images

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984a0dc38655: [OpenMP] Use new offloading binary when embedding offloading images (authored by jhuber6). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

wolfgangp added a comment. Hi, there seems to be a unit test failure, for example here . /home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/tools/clang/unittests/Driver/./ClangDriverTests --gtest_filter=DxcModeTest.TargetProf

[clang] 329abac - Blind stab in the dark to fix a bot failure

Author: Chris Bieneman Date: 2022-04-15T20:12:59-05:00 New Revision: 329abac134a35acc81bfab30a87130a3c208be2a URL: https://github.com/llvm/llvm-project/commit/329abac134a35acc81bfab30a87130a3c208be2a DIFF: https://github.com/llvm/llvm-project/commit/329abac134a35acc81bfab30a87130a3c208be2a.diff

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

beanz added a comment. @wolfgangp I can't reproduce the failure locally, but I have a guess what's going wrong. I _think_ the issue is that the SmallStrings aren't null terminated and the cleared allocations aren't zero'd. I pushed a speculative fix in rG329abac134a3

[clang] 33b604d - [OpenMP] Fix linting diagnostics in the linker wrapper

Author: Joseph Huber Date: 2022-04-15T21:19:29-04:00 New Revision: 33b604d1c3017a6d09e47384566353efe7bbfe57 URL: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57 DIFF: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57.diff

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

cishida added a comment. > we might not always want to transform an absolute path because the resulting > relative include name might get remapped in a headermap, for example in test > known_files_only_hmap.c. But how does it work with modules where we need > relative includes? Is the setup in

[clang] e8760b5 - [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

Author: Shilei Tian Date: 2022-04-15T21:34:28-04:00 New Revision: e8760b51ee0f972587cb0af922a3f828ab6926d6 URL: https://github.com/llvm/llvm-project/commit/e8760b51ee0f972587cb0af922a3f828ab6926d6 DIFF: https://github.com/llvm/llvm-project/commit/e8760b51ee0f972587cb0af922a3f828ab6926d6.diff L

[PATCH] D123862: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8760b51ee0f: [Clang][OpenMP] Use bitfields for flags in `OMPAtomicDirective` (authored by tianshilei1992). Repository: rG LLVM Github Monorepo C

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 423198. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae created this revision. python3kgae added a reviewer: wolfgangp. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123887 Fi

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae added a comment. Created new patch to fix the test fail at https://reviews.llvm.org/D123887 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://reviews.llvm.org/D122865 ___ cfe-

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

beanz added a comment. I already merged a fix to resolve the test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits mailing list cfe-commi

[PATCH] D123887: [HLSL][clang][Driver] Fix test error for use SmallString::data instead SmallString::c_str.

python3kgae abandoned this revision. python3kgae added a comment. Thanks. Close this RP then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123887/new/ https://reviews.llvm.org/D123887 ___ cfe-commits ma

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: aaron.ballman, klimek. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. LegalizeAdulthood requested review of this revision. When a macr

[PATCH] D123889: [clang-tidy] Improve macro handling in modernize-macro-to-enum

LegalizeAdulthood added a comment. This is an initial pass. While I believe the code handles other scenarios, I still need to add some more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123889/new/ https://reviews.llvm.org/D123889 __

[clang] 468c7b6 - [test] Test -Werror=foo -Wfoo & -Werror -Wno-error=foo -Wfoo

Author: Fangrui Song Date: 2022-04-15T20:14:07-07:00 New Revision: 468c7b65e578dd8decc3d7a2f9dce88410503fd1 URL: https://github.com/llvm/llvm-project/commit/468c7b65e578dd8decc3d7a2f9dce88410503fd1 DIFF: https://github.com/llvm/llvm-project/commit/468c7b65e578dd8decc3d7a2f9dce88410503fd1.diff

[clang] 7fde4e2 - Add some helpers to better check Scope's kind. NFC

Author: Jun Zhang Date: 2022-04-16T11:31:40+08:00 New Revision: 7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9 URL: https://github.com/llvm/llvm-project/commit/7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9 DIFF: https://github.com/llvm/llvm-project/commit/7fde4e221300dbdefe9cdd70ff59f22f1dc9aee9.diff LOG

<    1   2