cishida added a comment.

> we might not always want to transform an absolute path because the resulting 
> relative include name might get remapped in a headermap, for example in test 
> known_files_only_hmap.c. But how does it work with modules where we need 
> relative includes? Is the setup in known_files_only_hmap even valid?

I think, in most cases, this shouldn't matter because if the header path input 
doesn't match the location stored in the header map, they should still have the 
same source content. The same should be true with header search resolution with 
modules & vfsoverlay


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123831/new/

https://reviews.llvm.org/D123831

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to