[PATCH] D122830: [clang][dataflow] Add support for (built-in) (in)equality operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef1e1b3106a5: [clang][dataflow] Add support for (built-in) (in)equality operators (authored by ymandel). Repository: rG LLVM Github Monorepo CHAN

[clang] 01db103 - [clang][dataflow] Add support for correlation of boolean (tracked) values

Author: Yitzhak Mandelbaum Date: 2022-04-01T17:25:49Z New Revision: 01db10365e935ccca9dc2ed449b23319e170eea0 URL: https://github.com/llvm/llvm-project/commit/01db10365e935ccca9dc2ed449b23319e170eea0 DIFF: https://github.com/llvm/llvm-project/commit/01db10365e935ccca9dc2ed449b23319e170eea0.diff

[PATCH] D122838: [clang][dataflow] Add support for correlation of boolean (tracked) values

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG01db10365e93: [clang][dataflow] Add support for correlation of boolean (tracked) values (authored by ymandel). Changed prior to commit: https://reviews.llvm.org

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa created this revision. yihanaa added reviewers: rsmith, erichkeane, aaron.ballman. yihanaa added a project: clang. Herald added a project: All. yihanaa requested review of this revision. Herald added a subscriber: cfe-commits. Thanks for @rsmith to point this. I'm sorry for introducing thi

[PATCH] D122908: [clang][dataflow] Add support for clang's `__builtin_expect`.

ymandel updated this revision to Diff 419802. ymandel added a comment. add tests for other builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122908/new/ https://reviews.llvm.org/D122908 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp

[PATCH] D122908: [clang][dataflow] Add support for clang's `__builtin_expect`.

ymandel updated this revision to Diff 419804. ymandel added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122908/new/ https://reviews.llvm.org/D122908 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp clang/unittests/Anal

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman marked 3 inline comments as done. aaron.ballman added inline comments. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function declaration without a prototype is deprecated in all version

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka updated this revision to Diff 419816. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122869/new/ https://reviews.llvm.org/D122869 Files: clang/test/Unit/lit.cfg.py clang/test/lit.cfg.py cross-proj

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ItaniumMangle.cpp:5576 + "program to refer to the anonymous union, and there is therefore no need " + "to mangle its name. '"); +

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf98f973a13: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs (authored by erichkeane). Herald added a project: clang. Reposi

[clang] 4cf98f9 - [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

Author: Erich Keane Date: 2022-04-01T11:31:14-07:00 New Revision: 4cf98f973a13c5049322abff43f0dff3c214311b URL: https://github.com/llvm/llvm-project/commit/4cf98f973a13c5049322abff43f0dff3c214311b DIFF: https://github.com/llvm/llvm-project/commit/4cf98f973a13c5049322abff43f0dff3c214311b.diff L

[clang] 861c189 - Add some wildcards to pass FP difference on one of the buildbots

Author: Erich Keane Date: 2022-04-01T12:04:20-07:00 New Revision: 861c189d2a5203ba8c8e983e8d2e109c0de153a5 URL: https://github.com/llvm/llvm-project/commit/861c189d2a5203ba8c8e983e8d2e109c0de153a5 DIFF: https://github.com/llvm/llvm-project/commit/861c189d2a5203ba8c8e983e8d2e109c0de153a5.diff L

[clang] eb92098 - FIX the wildcards to pass an FP diff in mangle-nttp-anon-union.cpp

Author: Erich Keane Date: 2022-04-01T12:22:44-07:00 New Revision: eb920989865d992093993143ba3c6e71126cbb89 URL: https://github.com/llvm/llvm-project/commit/eb920989865d992093993143ba3c6e71126cbb89 DIFF: https://github.com/llvm/llvm-project/commit/eb920989865d992093993143ba3c6e71126cbb89.diff L

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek created this revision. phosek added reviewers: ldionne, smeenai, beanz. Herald added subscribers: abrachet, mgorny, dberris. Herald added a project: All. phosek requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. co

[PATCH] D122931: [CMake][compiler-rt] Support for using in-tree libc++

phosek updated this revision to Diff 419831. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122931/new/ https://reviews.llvm.org/D122931 Files: clang/cmake/caches/Fuchsia-stage2.cmake compiler-rt/CMakeL

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6393 +// If Val is null, that implies there were multiple declarations that each +// had a claim to the unmangled name. In this case, generation of hte alias +// is suppressed. See Code

[PATCH] D122869: [lit] Fix setup of sanitizer environment

ychen added inline comments. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']: -if symbolizer in os.environ: -config.environment[symbolizer] = os.environ[symb

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka added inline comments. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']: -if symbolizer in os.environ: -config.environment[symbolizer] = os.environ

[PATCH] D122935: [AST] Dont invalidate a ref-type var decl if it has no initializer.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. This would allow more AST nodes being preserved for broken code, and have a more consistent valid bit for ref-type var decl (curre

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6393 +// If Val is null, that implies there were multiple declarations that each +// had a claim to the unmangled name. In this case, generation

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

erichkeane updated this revision to Diff 419840. erichkeane marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122608/new/ https://reviews.llvm.org/D122608 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.h clang/test/CodeGenCX

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! I left one final comment about a double period that was my fault. Comment at: clang/lib/CodeGen/CodeGenModule.h:1578 + /// may not reference ali

[clang] 9ba8c40 - Fix behavior of ifuncs with 'used' extern "C" static functions

Author: Erich Keane Date: 2022-04-01T13:00:59-07:00 New Revision: 9ba8c4024b52bb8d0491fa1d15790ce7e9a9eae1 URL: https://github.com/llvm/llvm-project/commit/9ba8c4024b52bb8d0491fa1d15790ce7e9a9eae1 DIFF: https://github.com/llvm/llvm-project/commit/9ba8c4024b52bb8d0491fa1d15790ce7e9a9eae1.diff L

[PATCH] D122608: Fix behavior of ifuncs with 'used' extern "C" static functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ba8c4024b52: Fix behavior of ifuncs with 'used' extern "C" static functions (authored by erichkeane). Herald added a project: clang. Changed prior

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman updated this revision to Diff 419844. aaron.ballman marked 5 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895 Files: clang/docs/ReleaseNo

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/2009-06-01-addrofknr.c:8 -static int func(f) +static int func(f) // expected-warning {{this function declaration without a prototype is deprecated in all versions of C and changes behavior in C2x}} void *f;

[PATCH] D120662: [clang-offload-bundler] add -input/-output options

scchan updated this revision to Diff 419847. scchan added a comment. update the failing lit tests to recognize the new switches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120662/new/ https://reviews.llvm.org/D120662 Files: clang/lib/Driver/To

[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

aaron.ballman updated this revision to Diff 419853. aaron.ballman added a comment. Fix failing test case caught by precommit CI. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122895/new/ https://reviews.llvm.org/D122895 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/D

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

avogelsgesang accepted this revision. avogelsgesang added a comment. This revision is now accepted and ready to land. LGTM (for whatever that's worth - still pretty unexperienced with the clang AST) Thanks for picking this up again! Looking forward to have this available in clangd! :) Reposito

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

avogelsgesang added a comment. > Not easy to do in this patch, we don't have a good way to associate fixes > with clang diagnostics yet. Is this a clangd-specific implementation issue or a general short-coming in the LSP protocol? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] f547fc8 - [clang-tidy] Add modernize-macro-to-enum check

Author: Richard Date: 2022-04-01T15:24:21-06:00 New Revision: f547fc89c0730e0fee220d790957791bdfd23fcd URL: https://github.com/llvm/llvm-project/commit/f547fc89c0730e0fee220d790957791bdfd23fcd DIFF: https://github.com/llvm/llvm-project/commit/f547fc89c0730e0fee220d790957791bdfd23fcd.diff LOG:

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall added a comment. Thanks! In D116514#3423420 , @avogelsgesang wrote: >> Not easy to do in this patch, we don't have a good way to associate fixes >> with clang diagnostics yet. > > Is this a clangd-specific implementation issue or a general sh

[PATCH] D120864: [AArch64] Avoid scanning feature list for target parsing

tyb0807 updated this revision to Diff 419866. tyb0807 added a comment. Herald added a subscriber: MaskRay. Refactor fp16 feature handling and add more fp16 tests for v8.5 and later Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120864/new/ https://r

[PATCH] D122698: [clangd] Add support to extract method for ExtractFunction Tweak

FabioRS updated this revision to Diff 419868. FabioRS marked an inline comment as done. FabioRS added a comment. I did some simple refactor on the code I did for the function-method and it fixed the namespace syntactic problem too. I am not sure if it expands the pull request scope. CHANGES SI

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim marked 7 inline comments as done. hctim added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/test/Lexer/has_feature_memtag_stack.cpp:2 +// RUN: %clang_cc1 -E -fsanitize=memtag-stack %s -o - | FileCheck --check-prefix=CHECK-MEMTAG %s +// RUN: %cla

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

hctim updated this revision to Diff 419874. hctim marked an inline comment as done. hctim added a comment. (comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118948/new/ https://reviews.llvm.org/D118948 Files: clang/include/clang/Basic/Dia

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. In D116203#3255018 , @aaron.ballman wrote: > In D116203#3220165 , @aaron.ballman > wrote: > >> The summary for the patch explains what's being added, but there's really no >> information a

[PATCH] D122768: [WIP][Clang] Support capturing structured bindings in lambdas

cor3ntin updated this revision to Diff 419880. cor3ntin added a comment. Try to rerun the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122768/new/ https://reviews.llvm.org/D122768 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertU

[PATCH] D122869: [lit] Fix setup of sanitizer environment

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. I'm looking at relevant code recently. This LGTM. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZE

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D122820: [GH54588]Fix ItaniumMangler for NTTP unnamed unions w/ unnamed structs

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/31733/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122820/new/ https://reviews.l

[clang] 9262d03 - [NFCI] clang-format SanitizerArgs.cpp

Author: Mitch Phillips Date: 2022-04-01T16:38:15-07:00 New Revision: 9262d031a452c96bf69d2db75ef62e3ea973a828 URL: https://github.com/llvm/llvm-project/commit/9262d031a452c96bf69d2db75ef62e3ea973a828 DIFF: https://github.com/llvm/llvm-project/commit/9262d031a452c96bf69d2db75ef62e3ea973a828.diff

[PATCH] D122865: [HLSL][clang][Driver] Support target profile command line option.

python3kgae updated this revision to Diff 419893. python3kgae added a comment. Herald added a subscriber: ormris. Change lit test to unit test to avoid require build DirectX target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122865/new/ https://

[PATCH] D121756: [clang-format] Clean up code looking for if statements NFC

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:252-256 +} else if (OpeningParen.isConditionLParen(/*IncludeFor=*/false) || + (OpeningParen.Previous && +OpeningParen.Previous->isOneOf(TT_BinaryOperator, tok::l_paren

[clang] 492cb7b - [clang-format] Fix a crash in qualifier alignment

Author: Owen Pan Date: 2022-04-01T17:30:59-07:00 New Revision: 492cb7bf91648058f3fc9ca37f9383786f7ce718 URL: https://github.com/llvm/llvm-project/commit/492cb7bf91648058f3fc9ca37f9383786f7ce718 DIFF: https://github.com/llvm/llvm-project/commit/492cb7bf91648058f3fc9ca37f9383786f7ce718.diff LOG:

[PATCH] D122756: [clang-format] Fix a crash in qualifier alignment

owenpan closed this revision. owenpan added a comment. rG492cb7bf9164 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122756/new/ https://reviews.llvm.org/D122756 ___

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

MaskRay added a comment. Is this a problem with D105462 ? Should -msse4.2 imply -mcrc32? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789

[PATCH] D118948: [MTE] Add -fsanitize=memtag* and friends.

MaskRay added inline comments. Comment at: clang/test/CodeGen/memtag-attr.cpp:18 +// CHECK-NO-NOT: sanitize_memtag +// CHECK-NO-NEXT: define {{.*}}HasSanitizeMemTag +// CHECK-MEMTAG: Function Attrs: {{.*}} sanitize_memtag By placing a space before `HasSanitizeMem

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 419923. yihanaa added a comment. Reformat code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/dump-str

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 419928. yihanaa added a comment. Reformat code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/dump-stru

[PATCH] D122781: Refactor sanitizer options handling for AMDGPU Toolchain

ampandey-AMD added a comment. In D122781#3422366 , @yaxunl wrote: > LGTM. Thanks. Hi @yaxunl , I don't have commit access to llvm trunk. Could you please commit on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3423846 , @MaskRay wrote: > Is this a problem with D105462 ? Should > -msse4.2 imply -mcrc32? -msse4.2 implies -mcrc32: https://godbolt.org/z/xaPccrKx3 Repository: rG LLVM Github

[clang] 979d876 - [X86][AMX] enable amx cast intrinsics in FE.

Author: Luo, Yuanke Date: 2022-04-02T14:02:35+08:00 New Revision: 979d876bb4e93db1be50360a4941b83319d4e114 URL: https://github.com/llvm/llvm-project/commit/979d876bb4e93db1be50360a4941b83319d4e114 DIFF: https://github.com/llvm/llvm-project/commit/979d876bb4e93db1be50360a4941b83319d4e114.diff L

[PATCH] D122567: [X86][AMX] enable amx cast intrinsics in FE.

This revision was automatically updated to reflect the committed changes. Closed by commit rG979d876bb4e9: [X86][AMX] enable amx cast intrinsics in FE. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122567/new/ https://review

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. So it's interesting, it shouldn't fail that way https://godbolt.org/z/jcqx5x9j7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122789/new/ https://reviews.llvm.org/D122789 ___ cfe

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rjmccall added a comment. In D116203#3423594 , @cjdb wrote: > In D116203#3277515 , @zoecarver > wrote: > >> This patch looks awesome, Chris. >> >> Does it make sense to have builtins for `add_const`, etc.? Isn't

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

MaskRay added a comment. In D122789#3424213 , @pengfei wrote: > In D122789#3423846 , @MaskRay wrote: > >> Is this a problem with D105462 ? Should >> -msse4.2 imply -mcrc32? > > -

[clang] d369dd1 - [clang][Sparc] Enable IAS on the remaining OS's

Author: Brad Smith Date: 2022-04-02T02:18:30-04:00 New Revision: d369dd1c0660b9fde723215e82d82019a2d4c296 URL: https://github.com/llvm/llvm-project/commit/d369dd1c0660b9fde723215e82d82019a2d4c296 DIFF: https://github.com/llvm/llvm-project/commit/d369dd1c0660b9fde723215e82d82019a2d4c296.diff LO

[PATCH] D122965: Correct Command

ps-19 created this revision. ps-19 added reviewers: aaron.ballman, ktkachov, beanz, phosek, ldionne, smeenai, compnerd. Herald added a subscriber: pengfei. Herald added a project: All. ps-19 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D122789: [compiler-rt] [scudo] Use -mcrc32 on x86 when available

pengfei added a comment. In D122789#3424226 , @MaskRay wrote: > In D122789#3424213 , @pengfei wrote: > >> In D122789#3423846 , @MaskRay >> wrote: >> >>> Is this a problem

<    1   2