[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

2022-03-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: mgorny, sunlin. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The rule was added in 2014 to support -stdli

[clang] ce21c92 - [Clang] Work with multiple pragmas weak before definition

2022-03-24 Thread Hubert Tong via cfe-commits
Author: Hubert Tong Date: 2022-03-24T20:17:49-04:00 New Revision: ce21c926f8efe969717e21e3ae6c5a3246b3d455 URL: https://github.com/llvm/llvm-project/commit/ce21c926f8efe969717e21e3ae6c5a3246b3d455 DIFF: https://github.com/llvm/llvm-project/commit/ce21c926f8efe969717e21e3ae6c5a3246b3d455.diff L

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

2022-03-24 Thread Hubert Tong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce21c926f8ef: [Clang] Work with multiple pragmas weak before definition (authored by hubert.reinterpretcast). Changed prior to commit: https://reviews.llvm.org/D121927?vs=417755&id=418092#toc Repositor

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

2022-03-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Why is --overlay-platform-toolchain added instead of using `-isystem` and `-L`? > In some cases, we need to set alternative toolchain path other than the > default with system (headers, libraries, dynamic linker prefix, ld path, > etc.), e.g., to pick up newer component

[PATCH] D122443: [OpenMP] Replace device kernel linkage with weak_odr

2022-03-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122443/new/ https://reviews.llvm.org/D122443 ___

[clang] 350d43f - Fix a bug where an extended vector of __fp16 was being converted to a

2022-03-24 Thread Akira Hatanaka via cfe-commits
Author: Akira Hatanaka Date: 2022-03-24T18:06:10-07:00 New Revision: 350d43f1efd711d057cdb53decabb6f32491dff0 URL: https://github.com/llvm/llvm-project/commit/350d43f1efd711d057cdb53decabb6f32491dff0 DIFF: https://github.com/llvm/llvm-project/commit/350d43f1efd711d057cdb53decabb6f32491dff0.diff

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

2022-03-24 Thread Zixu Wang via Phabricator via cfe-commits
zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Add support for Objective-C interface declarations in ExtractAPI. - Use `clang::Language` for l

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-24 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. In D120874#3404420 , @ChuanqiXu wrote: > @vsapsai @dblaikie I want to make sure if this one would affect clang > modules. Or simply, would the name of clang modules contain `:`? (`:` is the > separator of C++20 modules partition

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-24 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. By the way, tried a module name with a colon and ModuleMapParser doesn't accept it include/module.modulemap:1:12: error: skipping stray token module Test:Colon { ^ include/module.modulemap:1:13: error: expected '{' to start module 'Test' module Test:

[clang] b62ea9b - [AVR] Add more devices

2022-03-24 Thread Ben Shi via cfe-commits
Author: Ben Shi Date: 2022-03-25T01:43:41Z New Revision: b62ea9b38b627ce2a96f66242c15250d59a9b134 URL: https://github.com/llvm/llvm-project/commit/b62ea9b38b627ce2a96f66242c15250d59a9b134 DIFF: https://github.com/llvm/llvm-project/commit/b62ea9b38b627ce2a96f66242c15250d59a9b134.diff LOG: [AVR]

[PATCH] D122401: [AVR] Add more devices

2022-03-24 Thread Ben Shi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb62ea9b38b62: [AVR] Add more devices (authored by benshi001). Herald added a subscriber: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D122413: [C++20][Modules] Limit ModuleInternalLinkage to modules-ts.

2022-03-24 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122413/new/ https://reviews.llvm.org/D122413

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

2022-03-24 Thread Tao He via Phabricator via cfe-commits
sighingnow updated this revision to Diff 418107. sighingnow added a comment. Fixes the enumerate values. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 Files: clang/bindings/python/clang/cindex.py cl

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

2022-03-24 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D120874#3406954 , @vsapsai wrote: > By the way, tried a module name with a colon and ModuleMapParser doesn't > accept it > > include/module.modulemap:1:12: error: skipping stray token > module Test:Colon { >

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

2022-03-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2707-2708 + if (FormatTok->is(tok::l_brace)) { +CompoundStatementIndenter Indenter(this, Style, Line->Level); +FormatToken *LeftBrace = FormatTok; +parseBlock(); You

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

2022-03-24 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D119409#3405733 , @dblaikie wrote: > is this an issue for Clang Header Modules codegen too? (maybe the solution > should be the same for both, then) For my limited knowledge to clang header modules, `.modulemap` is a necess

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

2022-03-24 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood marked 3 inline comments as done. LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; aaron.ballman wrote: > LegalizeAdulthood wrote: > > aaron.ballman

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

2022-03-24 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood updated this revision to Diff 418112. LegalizeAdulthood added a comment. - clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/clang-

[PATCH] D122455: Revert "[RISCV] Add policy operand for masked compare and vmsbf/vmsif/vmsof IR"

2022-03-24 Thread Zakk Chen via Phabricator via cfe-commits
khchen created this revision. khchen added reviewers: craig.topper, rogfer01, frasercrmck, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: s, VincentWu, luke957, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,

[PATCH] D122408: [pseudo] [WIP2] Implement GLR parser

2022-03-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 418127. sammccall added a comment. Smarter reduce algorithm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122408/new/ https://reviews.llvm.org/D122408 Files: clang-tools-extra/pseudo/include/clang-pseudo/F

[PATCH] D122409: [libclang] Add missing CursorKind enums defined in Index.h.

2022-03-24 Thread Tao He via Phabricator via cfe-commits
sighingnow added a comment. Polite ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122409/new/ https://reviews.llvm.org/D122409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

2022-03-24 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf added a comment. Hi, > Why is --overlay-platform-toolchain added instead of using -isystem and -L? > > The functionality overlaps with -B. Unsure why introduce a new mechanism. We may want to use an extra toolchain like the Advance Toolchain (https://github.com/advancetoolchain/advance-to

[PATCH] D122460: [clang] fixed bug #54406

2022-03-24 Thread Randy via Phabricator via cfe-commits
randyli created this revision. randyli added reviewers: doug.gregor, rjmccall, rsmith, dblaikie, tigerleapgorge. Herald added a project: All. randyli requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. try to fix bug #54406 Per [class.access.

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

2022-03-24 Thread Scott Linder via Phabricator via cfe-commits
scott.linder updated this revision to Diff 418135. scott.linder retitled this revision from "[AMDGPU] Only warn when mixing printf and hostcall" to "[AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5". scott.linder edited the summary of this revision. scott.linder added a co

[PATCH] D121756: [clang-format] Clean up code looking for if statements

2022-03-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D121756#3398165 , @sstwcw wrote: > It turned out this patch does change behavior. > > - while ( > - FormatTok->isOneOf(tok::identifier, tok::kw_requires, > tok::coloncolon)) { > + while (FormatTok->isOneOf(tok::id

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

2022-03-24 Thread Sameer Sahasrabuddhe via Phabricator via cfe-commits
sameerds added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9381 + M.getTarget().getTargetOpts().CodeObjectVersion != 500) { +F->addFnAttr("amdgpu-no-hostcall-ptr"); + } The frontend does not need to worry about this attribute. See the

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

2022-03-24 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 418140. nridge added a comment. Remove clangd test, remove explicit deduction guide from clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113874/new/ https://reviews.llvm.org/D113874 Files: clang/lib/

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

2022-03-24 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56a54910c597: [clang] Propagate requires-clause from constructor template to implicit… (authored by nridge). Repository: rG LLVM Github Monorepo

[clang] 56a5491 - [clang] Propagate requires-clause from constructor template to implicit deduction guide

2022-03-24 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2022-03-25T02:46:22-04:00 New Revision: 56a54910c5978947adfcf230f360a15b34c0e32e URL: https://github.com/llvm/llvm-project/commit/56a54910c5978947adfcf230f360a15b34c0e32e DIFF: https://github.com/llvm/llvm-project/commit/56a54910c5978947adfcf230f360a15b34c0e32e.diff

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

2022-03-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D121992#3407220 , @qiucf wrote: > Hi, > >> Why is --overlay-platform-toolchain added instead of using -isystem and -L? >> >> The functionality overlaps with -B. Unsure why introduce a new mechanism. > > We may want to use an ex

<    1   2   3