[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer && CurLexer->Is_Pra

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

sammccall added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer && CurLexer->Is_Pra

[PATCH] D122249: [Clang] Add a compatibiliy warning for non-literals in constexpr.

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:1905-1907 + CheckLiteralType(SemaRef, Kind, VD->getLocation(), VD->getType(), + diag::warn_cxx20_compat_constexpr_var, + isa(Dcl),

[PATCH] D121969: Pass split-machine-functions to code generator when flto is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG72acd042bad3: Pass split-machine-functions to code generator when flto is used (authored by junfd, committed by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 72acd04 - Pass split-machine-functions to code generator when flto is used

Author: Junfeng Dong Date: 2022-03-23T08:55:30-07:00 New Revision: 72acd042bad35f78232f17addc02196a7af1a6e9 URL: https://github.com/llvm/llvm-project/commit/72acd042bad35f78232f17addc02196a7af1a6e9 DIFF: https://github.com/llvm/llvm-project/commit/72acd042bad35f78232f17addc02196a7af1a6e9.diff

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:68 return true; // Fixes are always in the main file. if (!D.Fixes.empty()) update

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417648. rZhBoYao edited the summary of this revision. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Added an entry in release notes. Waiting for CI... Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang-tools-extra] b857a50 - [clangd] Support include-fixer inside macro arguments.

Author: Sam McCall Date: 2022-03-23T17:12:33+01:00 New Revision: b857a5092c5e07121426196e79d51400382ff27a URL: https://github.com/llvm/llvm-project/commit/b857a5092c5e07121426196e79d51400382ff27a DIFF: https://github.com/llvm/llvm-project/commit/b857a5092c5e07121426196e79d51400382ff27a.diff LO

[PATCH] D120619: [clangd] Support include-fixer inside macro arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb857a5092c5e: [clangd] Support include-fixer inside macro arguments. (authored by sammccall). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D120619?vs=411622&id=417655#t

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. Thanks for the fix! Can you please add a release note as well? Comment at: clang/test/CodeGen/dump-struct-builtin.c:653 + // CHECK: call i32 (i8*, ...) @printf( + __builtin_dump_struct(&a, &printf); +} Can you add some test cov

[clang-tools-extra] 2da5c57 - [clangd] Add inlay hints for auto-typed parameters with one instantiation.

Author: Sam McCall Date: 2022-03-23T17:26:25+01:00 New Revision: 2da5c5781e5a833f52a47752d76423bbb7bcf1a1 URL: https://github.com/llvm/llvm-project/commit/2da5c5781e5a833f52a47752d76423bbb7bcf1a1 DIFF: https://github.com/llvm/llvm-project/commit/2da5c5781e5a833f52a47752d76423bbb7bcf1a1.diff LO

[PATCH] D120258: [clangd] Add inlay hints for auto-typed parameters with one instantiation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da5c5781e5a: [clangd] Add inlay hints for auto-typed parameters with one instantiation. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D120258?vs=410814&id=417658#toc Repos

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:269 +// the implication `(opt.value_or(X) != X) => opt.hasValue()`. +State.Env.addToFlowCondition( +State.Env.makeImplication(*ComparisonExprValu

[PATCH] D122325: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The generated arm_neon.h header isn't -Wdeclaration-after-statemen

[PATCH] D122325: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. D122189 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122325/new/ https://reviews.llvm.org/D122325 ___

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417661. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix incorrect REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D12

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

ributzka accepted this revision. ributzka added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

aaron.ballman added a comment. In D109701#3376127 , @vaibhav.y wrote: > Hi, > > Apologies for the long delay! I was on a break to focus to other projects. Not a problem at all! > I have some changes in mind such as: > > - Creating the `SarifLog` object

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. Seems reasonable to me. Obviously needs release notes + the tests that Aaron did, but I think this looks right. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122248/new/ https://reviews.llvm.org/D122248 __

[clang] 5ef2ec7 - [clang][extract-api] Suppprt for the module name property in SymbolGraph

Author: Daniel Grumberg Date: 2022-03-23T16:34:08Z New Revision: 5ef2ec7e4e129cb9a1d9e688fbf8590a85f01530 URL: https://github.com/llvm/llvm-project/commit/5ef2ec7e4e129cb9a1d9e688fbf8590a85f01530 DIFF: https://github.com/llvm/llvm-project/commit/5ef2ec7e4e129cb9a1d9e688fbf8590a85f01530.diff LO

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ef2ec7e4e12: [clang][extract-api] Suppprt for the module name property in SymbolGraph (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1221

[clang] 355f1c7 - [Clang] Fix PR28101

Author: PoYao Chang Date: 2022-03-24T00:38:45+08:00 New Revision: 355f1c75aa66fc3d9bef897375f5e0979a55001d URL: https://github.com/llvm/llvm-project/commit/355f1c75aa66fc3d9bef897375f5e0979a55001d DIFF: https://github.com/llvm/llvm-project/commit/355f1c75aa66fc3d9bef897375f5e0979a55001d.diff L

[PATCH] D115248: [Clang] Fix PR28101

This revision was automatically updated to reflect the committed changes. Closed by commit rG355f1c75aa66: [Clang] Fix PR28101 (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files:

[clang] 5a2e56b - [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

Author: Nick Desaulniers Date: 2022-03-23T09:40:43-07:00 New Revision: 5a2e56b70e2fa7ad0d82e54bc4c741b16f05e475 URL: https://github.com/llvm/llvm-project/commit/5a2e56b70e2fa7ad0d82e54bc4c741b16f05e475 DIFF: https://github.com/llvm/llvm-project/commit/5a2e56b70e2fa7ad0d82e54bc4c741b16f05e475.di

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2e56b70e2f: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement (authored by nickdesaulniers). Repository: rG LLVM Github

[PATCH] D121873: [clang][extract-api] Add enum support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121873/new/ https://reviews.llvm.org/D121873 ___ cf

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast updated this revision to Diff 417666. hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added a comment. - Address review comments: Return `const` from getAlias() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 71b4c22 - [clang][extract-api] Add enum support

Author: Zixu Wang Date: 2022-03-23T09:41:21-07:00 New Revision: 71b4c22612a06c950d31db83a45dee7412a64c64 URL: https://github.com/llvm/llvm-project/commit/71b4c22612a06c950d31db83a45dee7412a64c64 DIFF: https://github.com/llvm/llvm-project/commit/71b4c22612a06c950d31db83a45dee7412a64c64.diff LOG

[PATCH] D121873: [clang][extract-api] Add enum support

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b4c22612a0: [clang][extract-api] Add enum support (authored by zixuw). Changed prior to commit: https://reviews.llvm.org/D121873?vs=417424&id=417667#toc Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast added a comment. @aaron.ballman, I believe I have responded to all of the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121927/new/ https://reviews.llvm.org/D121927 ___ c

[PATCH] D122202: [clang][extract-api] Add struct support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122202/new/ https://reviews.llvm.org/D122202 ___ cf

[clang] 5bb5704 - [clang][extract-api] Add struct support

Author: Zixu Wang Date: 2022-03-23T09:45:06-07:00 New Revision: 5bb5704c1b35023b8a6217a6eb7d98a47efe1ca2 URL: https://github.com/llvm/llvm-project/commit/5bb5704c1b35023b8a6217a6eb7d98a47efe1ca2 DIFF: https://github.com/llvm/llvm-project/commit/5bb5704c1b35023b8a6217a6eb7d98a47efe1ca2.diff LOG

[PATCH] D122202: [clang][extract-api] Add struct support

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb5704c1b35: [clang][extract-api] Add struct support (authored by zixuw). Changed prior to commit: https://reviews.llvm.org/D122202?vs=417438&id=417668#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for the fix! Comment at: clang/include/clang/Sema/Weak.h:62 +return false; + return LHS.getAlias()->getName() == RHS.getAlias()->getName(); +} hubert.reinterpr

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:5-16 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang -target i386-unknown-unknown

[PATCH] D120619: [clangd] Support include-fixer inside macro arguments.

thakis added a comment. This breaks tests on windows: http://45.33.8.238/win/54910/step_9.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120619/new/ https://reviews.llvm.org/D120

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3402875 , @aaron.ballman wrote: > Thanks for the fix! Can you please add a release note as well? Okay, i try to add some test case for zero-width bitfield and unnamed bitfield, and add a release notes. Repository:

[PATCH] D104040: [OpenCL] Add TableGen emitter for OpenCL builtin header

svenvh updated this revision to Diff 417678. svenvh added a comment. Herald added a subscriber: Naghasan. Herald added a project: All. Rebased on latest `main`. Also takes TypeExtensions into account now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104040/new/ https://reviews.llvm.or

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions

ASDenysPetrov added a comment. Herald added a project: All. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers

ASDenysPetrov added a comment. Herald added a project: All. Ping. If there is somebody interested in this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103096/new/ https://reviews.llvm.org/D103096 ___ cfe-commits mailing list cfe-commits@

[PATCH] D121873: [clang][extract-api] Add enum support

mstorsjo added a comment. This (or some closely related commit?) causes a huge amount of warnings when building with GCC: warning: ‘clang::extractapi::EnumRecord’ has a field ‘clang::extractapi::EnumRecord::Constants’ whose type uses the anonymous namespace [-Wsubobject-linkage] 167 | str

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using a BumpPtrAllocator introduced memory leaks for APIRecords as they co

[clang] e4a42c5 - Change __auto_type behavior with qualifiers to match GCC behavior

Author: Aaron Ballman Date: 2022-03-23T13:25:31-04:00 New Revision: e4a42c5b64d044ae28d9483b0ebd12038d5b5917 URL: https://github.com/llvm/llvm-project/commit/e4a42c5b64d044ae28d9483b0ebd12038d5b5917 DIFF: https://github.com/llvm/llvm-project/commit/e4a42c5b64d044ae28d9483b0ebd12038d5b5917.diff

[PATCH] D122029: Change __auto_type behavior with qualifiers to match GCC behavior

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews, I've committed in e4a42c5b64d044ae28d9483b0ebd12038d5b5917 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122029/new/ https:

[PATCH] D122069: [Clang] Add binary format for bundling offloading metadata

jhuber6 updated this revision to Diff 417685. jhuber6 added a comment. Updating to use path instead of generic cmdline, makes it a lot easier to pass it. Also just adding a reserved field in case I want to add the cmdline back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120616: [clangd] IncludeFixer: resolve Class in ns::Class::method();

sammccall added a comment. Herald added a project: All. Friendly ping :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120616/new/ https://reviews.llvm.org/D120616 ___ cfe-commits mailing list cfe-commi

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

hubert.reinterpretcast added a comment. LGTM; thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://reviews.llvm.org/D121992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa updated this revision to Diff 417687. yihanaa added a comment. 1. Support zero-width bitfield. 2. Supported unnamed bitfield. 3. Add a release notes. The builtin function __builtin_dump_struct behaves for zero-width bitfield and unnamed bitfield as follows void test8(void) { struc

[clang-tools-extra] 31dc248 - [clangd] Fix IncludeFixer test on windows

Author: Sam McCall Date: 2022-03-23T18:57:08+01:00 New Revision: 31dc248ffc3cbf9ea6d11819b6b7b731b414b352 URL: https://github.com/llvm/llvm-project/commit/31dc248ffc3cbf9ea6d11819b6b7b731b414b352 DIFF: https://github.com/llvm/llvm-project/commit/31dc248ffc3cbf9ea6d11819b6b7b731b414b352.diff LO

[PATCH] D120619: [clangd] Support include-fixer inside macro arguments.

sammccall added a comment. In D120619#3403021 , @thakis wrote: > This breaks tests on windows: http://45.33.8.238/win/54910/step_9.txt > > Please take a look and revert for now if it takes a while to fix. Thanks, forced the test to pass in 31dc248ffc3cbf

[PATCH] D122275: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bd66b312c3e: [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE (authored by aeubanks). Herald added subscribers: cfe-com

[clang] 9bd66b3 - [PassManager][Coroutine] Run passes under -O0 conditionally and run GlobalDCE

Author: Arthur Eubanks Date: 2022-03-23T11:03:26-07:00 New Revision: 9bd66b312c3e0e539ac6c85c1bacd17bdc731614 URL: https://github.com/llvm/llvm-project/commit/9bd66b312c3e0e539ac6c85c1bacd17bdc731614 DIFF: https://github.com/llvm/llvm-project/commit/9bd66b312c3e0e539ac6c85c1bacd17bdc731614.diff

[PATCH] D122087: Add HLSL Language Option and Preprocessor

rnk accepted this revision. rnk added a comment. Herald added a subscriber: StephenFan. lgtm Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401-403 +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - +(uint32_t)llvm::Tri

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Sema/Weak.h:47 +static unsigned getHashValue(const WeakInfo &W) { + return W.getAlias() ? DenseMapInfo::getHashValue(W.getAlias()->getName()) + : DenseMapInfo::getHashV

[PATCH] D122087: Add HLSL Language Option and Preprocessor

beanz added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:401-403 +uint32_t StageInteger = StageInteger = +(uint32_t)TI.getTriple().getEnvironment() - +(uint32_t)llvm::Triple::Pixel; rnk wrote: > This here suggests that

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3397508 , @thakis wrote: > Looks like this breaks tests on Windows: > http://45.33.8.238/win/54785/step_7.txt > > Please take a look, and revert for now if takes a while to fix. I can't seem to reproduce the test fai

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem created this revision. Herald added subscribers: ellis, abrachet, phosek, hiraditya. Herald added a project: All. gulfem requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoverageMappingModuleGen generates a coverage

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

aaron.ballman added a comment. In D120185#3403230 , @njames93 wrote: > In D120185#3397508 , @thakis wrote: > >> Looks like this breaks tests on Windows: >> http://45.33.8.238/win/54785/step_7.txt >> >> Please tak

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

abrachet added a comment. In D122335#3403281 , @hubert.reinterpretcast wrote: > For users on Windows, would this cause extra trouble if they wanted to see > what was included? Is `tar(1)` not available on Windows? CHANGES SINCE LAST ACTION https://

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403283 , @abrachet wrote: > In D122335#3403281 , > @hubert.reinterpretcast wrote: > >> For users on Windows, would this cause extra trouble if they wanted to see >> wha

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3402924 , @erichkeane wrote: > Seems reasonable to me. Obviously needs release notes + the tests that Aaron > did, but I think this looks right. Thank you for reminding，i have add a release notes entry and a test ca

[PATCH] D121927: [Clang] Work with multiple pragmas weak before definition

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Weak.h:47 +static unsigned getHashValue(const WeakInfo &W) { + return W.getAlias() ? DenseMapInfo::getHashValue(W.getAlias()->getName()) + : DenseMapInfo::getHashValue("");

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403143 , @yihanaa wrote: > 1. Support zero-width bitfield, named bitfield and unnamed bitfield. > 2. Add a release notes. > > The builtin function __builtin_dump_struct behaves for zero-width bitfield > and unna

[PATCH] D122271: [Clang] -Wunused-but-set-variable warning - handle also pre/post unary operators

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122271/new/ https://reviews.llvm.org/D122271 ___

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403315 , @aaron.ballman wrote: > In D122248#3403143 , @yihanaa wrote: > >> 1. Support zero-width bitfield, named bitfield and unnamed bitfield. >> 2. Add a release notes. >> >

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

lhames added a comment. > I'm currently doing that via MCContext::getGenDwarfForAssembly... This isn't my wheelhouse, but at first glance GenDwarfForAssembly looks like it might control all Dwarf sections (including debug ones). If that's the case you might need to introduce something eh-frame

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403343 , @yihanaa wrote: > In D122248#3403315 , @aaron.ballman > wrote: > >> In D122248#3403143 , @yihanaa >> wrote: >> >>> 1. Su

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403349 , @erichkeane wrote: > In D122248#3403343 , @yihanaa wrote: > >> In D122248#3403315 , >> @aaron.ballman wrote: >> >>> In D122

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403305 , @aaron.ballman wrote: > In D122335#3403283 , @abrachet > wrote: > >> In D122335#3403281 , >> @hubert.reinterpretcast wr

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 added projects: OpenMP, clang. Herald added subscribers: guansong, yaxunl. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Current

[clang] f833aab - [clang][extract-api] Enable processing of multiple headers

Author: Daniel Grumberg Date: 2022-03-23T19:05:19Z New Revision: f833aab0d0bf1bd9e9903a1398e429f431532f5f URL: https://github.com/llvm/llvm-project/commit/f833aab0d0bf1bd9e9903a1398e429f431532f5f DIFF: https://github.com/llvm/llvm-project/commit/f833aab0d0bf1bd9e9903a1398e429f431532f5f.diff LO

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rGf833aab0d0bf: [clang][extract-api] Enable processing of multiple headers (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto updated this revision to Diff 417705. hkmatsumoto added a comment. Reflect code reviews - Factor out pattern matching code and exit early if it didn't match - Rename foldOrOfCtpop to foldIsPowerOf2OrZero - Rename 2 tests in ispow2.ll to is_pow2_or_zero(_logical) to inform that this p

[PATCH] D122338: [OPENMP] Eliminate extra set of simd variant function attribute.

ABataev added a comment. If ParamPositions grows, it means that the item is not found. Is it correct behavior if the compiler inserts new item in the ParamPositions map? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122338/new/ https://reviews.llv

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403357 , @erichkeane wrote: > In D122335#3403305 , @aaron.ballman > wrote: > >> In D122335#3403283 , @abrachet >> wrote: >> >

[PATCH] D119493: Fixing surplus assert condition in EvaluateTemporary

efriedma added a comment. I'm not sure this is the right fix. If we were handling the pseudo-destructor correctly, I would expect the following to compile successfully: typedef bool Var; constexpr bool foobool() { return (bool().Var::~Var(), false); } CHANGES SINCE LAST ACTION

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

erichkeane added a comment. In D122335#3403453 , @aaron.ballman wrote: > In D122335#3403357 , @erichkeane > wrote: > >> In D122335#3403305 , >> @aaron.ballman wrote: >>

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403349 , @erichkeane wrote: > In D122248#3403343 , @yihanaa wrote: > >> In D122248#3403315 , >> @aaron.ballman wrote: >> >>> I

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403468 , @aaron.ballman wrote: > In D122248#3403349 , @erichkeane > wrote: > >> In D122248#3403343 , @yihanaa >> wrote: >> >>> I

[PATCH] D122335: [clang] Emit crash reproduction as a single tar file

aaron.ballman added a comment. In D122335#3403459 , @erichkeane wrote: > In D122335#3403453 , @aaron.ballman > wrote: > >> In D122335#3403357 , @erichkeane >> wrote: >>

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. If it is ok, I think we should probably change the format of the 'dump' for fields. Using the colon to split up the field from the value is unfortunate, may I suggest replacing it with '=' instead? As well as printing the size after a colon. So for: void foo(vo

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

aaron.ballman created this revision. aaron.ballman added reviewers: erichkeane, efriedma, jyknight, rjmccall. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Naked functions have no prolog, so it's not valid to emit prolog code to evalu

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

aaron.ballman added a comment. In D122248#3403478 , @erichkeane wrote: > If it is ok, I think we should probably change the format of the 'dump' for > fields. Using the colon to split up the field from the value is unfortunate, > may I suggest replaci

[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

ekieri created this revision. ekieri added reviewers: bruno, v.g.vassilev, thakis, dexonsmith. Herald added a reviewer: sscalpone. Herald added a project: All. ekieri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes --vers

[PATCH] D122341: Fix a crash with variably-modified parameter types in a naked function

erichkeane added a comment. Other than this 1 thing, LGTM. I DO find myself wondering how much of the CXXMethodDecl bit in the branch above is valid for 'naked' as well. If it ISN'T we might consider moving this loop AND that to EmitFunctionPrologue. Comment at: clang/lib/

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman added inline comments. Comment at: clang/lib/Lex/PPLexerChange.cpp:436 + if (PragmaAssumeNonNullLoc.isValid() && !this->PPOpts->GeneratePreamble && + !(CurLexer && CurLexer->getFileID() == PredefinesFileID) && !isEndOfMacro && !(CurLexer && CurLexer->Is_Prag

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403478 , @erichkeane wrote: > If it is ok, I think we should probably change the format of the 'dump' for > fields. Using the colon to split up the field from the value is unfortunate, > may I suggest replacing it

[clang] 3fb101a - [NFC] Replace a not-null-check && isa with isa_and_nonnull

Author: Erich Keane Date: 2022-03-23T13:09:28-07:00 New Revision: 3fb101a6914b6d0e7a46b425eeafc44578d7ff78 URL: https://github.com/llvm/llvm-project/commit/3fb101a6914b6d0e7a46b425eeafc44578d7ff78 DIFF: https://github.com/llvm/llvm-project/commit/3fb101a6914b6d0e7a46b425eeafc44578d7ff78.diff L

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. Reading this again, I have a feeling defaulting to newest will come back to bite us (or, well, apple folks.) But we can reevaluate if we get to that. So, LGTM, thanks! Repository: rG LLVM Githu

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403518 , @aaron.ballman wrote: > In D122248#3403478 , @erichkeane > wrote: > >> If it is ok, I think we should probably change the format of the 'dump' for >> fields. Using

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. In D122248#3403636 , @yihanaa wrote: > In D122248#3403518 , @aaron.ballman > wrote: > >> In D122248#3403478 , @erichkeane >> wrote: >> >>> If

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

hkmatsumoto marked 3 inline comments as done. hkmatsumoto added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp:921 + if (IsAnd && + match(Cmp0, m_ICmp(Pred0, m_Intrinsic(m_Value(X)), + m_SpecificInt(1))) && -

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. In D120185#3403270 , @aaron.ballman wrote: > I'd like to understand what's happening better rather than land with a > disabled test. Not getting the crash dump in some circumstances could either > be specific to the machine co

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

yihanaa added a comment. In D122248#3403637 , @erichkeane wrote: > In D122248#3403636 , @yihanaa wrote: > >> In D122248#3403518 , >> @aaron.ballman wrote: >> >>> In D122

[PATCH] D122248: [clang][CodeGen]Fix clang crash and add bitfield support in __builtin_dump_struct

erichkeane added a comment. > I'm sorry I misunderstood what you meant @aaron.ballman. > > Can we follow the lead of LLVM IR？it use 'undef' > for example: > > struct T6A { > unsigned a : 1; > unsigned : 0; > unsigned c : 1; > }; > > @__const.foo.a = private unnamed_addr

[PATCH] D122155: Add warning when eval-method is set in the presence of value unsafe floating-point calculations.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:50-53 +def warn_eval_method_setting_via_option_in_value_unsafe_context : Warning< +"setting the eval method via '-ffp-eval-method' has n

[PATCH] D122331: [clang][extract-api] Stop allocating APIRecords via BumpPtrAllocator

zixuw added a comment. This is much cleaner now. Thanks Daniel! Comment at: clang/include/clang/ExtractAPI/API.h:326 + /// Note: The main use for this is being able to deduplicate strings. llvm::BumpPtrAllocator Allocator; Should we just rename the alloca

[PATCH] D121873: [clang][extract-api] Add enum support

zixuw added a comment. In D121873#3403082 , @mstorsjo wrote: > This (or some closely related commit?) causes a huge amount of warnings when > building with GCC: > > warning: ‘clang::extractapi::EnumRecord’ has a field > ‘clang::extractapi::EnumRecord:

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:47 +CRLF, +CRLFCR, + }; aaron.ballman wrote: > LegalizeAdulthood wrote: > > aaron.ballman wrote: > > > LegalizeAdulthood wrote: > > > > aaron

[PATCH] D122303: [pseudo] Sort nonterminals based on their reduction order.

hokein updated this revision to Diff 417731. hokein marked an inline comment as done. hokein added a comment. address comments, remove the extraction of TestGrammar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122303/new/ https://reviews.llvm.org

  1   2   3   4   >