[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev updated this revision to Diff 415021. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121455/new/ https://reviews.llvm.org/D121455 Files: clang/li

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415022. kovdan01 added a comment. Keep private headers untouched CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 Files: llvm/include/llvm/CodeGen/GlobalISel/GISelWorkList.h llvm/include/llvm/CodeGen/M

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(&SubExpr); +if (auto *Val = dyn_cast_or_null( xazax.hun wrote: > Could you elaborate on when would this happen? I'd expect the trave

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 marked an inline comment as done. kovdan01 added inline comments. Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.h:601 + // TODO: place logger under #if LLVM_ENABLE_ABI_BREAKING_CHECKS #ifndef NDEBUG mehdi_amini wrote: > This is a pri

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D121549: Define ABI breaking class members correctly

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list cfe

[PATCH] D121578: [RISCV][NFC] Add tests to address invalid arch dependencies.

khchen created this revision. khchen added reviewers: craig.topper, kito-cheng. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosb

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. This revision is now accepted and ready to land. Thx for the patch, please address the comment before submitting. Comment at: clang/lib/Sema/SemaChecking.cpp:1946-1953 +auto ArgArrayConversion = [&](unsigned Arg)

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan updated this revision to Diff 415031. owenpan added a comment. Reset the `Spaces` of the closing brace only if it can be unwrapped. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ https://reviews.llvm.org/D121576 Files: clang/lib/Format/WhitespaceManager.cpp clang

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415041. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address Hubert's feedback - Add a diagnostic during constant evaluation when evaluating the declaration of a variable with non-automatic storage duration - Add more tests - Restore

[PATCH] D121427: [lit] add lit_config.substitute to interpolate lit_config.params

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. This patch is definitely an improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121427/new/ https://reviews.llvm.org/D121427 ___

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added a comment. In D88905#3375676 , @aaron.ballman wrote: > In D88905#3362347 , @kaz7 wrote: > >> At the beginning, this implementation extends `vector_type` attribute which >> is GCC's attribute. So, thi

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I'm wondering if the presence of the comment would impact the CellCount, I might go back and add some more unit tests for the "non rectangular" change I made. So this fixes the "}" going up onto the comment line, but not the

[clang] 2507e0a - [clang-format] Clean up UnwrappedLineParser::parseRecord. NFC.

Author: Marek Kurdej Date: 2022-03-14T11:59:52+01:00 New Revision: 2507e0a257991fd46bd847c8fa0964bc70891add URL: https://github.com/llvm/llvm-project/commit/2507e0a257991fd46bd847c8fa0964bc70891add DIFF: https://github.com/llvm/llvm-project/commit/2507e0a257991fd46bd847c8fa0964bc70891add.diff

[PATCH] D121549: Define ABI breaking class members correctly

kovdan01 updated this revision to Diff 415049. kovdan01 marked an inline comment as done. kovdan01 removed projects: MLIR, clang. kovdan01 added a comment. Fix formatting problems found on pre-merge checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.or

[PATCH] D121584: [clang-format] Correctly recognize arrays in template parameter list.

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[PATCH] D121592: [clangd] Expose include cleaner interface in clangd

serge-sans-paille created this revision. serge-sans-paille added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald ad

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

serge-sans-paille created this revision. serge-sans-paille added reviewers: kbobyrev, sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-bi

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains added a subscriber: clang-modules. iains published this revision for review. iains added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a s

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

iains created this revision. Herald added a subscriber: dang. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. These command-line flags are alternates to

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow an invocation like clang -fmodule-header bar.h (which will be a C++ c

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains created this revision. Herald added a project: All. iains added reviewers: rsmith, urnathan, ChuanqiXu. iains published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the -fdirectives-only option is used together with -E, the preprocesso

[clang] 2d8e907 - [clang-format][NFC] Rename Left to OpeningParen...

Author: Björn Schäpers Date: 2022-03-14T12:44:45+01:00 New Revision: 2d8e907016ef323ed1a9e2e70c558eb9c3568b06 URL: https://github.com/llvm/llvm-project/commit/2d8e907016ef323ed1a9e2e70c558eb9c3568b06 DIFF: https://github.com/llvm/llvm-project/commit/2d8e907016ef323ed1a9e2e70c558eb9c3568b06.diff

[clang] acd17a2 - [clang-format] Fix crash on invalid requires expression

Author: Björn Schäpers Date: 2022-03-14T12:44:46+01:00 New Revision: acd17a2be81a33abf4350e31ae1747dcb0f12332 URL: https://github.com/llvm/llvm-project/commit/acd17a2be81a33abf4350e31ae1747dcb0f12332 DIFF: https://github.com/llvm/llvm-project/commit/acd17a2be81a33abf4350e31ae1747dcb0f12332.diff

[clang] b7494a1 - [clang-format][NFC] Left renamed to OpeningBrace...

Author: Björn Schäpers Date: 2022-03-14T12:44:47+01:00 New Revision: b7494a1d72c16a4d1f9cc8d4b3eba36934c35664 URL: https://github.com/llvm/llvm-project/commit/b7494a1d72c16a4d1f9cc8d4b3eba36934c35664 DIFF: https://github.com/llvm/llvm-project/commit/b7494a1d72c16a4d1f9cc8d4b3eba36934c35664.diff

[clang] 35abbf1 - [clang-format] Fix crash on asm block with label

Author: Björn Schäpers Date: 2022-03-14T12:44:48+01:00 New Revision: 35abbf166d4ad13e4a89095307bb6e4b2e96e0b3 URL: https://github.com/llvm/llvm-project/commit/35abbf166d4ad13e4a89095307bb6e4b2e96e0b3 DIFF: https://github.com/llvm/llvm-project/commit/35abbf166d4ad13e4a89095307bb6e4b2e96e0b3.diff

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d8e907016ef: [clang-format][NFC] Rename Left to OpeningParen... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121557/new/

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

This revision was automatically updated to reflect the committed changes. Closed by commit rGacd17a2be81a: [clang-format] Fix crash on invalid requires expression (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121550/

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7494a1d72c1: [clang-format][NFC] Left renamed to OpeningBrace... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121558/new/

[PATCH] D121559: [clang-format] Fix crash on asm block with label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35abbf166d4a: [clang-format] Fix crash on asm block with label (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

egorzhdan updated this revision to Diff 415069. egorzhdan added a comment. Rename a lambda to improve readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 Files: clang/lib/Sema/SemaChecking.cpp

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Please fix the clang format issue as well. Other than that and a nit, this LGTM. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1587 + // The `minus` opera

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. In D88905#3378933 , @simoll wrote: > In D88905#3375676 , @aaron.ballman > wrote: > >> In D88905#3362347 , @kaz7 wrote: >> >>> At the beginning

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich to look at this WIP for early feedback as he's recently been looking at template instantiation guts rather deeply, but I added some questions. Comment at: clang/include/clang/AST/DeclCXX.h

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

gchatelet accepted this revision. gchatelet added a comment. Much better, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121475/new/ https://reviews.llvm.org/D121475 ___ cfe-commits mailing lis

[clang] 6ca2f19 - [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

Author: Egor Zhdan Date: 2022-03-14T12:47:30Z New Revision: 6ca2f1938f96a71abdecdd96508f48e4d20a5694 URL: https://github.com/llvm/llvm-project/commit/6ca2f1938f96a71abdecdd96508f48e4d20a5694 DIFF: https://github.com/llvm/llvm-project/commit/6ca2f1938f96a71abdecdd96508f48e4d20a5694.diff LOG: [C

[PATCH] D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

erichkeane added a comment. This seems reasonable to me, but can you please add a lit test and fix the format of the code in your commit message? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121498/new/ https://reviews.llvm.org/D121498 _

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. In D121283#3375806 , @egorzhdan wrote: > In D121283#3373560 , @aaron.ballman > wrote: > >> why do we support multiple attribute *specifiers* in the same pragma? I >> would not expe

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") Could you comment at the top of this file (i

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. erichkeane marked an inline comment as done. Closed by commit rGdc152659b452: Have cpu-specific variants set 'tune-cpu' as an optimization hint (authored by erichkeane)

[clang] dc15265 - Have cpu-specific variants set 'tune-cpu' as an optimization hint

Author: Erich Keane Date: 2022-03-14T06:14:30-07:00 New Revision: dc152659b4527cc2e5f75cc33f36df67c7d5db26 URL: https://github.com/llvm/llvm-project/commit/dc152659b4527cc2e5f75cc33f36df67c7d5db26 DIFF: https://github.com/llvm/llvm-project/commit/dc152659b4527cc2e5f75cc33f36df67c7d5db26.diff L

[PATCH] D121599: [AST] Better recovery on an expression refers to an invalid decl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Prior to the patch, we didn't build a DeclRefExpr if the Decl being referred to is invalid, because many clang downstream AST cons

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415079. simoll added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: clang/docs/LanguageExtensions.rst clang/include/clang/AST/Type.h cla

[clang] 8cba721 - Implement literal suffixes for _BitInt

Author: Aaron Ballman Date: 2022-03-14T09:24:19-04:00 New Revision: 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 URL: https://github.com/llvm/llvm-project/commit/8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 DIFF: https://github.com/llvm/llvm-project/commit/8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8.diff

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've commit in 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8 (LLVM bits) and 8cba72177dcd8de5d37177dbaf2347e5c1f0f1e8

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242 +#if 0 +BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n") +BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n") simoll wrote: > Could you comment at the top o

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

simoll accepted this revision. simoll added a comment. This revision is now accepted and ready to land. Thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121586/new/ https://reviews.llvm.org/D121586 ___

[PATCH] D121498: let EST_Uninstantiated in FunctionProtoType::canThrow return CT_Dependent

zhouyizhou added a comment. In D121498#3379222 , @erichkeane wrote: > This seems reasonable to me, but can you please add a lit test and fix the > format of the code in your commit message? Thank you for reviewing the patch for me ;-) I am a beginner,

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra accepted this revision. amilendra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, Fea

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:615 +TEST_F(TokenAnnotatorTest, UnderstandsObjCBlock) { + auto Tokens = annotate("int (^)() = ^ ()\n" I hope the name is appropriate, I don't know shit about ob

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

xbolva00 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") Why leave dead code under

[clang] 9e3e85a - Silence -Wlogical-op-parentheses and fix a logic bug while doing so

Author: Aaron Ballman Date: 2022-03-14T10:13:39-04:00 New Revision: 9e3e85ac6efeb948647810dae93f3ba0cc8a4314 URL: https://github.com/llvm/llvm-project/commit/9e3e85ac6efeb948647810dae93f3ba0cc8a4314 DIFF: https://github.com/llvm/llvm-project/commit/9e3e85ac6efeb948647810dae93f3ba0cc8a4314.diff

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

stuij marked 2 inline comments as done. stuij added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, FeatureSPE, FeatureFullFP16, FeatureDotProd]; l

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12948 + + if (OldClass->isDependentContext()) +getDerived().transformedLocalDecl(OldClass, {Class}); aaron.ballman wrote: > Can you explain why you only do these transformations when

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jhuber6 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120271/new/ https://reviews.llvm.org/D120271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D121586: [Clang][VE] Add the rest of intrinsics to clang

kaz7 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:35 +// TODO: Vector mask registers +// Depend on https://reviews.llvm.org/D88905 +// BUILTIN(__builtin_ve_vl_vst_vssml, "vV256dLUiv*V256bUi", "n") xbolva00 wrote: > Why leave d

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Model nullopt, inplace, value, and conversion construc

[clang] a6b2f50 - Revert "[clang-format] Correctly format variable templates."

Author: Marek Kurdej Date: 2022-03-14T16:04:09+01:00 New Revision: a6b2f50fb47da3baeee10b1906da6e30ac5d26ec URL: https://github.com/llvm/llvm-project/commit/a6b2f50fb47da3baeee10b1906da6e30ac5d26ec DIFF: https://github.com/llvm/llvm-project/commit/a6b2f50fb47da3baeee10b1906da6e30ac5d26ec.diff

[PATCH] D121456: [clang-format] Correctly format variable templates.

curdeius reopened this revision. curdeius added a comment. This revision is now accepted and ready to land. Reverting as it provoked bug https://github.com/llvm/llvm-project/issues/54374. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121456/new/ ht

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(&SubExpr); +if (auto *Val = dyn_cast_or_null( sgatev wrote: > xazax.hun wrote: > > Could you elaborate on when would this happen?

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(&SubExpr); +if (auto *Val = dyn_cast_or_null( xazax.hun wrote: > sgatev wrote: > > xazax.hun wrote: > > > Could you elaborate on whe

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:516 +// assigned to it. +Visit(&SubExpr); +if (auto *Val = dyn_cast_or_null( sgatev wrote: > xazax.hun wrote: > > sgatev wrote

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:42 - /// Current lattice element. + ASTContext &ASTCtx; LatticeT &Lattice; This shouldn't be needed, since we now pass the `MatchFinder::MatchResult` in `A

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a comment. Ping, all green here, I just had to mess with the test regex a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 ___ cfe-commits mailin

[PATCH] D121332: Cleanup includes: DebugInfo & CodeGen

steven_wu added a comment. This breaks implicit module on macOS bots: https://green.lab.llvm.org/green/job/lldb-cmake/42098/console Error message: /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/CodeGen/MachinePipeliner.h:136:3: error: missing '#include "llvm/A

[clang-tools-extra] 5da83ee - clang-tidy: discover binaries in build dir

Author: Keith Smiley Date: 2022-03-14T09:04:36-07:00 New Revision: 5da83eeb91bab848a096db7521c6d8be29231665 URL: https://github.com/llvm/llvm-project/commit/5da83eeb91bab848a096db7521c6d8be29231665 DIFF: https://github.com/llvm/llvm-project/commit/5da83eeb91bab848a096db7521c6d8be29231665.diff

[PATCH] D100692: clang-tidy: discover binaries in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da83eeb91ba: clang-tidy: discover binaries in build dir (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100692/new/ https://reviews.llvm

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added a comment. Sema bits look pretty reasonable to me (I don't feel qualified to review the codegen bits). Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrE

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:55 + return hasType( + recordDecl(anyOf(hasName("std::nullopt_t"), hasName("absl::nullopt_t"), + hasName("base::nullopt_t"; -

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kbobyrev added a comment. Hi! I'm glad you're excited about IncludeCleaner and having a tool to try it out seems like a cool idea! > I'm not sure why include-cleaner wasn't integrated in clang-tidy, but I > suspect there's a good reason. The problem with IncludeCleaner as of right now is that

[clang] f51d7e4 - Fix the implicit module build

Author: Jonas Devlieghere Date: 2022-03-14T09:24:17-07:00 New Revision: f51d7e4bae9e861e711ad9711599456fc2f1bbca URL: https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca DIFF: https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca.d

[clang] 4fc7c55 - [NewPM] Actually recompute GlobalsAA before module optimization pipeline

Author: Arthur Eubanks Date: 2022-03-14T09:42:34-07:00 New Revision: 4fc7c551bb2b23fc022331b82b086d4b03b4 URL: https://github.com/llvm/llvm-project/commit/4fc7c551bb2b23fc022331b82b086d4b03b4 DIFF: https://github.com/llvm/llvm-project/commit/4fc7c551bb2b23fc022331b82b086d4b03b4.diff

[PATCH] D121167: [NewPM] Actually recompute GlobalsAA before module optimization pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fc7c551: [NewPM] Actually recompute GlobalsAA before module optimization pipeline (authored by aeubanks). Herald added a project: clang. Herald

[clang] df6fcef - Fix the implicit module build (2/2)

Author: Jonas Devlieghere Date: 2022-03-14T09:43:13-07:00 New Revision: df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9 URL: https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9 DIFF: https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9.d

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

efriedma updated this revision to Diff 415136. efriedma added a comment. Use KEYMSCOMPAT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412 Files: clang/include/clang/Basic/TokenKinds.def Index: clang/in

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks updated this revision to Diff 415137. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm_acle.c c

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

aeubanks added a comment. In D120527#3372092 , @dmgreen wrote: > Seems OK. Thanks for the patch. > > Do opaque pointer variants (like `i32 @llvm.aarch64.stxr.p0(i64 1, ptr > elementtype(i64) %ptr.0)`) get tested automatically from the existing tests > o

[clang] 250620f - [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

Author: Arthur Eubanks Date: 2022-03-14T10:09:59-07:00 New Revision: 250620f76e070cbbd4e8511f751f577b6e1633ac URL: https://github.com/llvm/llvm-project/commit/250620f76e070cbbd4e8511f751f577b6e1633ac DIFF: https://github.com/llvm/llvm-project/commit/250620f76e070cbbd4e8511f751f577b6e1633ac.diff

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG250620f76e07: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] cf63e9d - [clang][dataflow] Add support for nested composite bool expressions

Author: Stanislav Gatev Date: 2022-03-14T17:18:30Z New Revision: cf63e9d4caccbd540df083c63a5217ac50b5e1f9 URL: https://github.com/llvm/llvm-project/commit/cf63e9d4caccbd540df083c63a5217ac50b5e1f9 DIFF: https://github.com/llvm/llvm-project/commit/cf63e9d4caccbd540df083c63a5217ac50b5e1f9.diff LO

[PATCH] D121455: [clang][dataflow] Add support for nested composite bool expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGcf63e9d4cacc: [clang][dataflow] Add support for nested composite bool expressions (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121455/

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121412/new/ https://reviews.llvm.org/D121412 ___ cfe-c

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll updated this revision to Diff 415153. simoll marked an inline comment as done. simoll added a comment. Simplify following comments. Thx :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88905/new/ https://reviews.llvm.org/D88905 Files: cla

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

simoll added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrExtVectorBoolType(LHSType) && + isBoolOrExtVectorBoolType(RHSType)))

[PATCH] D121533: [clang][deps] Fix traversal of precompiled dependencies

dexonsmith added a comment. I'm not a big fan of moving to the recursive call. Creating a separate `StringMap` for each iteration seems awfully wasteful. I'd prefer fixing the iterative algorithm so that it's correct and easy to verify. This can be done with a stack that points at the stable po

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

dexonsmith added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:305 // maps, searching for a module map that describes this module. - for (It = search_dir_begin(); It != search_dir_end(); ++It) { -if (It->isFramework()) { + for (DirectoryLookup Dir : search_

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, FeatureSPE, FeatureFullFP16, FeatureDotProd]; list X1C = [HasV8_2aOps, FeatureCryp

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121206/new/ https://reviews.llvm.org/D121206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D121303: [clang][deps] Don't prune search paths used by dependencies

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:31 + [&](const serialization::ModuleFile *MF) -> void { +SearchPathUsage |=

[PATCH] D121512: [Support] Change zlib::compress to return void

ikudrin added inline comments. Comment at: llvm/lib/ObjCopy/ELF/ELFObject.cpp:568 DebugCompressionType CompressionType, Error &OutErr) : SectionBase(Sec), CompressionType(CompressionType), --

[PATCH] D121627: [IROutliner][NFC] Fix typo in doc of findOrCreatePHIInBlock

hkmatsumoto created this revision. Herald added subscribers: ormris, hiraditya. Herald added a project: All. hkmatsumoto requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121627

[PATCH] D121549: Define ABI breaking class members correctly

dexonsmith accepted this revision. dexonsmith added a comment. LGTM too; thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121549/new/ https://reviews.llvm.org/D121549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D121628: Only run this test for x86 registed targets.

abhina.sreeskantharajan created this revision. Herald added a project: All. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121628 Files: clang/test

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:110 +return false; + auto TypeName = Type->getAsCXXRecordDecl()->getQualifiedNameAsString(); + return TypeName == "std::optional" || TypeName == "absl::optio

[PATCH] D121512: [Support] Change zlib::compress to return void

MaskRay updated this revision to Diff 415167. MaskRay marked an inline comment as done. MaskRay added a comment. Simplify CompressedSection::CompressedSection in llvm-objcopy. CompressedSection::create can be further simplified, but I'll leave that as a future change. Repository: rG LLVM Git

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 created this revision. Herald added a project: All. durin42 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, we only check alloc_alignment claims in the caller. I'm about to add some extra logic that threads allo

[PATCH] D88905: [Clang] Allow "ext_vector_type" applied to Booleans

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:10244-10245 + // This operation may not be performed on boolean vectors. + if (!AllowBoolOperation && (isBoolOrExtVectorBoolType(LHSType) && + isBoolOrExtVectorBoolType(RHS

  1   2   3   >