kaz7 added inline comments.
================
Comment at: clang/include/clang/Basic/BuiltinsVEVL.gen.def:1242
+#if 0
+BUILTIN(__builtin_ve_vl_andm_mmm, "V256bV256bV256b", "n")
+BUILTIN(__builtin_ve_vl_andm_MMM, "V512bV512bV512b", "n")
----------------
simoll wrote:
> Could you comment at the top of this file (i know, again) that the `#if 0`-ed
> and commented-out parts are because of the missing mask vector type?
I don't want to add at the top of this file bacause this file is automatically
generated and I don't want to use any structured comments. But, I added
comments at the each point of `#if 0` and added comments at the place where
include this file.
================
Comment at: clang/lib/Headers/velintrin.h:65
+
+static inline unsigned long int _vel_pack_i32(int a, int b) {
+ return (((unsigned long int)a) << 32) | (unsigned int)b;
----------------
simoll wrote:
> Is there any particular reason the parameters are signed?
I guess no. So, I changed the code following your suggestion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121586/new/
https://reviews.llvm.org/D121586
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
