[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. You probably want to add these intrinsics to the auto-upgrade code in `BitcodeReader::propagateAttributeTypes()` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

curdeius accepted this revision. curdeius added a comment. LGTM % nits. Thanks for working on this! Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:54-55 +Tok = processTokens(Tok, tok::l_paren, tok::r_paren, nullptr); + } else if (Tok->is(tok::l_square)) +To

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

curdeius accepted this revision. curdeius added a comment. LGTM. Thanks a lot! Comment at: clang/lib/Format/Format.cpp:1181-1184 + LLVMStyle.AlignConsecutiveAssignments = { + /*Enabled=*/false, /*AcrossEmptyLines=*/false, + /*AcrossComments=*/false, /*AlignCompound=*

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

djtodoro added a comment. Hmmm... if this should be done within compiler side, I am wondering whether this should be resolved in AsmPrinter/DwarfDebug instead. @aprantl please let me know wyt? However, it looks like that after this hack the `name` here isn't the appropriate one... and it looks

[PATCH] D121286: [clangd] Test against path insensitivity

kadircet updated this revision to Diff 414301. kadircet added a comment. Add tests specifically and postpone change in testRoot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/c

[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

condy added a comment. IMHO, it's the duty of build systems. CMake provides `check_cxx_compiler_flag` to report unknown options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175 __

[PATCH] D121359: [AVR] Synchronize device list with gcc-avr 5.4.0 and avr-libc 2.0.0

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: Jim, hiraditya. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jacquesguan. Herald added projects: clang, LLVM.

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

whisperity added a comment. In D121214#3369871 , @steakhal wrote: > Drop the alias-related changes and preserve the note in the > `bugprone-shared-ptr-array-mismatch.rst` stating this relationship with the > cert rule? > If we do it like that, then this

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

dmgreen added a comment. Seems OK. Thanks for the patch. Do opaque pointer variants (like `i32 @llvm.aarch64.stxr.p0(i64 1, ptr elementtype(i64) %ptr.0)`) get tested automatically from the existing tests once -opaque-pointers is the default? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121365: [CFG] Fix crash on CFG building when deriving from a template.

courbet created this revision. courbet added reviewers: gribozavr, alexfh. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121365 Files: clang/lib/Analysis/CFG.cpp clang/uni

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

martong added a comment. Basically, this looks good to me. But my confidence with ObjC is low, so, I'd like @shafik as well to approve. Besides, seems like the pre-merge check fails with the new tests on Debian, could you please address that? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

steakhal planned changes to this revision. steakhal added a comment. In D121214#3372091 , @whisperity wrote: > In D121214#3369871 , @steakhal > wrote: > >> Drop the alias-related changes and preserve the note in

[PATCH] D121359: [AVR] Add more devices

benshi001 updated this revision to Diff 414319. benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121359/new/ https://reviews.llvm.org/D121359 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Driver/ToolChains/AVR.cpp clang/test/Misc/targe

[PATCH] D121286: [clangd] Test against path insensitivity

kadircet updated this revision to Diff 414324. kadircet added a comment. - Adjust after tests on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/clangd/HeaderSourceSwitc

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 414325. kadircet retitled this revision from "[clangd] Test against path insensitivity" to "[clangd] Handle case insensitive file systems in header/source switch". kadircet added a comment. - rename patch Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 414326. kadircet added a comment. - Match path ignoring case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/clangd/HeaderSourceSwitch.cp

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: alextsao1999. Herald added a project: clang. Forest node by design is unmutable. To create an ambiguous node, we have to know all alte

[clang] af98b0a - [clang][dataflow] Add analysis that detects unsafe accesses to optionals

Author: Stanislav Gatev Date: 2022-03-10T11:05:31Z New Revision: af98b0af6705df3859ee3c98525b57025d40d9e8 URL: https://github.com/llvm/llvm-project/commit/af98b0af6705df3859ee3c98525b57025d40d9e8 DIFF: https://github.com/llvm/llvm-project/commit/af98b0af6705df3859ee3c98525b57025d40d9e8.diff LO

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:33 + llvm::function_ref Fn) { + if (!Tok || !Tok->is(StartTok)) +return Tok; And other places below where applicable. Comment at: clang/

[PATCH] D121368: [pseudo][WIP] Build Ambiguous forest node in the GLR Parser.

hokein added a comment. The implementation (`performReduction`) is awkward at the moment, but it is completed, should give a global view of the algorithm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121368/new/ https://reviews.llvm.org/D121368

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk created this revision. kwk added reviewers: HazardyKnusperkeks, MyDeveloperDay. Herald added a project: All. kwk requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #38995 This is an attempt to modify the regular expression to identi

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

kuzkry added a comment. Herald added a project: All. Kind reminder, please deliver this one for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120631/new/ https://reviews.llvm.org/D120631 ___ cfe-comm

[PATCH] D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs

steakhal updated this revision to Diff 414337. steakhal retitled this revision from "[clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch" to "[clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs". steakhal added a comment.

[PATCH] D121372: [clang-tidy][docs][NFC] Update URL and docs of PostfixOperatorCheck

steakhal created this revision. steakhal added reviewers: whisperity, aaron.ballman, njames93, LegalizeAdulthood. steakhal added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revis

[PATCH] D121373: [clang-tidy][docs] Fix wrong url in DontModifyStdNamespaceCheck

steakhal created this revision. steakhal added reviewers: whisperity, aaron.ballman, njames93, LegalizeAdulthood. steakhal added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revis

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski created this revision. awarzynski added reviewers: rovka, schweitz, Leporacanthicus, kiranchandramohan, shraiysh. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscriber

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2759 + IncludeName = + StringRef(Twine("<", IncludeName).concat(Twine(">")).str()); +} How does that not go out of scope and I have a dangling referenc

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

sstwcw updated this revision to Diff 414347. sstwcw added a comment. Modify initialization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

aaron.ballman added a comment. In D121233#3371422 , @sammccall wrote: > Thanks Aaron, and my apologies for being easily frustrated. No worries at all! I always appreciate our discussions, even when we don't initially agree. > In D121233#3370992

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

xbolva00 added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + mllvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374

[PATCH] D121375: [clang] NFC, move the utility function CompilerInvocation::setLangDefaults to LangOptions.h

hokein created this revision. hokein added a reviewer: sammccall. Herald added a subscriber: dexonsmith. Herald added a project: All. hokein requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. The function will

[PATCH] D91000: [clang-tidy] Add cert-msc24-msc33-c checker.

futogergely added a comment. Herald added a project: All. In D91000#3313892 , @balazske wrote: > Now it would be better to have a checker called `UnsafeFunctionsCheck` > (probably in bugprone) and add the cert checkers "msc24-c" and "msc33-c" as > aliase

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

futogergely updated this revision to Diff 414359. futogergely retitled this revision from "[clang-tidy] Add cert-msc24-msc33-c checker." to "[clang-tidy] Add bugprone-unsafe-functions checker.". futogergely added a comment. Checker has been moved to bugprone. CHANGES SINCE LAST ACTION https:/

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

shraiysh added a comment. LGTM (will let others review as this includes changes to clang too and I am not familiar with it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121374/new/ https://reviews.llvm.org/D121374 ___

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + xbolva00 wrote: > mllvm Does it matter? `-mllvm` is consistent with other tests in this directory (e.g. https://github.com/llvm/llvm-project/blob/main/flang/

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added subscribers: phosek, mstorsjo. mstorsjo added a comment. FWIW I think D116689 interacts with this somewhat. I think D116689 is useful for the fixes I want to do wrt libcxxabi integration on Windows (but I haven'

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

xbolva00 added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + awarzynski wrote: > xbolva00 wrote: > > mllvm > Does it matter? `-mllvm` is consistent with other tests in this directory > (e.g. > https://github.com/llvm/ll

[PATCH] D121374: [flang][driver] Add support for `-mllvm`

awarzynski added inline comments. Comment at: flang/test/Driver/mllvm.f90:1 +! Test the `-mlvm` option + xbolva00 wrote: > awarzynski wrote: > > xbolva00 wrote: > > > mllvm > > Does it matter? `-mllvm` is consistent with other tests in this directory > > (e.g.

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2685 const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#]?[\t\ ]*(import|include)[^"<]*[\t\n\ \\]*("[^"]+"|<[^>]+>|[^"<>;]+;))"; ---

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2685 const char CppIncludeRegexPattern[] = -R"(^[\t\ ]*#[\t\ ]*(import|include)[^"<]*(["<][^">]*[">]))"; +R"(^[\t\ ]*[@#]?[\t\ ]*(import|include)[^"<]*[\t\n\ \\]*("[^"]+"|<[^>]+>|[^"<>;]+;))"; ---

[PATCH] D120272: [CUDA] Add driver support for compiling CUDA with the new driver

jhuber6 updated this revision to Diff 414371. jhuber6 added a comment. Herald added subscribers: abrachet, phosek. Fix architecture parsing and still include the GPU binary so cuobjcopy can use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[PATCH] D121165: [pseudo] Add crude heuristics to choose taken preprocessor branches.

hokein added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/DirectiveMap.h:123 +/// The choices are stored in Conditional::Taken nodes. +void chooseConditionalBranches(DirectiveMap &, const TokenStream &Code); + off-topic: a random idea on

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

ldionne added a comment. In D120727#3372594 , @mstorsjo wrote: > FWIW I think D116689 interacts with this > somewhat. I think D116689 is useful for > the fixes I want to do wrt libcxx

[PATCH] D119590: exclude openembedded distributions from setting rpath on openmp executables

raj.khem added a comment. Herald added a project: All. In D119590#3316050 , @JonChesterfield wrote: > Cross compilers are a hazard here. I'd expect there to be a fairly long list > of magic flags you need to pass to clang to get it to find the right >

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Model `make_optional`, optional's default constructor,

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

jyknight added a comment. In D118511#3371432 , @tstellar wrote: > I'm fine with reverting if you think this is the best solution. I just would > like to conclude soon so I can make the final release candidate. ISTM that reverting the ABI change in the

[PATCH] D120989: Support debug info for alias variable

aprantl added a comment. This looks mostly fine to me, I have a couple of superficial comments inline. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3914 + // imported declaration + auto IE = ImportedDeclCache.find(D->getCanonicalDecl()); Nit: The LLVM codi

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam created this revision. zahiraam added reviewers: aaron.ballman, andrew.w.kaylor. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Diagnose when `#pragma clang fp eval_method` doesn't have a supported value. Currently the compiler is

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:64 static BoolValue *getHasValue(Value *Val) { - if (auto *OptionalVal =

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev updated this revision to Diff 414396. sgatev marked an inline comment as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121378/new/ https://reviews.llvm.org/D121378 Files: clang/li

[PATCH] D121378: [clang][dataflow] Model the behavior of various optional members

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/UncheckedOptionalAccessModelTest.cpp:33 static constexpr char StdTypeTraitsHeader[] = R"( +#ifndef TYPE_TRAITS_H +#define TYPE_TRAITS_H xaz

[PATCH] D121387: [analyzer] ClangSA should tablegen doc urls refering to the main doc page

steakhal created this revision. steakhal added reviewers: aaron.ballman, NoQ, Szelethus, whisperity, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. steakhal reque

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

dblaikie added a comment. Fixes in LLVM require tests in LLVM - probably taking the clang test and compiling that to llvm IR (include the original C++ source in a comment in the IR test case) and then testing it in LLVM instead of clang. Also looks like the test could be simplified a bit more:

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

dblaikie added a comment. Yeah, happy to hear other perspectives - but my rough reaction is similar: putting mangled names in the "name" field seems problematic (consumer wouldn't necessarily know that the name should be demangled, for instance? Maybe?). So at the IR level maybe it's better to

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a tiny tweak to the diagnostic. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1493 + "'ignore', 'maytrap' or 'strict'|" + "'source'

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. I'm happy that you found a reasonable compromise. I like it too. ;) Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "n

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3372728 , @jyknight wrote: > In D118511#3371432 , @tstellar > wrote: > >> I'm fine with reverting if you think this is the best solution. I just >> would like to conclude so

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414416. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp ==

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are a

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all tak

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2733 +/// \endcode +AST_MATCHER_P(AttributedStmt, isAttr, attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), sammccall wrote: > This definitely seems more

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414424. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp ==

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. In D118511#3373082 , @dblaikie wrote: > In D118511#3372728 , @jyknight > wrote: > >> In D118511#3371432 , @tstellar >> wrote: >> >>> I'm fine w

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

sammccall added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2713-2714 +/// \endcode +extern const internal::VariadicDynCastAllOfMatcher +attributedStmt; + aaron.ballman wrote: > sammccall wrote: > > jdoerfert wrote: > > > aaron.

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2713-2714 +/// \endcode +extern const internal::VariadicDynCastAllOfMatcher +attributedStmt; + sammccall wrote: > aaron.ballman wrote: > > sammccall wrote: > > > jd

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3373173 , @tstellar wrote: > In D118511#3373082 , @dblaikie > wrote: > >> In D118511#3372728 , @jyknight >> wrote: >> >>> In D118511

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), Shouldn't this be looking at `getLangOpts().

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3373139 , @philnik wrote: > In D121078#3373081 , @SimplyDanny > wrote: > >> I'm happy that you found a reasonable compromise. I like it too. ;) >> >> Now, I ask you to help

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), aaron.ballman wrote: > Shouldn't this be looking

[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

aprantl added a comment. Ideally, this would be fixed in GDB. If that's really not feasibly I would rather like to see this as a gdb debugger tuning instead f the default behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121100/new/ https://

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/Sema.cpp:258 + // Fast-math is enabled. + if (getLangOpts().AllowFPReassoc || getLangOpts().AllowRecip) +PP.setCurrentFPEvalMethod(SourceLocation(), zahiraam wrote: > aaron.ballman wrote: > > S

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

zequanwu updated this revision to Diff 414442. zequanwu marked 7 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 Files: clang/lib/For

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414460. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 414461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/eval-method-fast-math.c Inde

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

aaron.ballman added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { What should happen in a case like this? ``` int whatever(float a, float b, float c) { #pragma float_control(pre

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

kstoimenov created this revision. Herald added a subscriber: mgorny. Herald added a project: All. kstoimenov requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

zahiraam updated this revision to Diff 414467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121380/new/ https://reviews.llvm.org/D121380 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/test/Sema/fp-eval-pragma.cpp Index: clang/test/Sema/fp-eval-pragma.cpp ==

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk updated this revision to Diff 414469. kwk marked 2 inline comments as done. kwk added a comment. - Make @ or # not optional again - Remove [\t\n\ \\]* - Properly concat string Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://re

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk added a comment. Thank you for your comments! I've addressed many of them and now address the rest. Comment at: clang/lib/Format/Format.cpp:2759 + IncludeName = + StringRef(Twine("<", IncludeName).concat(Twine(">")).str()); +}

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but maybe we can chat about that later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121405/new/ https://reviews.llvm.org/D1

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

aaron.ballman added a comment. Thanks for this, I plan on giving it a more thorough review when I can. But the summary led me to a design question: why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma give

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

kwk planned changes to this revision. kwk added a comment. A test if failing. Need to address this first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 ___ cf

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/test/CodeGen/eval-method-fast-math.c:83 +#pragma float_control(pop) + +int getFPEvalMethod() { aaron.ballman wrote: > What should happen in a case like this? > ``` > int whatever(float a, float b, float c) { > #

[clang] 035441f - [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

Author: Kirill Stoimenov Date: 2022-03-10T21:11:32Z New Revision: 035441ff3008c2a1930363751c6db61b71a5f089 URL: https://github.com/llvm/llvm-project/commit/035441ff3008c2a1930363751c6db61b71a5f089 DIFF: https://github.com/llvm/llvm-project/commit/035441ff3008c2a1930363751c6db61b71a5f089.diff L

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

This revision was automatically updated to reflect the committed changes. Closed by commit rG035441ff3008: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase. (authored by kstoimenov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 15ef06f - Diagnose when `#pragma clang fp eval_method` doesn't have a supported value.

Author: Zahira Ammarguellat Date: 2022-03-10T13:19:53-08:00 New Revision: 15ef06f453c6f9513b476e80dd9567d01fc662e8 URL: https://github.com/llvm/llvm-project/commit/15ef06f453c6f9513b476e80dd9567d01fc662e8 DIFF: https://github.com/llvm/llvm-project/commit/15ef06f453c6f9513b476e80dd9567d01fc662e8

[PATCH] D121380: Pragma `clang fp eval_method` needs to take as input a supported value.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15ef06f453c6: Diagnose when `#pragma clang fp eval_method` doesn't have a supported value. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:108 + // which one is name. For example, `namespace A B {`. + while (Tok && !Tok->is(tok::l_brace)) { +if (FirstNSTok) { ===

[clang] e2b219b - [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

Author: owenca Date: 2022-03-10T13:30:53-08:00 New Revision: e2b219bded113160500d1084f87ee11ec926877b URL: https://github.com/llvm/llvm-project/commit/e2b219bded113160500d1084f87ee11ec926877b DIFF: https://github.com/llvm/llvm-project/commit/e2b219bded113160500d1084f87ee11ec926877b.diff LOG: [

[PATCH] D121352: [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b219bded11: [clang-format] Handle "// clang-format off" for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121352/ne

[PATCH] D119675: Also remove the empty StoredDeclsList entry from the lookup table

v.g.vassilev added a comment. Herald added a project: All. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119675/new/ https://reviews.llvm.org/D119675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane created this revision. erichkeane added a reviewer: aaron.ballman. Herald added a subscriber: pengfei. Herald added a project: All. erichkeane requested review of this revision. Due to various implementation constraints, despite the programmer choosing a 'processor' cpu_dispatch/cpu_spe

[PATCH] D121410: Have cpu-specific variants set 'tune-cpu' as an optimization hint

erichkeane added a comment. @aaron.ballman : if you can add other reviewers or subscribers (particularly those from "VendorA") it would be greatly appreciated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121410/new/ https://reviews.llvm.org/D121410 __

[PATCH] D121412: Complete the list of single-underscore keywords for MSVC compat.

efriedma created this revision. efriedma added reviewers: rnk, mstorsjo. Herald added a subscriber: dexonsmith. Herald added a project: All. efriedma requested review of this revision. Herald added a project: clang. List derived from https://docs.microsoft.com/en-us/cpp/cpp/keywords-cpp . Not th

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, lhames, sgraenitz. Herald added a project: All. v.g.vassilev requested review of this revision. This patch will allow better incremental adoption of these changes in downstream cling and other users which want to experiment

[PATCH] D121413: [clang-repl] Add an accessor to our underlying execution engine

v.g.vassilev updated this revision to Diff 414494. v.g.vassilev added a comment. Order fwd decls alphabetically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121413/new/ https://reviews.llvm.org/D121413 Files: clang/include/clang/Interpreter/Interpreter.h clang/lib/Interpreter/Inc

[clang-tools-extra] 69924cc - Remove redundant lit config already handled in llvm_config. NFCI

Author: Sam McCall Date: 2022-03-10T23:11:01+01:00 New Revision: 69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c URL: https://github.com/llvm/llvm-project/commit/69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c DIFF: https://github.com/llvm/llvm-project/commit/69924ccf7a328f5f9bcc7073f38fa608a0dbfe2c.diff LO

[clang-tools-extra] 6ed2f89 - Fix reference to execute_external leftover in 69924ccf7a328f

Author: Sam McCall Date: 2022-03-10T23:20:03+01:00 New Revision: 6ed2f8902b8f109ead47e20a519860c803900d29 URL: https://github.com/llvm/llvm-project/commit/6ed2f8902b8f109ead47e20a519860c803900d29 DIFF: https://github.com/llvm/llvm-project/commit/6ed2f8902b8f109ead47e20a519860c803900d29.diff LO

[clang-tools-extra] 2d58ba2 - [clang-tools-extra] Remove unused lit features/substitutions. NFCI

Author: Sam McCall Date: 2022-03-10T23:28:43+01:00 New Revision: 2d58ba200a39ddacaa9923cb623321c295ae5949 URL: https://github.com/llvm/llvm-project/commit/2d58ba200a39ddacaa9923cb623321c295ae5949 DIFF: https://github.com/llvm/llvm-project/commit/2d58ba200a39ddacaa9923cb623321c295ae5949.diff LO

[clang] 0be56c8 - [clang-format][NFC] Group all C++ passes under isCpp()

Author: owenca Date: 2022-03-10T14:30:30-08:00 New Revision: 0be56c87013b585405209f324cc8dfc5ebde416f URL: https://github.com/llvm/llvm-project/commit/0be56c87013b585405209f324cc8dfc5ebde416f DIFF: https://github.com/llvm/llvm-project/commit/0be56c87013b585405209f324cc8dfc5ebde416f.diff LOG: [

  1   2   >