aprantl added a comment.
This looks mostly fine to me, I have a couple of superficial comments inline.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3914
+ // imported declaration
+ auto IE = ImportedDeclCache.find(D->getCanonicalDecl());
----------------
Nit: The LLVM coding style wants all comments to be full sentences, including a
trailing `.`
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3921
+ return cast<llvm::DINode>(GVE);
+ return dyn_cast_or_null<llvm::DINode>(N);
+ }
----------------
When would we enter a nullptr into the cache?
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:5496
+ if (!AliaseeDecl)
+ /* FIXME: Aliasee not declared yet - possibly declared later
+ * For example,
----------------
See LLVM coding style
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1502
+const GlobalDecl CodeGenModule::getMangledNameDecl(StringRef Name) {
+ auto it = MangledDeclNames.begin();
+ while (it != MangledDeclNames.end()) {
----------------
std::find()?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120989/new/
https://reviews.llvm.org/D120989
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
