[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin added inline comments. Comment at: clang/test/Driver/aix-ld.c:609 +// Check powerpc-ibm-aix7.1.0.0, 32-bit. -shared (with exp option strings in other opt). +// RUN: %clangxx -x c++ -no-canonical-prefixes %s 2>&1 -### \ +// RUN:-resource-dir=%S/Inputs/resource_d

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

aaron.ballman added a comment. Thank you for looking into this! I'm not certain this is the correct approach, however. The comment on the function is: /// ActOnCapScopeReturnStmt - Utility routine to type-check return statements /// for capturing scopes. however, there's not a capture scope

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added a comment. Another example that is... concerning: https://godbolt.org/z/84b8Yb7ne template void call_lambda(T&& L) { L(); } int g() { auto x = [](char c = ({return 5;'c';})){}; call_lambda(x); return 0; } int main() { return g(); } I filed a bug against GCC

[clang] 2e2e64d - [AMDGPU] Add gfx940 target

Author: Stanislav Mekhanoshin Date: 2022-03-02T13:54:48-08:00 New Revision: 2e2e64df4a4f6580499fa09c3c16d5c39d9dd4cb URL: https://github.com/llvm/llvm-project/commit/2e2e64df4a4f6580499fa09c3c16d5c39d9dd4cb DIFF: https://github.com/llvm/llvm-project/commit/2e2e64df4a4f6580499fa09c3c16d5c39d9dd4

[PATCH] D120688: [AMDGPU] Add gfx940 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e2e64df4a4f: [AMDGPU] Add gfx940 target (authored by rampitec). Herald added projects: clang, OpenMP. Herald added subscribers: openmp-commits, cfe-

[PATCH] D120846: [AMDGPU] Add gfx1036 target

aakanksha555 created this revision. aakanksha555 added reviewers: rampitec, msearles, kzhuravl. Herald added subscribers: asavonic, foad, dexonsmith, kerbowa, rupprecht, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, emaste, arsenm, jholewinski. Herald added a reviewer: jhenderson.

[PATCH] D120846: [AMDGPU] Add gfx1036 target

rampitec added a comment. Please also update these 2 files: clang/test/Driver/cuda-bad-arch.cu openmp/libomptarget/DeviceRTL/CMakeLists.txt In fact the last one was not updated before too, so the last target gfx1031 there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Herald added a project: All. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:75 +// Zbkb extension +TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb") +TARGET_BUILTIN(__builtin_riscv_zip, "ZiZi", "nc", "zbkb")

[PATCH] D120846: [AMDGPU] Add gfx1036 target

rampitec added a comment. You also need to rebase it, I have just landed gfx940 target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120846/new/ https://reviews.llvm.org/D120846 ___ cfe-commits mailing

[PATCH] D120846: [AMDGPU] Add gfx1036 target

rampitec added a comment. Looks like cuda-bad-arch.cu does not have any gfx10. Let's fix this in a separate followup patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120846/new/ https://reviews.llvm.org/D120846 ___

[PATCH] D120846: [AMDGPU] Add gfx1036 target

aakanksha555 updated this revision to Diff 412547. aakanksha555 added a comment. Herald added a subscriber: mgorny. Update openmp/libomptarget/DeviceRTL/CMakeLists.txt as well. clang/test/Driver/cuda-bad-arch.cu to be updated with all gfx10 targets in a separate patch. Repository: rG LLVM Git

[PATCH] D120846: [AMDGPU] Add gfx1036 target

aakanksha555 updated this revision to Diff 412554. aakanksha555 added a comment. Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120846/new/ https://reviews.llvm.org/D120846 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cu

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

dgoldman added a comment. Herald added a project: All. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116385/new/ https://reviews.llvm.org/D116385 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D120846: [AMDGPU] Add gfx1036 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120846/new/ https://reviews.llvm.org/D120846 ___

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4671 + if (HasMask) { +for (size_t i = 2; i < NumOperands; i++) { + Ops.push_back(Op.getOperand(i)); Drop curly braces Comment at: llvm/lib/Ta

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. Herald added a project: All. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] 8406958 - [AMDGPU] Add gfx1036 target

Author: Aakanksha Date: 2022-03-02T23:26:38Z New Revision: 840695814ae3e945dcc8c2e649929afeb8b629c1 URL: https://github.com/llvm/llvm-project/commit/840695814ae3e945dcc8c2e649929afeb8b629c1 DIFF: https://github.com/llvm/llvm-project/commit/840695814ae3e945dcc8c2e649929afeb8b629c1.diff LOG: [AM

[PATCH] D120846: [AMDGPU] Add gfx1036 target

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG840695814ae3: [AMDGPU] Add gfx1036 target (authored by Aakanksha ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

royjacobson updated this revision to Diff 412557. royjacobson added a comment. Thanks for the quick feedback :) I looked again at the AST and found out that there is a difference between instantiated and non-instantiated functions I missed - the instantiated functions have actual code AST. I ha

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added a comment. In D119609#3355368 , @erichkeane wrote: > Does this break a case like this? https://godbolt.org/z/Tc9Ko7hWY No, after applying the patch, clang accepts the code just like gcc > it seems the problem is with the Expression statem

[PATCH] D120856: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBlocks.cpp

ahatanak created this revision. ahatanak added reviewers: opaque-pointers, rjmccall. ahatanak added a project: clang. Herald added a project: All. ahatanak requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120856 Files: clang/lib/CodeGen/CGBlock

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

junaire added a comment. Frankly speaking, this is really a randomly written patch, and I have never thought it would raise so much concern. But I believe I can handle it if you guys can give me some trust and little guidance! <3 In D119609#3355409 , @a

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

void created this revision. Herald added subscribers: dang, jdoerfert, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Build the unit tests with (in the build

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

pengfei added a comment. Sorry, I missed this patch. I think this is a wrong fix. The `buf[9]` doesn't make sense to X86 registers. You can see GCC fails with it too. https://godbolt.org/z/vPcfoG714 I think we just need to do sema check for it to emit error gracefully. BTW, I have a patch D107

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM. Two nits about the comments and tests. Please wait for some days in case other reviews have some comments. Comment at: clang

[PATCH] D120395: [X86] Prohibit arithmetic operations on type `__bfloat16`

andrew.w.kaylor added a comment. Herald added a project: All. In D120395#3346591 , @scanon wrote: > There's a lot of churn around proposed "solutions" on this and related PR, > but not a very clear analysis of what the problem we're trying to solve is.

[PATCH] D120856: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBlocks.cpp

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120856/new/ https://reviews.llvm.org/D120856 ___

[PATCH] D120862: Sema: Allow scoped enums as source type for integral conversion.

pcc created this revision. pcc added a reviewer: rsmith. Herald added a project: All. pcc requested review of this revision. Herald added a project: clang. Fixes pr54158. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120862 Files: clang/lib/Sema/SemaOverload.cpp clang/tes

[PATCH] D120864: [AArch64] Avoid scanning feature list for target parsing

tyb0807 created this revision. tyb0807 added reviewers: tmatheson, nickdesaulniers, chill. Herald added a subscriber: kristof.beyls. Herald added a project: All. tyb0807 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in https:

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-gnutools.c:19 +// Check default when -mno-relax and -fno-integrated-as specified +// RUN: %clang -target riscv32 --gcc-toolchain=%S/Inputs/basic_riscv32_tree -mno-relax -fno-integrated-as %s -### -c \ --

[PATCH] D120864: [AArch64] Avoid scanning feature list for target parsing

tyb0807 updated this revision to Diff 412592. tyb0807 added a comment. Update logic to define crypto extensions, strictly following the old implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120864/new/ https://reviews.llvm.org/D120864

[PATCH] D120870: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.

khchen created this revision. khchen added reviewers: craig.topper, rogfer01, kito-cheng, arcbbb, monkchiang, eopXD. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewe

[PATCH] D120870: [RISCV][NFC] Refine and refactor RISCVVEmitter and riscv_vector.td.

rogfer01 accepted this revision. rogfer01 added a comment. This revision is now accepted and ready to land. Thanks for the cleanup @khchen ! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120870/new/ https://reviews.llvm.org/D120870

[PATCH] D120873: [clang-format] Handle wrapped else for RemoveBracesLLVM

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removes the ne

<    1   2