[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. other than the two nits, LGTM Comment at: clang/include/clang/Sema/Sema.h:2996-2997 /// \param ImportLoc The location of the 'import' keyword. /// \param Path The module

[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:415 + return ActOnModuleImport(StartLoc, ExportLoc, ImportLoc, Mod, Path); } it looks like there is an extra blank line before the closing brace.. Repository: rG LLVM Github Monorepo

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

jchlanda added a comment. Herald added a project: All. In D117887#3352079 , @tra wrote: > In D117887#3351257 , @jchlanda > wrote: > >> @tra thank you for landing the patches, it seems that the clang part >> (bui

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 412334. Herald added a project: All. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D120764: [C++20][Modules] Improve efficiency of isModuleParition method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG17ce5497aa01: [C++20][Modules] Improve efficiency of isModulePartition method. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120764/new/

[clang] 17ce549 - [C++20][Modules] Improve efficiency of isModulePartition method.

Author: Iain Sandoe Date: 2022-03-02T08:31:46Z New Revision: 17ce5497aa016707b31a2e99a05ec7451ba4014d URL: https://github.com/llvm/llvm-project/commit/17ce5497aa016707b31a2e99a05ec7451ba4014d DIFF: https://github.com/llvm/llvm-project/commit/17ce5497aa016707b31a2e99a05ec7451ba4014d.diff LOG: [

[PATCH] D116593: Fix `performance-unnecessary-value-param` for template specialization

Sockke updated this revision to Diff 412340. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116593/new/ https://reviews.llvm.org/D116593 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryValueParamCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/test/cla

[clang] 28efb1c - [pseudo] Fix an out-of-bound error in LRTable::find.

Author: Haojian Wu Date: 2022-03-02T09:53:52+01:00 New Revision: 28efb1ccf5eabd25119a3a7df2c2c1f1407dbfec URL: https://github.com/llvm/llvm-project/commit/28efb1ccf5eabd25119a3a7df2c2c1f1407dbfec DIFF: https://github.com/llvm/llvm-project/commit/28efb1ccf5eabd25119a3a7df2c2c1f1407dbfec.diff LO

[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG28efb1ccf5ea: [pseudo] Fix an out-of-bound error in LRTable::find. (authored by hokein). Herald added a project: All. Changed prior to commit: https://reviews.ll

[clang] ae60884 - [clang][dataflow] Add flow condition constraints to Environment

Author: Stanislav Gatev Date: 2022-03-02T08:57:27Z New Revision: ae60884dfe16a8f9382d778e4eef61bf9703e1f5 URL: https://github.com/llvm/llvm-project/commit/ae60884dfe16a8f9382d778e4eef61bf9703e1f5 DIFF: https://github.com/llvm/llvm-project/commit/ae60884dfe16a8f9382d778e4eef61bf9703e1f5.diff LO

[PATCH] D120711: [clang][dataflow] Add flow condition constraints to Environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae60884dfe16: [clang][dataflow] Add flow condition constraints to Environment (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 7f99e18 - [pseudo] Add a print-grammar option in the tool

Author: Haojian Wu Date: 2022-03-02T10:05:49+01:00 New Revision: 7f99e1870f776a25e03526e3190105c094750d98 URL: https://github.com/llvm/llvm-project/commit/7f99e1870f776a25e03526e3190105c094750d98 DIFF: https://github.com/llvm/llvm-project/commit/7f99e1870f776a25e03526e3190105c094750d98.diff LO

[PATCH] D120724: [pseudo] Add a print-grammar option in the tool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f99e1870f77: [pseudo] Add a print-grammar option in the tool (authored by hokein). Herald added a project: All. Repository: rG LLVM Github Monore

[PATCH] D120712: [clang-format][docs] handle explicit enum values

MyDeveloperDay added a comment. I have left, (some quite harsh opinions on this idea here, I'm sorry): https://github.com/llvm/llvm-project/issues/54137 If you do want to contribute can I suggest you start with an item off this list, I think it will give you good insight into what is involved wi

[clang] 05d7e9f - [pseudo] fix some comment nits, NFC.

Author: Haojian Wu Date: 2022-03-02T10:19:17+01:00 New Revision: 05d7e9f68ef005c43576278fe5d7ac03869974f3 URL: https://github.com/llvm/llvm-project/commit/05d7e9f68ef005c43576278fe5d7ac03869974f3 DIFF: https://github.com/llvm/llvm-project/commit/05d7e9f68ef005c43576278fe5d7ac03869974f3.diff LO

[PATCH] D120720: [clang][AVR] Implement standard calling convention for AVR and AVRTiny

benshi001 updated this revision to Diff 412357. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120720/new/ https://reviews.llvm.org/D120720 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/argument.c Inde

[clang] d813116 - [NFC][Lexer] Remove getLangOpts function from Lexer

Author: Dawid Jurczak Date: 2022-03-02T11:17:05+01:00 New Revision: d813116c9deaa960ddcce5b4b161ea589d6e9a34 URL: https://github.com/llvm/llvm-project/commit/d813116c9deaa960ddcce5b4b161ea589d6e9a34 DIFF: https://github.com/llvm/llvm-project/commit/d813116c9deaa960ddcce5b4b161ea589d6e9a34.diff

[PATCH] D120404: [NFC][Lexer] Remove getLangOpts function from Lexer

This revision was automatically updated to reflect the committed changes. Closed by commit rGd813116c9dea: [NFC][Lexer] Remove getLangOpts function from Lexer (authored by yurai007). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D120806: [clang-format] Recognize "if consteval".

curdeius created this revision. curdeius added reviewers: MyDeveloperDay, HazardyKnusperkeks, owenpan. Herald added a project: All. curdeius requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/5

[PATCH] D120449: [RISCV][RVV] Add strict vfcvt intrinsics that have side effects for dynamically-set rounding mode

kito-cheng added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4683 +Ops.push_back(VL); +Ops.push_back(DAG.getUNDEF(XLenVT)); // Policy + } Is this operand for tail policy? if so why this is `UNDEF`? I guess this should be `TA

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:561 + std::make_unique(triple); + CodeGenPasses.add(new llvm::TargetLibraryInfoWrapperPass(*TLII)); + schweitz wrote: > Got jumbled around somehow. TLII is allocated at lin

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM, but please adjust the naming nit to a better name. do you have commit rights? Otherwise someone (e.g. me) could commit on your behalf, of course with a

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

manas added a comment. Herald added a project: All. Buildbots are happy. I think we can land this. @steakhal do you mind landing it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120646/new/ https://reviews.llvm.org/D120646 ___

[PATCH] D120646: [clang][scan-build] Change mode of installation for scan-build.1

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ca109855709: [clang][scan-build] Change mode of installation for scan-build.1 (authored by manas, committed by steakhal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 3ca1098 - [clang][scan-build] Change mode of installation for scan-build.1

Author: Manas Date: 2022-03-02T13:12:08+01:00 New Revision: 3ca1098557091247524acef9a3759379ba7a3e59 URL: https://github.com/llvm/llvm-project/commit/3ca1098557091247524acef9a3759379ba7a3e59 DIFF: https://github.com/llvm/llvm-project/commit/3ca1098557091247524acef9a3759379ba7a3e59.diff LOG: [c

[PATCH] D120806: [clang-format] Recognize "if consteval".

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LFTM Do we also need to consider this in the context of "AllowShortIfStatments"? (that would be in a different review in my view) Repository: rG LLVM Github Monorepo CHAN

[clang] 1e78d07 - [clang-offload-bundler] Fix typo in a test case

Author: Saiyedul Islam Date: 2022-03-02T13:33:56Z New Revision: 1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb URL: https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb DIFF: https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb.diff LOG

[PATCH] D120806: [clang-format] Recognize "if consteval".

JohelEGP added a comment. In D120806#3354119 , @MyDeveloperDay wrote: > LFTM > > Do we also need to consider this in the context of "AllowShortIfStatments"? > (that would be in a different review in my view) Definitely. Since it didn't work at all, I

[PATCH] D120806: [clang-format] Recognize "if consteval".

curdeius added a comment. I'll handle `AllowShortIfStatements` and update this review. Should be pretty straightforward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120806/new/ https://reviews.llvm.org/D120806 __

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

awarzynski updated this revision to Diff 412386. awarzynski added a comment. - Got rid of `tripleName` - Added an assert for the newly created TLII - Rebased - Added `#includes` missing after the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker added a comment. In D120331#3354021 , @JonasToth wrote: > LGTM, but please adjust the naming nit to a better name. Thanks for the review again. Will rename the `group` to `config_group` as you suggested and I feel that too. > do you have commi

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412391. phyBrackets added a comment. Herald added a project: All. Created the separate test file for UninitializedRead checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

erichkeane added a comment. In D120255#3352920 , @royjacobson wrote: > In D120255#3352755 , @erichkeane > wrote: > >> Hmm... doing FileCheck in a Sema test is highly irregular. I would expect >> us to be able

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/test/SemaTemplate/constraints-instantiation.cpp:3-8 +// void PR46029::A<1>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi1EE1fEv +// void PR46029::A<2>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi2EE1fEv +// void PR46029:

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. Hey @NoQ and @steakhal , will you just check , if everything looks fine or not! The test cases run successfully tho now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 _

[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file= option

SAtacker updated this revision to Diff 412397. SAtacker added a comment. [clang-tidy][run-clang-tidy.py] Rename `group` to `config_group` Signed-off-by: Shreyas Atre Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120331/new/ https://reviews.llvm.o

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Previously, we didin't build a DeclRefExpr which refers to an invalid declaration. In this patch, we handle this case by buildin

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

hokein added inline comments. Comment at: clang/test/SemaCXX/copy-assignment.cpp:117 A(UndeclaredType n) : X(n) {} // expected-error {{unknown type name 'UndeclaredType'}} +// expected-error@-1 {{member initializer 'X' does not name a non-static data member or base cla

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

jansvoboda11 added inline comments. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38 +#if __has_include("d.h") // This should use 'd.modulemap' in order to determine that 'd.h' + // doesn't exist for 'c' because of its '[no_undecla

[PATCH] D120465: [clang][deps] Generate necessary "-fmodule-map-file=" arguments, disable implicit module maps

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:112 void dependencies::detail::collectPCMAndModuleMapPaths( llvm::ArrayRef Modules, dexonsmith wrote: > Should this be renamed? Yes, that would mak

[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

ChuanqiXu updated this revision to Diff 412404. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120793/new/ https://reviews.llvm.org/D120793 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/Parser.cpp clang/lib/Sema/SemaModule.cpp

[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:415 + return ActOnModuleImport(StartLoc, ExportLoc, ImportLoc, Mod, Path); } iains wrote: > it looks like there is an extra blank line before the closing brace.. No, it isn't. It shows

[PATCH] D120812: [AST] Use RecoveryExpr to model a DeclRefExpr which refers to an invalid Decl.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Very nice! I thought we had considered and rejected this in the past, but I think it was rather allowing lookup to find invalid decls in cases where it doesn't today.

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

krasimir added a comment. @achieveartificialintelligence thank you for looking into this, sorry for the late reply! It looks like the latest version addresses @nikic's IR reproducer with `-mtriple=riscv32`. There seems to be an error trying this out with `-mtriple=riscv64`: % cat test.ll

[clang] 3eb2da7 - [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

Author: Chuanqi Xu Date: 2022-03-02T23:06:36+08:00 New Revision: 3eb2da76d77044802135350668da16d433a7c7b6 URL: https://github.com/llvm/llvm-project/commit/3eb2da76d77044802135350668da16d433a7c7b6 DIFF: https://github.com/llvm/llvm-project/commit/3eb2da76d77044802135350668da16d433a7c7b6.diff LO

[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb2da76d770: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition (authored by ChuanqiXu). Repository: rG LLVM Github

[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36 + llvm::erase_if(Args, [](const std::string &Arg) { +return Arg.find("-fmodules-cache-path=") == 0; + }); dexonsmith wrote: > Is that the only

[PATCH] D120814: [clang-tidy] Add check to perfer pre-increment over post-increment

philnik created this revision. philnik added reviewers: aaron.ballman, JonasToth. Herald added subscribers: carlosgalvezp, xazax.hun, mgorny. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. R

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added a comment. Please mark the done comments as "done" with the corresponding button prior to submitting an update. Comment at: clang/test/Analysis/bstring_UninitRead.c:67-85 +//===--=== +// mempcpy

[clang] ca94f28 - [clang] ExprEngine::VisitCXXNewExpr - remove superfluous nullptr tests

Author: Simon Pilgrim Date: 2022-03-02T15:59:10Z New Revision: ca94f28d15d53bb77ad347d6e374486475f86121 URL: https://github.com/llvm/llvm-project/commit/ca94f28d15d53bb77ad347d6e374486475f86121 DIFF: https://github.com/llvm/llvm-project/commit/ca94f28d15d53bb77ad347d6e374486475f86121.diff LOG:

[PATCH] D120360: [libTooling] Generalize string explanation as Any metadata

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Looks really good! Comment at: clang/include/clang/Tooling/Transformer/RewriteRule.h:64 using TextGenerator = std::shared_ptr>; (and move down to afte

[PATCH] D120806: [clang-format] Recognize "if consteval".

JohelEGP accepted this revision. JohelEGP added a comment. My few cases format consistently with the condition case: diff diff --git a/tests/integration/test.waarudo.io.dynamic.cpp b/tests/integration/test.waarudo.io.dynamic.cpp index be5a626..e1265b9 100644 --- a/tests/integration/test.

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:67-85 +//===--=== +// mempcpy() +//===--=== + +#ifdef VA

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a reviewer: Szelethus. Herald added a project: All. balazske requested review of this revision. Herald added a

[PATCH] D120806: [clang-format] Recognize "if consteval".

curdeius added a comment. Great, I'll add a few test cases when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120806/new/ https://reviews.llvm.org/D120806 ___ cfe-commits mailing list cfe-commit

[clang] 13351fd - [clang-format] Recognize "if consteval".

Author: Marek Kurdej Date: 2022-03-02T17:46:45+01:00 New Revision: 13351fdf8cb448ffd60727f031df0d7cb348e48a URL: https://github.com/llvm/llvm-project/commit/13351fdf8cb448ffd60727f031df0d7cb348e48a DIFF: https://github.com/llvm/llvm-project/commit/13351fdf8cb448ffd60727f031df0d7cb348e48a.diff

[PATCH] D120806: [clang-format] Recognize "if consteval".

This revision was automatically updated to reflect the committed changes. Closed by commit rG13351fdf8cb4: [clang-format] Recognize "if consteval". (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D120806?vs=412366&id=412444#toc Repository: rG LLVM Github Monorepo C

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

erichkeane added a comment. Herald added a project: All. In D53847#3252460 , @cjdb wrote: > What's the status of this patch? It appears to me that the 'delta' right now is a couple of cases where this patch doesn't properly diagnose/warn (see the convo i

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

curdeius added inline comments. Herald added a project: All. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:910 + Style); + verifyFormat("TemplateType t;", "TemplateType t;", Style); +} HazardyKnusperkeks wrote: > As far as I understand

[clang] d112cc2 - [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-02T08:58:00-08:00 New Revision: d112cc27569b8329b4c9090265b809d459a4a5a8 URL: https://github.com/llvm/llvm-project/commit/d112cc27569b8329b4c9090265b809d459a4a5a8 DIFF: https://github.com/llvm/llvm-project/commit/d112cc27569b8329b4c9090265b809d459a4a5a8.diff

[PATCH] D120757: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in CreatePointerBitCastOrAddrSpaceCast

This revision was automatically updated to reflect the committed changes. Closed by commit rGd112cc27569b: [NFC][Clang][OpaquePtr] Remove the call to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120757/

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:1-84 +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -analyzer-checker=core \ +// RUN: -analyzer-checker=unix.cstring \ +// RUN: -analyzer-checker=alpha.unix.cstring \ +// RUN: -analyze

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:67-85 +//===--=== +// mempcpy() +//===--=== + +#ifdef VA

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412452. phyBrackets added a comment. Remove unneccesary RUN and some macros definitions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyz

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal accepted this revision. steakhal added a comment. The `core` checkers should be always enabled. Comment at: clang/test/Analysis/bstring_UninitRead.c:2 +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -analyzer-checker=alpha.unix.cstring + Reposito

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 412464. phyBrackets added a comment. enabled the core checker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added inline comments. Comment at: clang/test/Analysis/bstring_UninitRead.c:2 +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -analyzer-checker=alpha.unix.cstring + steakhal wrote: > Yeah done! Thanks Repository: rG LLVM Github Monorepo CHANG

[clang] 3f7c3ff - [OpenMP] Handle sysroot option in offloading linker wrapper

Author: Joseph Huber Date: 2022-03-02T13:02:41-05:00 New Revision: 3f7c3ff90e33393b7b8a0851f6056ec1d9c164af URL: https://github.com/llvm/llvm-project/commit/3f7c3ff90e33393b7b8a0851f6056ec1d9c164af DIFF: https://github.com/llvm/llvm-project/commit/3f7c3ff90e33393b7b8a0851f6056ec1d9c164af.diff

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets added a comment. @steakhal , if everything looks fine, can i land this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing lis

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

steakhal added a comment. Yup, land it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

sfertile added inline comments. Herald added a project: All. Comment at: clang/lib/Sema/SemaChecking.cpp:5246 + + if (const auto *ICE = dyn_cast(Arg->IgnoreParens())) { +if (const auto *DR = dyn_cast(ICE->getSubExpr())) { Nit: To avoid the deep nesting, can

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added a comment. In D93298#3354313 , @krasimir wrote: > @achieveartificialintelligence thank you for looking into this, sorry for the > late reply! > > It looks like the latest version addresses @nikic's IR reproducer with > `-mtriple=riscv3

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2517 +else if (OutputTy->isFloatingPointTy()) Arg = Builder.CreateFPExt(Arg, OutputTy); } Shall we keep the assert (in a new `else` branch) just in case there are ot

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

ztong0001 added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2517 +else if (OutputTy->isFloatingPointTy()) Arg = Builder.CreateFPExt(Arg, OutputTy); } MaskRay wrote: > Shall we keep the assert (in a new `else` branch) just i

[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

ellis added a comment. Herald added a subscriber: ormris. Herald added a project: All. Hi @tmsriram. I found a clang crash when using the flag `-funique-internal-linkage-names` that only happens after this diff. Would you mind taking a look? $ cat test.c inline void foo() {} extern void f

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120596/new/ https://reviews.llvm.org/D120596 __

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

ztong0001 added a comment. Hi Fangrui @MaskRay, Thanks for your review. Could you please also help me landing it since I don't have write permission to the repo. Please use Tong Zhang Thanks and have a good one! - Tong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] f76d3b8 - [clang][CGStmt] fix crash on invalid asm statement

Author: Tong Zhang Date: 2022-03-02T11:18:55-08:00 New Revision: f76d3b800f7341882ea93db47cc8f28d94e74f1c URL: https://github.com/llvm/llvm-project/commit/f76d3b800f7341882ea93db47cc8f28d94e74f1c DIFF: https://github.com/llvm/llvm-project/commit/f76d3b800f7341882ea93db47cc8f28d94e74f1c.diff LO

[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf76d3b800f73: [clang][CGStmt] fix crash on invalid asm statement (authored by ztong0001, committed by MaskRay). Changed prior to commit: https://r

Re: [PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

On Wed, Mar 2, 2022 at 11:08 AM Ellis Hoag via Phabricator < revi...@reviews.llvm.org> wrote: > ellis added a comment. > Herald added a subscriber: ormris. > Herald added a project: All. > > Hi @tmsriram. I found a clang crash when using the flag > `-funique-internal-linkage-names` that only happe

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

craig.topper added a comment. In D93298#3355088 , @craig.topper wrote: > In D93298#3354313 , @krasimir wrote: > >> @achieveartificialintelligence thank you for looking into this, sorry for >> the late reply! >> >>

[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

HazardyKnusperkeks added a comment. In D120398#3353053 , @owenpan wrote: > Can we use `int8_t` instead of `unsigned char` to keep the enum types signed > (and update the changes made in D93758 )? +1 Repository: rG LL

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. Does a double with `r` for RV32 work with that fix? That's supposed to give the low half of the register. You might need to also deal with the register pair class? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ h

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

jrtc27 added a comment. Never mind, I see you added a test for that case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@

[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins

tra added a comment. In D117887#3353653 , @jchlanda wrote: > I went with the web interface as described here: > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > with `git diff -U99 ...` didn't want to bite the bu

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

royjacobson added inline comments. Comment at: clang/test/SemaTemplate/constraints-instantiation.cpp:3-8 +// void PR46029::A<1>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi1EE1fEv +// void PR46029::A<2>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi2EE1fEv +// void PR46029::A

[PATCH] D120255: [Concepts] Check constraints for explicit template instantiations

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/constraints-instantiation.cpp:3-8 +// void PR46029::A<1>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi1EE1fEv +// void PR46029::A<2>::f() +// CHECK: define {{.*}} @_ZN7PR460291AILi2EE1fEv +// void PR46029::A<

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412502. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b) erichkeane wrote: > I can't help

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23747 + verifyFormat("template \n" + "concept integral = __is_integral(T);"); + curdeius wrote: > curdeius wrote: > > How about other kinds? > > This doesn'

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:65 bool isLong : 1; // This is *not* set for long long. bool isLongLong : 1; bool isSizeT : 1; // 1z, 1uz (C++2b) aaron.ballman wrote: > erichkeane wr

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412507. aaron.ballman added a comment. Correct a think-o that fixes a failing test. Also removed a newline that didn't need to exist. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/d

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman marked 5 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1157 + if (const auto *BT = Node->getType()->getAs()) { +OS << (BT->isUnsigned() ? "uwb" : "wb"); +return; erichkeane wrote: >

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1156 + if (const auto *BT = Node->getType()->getAs()) { +OS << (isSigned ? "wb" : "uwb"); You don't need BT here anymore (sorry for missing that!). CHANGES SINCE LAST ACTION ht

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman updated this revision to Diff 412509. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. getAs -> isa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:1156 + if (const auto *BT = Node->getType()->getAs()) { +OS << (isSigned ? "wb" : "uwb"); erichkeane wrote: > You don't need BT here anymore (sorry for missing that!). No worrie

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Would love someone to check out the APInt changes to confirm it is 'doing the right thing', but as far as I can tell it is right (and I'm just not confident enough to say so :D). CHA

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

emaste added a comment. Herald added a project: All. The original author appears to have given up on it. Someone will need to rebase and work on pushing it forward CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23934/new/ https://reviews.llvm.org/D23934

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added a comment. Herald added a project: All. Does this break a case like this? https://godbolt.org/z/Tc9Ko7hWY it seems the problem is with the Expression statements, and I'm not sure why we are doing "ActOnCapScopeReturnStmt" when we aren't really in a capture scope anymore, right?

[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

DiggerLin updated this revision to Diff 412516. DiggerLin marked an inline comment as done. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119147/new/ https://reviews.llvm.org/D119147 Files: clang/include/clang/Driver/J

  1   2   >